Make crash02 verbose in standard runfile
PATCH 1/1 Make crash02 verbose in standard runfile
Verbose output from crash02 will be useful for actually reporting bugs triggered by the test. With default verbosity level, it's difficult to figure out which syscall arguments crashed the system even if you know the random seed and can easily re-run crash02 -xv 2 on a system that uses the same rand() implementation.
--- runtest/crashme | 2 +- testcases/misc/crash/crash02.c | 13 ++++++------- 2 files changed, 7 insertions(+), 8 deletions(-)
runtest/crashme +1 -1
@@ -7,7 +7,7 @@ f00f f00f crash01 crash01 # Generate random code and execute it. Read f00f comment, # this test lockup SunOS,WindowsNT,etc. in seconds.. -crash02 crash02 +crash02 crash02 -v 2 # Generate random syscalls and execute them, less probability # to hose your system, but still. mem01 mem01 -r
testcases/misc/crash/crash02.c +6 -7
@@ -430,13 +430,12 @@ void try_one_crash(int try_num) arg6 =rand_long (); arg7 =rand_long (); -if (x_opt) { -if (verbose_level >=1 ) -printf ("%04d: syscall(%ld, %#lx, %#lx, %#lx, %#lx, " -"%#lx, %#lx, %#lx)\n" , - try_num, sysno, arg1, arg2, arg3, arg4, arg5, - arg6, arg7); - }else { +if (verbose_level >=1 ) +printf ("%04d: syscall(%ld, %#lx, %#lx, %#lx, %#lx, %#lx, " +"%#lx, %#lx)\n" , try_num, sysno, arg1, arg2, arg3, + arg4, arg5, arg6, arg7); + +if (!x_opt) {syscall (sysno, arg1, arg2, arg3, arg4, arg5, arg6, arg7);record_errno (errno); }
Signature · 1 line
2.24.0
PATCH 1/1 Make crash02 verbose in standard runfile
Hi Martin,
Quoted 5 lines
Verbose output from crash02 will be useful for actually reporting bugs triggered by the test. With default verbosity level, it's difficult to figure out which syscall arguments crashed the system even if you know the random seed and can easily re-run
crash02 -xv 2on a system that uses the samerand()implementation.
BTW help for -x is (and was before this patch) misleading because "hexdump random code instead" is now for -v2 even without -x (and before it required -v2). But that's a detail, so I'd be for merging it.
Kind regards,
Petr
PATCH v2 1/1 Make crash02 verbose in standard runfile
Verbose output from crash02 will be useful for actually reporting bugs triggered by the test. With default verbosity level, it's difficult to figure out which syscall arguments crashed the system even if you know the random seed and can easily re-run crash02 -xv 2 on a system that uses the same rand() implementation.
---
Changes in v2: Bring -x implementation in line with usage description.
runtest/crashme | 2 +- testcases/misc/crash/crash02.c | 13 ++++++------- 2 files changed, 7 insertions(+), 8 deletions(-)
runtest/crashme +1 -1
@@ -7,7 +7,7 @@ f00f f00f crash01 crash01 # Generate random code and execute it. Read f00f comment, # this test lockup SunOS,WindowsNT,etc. in seconds.. -crash02 crash02 +crash02 crash02 -v 2 # Generate random syscalls and execute them, less probability # to hose your system, but still. mem01 mem01 -r
testcases/misc/crash/crash02.c +6 -7
@@ -430,13 +430,12 @@ void try_one_crash(int try_num) arg6 =rand_long (); arg7 =rand_long (); -if (x_opt) { -if (verbose_level >=1 ) -printf ("%04d: syscall(%ld, %#lx, %#lx, %#lx, %#lx, " -"%#lx, %#lx, %#lx)\n" , - try_num, sysno, arg1, arg2, arg3, arg4, arg5, - arg6, arg7); - }else { +if (x_opt || verbose_level >=1 ) +printf ("%04d: syscall(%ld, %#lx, %#lx, %#lx, %#lx, %#lx, " +"%#lx, %#lx)\n" , try_num, sysno, arg1, arg2, arg3, + arg4, arg5, arg6, arg7); + +if (!x_opt) {syscall (sysno, arg1, arg2, arg3, arg4, arg5, arg6, arg7);record_errno (errno); }
Signature · 1 line
2.24.0
PATCH v2 1/1 Make crash02 verbose in standard runfile
Hi Martin,
Quoted 1 line
Changes in v2: Bring -x implementation in line with usage description.
Thanks for addressing this.
Patch merged.
Kind regards,
Petr