Skip to contentSkip to conversation

clk: uclass: clk_get_by_name() must not be available if CONFIG_OF_PLATDATA is enabled

PATCH New Giulio Benetti 2 participants 8 messages Dec 12, 2019 – Jan 17, 2020 Common clk

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: uclass: clk_get_by_name() must not be available if CONFIG_OF_PLATDATA is enabled

clk_get_by_name() requires clk_get_by_id() that is not available if CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into #else condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).

---
 drivers/clk/clk-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/clk-uclass.c +1 -1
index 9aa8537004..170e19db65 100644
@@ -326,7 +326,6 @@ int clk_set_defaults(struct udevice *dev, int stage)
 
 	return 0;
 }
-# endif /* OF_PLATDATA */
 
 int clk_get_by_name(struct udevice *dev, const char *name, struct clk *clk)
 {
@@ -343,6 +342,7 @@ int clk_get_by_name(struct udevice *dev, const char *name, struct clk *clk)
 
 	return clk_get_by_index(dev, index, clk);
 }
+# endif /* OF_PLATDATA */
 
 int clk_release_all(struct clk *clk, int count)
 {
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 clk: uclass: clk_get_by_name() must not be available if CONFIG_OF_PLATDATA is enabled

Hi Lukasz,

Quoted 5 lines · Giulio Benetti

clk_get_by_name() requires clk_get_by_id() that is not available if CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into #else condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).

I've already successfully executed a complete Travis with master and this patch applied:
https://travis-ci.org/giuliobenetti/u-boot-imxrt/builds/624256888

Kind regards

Signature · 2 lines
Giulio Benetti
Benetti Engineering sas
Quoted 25 lines
---
  drivers/clk/clk-uclass.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/clk-uclass.c +1 -1
index 9aa8537004..170e19db65 100644
@@ -326,7 +326,6 @@ int clk_set_defaults(struct udevice *dev, int stage)
 
  	return 0;
  }
-# endif /* OF_PLATDATA */
 
  int clk_get_by_name(struct udevice *dev, const char *name, struct clk *clk)
  {
@@ -343,6 +342,7 @@ int clk_get_by_name(struct udevice *dev, const char *name, struct clk *clk)
 
  	return clk_get_by_index(dev, index, clk);
  }
+# endif /* OF_PLATDATA */
 
  int clk_release_all(struct clk *clk, int count)
  {
#2 lore raw

PATCH 1/1 clk: uclass: clk_get_by_name() must not be available if CONFIG_OF_PLATDATA is enabled

Quoted 7 lines · On Fri, 13 Dec 2019 00:02:25 +0100 Giulio Benetti…

Hi Lukasz,

Quoted 4 lines · Giulio Benetti

clk_get_by_name() requires clk_get_by_id() that is not available if CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into #else condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).

Quoted 6 lines
Quoted 2 lines

Signed-off-by: Giulio Benetti
<[email protected]>

I've already successfully executed a complete Travis with master and this patch applied:
https://travis-ci.org/giuliobenetti/u-boot-imxrt/builds/624256888

Is this a preparatory patch for some other work? Or is it just a standalone fix?

Quoted 2 lines

Kind regards

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191213/af35b52e/attachment.sig>

#3 lore raw

PATCH 1/1 clk: uclass: clk_get_by_name() must not be available if CONFIG_OF_PLATDATA is enabled

Quoted 13 lines · Lukasz Majewski
Quoted 10 lines · On Fri, 13 Dec 2019 00:02:25 +0100 Giulio Benetti…

Hi Lukasz,

Quoted 6 lines · Giulio Benetti

clk_get_by_name() requires clk_get_by_id() that is not available if CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into #else condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).

Signed-off-by: Giulio Benetti
<[email protected]>

Quoted 6 lines
Quoted 3 lines

I've already successfully executed a complete Travis with master and this patch applied:
https://travis-ci.org/giuliobenetti/u-boot-imxrt/builds/624256888

Is this a preparatory patch for some other work? Or is it just a standalone fix?

This is a standalone fix.

Best regards

Signature · 2 lines
Giulio Benetti
Benetti Engineering sas
Quoted 16 lines
Quoted 2 lines

Kind regards

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de

#4 lore raw

PATCH 1/1 clk: uclass: clk_get_by_name() must not be available if CONFIG_OF_PLATDATA is enabled

Quoted 14 lines · On Fri, 13 Dec 2019 12:38:43 +0100 Giulio Benetti…
Quoted 13 lines · Lukasz Majewski
Quoted 10 lines · On Fri, 13 Dec 2019 00:02:25 +0100 Giulio Benetti…

Hi Lukasz,

Quoted 6 lines · Giulio Benetti

clk_get_by_name() requires clk_get_by_id() that is not available if CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into #else condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).

Signed-off-by: Giulio Benetti
<[email protected]>

Quoted 9 lines
Quoted 6 lines
Quoted 3 lines

I've already successfully executed a complete Travis with master and this patch applied:
https://travis-ci.org/giuliobenetti/u-boot-imxrt/builds/624256888

Is this a preparatory patch for some other work? Or is it just a standalone fix?

This is a standalone fix.

Ok. Thanks for preparing it.

Quoted 1 line

Best regards

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191213/0f70069a/attachment.sig>

#5 lore raw

PATCH 1/1 clk: uclass: clk_get_by_name() must not be available if CONFIG_OF_PLATDATA is enabled

In reply to Giulio Benetti

Hi Giulio,

Quoted 14 lines · Lukasz Majewski
Quoted 13 lines
Quoted 10 lines · On Fri, 13 Dec 2019 00:02:25 +0100 Giulio Benetti…

Hi Lukasz,

Quoted 6 lines · Giulio Benetti

clk_get_by_name() requires clk_get_by_id() that is not available if CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into #else condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).

Signed-off-by: Giulio Benetti
<[email protected]>

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

I've already successfully executed a complete Travis with master and this patch applied:
https://travis-ci.org/giuliobenetti/u-boot-imxrt/builds/624256888

Is this a preparatory patch for some other work? Or is it just a standalone fix?

This is a standalone fix.

As we are really close to final U-Boot release - I'm more keen to add this patch to u-boot-clk -next repository.

Do you mind ?

Quoted 2 lines

Best regards

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191215/f645f327/attachment.sig>

#6 lore raw

PATCH 1/1 clk: uclass: clk_get_by_name() must not be available if CONFIG_OF_PLATDATA is enabled

Hi Lukasz,

Quoted 23 lines · Lukasz Majewski

Hi Giulio,

Quoted 21 lines · Lukasz Majewski
Quoted 19 lines
Quoted 7 lines · On Fri, 13 Dec 2019 00:02:25 +0100 Giulio Benetti…

Hi Lukasz,

Quoted 4 lines · Giulio Benetti

clk_get_by_name() requires clk_get_by_id() that is not available if CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into #else condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).

Quoted 6 lines
Quoted 2 lines

Signed-off-by: Giulio Benetti
<[email protected]>

I've already successfully executed a complete Travis with master and this patch applied:
https://travis-ci.org/giuliobenetti/u-boot-imxrt/builds/624256888

Is this a preparatory patch for some other work? Or is it just a standalone fix?

Quoted 6 lines
Quoted 1 line

This is a standalone fix.

As we are really close to final U-Boot release - I'm more keen to add this patch to u-boot-clk -next repository.

Do you mind ?

No problem at all, we'll see it "next"!

Best regards

Signature · 2 lines
Giulio Benetti
Benetti Engineering sas
Quoted 16 lines
Quoted 2 lines

Best regards

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de

#7 lore raw

PATCH 1/1 clk: uclass: clk_get_by_name() must not be available if CONFIG_OF_PLATDATA is enabled

Hi Lukasz,

Quoted 28 lines · Giulio Benetti

Hi Lukasz,

Quoted 25 lines · Lukasz Majewski

Hi Giulio,

Quoted 22 lines · Lukasz Majewski
Quoted 13 lines
Quoted 10 lines · On Fri, 13 Dec 2019 00:02:25 +0100 Giulio Benetti…

Hi Lukasz,

Quoted 6 lines · Giulio Benetti

clk_get_by_name() requires clk_get_by_id() that is not available if CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into #else condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).

Signed-off-by: Giulio Benetti
<[email protected]>

Quoted 6 lines
Quoted 3 lines

I've already successfully executed a complete Travis with master and this patch applied:
https://travis-ci.org/giuliobenetti/u-boot-imxrt/builds/624256888

Is this a preparatory patch for some other work? Or is it just a standalone fix?

This is a standalone fix.

Quoted 9 lines
Quoted 4 lines

As we are really close to final U-Boot release - I'm more keen to add this patch to u-boot-clk -next repository.

Do you mind ?

No problem at all, we'll see it "next"!

Best regards

Kindly ping

Best regards

Signature · 2 lines
Giulio Benetti
Benetti Engineering sas