Skip to contentSkip to conversation

public/io/netif.h: document a mechanism to advertise carrier state

PATCH In review Paul Durrant 2 participants 2 messages Dec 13, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 public/io/netif.h: document a mechanism to advertise carrier state

This patch adds a specification for a 'carrier' node in xenstore to allow a backend to notify a frontend of it's virtual carrier/link state. E.g. a backend that is unable to forward packets from the guest because it is not attached to a bridge may wish to advertise 'no carrier'.

While in the area also fix an erroneous backend path description.

NOTE: This is purely a documentation patch. No functional change.

---
Cc: Konrad Rzeszutek Wilk <[email protected]>
Cc: Juergen Gross <[email protected]>

v2:
- Fix text
- Fix path

---
 xen/include/public/io/netif.h | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)
xen/include/public/io/netif.h +15 -1
index 2454448baa..52dd2087cd 100644
@@ -171,7 +171,7 @@
  * The ability of the backend to use a control ring is advertised by
  * setting:
  *
- * /local/domain/X/backend/<domid>/<vif>/feature-ctrl-ring = "1"
+ * /local/domain/X/backend/vif/<domid>/<vif>/feature-ctrl-ring = "1"
  *
  * The frontend provides a control ring to the backend by setting:
  *
@@ -190,6 +190,20 @@
  * order as requests.
  */
 
+/*
+ * Link state
+ * ==========
+ *
+ * The backend can advertise its current link (carrier) state to the
+ * frontend using the /local/domain/X/backend/vif/<domid>/<vif>/carrier
+ * node. If this node is not present, then the frontend should assume that
+ * the link is up (for compatibility with backends that do no implement
+ * this feature). If this node is present, then a value of "0" should be
+ * interpreted by the frontend as the link being down (no carrier) and a
+ * value of "1" should be interpreted as the link being up (carrier
+ * present).
+ */
+
 /*
  * Hash types
  * ==========
Signature · 7 lines
2.20.1


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Reviewed-by on v2 1/1
#1 lore raw
Quoted 36 lines · Paul Durrant

This patch adds a specification for a 'carrier' node in xenstore to allow a backend to notify a frontend of it's virtual carrier/link state. E.g. a backend that is unable to forward packets from the guest because it is not attached to a bridge may wish to advertise 'no carrier'.

While in the area also fix an erroneous backend path description.

NOTE: This is purely a documentation patch. No functional change.

---
Cc: Konrad Rzeszutek Wilk <[email protected]>
Cc: Juergen Gross <[email protected]>

v2:
- Fix text
- Fix path

---
  xen/include/public/io/netif.h | 16 +++++++++++++++-
  1 file changed, 15 insertions(+), 1 deletion(-)
xen/include/public/io/netif.h +1 -1
index 2454448baa..52dd2087cd 100644
@@ -171,7 +171,7 @@
   * The ability of the backend to use a control ring is advertised by
   * setting:
   *
- * /local/domain/X/backend/<domid>/<vif>/feature-ctrl-ring = "1"
+ * /local/domain/X/backend/vif/<domid>/<vif>/feature-ctrl-ring = "1"
   *
   * The frontend provides a control ring to the backend by setting:
   *
@@ -190,6 +190,20 @@
   * order as requests.

xen/include/public/io/netif.h line 200

Quoted 10 lines
xen/include/public/io/netif.h +8 -0
   */
 
+/*
+ * Link state
+ * ==========
+ *
+ * The backend can advertise its current link (carrier) state to the
+ * frontend using the /local/domain/X/backend/vif/<domid>/<vif>/carrier
+ * node. If this node is not present, then the frontend should assume that
+ * the link is up (for compatibility with backends that do no implement

Oh, only seeing it now: s/no implement/not implement/

With that fixed:

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel