Skip to contentSkip to conversation

package/wpewebkit: add option to enable sandboxing support

PATCH New Adrian Perez de Castro 3 participants 5 messages Dec 14, 2019 – Dec 15, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/wpewebkit: add option to enable sandboxing support

Add an option to enable WebKit's sandbox, which uses kernel namespaces to isolate the processes used for Web content rendering (WebKitWebProcess) and network/disk access (WebKitNetworkProcess).

The reason to have an option is that it needs additional dependencies (bubblewrap, xdg-dbus-proxy, libseccomp), and that some users may choose to deploy alternative solution (for example: putting all of WebKit inside its own container, using systemd-nspawn or the like).

---
 package/wpewebkit/Config.in    | 14 ++++++++++++++
 package/wpewebkit/wpewebkit.mk | 14 ++++++++++++--
 2 files changed, 26 insertions(+), 2 deletions(-)
package/wpewebkit/Config.in +14 -0
index f1460db20e..37a3065761 100644
@@ -63,6 +63,20 @@ config BR2_PACKAGE_WPEWEBKIT
 
 if BR2_PACKAGE_WPEWEBKIT
 
+config BR2_PACKAGE_WPEWEBKIT_SANDBOX
+	bool "sandboxing support"
+	depends on BR2_PACKAGE_LIBSECCOMP_ARCH_SUPPORTS # libseccomp
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12 # libseccomp
+	select BR2_PACKAGE_BUBBLEWRAP # runtime
+	select BR2_PACKAGE_XDG_DBUS_PROXY # runtime
+	help
+	  Enable sandboxing of the processes used for network operation,
+	  disk asccess, and Web content rendering.
+
+comment "sandboxing supports needs a toolchain w/ headers >= 3.12"
+	depends on BR2_PACKAGE_LIBSECCOMP_ARCH_SUPPORTS
+	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12
+
 config BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA
 	bool "multimedia support"
 	select BR2_PACKAGE_GSTREAMER1
package/wpewebkit/wpewebkit.mk +12 -2
index c90e2d1421..d732938b57 100644
@@ -20,8 +20,18 @@ WPEWEBKIT_CONF_OPTS = \
 	-DPORT=WPE \
 	-DENABLE_ACCESSIBILITY=OFF \
 	-DENABLE_API_TESTS=OFF \
-	-DENABLE_BUBBLEWRAP_SANDBOX=OFF \
-	-DENABLE_MINIBROWSER=OFF
+	-DENABLE_MINIBROWSER=OFF \
+	-DSILENCE_CROSS_COMPILATION_NOTICES=ON
+
+ifeq ($(BR2_PACKAGE_WPEWEBKIT_SANDBOX),y)
+WPEWEBKIT_CONF_OPTS += \
+	-DENABLE_BUBBLEWRAP_SANDBOX=ON \
+	-DBWRAP_EXECUTABLE=/usr/bin/bwrap \
+	-DDBUS_PROXY_EXECUTABLE=/usr/bin/xdg-dbus-proxy
+WPEWEBKIT_DEPENDENCIES += libseccomp
+else
+WPEWEBKIT_CONF_OPTS += -DENABLE_BUBBLEWRAP_SANDBOX=OFF
+endif
 
 ifeq ($(BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA),y)
 WPEWEBKIT_CONF_OPTS += \
Signature · 1 line
2.24.1
#1 lore raw

PATCH 1/1 package/wpewebkit: add option to enable sandboxing support

Quoted 21 lines · On Sat, 14 Dec 2019 16:22:16 +0200 Adrian Perez de Castro <[email protected]>…

Add an option to enable WebKit's sandbox, which uses kernel namespaces to isolate the processes used for Web content rendering (WebKitWebProcess) and network/disk access (WebKitNetworkProcess).

The reason to have an option is that it needs additional dependencies (bubblewrap, xdg-dbus-proxy, libseccomp), and that some users may choose to deploy alternative solution (for example: putting all of WebKit inside its own container, using systemd-nspawn or the like).

---
 package/wpewebkit/Config.in    | 14 ++++++++++++++
 package/wpewebkit/wpewebkit.mk | 14 ++++++++++++--
 2 files changed, 26 insertions(+), 2 deletions(-)
package/wpewebkit/Config.in +0 -0
index f1460db20e..37a3065761 100644

package/wpewebkit/Config.in config BR2_PACKAGE_WPEWEBKIT · line 71

Quoted 9 lines
package/wpewebkit/Config.in +6 -0
@@ -63,6 +63,20 @@ config BR2_PACKAGE_WPEWEBKIT
 
 if BR2_PACKAGE_WPEWEBKIT
 
+config BR2_PACKAGE_WPEWEBKIT_SANDBOX
+	bool "sandboxing support"
+	depends on BR2_PACKAGE_LIBSECCOMP_ARCH_SUPPORTS # libseccomp
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12 # libseccomp
+	select BR2_PACKAGE_BUBBLEWRAP # runtime
+	select BR2_PACKAGE_XDG_DBUS_PROXY # runtime

Didn't you forgot a:

select BR2_PACKAGE_LIBSECCOMP

here ? No need to resend just for that, can be fixed when applying.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/wpewebkit: add option to enable sandboxing support

Hi Thomas,

Quoted 36 lines · Thomas Petazzoni
Quoted 21 lines · On Sat, 14 Dec 2019 16:22:16 +0200 Adrian Perez de Castro <[email protected]>…

Add an option to enable WebKit's sandbox, which uses kernel namespaces to isolate the processes used for Web content rendering (WebKitWebProcess) and network/disk access (WebKitNetworkProcess).

The reason to have an option is that it needs additional dependencies (bubblewrap, xdg-dbus-proxy, libseccomp), and that some users may choose to deploy alternative solution (for example: putting all of WebKit inside its own container, using systemd-nspawn or the like).

---
 package/wpewebkit/Config.in    | 14 ++++++++++++++
 package/wpewebkit/wpewebkit.mk | 14 ++++++++++++--
 2 files changed, 26 insertions(+), 2 deletions(-)
package/wpewebkit/Config.in +0 -0
index f1460db20e..37a3065761 100644

package/wpewebkit/Config.in config BR2_PACKAGE_WPEWEBKIT · line 71

Quoted 9 lines
package/wpewebkit/Config.in +6 -0
@@ -63,6 +63,20 @@ config BR2_PACKAGE_WPEWEBKIT
 
 if BR2_PACKAGE_WPEWEBKIT
 
+config BR2_PACKAGE_WPEWEBKIT_SANDBOX
+	bool "sandboxing support"
+	depends on BR2_PACKAGE_LIBSECCOMP_ARCH_SUPPORTS # libseccomp
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12 # libseccomp
+	select BR2_PACKAGE_BUBBLEWRAP # runtime
+	select BR2_PACKAGE_XDG_DBUS_PROXY # runtime

Didn't you forgot a:

Quoted 3 lines

select BR2_PACKAGE_LIBSECCOMP

here ? No need to resend just for that, can be fixed when applying.

Good catch, this ?select? is indeed missing. Please add it when applying.

(Side note: I have noticed that the WebKitGTK package has the same issue, I'll submit a patch.)

Cheers,
?Adri?n
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20191215/3e4abdd5/attachment.asc>

#3 lore raw

PATCH 1/1 package/wpewebkit: add option to enable sandboxing support

Hello,

Quoted 39 lines · Adrian Perez de Castro

Hi Thomas,

Quoted 36 lines · Thomas Petazzoni
Quoted 21 lines · On Sat, 14 Dec 2019 16:22:16 +0200 Adrian Perez de Castro <[email protected]>…

Add an option to enable WebKit's sandbox, which uses kernel namespaces to isolate the processes used for Web content rendering (WebKitWebProcess) and network/disk access (WebKitNetworkProcess).

The reason to have an option is that it needs additional dependencies (bubblewrap, xdg-dbus-proxy, libseccomp), and that some users may choose to deploy alternative solution (for example: putting all of WebKit inside its own container, using systemd-nspawn or the like).

---
 package/wpewebkit/Config.in    | 14 ++++++++++++++
 package/wpewebkit/wpewebkit.mk | 14 ++++++++++++--
 2 files changed, 26 insertions(+), 2 deletions(-)
package/wpewebkit/Config.in +0 -0
index f1460db20e..37a3065761 100644

package/wpewebkit/Config.in config BR2_PACKAGE_WPEWEBKIT · line 71

Quoted 9 lines
package/wpewebkit/Config.in +6 -0
@@ -63,6 +63,20 @@ config BR2_PACKAGE_WPEWEBKIT
 
 if BR2_PACKAGE_WPEWEBKIT
 
+config BR2_PACKAGE_WPEWEBKIT_SANDBOX
+	bool "sandboxing support"
+	depends on BR2_PACKAGE_LIBSECCOMP_ARCH_SUPPORTS # libseccomp
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12 # libseccomp
+	select BR2_PACKAGE_BUBBLEWRAP # runtime
+	select BR2_PACKAGE_XDG_DBUS_PROXY # runtime

Didn't you forgot a:

Quoted 8 lines
Quoted 3 lines

select BR2_PACKAGE_LIBSECCOMP

here ? No need to resend just for that, can be fixed when applying.

Good catch, this ?select? is indeed missing. Please add it when applying.

(Side note: I have noticed that the WebKitGTK package has the same issue, I'll submit a patch.)

Submitted: https://patchwork.ozlabs.org/patch/1209998/

Cheers,
?Adri?n
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20191215/6d3b3b6d/attachment.asc>

#4 lore raw

PATCH 1/1 package/wpewebkit: add option to enable sandboxing support

In reply to Adrian Perez de Castro
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Adrian" == Adrian Perez de Castro <[email protected]> writes:

Hi,

Quoted 7 lines
Quoted 5 lines

Didn't you forgot a:

select BR2_PACKAGE_LIBSECCOMP

here ? No need to resend just for that, can be fixed when applying.

Good catch, this ?select? is indeed missing. Please add it when applying.

Committed with that fixed, thanks.

Signature · 1 line
Bye, Peter Korsgaard