PM / devfreq: rockchip-dfi: add missing of_node_put()
PATCH 1/2 PM / devfreq: rockchip-dfi: add missing of_node_put()
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using.
--- drivers/devfreq/event/rockchip-dfi.c | 1 + 1 file changed, 1 insertion(+)
drivers/devfreq/event/rockchip-dfi.c +1 -0
@@ -200,6 +200,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev) node =of_parse_phandle (np,"rockchip,pmu" ,0 );if (node) { data->regmap_pmu =syscon_node_to_regmap (node); +of_node_put (node);if (IS_ERR (data->regmap_pmu))return PTR_ERR (data->regmap_pmu); }
Signature · 1 line
2.17.1
PATCH 2/2 PM / devfreq: rk3399_dmc: add missing of_node_put()
of_node_put() needs to be called when the device node which is got from of_parse_phandle has finished using.
--- drivers/devfreq/rk3399_dmc.c | 1 + 1 file changed, 1 insertion(+)
drivers/devfreq/rk3399_dmc.c +1 -0
@@ -372,6 +372,7 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) node =of_parse_phandle (np,"rockchip,pmu" ,0 );if (node) { data->regmap_pmu =syscon_node_to_regmap (node); +of_node_put (node);if (IS_ERR (data->regmap_pmu))return PTR_ERR (data->regmap_pmu); }
Signature · 1 line
2.17.1
Re: [PATCH 2/2] PM / devfreq: rk3399_dmc: add missing of_node_put()
2019년 12월 15일 (일) 오전 3:12, Yangtao Li <[email protected]>님이 작성:
Quoted 22 lines
of_node_put()needs to be called when the device node which is got fromof_parse_phandlehas finished using.Signed-off-by Yangtao Li <[email protected]>--- drivers/devfreq/rk3399_dmc.c | 1 + 1 file changed, 1 insertion(+)drivers/devfreq/rk3399_dmc.c +1
-1@@ -372,6 +372,7 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) node =of_parse_phandle (np,"rockchip,pmu" ,0 );if (node) { data->regmap_pmu =syscon_node_to_regmap (node); +of_node_put (node);if (IS_ERR (data->regmap_pmu))return PTR_ERR (data->regmap_pmu); } --
Quoted 2 lines
2.17.1
Applied it.
Signature · 2 lines
Best Regards, Chanwoo Choi
Chanwoo Choi
Applied2019년 12월 15일 (일) 오전 3:12, Yangtao Li <[email protected]>님이 작성:
Quoted 22 lines
of_node_putneeds to be called when the device node which is got fromof_parse_phandlehas finished using.Signed-off-by Yangtao Li <[email protected]>--- drivers/devfreq/event/rockchip-dfi.c | 1 + 1 file changed, 1 insertion(+)drivers/devfreq/event/rockchip-dfi.c +1
-1@@ -200,6 +200,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev) node =of_parse_phandle (np,"rockchip,pmu" ,0 );if (node) { data->regmap_pmu =syscon_node_to_regmap (node); +of_node_put (node);if (IS_ERR (data->regmap_pmu))return PTR_ERR (data->regmap_pmu); } --
Quoted 2 lines
2.17.1
Applied it. Better to use the capital letter for first char of sentence.
Signature · 2 lines
Best Regards, Chanwoo Choi
Quoted 20 lines · Chanwoo Choi
2019년 12월 15일 (일) 오전 3:12, Yangtao Li <[email protected]>님이 작성:
Quoted 18 lines
of_node_putneeds to be called when the device node which is got fromof_parse_phandlehas finished using.Signed-off-by Yangtao Li <[email protected]>--- drivers/devfreq/event/rockchip-dfi.c | 1 + 1 file changed, 1 insertion(+)drivers/devfreq/event/rockchip-dfi.c +1
-0@@ -200,6 +200,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev) node =of_parse_phandle (np,"rockchip,pmu" ,0 );if (node) { data->regmap_pmu =syscon_node_to_regmap (node); +of_node_put (node);
Quoted 8 lines
Quoted 6 lines
drivers/devfreq/event/rockchip-dfi.c +0
-1if (IS_ERR (data->regmap_pmu))return PTR_ERR (data->regmap_pmu); } --2.17.1
Applied it. Better to use the capital letter for first char of sentence.
Thx!
Yangtao
Quoted 4 lines
--
Best Regards,
Chanwoo Choi
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel