Skip to contentSkip to conversation

package/python-subprocess32: add PYTHON_SUBPROCESS32_CONFIGURE_CMDS

PATCH New Fabrice Fontaine 3 participants 4 messages Dec 14, 2019 – Dec 23, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/python-subprocess32: add PYTHON_SUBPROCESS32_CONFIGURE_CMDS

Since commit 1745fcde740057951dcc5429f3bfabd103b764a1, python-subprocess32 fails to build because it runs configure with incorrect arguments so add a PYTHON_SUBPROCESS32_CONFIGURE_CMDS

Fixes:
- http://autobuild.buildroot.org/results/dcf944129392ee6cacc106e096d8d3adfa4447bb

---
 .../python-subprocess32/python-subprocess32.mk  | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
package/python-subprocess32/python-subprocess32.mk +17 -0
index ee591e6a6b..fb8a47f974 100644
@@ -11,4 +11,21 @@ PYTHON_SUBPROCESS32_SETUP_TYPE = setuptools
 PYTHON_SUBPROCESS32_LICENSE = Python-2.0
 PYTHON_SUBPROCESS32_LICENSE_FILES = LICENSE
 
+# The configure step needs to be run outside of the setup.py since it isn't
+# run correctly for cross-compiling
+define PYTHON_SUBPROCESS32_CONFIGURE_CMDS
+	(cd $(@D) && \
+	$(TARGET_CONFIGURE_OPTS) \
+	$(TARGET_CONFIGURE_ARGS) \
+	./configure \
+		--target=$(GNU_TARGET_NAME) \
+		--host=$(GNU_TARGET_NAME) \
+		--build=$(GNU_HOST_NAME) \
+		--prefix=/usr \
+		--exec-prefix=/usr \
+		--sysconfdir=/etc \
+		--program-prefix="" \
+	)
+endef
+
 $(eval $(python-package))
Signature · 1 line
2.24.0
#1 lore raw

PATCH 1/1 package/python-subprocess32: add PYTHON_SUBPROCESS32_CONFIGURE_CMDS

Quoted 8 lines · On Sat, 14 Dec 2019 18:10:23 +0100 Fabrice Fontaine…

Since commit 1745fcde740057951dcc5429f3bfabd103b764a1, python-subprocess32 fails to build because it runs configure with incorrect arguments so add a PYTHON_SUBPROCESS32_CONFIGURE_CMDS

Fixes:
- http://autobuild.buildroot.org/results/dcf944129392ee6cacc106e096d8d3adfa4447bb

When seeing this, I was a bit "meh, how did it work before?". So I built python-subprocess32 with 1745fcde740057951dcc5429f3bfabd103b764a1 reverted. What happens is that the ./configure script is executed, with no arguments at all, and no CC variable is passed. So it happily uses the host compiler, does a bunch of tests with it, and then uses the resulting config.h file to build some target library. This is obviously completely bogus!

With 1745fcde740057951dcc5429f3bfabd103b764a1, we now pass CC=cross-compiler, so ./configure doesn't work because it uses a cross-compiler, but no --host= value is passed, leading to the build failure.

So 1745fcde740057951dcc5429f3bfabd103b764a1 really uncovered a real bug in the python-subprocess32 packaging, which your patch fixes.

Applied to master. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/python-subprocess32: add PYTHON_SUBPROCESS32_CONFIGURE_CMDS

Quoted 22 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Quoted 8 lines · On Sat, 14 Dec 2019 18:10:23 +0100 Fabrice Fontaine…

Since commit 1745fcde740057951dcc5429f3bfabd103b764a1, python-subprocess32 fails to build because it runs configure with incorrect arguments so add a PYTHON_SUBPROCESS32_CONFIGURE_CMDS

Fixes:
- http://autobuild.buildroot.org/results/dcf944129392ee6cacc106e096d8d3adfa4447bb

When seeing this, I was a bit "meh, how did it work before?". So I built python-subprocess32 with 1745fcde740057951dcc5429f3bfabd103b764a1 reverted. What happens is that the ./configure script is executed, with no arguments at all, and no CC variable is passed. So it happily uses the host compiler, does a bunch of tests with it, and then uses the resulting config.h file to build some target library. This is obviously completely bogus!

Quoted 7 lines

With 1745fcde740057951dcc5429f3bfabd103b764a1, we now pass CC=cross-compiler, so ./configure doesn't work because it uses a cross-compiler, but no --host= value is passed, leading to the build failure.

So 1745fcde740057951dcc5429f3bfabd103b764a1 really uncovered a real bug in the python-subprocess32 packaging, which your patch fixes.

Wow, (part of) this info would have been great to add to the commit message.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/1 package/python-subprocess32: add PYTHON_SUBPROCESS32_CONFIGURE_CMDS

In reply to Fabrice Fontaine
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Since commit 1745fcde740057951dcc5429f3bfabd103b764a1, python-subprocess32 fails to build because it runs configure with incorrect arguments so add a PYTHON_SUBPROCESS32_CONFIGURE_CMDS

Fixes:
- http://autobuild.buildroot.org/results/dcf944129392ee6cacc106e096d8d3adfa4447bb

Committed to 2019.02.x and 2019.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard