net: dsa: ocelot: add NET_VENDOR_MICROSEMI dependency
Subsystems (4)
Vladimir Oltean
maintainerPATCH v2 1/1 net: dsa: ocelot: add NET_VENDOR_MICROSEMI dependency
From: Arnd Bergmann <[email protected]>
Selecting MSCC_OCELOT_SWITCH is not possible when NET_VENDOR_MICROSEMI is disabled:
WARNING: unmet direct dependencies detected for MSCC_OCELOT_SWITCH
Depends on [n]: NETDEVICES [=y] && ETHERNET [=n] && NET_VENDOR_MICROSEMI [=n] && NET_SWITCHDEV [=y] && HAS_IOMEM [=y] Selected by [m]:
- NET_DSA_MSCC_FELIX [=m] && NETDEVICES [=y] && HAVE_NET_DSA [=y] && NET_DSA [=y] && PCI [=y]
Add a Kconfig dependency on NET_VENDOR_MICROSEMI, which also implies CONFIG_NETDEVICES.
Depending on a vendor config violates menuconfig locality for the DSA driver, but is the smallest compromise since all other solutions are much more complicated (see [0]).
https://www.spinics.net/lists/netdev/msg618808.html
---
Changes in v2:
- Back to Arnd's and Mao's original proposal. The final straw to the much more complicated approach in the v1 linked above is the need to do this in drivers/net/ethernet/Makefile:
-obj-$(CONFIG_NET_VENDOR_MICROSEMI) += mscc/ +obj-y += mscc/
drivers/net/dsa/ocelot/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/net/dsa/ocelot/Kconfig +1 -0
@@ -2,6 +2,7 @@ config NET_DSA_MSCC_FELIX tristate "Ocelot / Felix Ethernet switch support" depends on NET_DSA && PCI + depends on NET_VENDOR_MICROSEMI select MSCC_OCELOT_SWITCH select NET_DSA_TAG_OCELOT help
Signature · 1 line
2.17.1
From: Vladimir Oltean <[email protected]>
Date: Mon, 16 Dec 2019 00:12:14 +0200
Quoted 17 lines
From: Arnd Bergmann <[email protected]>
Selecting
MSCC_OCELOT_SWITCHis not possible whenNET_VENDOR_MICROSEMIis disabled:WARNING: unmet direct dependencies detected for
MSCC_OCELOT_SWITCH
Depends on [n]: NETDEVICES [=y] && ETHERNET [=n] &&NET_VENDOR_MICROSEMI[=n] &&NET_SWITCHDEV[=y] &&HAS_IOMEM[=y] Selected by [m]:
-NET_DSA_MSCC_FELIX[=m] && NETDEVICES [=y] &&HAVE_NET_DSA[=y] &&NET_DSA[=y] && PCI [=y]Add a
Kconfigdependency onNET_VENDOR_MICROSEMI, which also impliesCONFIG_NETDEVICES.Depending on a vendor config violates menuconfig locality for the DSA driver, but is the smallest compromise since all other solutions are much more complicated (see [0]).
Quoted 6 lines
https://www.spinics.net/lists/netdev/msg618808.html
Fixes 56051948773e ("net: dsa: ocelot: add driver for Felix switch family")Signed-off-by Arnd Bergmann <[email protected]>Signed-off-by Mao Wenan <[email protected]>Signed-off-by Vladimir Oltean <[email protected]>
Applied.