kernel: events: add releases() notation
PATCH 1/1 kernel: events: add releases() notation
Add releases() notation to remove issue detected by sparse context imbalance in perf_output_end() - unexpected unlock
--- kernel/events/ring_buffer.c | 1 + 1 file changed, 1 insertion(+)
kernel/events/ring_buffer.c +1 -0
@@ -295,6 +295,7 @@ unsigned int perf_output_skip(struct perf_output_handle *handle, }void perf_output_end (struct perf_output_handle *handle) +__releases () {perf_output_put_handle (handle);rcu_read_unlock ();
Signature · 1 line
2.23.0
Peter Zijlstra
maintainerQuoted 2 lines · Jules Irenge
Add
releases()notation to remove issue detected by sparse context imbalance inperf_output_end()- unexpected unlock
None of the perf code uses the __acquire / __release annotations crud. Also, your annotation is broken, I think it should be __releases(RCU) or something like that.
Quoted 9 lines · Peter Zijlstra
Quoted 2 lines · Jules Irenge
Add
releases()notation to remove issue detected by sparse context imbalance inperf_output_end()- unexpected unlockNone of the perf code uses the
__acquire/__releaseannotations crud. Also, your annotation is broken, I think it should be__releases(RCU)or something like that.
Thanks for the response. I already updated.