virtio: update queue size on guest write
PATCH 1/1 virtio: update queue size on guest write
Some guests read back queue size after writing it. Update the size immediatly upon write otherwise they get confused.
--- hw/virtio/virtio-pci.c | 2 ++ 1 file changed, 2 insertions(+)
hw/virtio/virtio-pci.c +2 -0
@@ -1256,6 +1256,8 @@ static void virtio_pci_common_write(void *opaque, hwaddr addr,break ;case VIRTIO_PCI_COMMON_Q_SIZE : proxy->vqs[vdev->queue_sel].num = val; +virtio_queue_set_num (vdev, vdev->queue_sel, + proxy->vqs[vdev->queue_sel].num);break ;case VIRTIO_PCI_COMMON_Q_MSIX : msix_vector_unuse(&proxy->pci_dev,
Signature · 1 line
MST
Quoted 8 lines · Michael S. Tsirkin
Some guests read back queue size after writing it. Update the size immediatly upon write otherwise they get confused.
Signed-off-by Michael S. Tsirkin <[email protected]>--- hw/virtio/virtio-pci.c | 2 ++ 1 file changed, 2 insertions(+)
Just a question, should we do the same in virtio-mmio?
Maybe doing virtio_queue_set_num() in any case (legacy and non-legacy) during VIRTIO_MMIO_QUEUE_NUM writing.
Thanks,
Stefano
Quoted 18 lines
hw/virtio/virtio-pci.c +2
-0@@ -1256,6 +1256,8 @@ static void virtio_pci_common_write(void *opaque, hwaddr addr,break ;case VIRTIO_PCI_COMMON_Q_SIZE : proxy->vqs[vdev->queue_sel].num = val; +virtio_queue_set_num (vdev, vdev->queue_sel, + proxy->vqs[vdev->queue_sel].num);break ;case VIRTIO_PCI_COMMON_Q_MSIX : msix_vector_unuse(&proxy->pci_dev,Signature · 1 line
MST
Quoted 13 lines · Stefano Garzarella
Quoted 8 lines · Michael S. Tsirkin
Some guests read back queue size after writing it. Update the size immediatly upon write otherwise they get confused.
Signed-off-by Michael S. Tsirkin <[email protected]>--- hw/virtio/virtio-pci.c | 2 ++ 1 file changed, 2 insertions(+)Reviewed-by Stefano Garzarella <[email protected]>
Quoted 7 lines
Just a question, should we do the same in virtio-mmio?
Maybe doing
virtio_queue_set_num()in any case (legacy and non-legacy) duringVIRTIO_MMIO_QUEUE_NUMwriting.Thanks,
Stefano
I guess it makes sense ...
Quoted 20 lines
Quoted 18 lines
hw/virtio/virtio-pci.c +2
-0@@ -1256,6 +1256,8 @@ static void virtio_pci_common_write(void *opaque, hwaddr addr,break ;case VIRTIO_PCI_COMMON_Q_SIZE : proxy->vqs[vdev->queue_sel].num = val; +virtio_queue_set_num (vdev, vdev->queue_sel, + proxy->vqs[vdev->queue_sel].num);break ;case VIRTIO_PCI_COMMON_Q_MSIX : msix_vector_unuse(&proxy->pci_dev,Signature · 1 line
MST