Skip to contentSkip to conversation

mach-imx: nandbcb: improve cmd help

PATCH New Igor Opaniuk 3 participants 3 messages Dec 16, 2019 – Jan 4, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mach-imx: nandbcb: improve cmd help

From: Igor Opaniuk <[email protected]>

Add info about supported i.MX7, improve details the usage of bcbonly subcommand.

---

 arch/arm/mach-imx/cmd_nandbcb.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
arch/arm/mach-imx/cmd_nandbcb.c +6 -3
index 9d3ed1aac3..334cc0766e 100644
@@ -590,11 +590,14 @@ static char nandbcb_help_text[] =
 	"update addr off|partition len	- update 'len' bytes starting at\n"
 	"       'off|part' to memory address 'addr', skipping  bad blocks\n"
 	"bcbonly fw-size fw1-off [fw2-off] - write only BCB (FCB and DBBT)\n"
-	"       where `fw-size` is fw sizes in bytes, `fw1-off` and\n"
-	"       and `fw2-off` - firmware offsets		";
+	"       where `fw-size` is fw sizes in bytes, `fw1-off`\n"
+	"       and `fw2-off` - firmware offsets\n"
+	"       FIY, BCB isn't erased automatically, so mtd erase should\n"
+	"       be called in advance before writing new BCB:\n"
+	"           > mtd erase mx7-bcb";
 #endif
 
 U_BOOT_CMD(nandbcb, 5, 1, do_nandbcb,
-	   "i.MX6 Nand BCB",
+	   "i.MX6/i.MX7 NAND Boot Control Blocks write",
 	   nandbcb_help_text
 );
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 mach-imx: nandbcb: improve cmd help

Quoted 7 lines · Igor Opaniuk

From: Igor Opaniuk <[email protected]>

Add info about supported i.MX7, improve details the usage of bcbonly subcommand.

Quoted 30 lines

---

 arch/arm/mach-imx/cmd_nandbcb.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
arch/arm/mach-imx/cmd_nandbcb.c +6 -4
index 9d3ed1aac3..334cc0766e 100644
@@ -590,11 +590,14 @@ static char nandbcb_help_text[] =
        "update addr off|partition len  - update 'len' bytes starting at\n"
        "       'off|part' to memory address 'addr', skipping  bad blocks\n"
        "bcbonly fw-size fw1-off [fw2-off] - write only BCB (FCB and DBBT)\n"
-       "       where `fw-size` is fw sizes in bytes, `fw1-off` and\n"
-       "       and `fw2-off` - firmware offsets                ";
+       "       where `fw-size` is fw sizes in bytes, `fw1-off`\n"
+       "       and `fw2-off` - firmware offsets\n"
+       "       FIY, BCB isn't erased automatically, so mtd erase should\n"
+       "       be called in advance before writing new BCB:\n"
+       "           > mtd erase mx7-bcb";
 #endif
 
 U_BOOT_CMD(nandbcb, 5, 1, do_nandbcb,
-          "i.MX6 Nand BCB",
+          "i.MX6/i.MX7 NAND Boot Control Blocks write",
           nandbcb_help_text
 );
--

2.17.1

Signature · 6 lines
Best regards
Oleksandr Suvorov

Toradex AG
Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500
4800 (main line)
#2 lore raw

PATCH 1/1 mach-imx: nandbcb: improve cmd help

In reply to Igor Opaniuk
Quoted 5 lines

From: Igor Opaniuk <[email protected]>
Add info about supported i.MX7, improve details the usage of bcbonly subcommand.

Applied to u-boot-imx, -next, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================