drm/panfrost: Prefix interrupt handlers' names
Subsystems (3)
PATCH v2 1/1 drm/panfrost: Prefix interrupt handlers' names
Currently, the interrupt lines requested by Panfrost use unmeaningful names, which adds some obscurity to interrupt introspection (i.e. any tool based on procfs' interrupts file).
In order to improve this, prefix each requested interrupt with the module name: panfrost-{gpu,job,mmu}.
---
v2:
* Use consistent naming, as suggested by Alyssa, Neil and Robin.
drivers/gpu/drm/panfrost/panfrost_gpu.c | 2 +- drivers/gpu/drm/panfrost/panfrost_job.c | 2 +- drivers/gpu/drm/panfrost/panfrost_mmu.c | 6 ++++-- 3 files changed, 6 insertions(+), 4 deletions(-)
drivers/gpu/drm/panfrost/panfrost_gpu.c +1 -1
@@ -348,7 +348,7 @@ int panfrost_gpu_init(struct panfrost_device *pfdev)return -ENODEV ; err =devm_request_irq (pfdev->dev, irq, panfrost_gpu_irq_handler, -IRQF_SHARED ,"gpu" , pfdev); +IRQF_SHARED ,KBUILD_MODNAME "-gpu" , pfdev);if (err) {dev_err (pfdev->dev,"failed to request gpu irq" );return err;
drivers/gpu/drm/panfrost/panfrost_job.c +1 -1
@@ -480,7 +480,7 @@ int panfrost_job_init(struct panfrost_device *pfdev)return -ENODEV ; ret =devm_request_irq (pfdev->dev, irq, panfrost_job_irq_handler, -IRQF_SHARED ,"job" , pfdev); +IRQF_SHARED ,KBUILD_MODNAME "-job" , pfdev);if (ret) {dev_err (pfdev->dev,"failed to request job irq" );return ret;
drivers/gpu/drm/panfrost/panfrost_mmu.c +4 -2
@@ -612,9 +612,11 @@ int panfrost_mmu_init(struct panfrost_device *pfdev)if (irq <=0 )return -ENODEV ; - err =devm_request_threaded_irq (pfdev->dev, irq, panfrost_mmu_irq_handler, + err =devm_request_threaded_irq (pfdev->dev, irq, + panfrost_mmu_irq_handler, panfrost_mmu_irq_handler_thread, -IRQF_SHARED ,"mmu" , pfdev); +IRQF_SHARED ,KBUILD_MODNAME "-mmu" , + pfdev);if (err) {dev_err (pfdev->dev,"failed to request mmu irq" );
Signature · 6 lines
2.22.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 9 lines · Ezequiel Garcia
Currently, the interrupt lines requested by Panfrost use unmeaningful names, which adds some obscurity to interrupt introspection (i.e. any tool based on procfs' interrupts file).
In order to improve this, prefix each requested interrupt with the module name: panfrost-{gpu,job,mmu}.
Signed-off-by Ezequiel Garcia <[email protected]>
LGTM
Quoted 44 lines
---
v2:
* Use consistent naming, as suggested by Alyssa, Neil and Robin.drivers/gpu/drm/panfrost/panfrost_gpu.c | 2 +- drivers/gpu/drm/panfrost/panfrost_job.c | 2 +- drivers/gpu/drm/panfrost/panfrost_mmu.c | 6 ++++-- 3 files changed, 6 insertions(+), 4 deletions(-)drivers/gpu/drm/panfrost/panfrost_gpu.c +1
-1@@ -348,7 +348,7 @@ int panfrost_gpu_init(struct panfrost_device *pfdev)return -ENODEV ; err =devm_request_irq (pfdev->dev, irq, panfrost_gpu_irq_handler, -IRQF_SHARED ,"gpu" , pfdev); +IRQF_SHARED ,KBUILD_MODNAME "-gpu" , pfdev);if (err) {dev_err (pfdev->dev,"failed to request gpu irq" );return err;drivers/gpu/drm/panfrost/panfrost_job.c +1
-1@@ -480,7 +480,7 @@ int panfrost_job_init(struct panfrost_device *pfdev)return -ENODEV ; ret =devm_request_irq (pfdev->dev, irq, panfrost_job_irq_handler, -IRQF_SHARED ,"job" , pfdev); +IRQF_SHARED ,KBUILD_MODNAME "-job" , pfdev);if (ret) {dev_err (pfdev->dev,"failed to request job irq" );return ret;drivers/gpu/drm/panfrost/panfrost_mmu.c +0
-0@@ -612,9 +612,11 @@ int panfrost_mmu_init(struct panfrost_device *pfdev)if (irq <=0 )return -ENODEV ;
drivers/gpu/drm/panfrost/panfrost_mmu.c int panfrost_mmu_init(struct panfrost_device *pfdev) · line 622
Quoted 10 lines
drivers/gpu/drm/panfrost/panfrost_mmu.c +4
-2- err =devm_request_threaded_irq (pfdev->dev, irq, panfrost_mmu_irq_handler, + err =devm_request_threaded_irq (pfdev->dev, irq, + panfrost_mmu_irq_handler, panfrost_mmu_irq_handler_thread, -IRQF_SHARED ,"mmu" , pfdev); +IRQF_SHARED ,KBUILD_MODNAME "-mmu" , + pfdev);if (err) {dev_err (pfdev->dev,"failed to request mmu irq" );
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 9 lines · Ezequiel Garcia
Currently, the interrupt lines requested by Panfrost use unmeaningful names, which adds some obscurity to interrupt introspection (i.e. any tool based on procfs' interrupts file).
In order to improve this, prefix each requested interrupt with the module name: panfrost-{gpu,job,mmu}.
Signed-off-by Ezequiel Garcia <[email protected]>
Gentle ping.
Thanks,
Ezequiel
Quoted 43 lines
---
v2:
* Use consistent naming, as suggested by Alyssa, Neil and Robin.drivers/gpu/drm/panfrost/panfrost_gpu.c | 2 +- drivers/gpu/drm/panfrost/panfrost_job.c | 2 +- drivers/gpu/drm/panfrost/panfrost_mmu.c | 6 ++++-- 3 files changed, 6 insertions(+), 4 deletions(-)drivers/gpu/drm/panfrost/panfrost_gpu.c +1
-1@@ -348,7 +348,7 @@ int panfrost_gpu_init(struct panfrost_device *pfdev)return -ENODEV ; err =devm_request_irq (pfdev->dev, irq, panfrost_gpu_irq_handler, -IRQF_SHARED ,"gpu" , pfdev); +IRQF_SHARED ,KBUILD_MODNAME "-gpu" , pfdev);if (err) {dev_err (pfdev->dev,"failed to request gpu irq" );return err;drivers/gpu/drm/panfrost/panfrost_job.c +1
-1@@ -480,7 +480,7 @@ int panfrost_job_init(struct panfrost_device *pfdev)return -ENODEV ; ret =devm_request_irq (pfdev->dev, irq, panfrost_job_irq_handler, -IRQF_SHARED ,"job" , pfdev); +IRQF_SHARED ,KBUILD_MODNAME "-job" , pfdev);if (ret) {dev_err (pfdev->dev,"failed to request job irq" );return ret;drivers/gpu/drm/panfrost/panfrost_mmu.c +0
-0@@ -612,9 +612,11 @@ int panfrost_mmu_init(struct panfrost_device *pfdev)if (irq <=0 )return -ENODEV ;
drivers/gpu/drm/panfrost/panfrost_mmu.c int panfrost_mmu_init(struct panfrost_device *pfdev) · line 622
Quoted 10 lines
drivers/gpu/drm/panfrost/panfrost_mmu.c +4
-2- err =devm_request_threaded_irq (pfdev->dev, irq, panfrost_mmu_irq_handler, + err =devm_request_threaded_irq (pfdev->dev, irq, + panfrost_mmu_irq_handler, panfrost_mmu_irq_handler_thread, -IRQF_SHARED ,"mmu" , pfdev); +IRQF_SHARED ,KBUILD_MODNAME "-mmu" , + pfdev);if (err) {dev_err (pfdev->dev,"failed to request mmu irq" );
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 7 lines · Ezequiel Garcia
Quoted 5 lines · Ezequiel Garcia
Currently, the interrupt lines requested by Panfrost use unmeaningful names, which adds some obscurity to interrupt introspection (i.e. any tool based on procfs' interrupts file).
Quoted 6 lines
Quoted 4 lines
In order to improve this, prefix each requested interrupt with the module name: panfrost-{gpu,job,mmu}.
Signed-off-by Ezequiel Garcia <[email protected]>Gentle ping.
Applied.
Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel