Skip to contentSkip to conversation

arm64: dts: qcom: sm8150: Update UFS resets

PATCH New Vinod Koul 1 participant 2 messages Dec 16, 2019

Subsystems (3)
lore
Share & tools
lore

Vinod Koul

author
#0 lore raw

PATCH 1/2 arm64: dts: qcom: sm8150: Update UFS resets

The reset described is the phy reset so it should be named ufsphy, so update it and add the UFS card reset

Earlier reset description was incorrect as phy reset was pointed to 'rst' as well as 'ufsphy' so both phy and core attempted to reset this causing UFS to not come up. This was discovered with 870b1279c7a0 ("scsi: ufs-qcom: Add reset control support for host controller")

---
 arch/arm64/boot/dts/qcom/sm8150.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/sm8150.dtsi +3 -2
index f36d621a53e2..6a351e0cb3a6 100644
@@ -517,8 +517,9 @@
 			phy-names = "ufsphy";
 			lanes-per-direction = <2>;
 			#reset-cells = <1>;
-			resets = <&gcc GCC_UFS_PHY_BCR>;
-			reset-names = "rst";
+			resets = <&gcc GCC_UFS_PHY_BCR>,
+				 <&gcc GCC_UFS_CARD_BCR>;
+			reset-names = "ufsphy", "rst";
 
 			clock-names =
 				"core_clk",
Signature · 1 line
2.23.0
author
#1 lore raw

PATCH 2/2 arm64: dts: qcom: sm8150-mtp: Add reset line for UFS

Add the reset line for the UFS node.

---
 arch/arm64/boot/dts/qcom/sm8150-mtp.dts | 3 +++
 1 file changed, 3 insertions(+)
arch/arm64/boot/dts/qcom/sm8150-mtp.dts +3 -0
index 1eb93a768a85..9cab51759d2f 100644
@@ -7,6 +7,7 @@
 /dts-v1/;
 
 #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+#include <dt-bindings/gpio/gpio.h>
 #include "sm8150.dtsi"
 #include "pm8150.dtsi"
 #include "pm8150b.dtsi"
@@ -389,6 +390,8 @@
 &ufs_mem_hc {
 	status = "okay";
 
+	reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>;
+
 	vcc-supply = <&vreg_l10a_2p5>;
 	vcc-max-microamp = <750000>;
 	vccq-supply = <&vreg_l9a_1p2>;
Signature · 1 line
2.23.0