Skip to contentSkip to conversation

drm: Add getfb2 ioctl

PATCH In review Juston Li 3 participants 4 messages Dec 17, 2019 – Jan 13, 2020

Subsystems (2)
lore
Share & tools
lore

Juston Li

author
#0 lore raw

PATCH v3 1/1 drm: Add getfb2 ioctl

From: Daniel Stone <[email protected]>

getfb2 allows us to pass multiple planes and modifiers, just like addfb2 over addfb.

Changes since v2:
- add privilege checks from getfb1 since handles should only be returned to master/root

Changes since v1:
- unused modifiers set to 0 instead of DRM_FORMAT_MOD_INVALID
- update ioctl number

---
 drivers/gpu/drm/drm_crtc_internal.h |   2 +
 drivers/gpu/drm/drm_framebuffer.c   | 122 ++++++++++++++++++++++++++++
 drivers/gpu/drm/drm_ioctl.c         |   1 +
 include/uapi/drm/drm.h              |   2 +
 4 files changed, 127 insertions(+)
drivers/gpu/drm/drm_crtc_internal.h +2 -0
index c7d5e4c21423..16f2413403aa 100644
@@ -216,6 +216,8 @@ int drm_mode_rmfb_ioctl(struct drm_device *dev,
 			void *data, struct drm_file *file_priv);
 int drm_mode_getfb(struct drm_device *dev,
 		   void *data, struct drm_file *file_priv);
+int drm_mode_getfb2_ioctl(struct drm_device *dev,
+			  void *data, struct drm_file *file_priv);
 int drm_mode_dirtyfb_ioctl(struct drm_device *dev,
 			   void *data, struct drm_file *file_priv);
 
drivers/gpu/drm/drm_framebuffer.c +122 -0

135 lines not on this page · raw message

drivers/gpu/drm/drm_ioctl.c +1 -0
index 5afb39688b55..9e41972c4bbc 100644
@@ -671,6 +671,7 @@ static const struct drm_ioctl_desc drm_ioctls[] = {
 	DRM_IOCTL_DEF(DRM_IOCTL_MODE_SETPROPERTY, drm_connector_property_set_ioctl, DRM_MASTER),
 	DRM_IOCTL_DEF(DRM_IOCTL_MODE_GETPROPBLOB, drm_mode_getblob_ioctl, 0),
 	DRM_IOCTL_DEF(DRM_IOCTL_MODE_GETFB, drm_mode_getfb, 0),
+	DRM_IOCTL_DEF(DRM_IOCTL_MODE_GETFB2, drm_mode_getfb2_ioctl, 0),
 	DRM_IOCTL_DEF(DRM_IOCTL_MODE_ADDFB, drm_mode_addfb_ioctl, 0),
 	DRM_IOCTL_DEF(DRM_IOCTL_MODE_ADDFB2, drm_mode_addfb2_ioctl, 0),
 	DRM_IOCTL_DEF(DRM_IOCTL_MODE_RMFB, drm_mode_rmfb_ioctl, 0),
include/uapi/drm/drm.h +2 -0
index 868bf7996c0f..808b48a93330 100644
@@ -948,6 +948,8 @@ extern "C" {
 #define DRM_IOCTL_SYNCOBJ_TRANSFER	DRM_IOWR(0xCC, struct drm_syncobj_transfer)
 #define DRM_IOCTL_SYNCOBJ_TIMELINE_SIGNAL	DRM_IOWR(0xCD, struct drm_syncobj_timeline_array)
 
+#define DRM_IOCTL_MODE_GETFB2		DRM_IOWR(0xCE, struct drm_mode_fb_cmd2)
+
 /**
  * Device specific ioctls should only be in their respective headers
  * The device specific ioctl range is from 0x40 to 0x9f.
Signature · 6 lines
2.21.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Add getfb2 ioctl (rev2)

== Series Details ==

== Series Details ==

Series: drm: Add getfb2 ioctl (rev2)
URL : https://patchwork.freedesktop.org/series/67553/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7578 -> Patchwork_15806
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15806/index.html

Known issues
------------

Here are the changes found in Patchwork_15806 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_close_race@basic-threads:
- fi-byt-j1900: [PASS][1] -> [TIMEOUT][2] ([i915#816])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-byt-j1900/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15806/fi-byt-j1900/igt@[email protected]

* igt@i915_module_load@reload-with-fault-injection:
- fi-skl-6770hq: [PASS][3] -> [DMESG-WARN][4] ([i915#88])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-skl-6770hq/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15806/fi-skl-6770hq/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [PASS][5] -> [FAIL][6] ([i915#178])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-skl-6770hq/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15806/fi-skl-6770hq/igt@[email protected]

* igt@i915_selftest@live_blt:
- fi-hsw-4770r: [PASS][7] -> [DMESG-FAIL][8] ([i915#553] / [i915#725])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15806/fi-hsw-4770r/igt@i915_selftest@live_blt.html

* igt@i915_selftest@live_gem_contexts:
- fi-hsw-peppy: [PASS][9] -> [INCOMPLETE][10] ([i915#694])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15806/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html

#### Possible fixes ####

* igt@gem_exec_parallel@basic:
- {fi-tgl-u}: [INCOMPLETE][11] ([i915#476]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-tgl-u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15806/fi-tgl-u/igt@[email protected]

* igt@gem_exec_suspend@basic-s3:
- fi-icl-u2: [FAIL][13] ([fdo#103375]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-icl-u2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15806/fi-icl-u2/igt@[email protected]

* igt@gem_exec_suspend@basic-s4-devices:
- fi-icl-u2: [FAIL][15] ([fdo#111550]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-icl-u2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15806/fi-icl-u2/igt@[email protected]

* igt@i915_selftest@live_gem_contexts:
- fi-cfl-guc: [DMESG-FAIL][17] ([i915#730]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15806/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html

* igt@kms_busy@basic-flip-pipe-a:
- fi-icl-u2: [INCOMPLETE][19] ([i915#140]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-icl-u2/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15806/fi-icl-u2/igt@[email protected]

* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [FAIL][21] ([fdo#109635] / [i915#217]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-7500u/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15806/fi-kbl-7500u/igt@[email protected]

#### Warnings ####

* igt@gem_exec_suspend@basic-s0:
- fi-kbl-x1275: [DMESG-WARN][23] ([i915#62] / [i915#92]) -> [DMESG-WARN][24] ([i915#62] / [i915#92] / [i915#95]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-x1275/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15806/fi-kbl-x1275/igt@[email protected]

* igt@i915_selftest@live_blt:
- fi-hsw-4770: [DMESG-FAIL][25] ([i915#553] / [i915#725]) -> [DMESG-FAIL][26] ([i915#725])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-hsw-4770/igt@i915_selftest@live_blt.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15806/fi-hsw-4770/igt@i915_selftest@live_blt.html

* igt@i915_selftest@live_gem_contexts:
- fi-byt-n2820: [DMESG-FAIL][27] ([i915#722]) -> [INCOMPLETE][28] ([i915#45])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15806/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][29] ([fdo#111096] / [i915#323]) -> [FAIL][30] ([fdo#111407])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-7500u/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15806/fi-kbl-7500u/igt@[email protected]

* igt@kms_flip@basic-flip-vs-modeset:
- fi-kbl-x1275: [DMESG-WARN][31] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][32] ([i915#62] / [i915#92]) +12 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-x1275/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15806/fi-kbl-x1275/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109635]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111550]: https://bugs.freedesktop.org/show_bug.cgi?id=111550
[fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
[i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
[i915#178]: https://gitlab.freedesktop.org/drm/intel/issues/178
[i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
[i915#476]: https://gitlab.freedesktop.org/drm/intel/issues/476
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#730]: https://gitlab.freedesktop.org/drm/intel/issues/730
[i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816
[i915#88]: https://gitlab.freedesktop.org/drm/intel/issues/88
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95

Participating hosts (51 -> 44)
------------------------------

Additional (1): fi-kbl-soraka
Missing (8): fi-ilk-m540 fi-bdw-5557u fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_7578 -> Patchwork_15806

CI-20190529: 20190529
CI_DRM_7578: cc329d389f5609d2969d0797bc96f754adb26d62 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5349: 048f58513d8b8ec6bb307a939f0ac959bc0f0e10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15806: 338b48526ab5b69bd0f5199a45fea10f04dea2e9 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

338b48526ab5 drm: Add getfb2 ioctl

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15806/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm: Add getfb2 ioctl (rev2)

In reply to Juston Li
== Series Details ==

== Series Details ==

Series: drm: Add getfb2 ioctl (rev2)
URL : https://patchwork.freedesktop.org/series/67553/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7578_full -> Patchwork_15806_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_15806_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_15806_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_15806_full:

### IGT changes ###

#### Possible regressions ####

* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
- shard-apl: [PASS][1] -> [TIMEOUT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl3/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15806/shard-apl1/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html

### Piglit changes ###

#### Possible regressions ####

* [email protected]@execution@texelfetch@fs-texelfetch-isampler1darray (NEW):
- {pig-hsw-4770r}: NOTRUN -> [FAIL][3] +958 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15806/pig-hsw-4770r/[email protected]@execution@[email protected]

New tests
---------

New tests have been introduced between CI_DRM_7578_full and Patchwork_15806_full:

### New Piglit tests (960) ###

* object namespace pollution@texture with glcopyimagesubdata:
- Statuses : 1 fail(s)
- Exec time: [0.12] s

* object namespace pollution@texture with gldrawpixels:
- Statuses : 1 fail(s)
- Exec time: [0.17] s

* object namespace pollution@texture with glgetteximage-compressed:
- Statuses : 1 fail(s)
- Exec time: [0.32] s

* shaders@glsl-fs-frontfacing-not:
- Statuses : 1 fail(s)
- Exec time: [0.12] s

* spec@!opengl 1.1@depthstencil-default_fb-copypixels samples=2:
- Statuses : 1 fail(s)
- Exec time: [0.09] s

* spec@!opengl 1.1@depthstencil-default_fb-drawpixels-24_8 samples=2:
- Statuses : 1 fail(s)
- Exec time: [0.09] s

* spec@!opengl 1.1@depthstencil-default_fb-drawpixels-float-and-ushort:
- Statuses : 1 fail(s)
- Exec time: [0.08] s

* spec@!opengl 1.1@depthstencil-default_fb-drawpixels-float-and-ushort samples=2:
- Statuses : 1 fail(s)
- Exec time: [0.09] s

* spec@!opengl 1.1@depthstencil-default_fb-readpixels-32f_24_8_rev samples=2:
- Statuses : 1 fail(s)
- Exec time: [0.08] s

* spec@!opengl 1.1@draw-pixels:
- Statuses : 1 fail(s)
- Exec time: [0.99] s

* spec@!opengl 1.1@getteximage-depth:
- Statuses : 1 fail(s)
- Exec time: [6.34] s

* spec@!opengl 1.1@getteximage-formats:
- Statuses : 1 fail(s)
- Exec time: [8.79] s

* spec@!opengl 1.1@teximage-colors gl_alpha:
- Statuses : 1 fail(s)
- Exec time: [0.28] s

* spec@!opengl 1.1@teximage-colors gl_alpha12:
- Statuses : 1 fail(s)
- Exec time: [0.34] s

* spec@!opengl 1.1@teximage-colors gl_alpha16:
- Statuses : 1 fail(s)
- Exec time: [0.37] s

* spec@!opengl 1.1@teximage-colors gl_alpha4:
- Statuses : 1 fail(s)
- Exec time: [0.34] s

* spec@!opengl 1.1@teximage-colors gl_alpha8:
- Statuses : 1 fail(s)
- Exec time: [0.31] s

* spec@!opengl 1.1@teximage-colors gl_luminance:
- Statuses : 1 fail(s)
- Exec time: [0.31] s

* spec@!opengl 1.1@teximage-colors gl_luminance12:
- Statuses : 1 fail(s)
- Exec time: [0.29] s

* spec@!opengl 1.1@teximage-colors gl_luminance12_alpha12:
- Statuses : 1 fail(s)
- Exec time: [0.31] s

* spec@!opengl 1.1@teximage-colors gl_luminance12_alpha4:
- Statuses : 1 fail(s)
- Exec time: [0.37] s

* spec@!opengl 1.1@teximage-colors gl_luminance16:
- Statuses : 1 fail(s)
- Exec time: [0.35] s

* spec@!opengl 1.1@teximage-colors gl_luminance16_alpha16:
- Statuses : 1 fail(s)
- Exec time: [0.35] s

* spec@!opengl 1.1@teximage-colors gl_luminance4:
- Statuses : 1 fail(s)
- Exec time: [0.35] s

* spec@!opengl 1.1@teximage-colors gl_luminance4_alpha4:
- Statuses : 1 fail(s)
- Exec time: [0.28] s

* spec@!opengl 1.1@teximage-colors gl_luminance6_alpha2:
- Statuses : 1 fail(s)
- Exec time: [0.31] s

* spec@!opengl 1.1@teximage-colors gl_luminance8:
- Statuses : 1 fail(s)
- Exec time: [0.28] s

* spec@!opengl 1.1@teximage-colors gl_luminance8_alpha8:
- Statuses : 1 fail(s)
- Exec time: [0.32] s

* spec@!opengl 1.1@teximage-colors gl_luminance_alpha:
- Statuses : 1 fail(s)
- Exec time: [0.31] s

* spec@!opengl 1.1@teximage-colors gl_r11f_g11f_b10f:
- Statuses : 1 fail(s)
- Exec time: [0.31] s

* spec@!opengl 1.1@teximage-colors gl_r16:
- Statuses : 1 fail(s)
- Exec time: [0.33] s

* spec@!opengl 1.1@teximage-colors gl_r16_snorm:
- Statuses : 1 fail(s)
- Exec time: [0.34] s

* spec@!opengl 1.1@teximage-colors gl_r16f:
- Statuses : 1 fail(s)
- Exec time: [0.32] s

* spec@!opengl 1.1@teximage-colors gl_r32f:
- Statuses : 1 fail(s)
- Exec time: [0.29] s

* spec@!opengl 1.1@teximage-colors gl_r3_g3_b2:
- Statuses : 1 fail(s)
- Exec time: [0.34] s

* spec@!opengl 1.1@teximage-colors gl_r8:
- Statuses : 1 fail(s)
- Exec time: [0.32] s

* spec@!opengl 1.1@teximage-colors gl_r8_snorm:
- Statuses : 1 fail(s)
- Exec time: [0.32] s

* spec@!opengl 1.1@teximage-colors gl_red:
- Statuses : 1 fail(s)
- Exec time: [0.36] s

* spec@!opengl 1.1@teximage-colors gl_rg:
- Statuses : 1 fail(s)
- Exec time: [0.29] s

* spec@!opengl 1.1@teximage-colors gl_rg16:
- Statuses : 1 fail(s)
- Exec time: [0.31] s

* spec@!opengl 1.1@teximage-colors gl_rg16_snorm:
- Statuses : 1 fail(s)
- Exec time: [0.30] s

* spec@!opengl 1.1@teximage-colors gl_rg16f:
- Statuses : 1 fail(s)
- Exec time: [0.29] s

* spec@!opengl 1.1@teximage-colors gl_rg32f:
- Statuses : 1 fail(s)
- Exec time: [0.34] s

* spec@!opengl 1.1@teximage-colors gl_rg8:
- Statuses : 1 fail(s)
- Exec time: [0.31] s

* spec@!opengl 1.1@teximage-colors gl_rg8_snorm:
- Statuses : 1 fail(s)
- Exec time: [0.31] s

* spec@!opengl 1.1@teximage-colors gl_rgb:
- Statuses : 1 fail(s)
- Exec time: [0.30] s

* spec@!opengl 1.1@teximage-colors gl_rgb10:
- Statuses : 1 fail(s)
- Exec time: [0.29] s

* spec@!opengl 1.1@teximage-colors gl_rgb10_a2:
- Statuses : 1 fail(s)
- Exec time: [0.29] s

* spec@!opengl 1.1@teximage-colors gl_rgb12:
- Statuses : 1 fail(s)
- Exec time: [0.34] s

* spec@!opengl 1.1@teximage-colors gl_rgb16:
- Statuses : 1 fail(s)
- Exec time: [0.29] s

* spec@!opengl 1.1@teximage-colors gl_rgb16_snorm:
- Statuses : 1 fail(s)
- Exec time: [0.31] s

* spec@!opengl 1.1@teximage-colors gl_rgb16f:
- Statuses : 1 fail(s)
- Exec time: [0.34] s

* spec@!opengl 1.1@teximage-colors gl_rgb32f:
- Statuses : 1 fail(s)
- Exec time: [0.27] s

* spec@!opengl 1.1@teximage-colors gl_rgb4:
- Statuses : 1 fail(s)
- Exec time: [0.32] s

* spec@!opengl 1.1@teximage-colors gl_rgb5:
- Statuses : 1 fail(s)
- Exec time: [0.29] s

* spec@!opengl 1.1@teximage-colors gl_rgb5_a1:
- Statuses : 1 fail(s)
- Exec time: [0.33] s

* spec@!opengl 1.1@teximage-colors gl_rgb8:
- Statuses : 1 fail(s)
- Exec time: [0.29] s

* spec@!opengl 1.1@teximage-colors gl_rgb8_snorm:
- Statuses : 1 fail(s)
- Exec time: [0.36] s

* spec@!opengl 1.1@teximage-colors gl_rgb9_e5:
- Statuses : 1 fail(s)
- Exec time: [0.30] s

* spec@!opengl 1.1@teximage-colors gl_rgba:
- Statuses : 1 fail(s)
- Exec time: [0.35] s

* spec@!opengl 1.1@teximage-colors gl_rgba12:
- Statuses : 1 fail(s)
- Exec time: [0.29] s

* spec@!opengl 1.1@teximage-colors gl_rgba16:
- Statuses : 1 fail(s)
- Exec time: [0.25] s

* spec@!opengl 1.1@teximage-colors gl_rgba16_snorm:
- Statuses : 1 fail(s)
- Exec time: [0.31] s

* spec@!opengl 1.1@teximage-colors gl_rgba2:
- Statuses : 1 fail(s)
- Exec time: [0.30] s

* spec@!opengl 1.1@teximage-colors gl_rgba32f:
- Statuses : 1 fail(s)
- Exec time: [0.29] s

* spec@!opengl 1.1@teximage-colors gl_rgba4:
- Statuses : 1 fail(s)
- Exec time: [0.33] s

* spec@!opengl 1.1@teximage-colors gl_rgba8:
- Statuses : 1 fail(s)
- Exec time: [0.29] s

* spec@!opengl 1.1@teximage-colors gl_rgba8_snorm:
- Statuses : 1 fail(s)
- Exec time: [0.33] s

* spec@!opengl 1.1@teximage-colors gl_sluminance8:
- Statuses : 1 fail(s)
- Exec time: [0.35] s

* spec@!opengl 1.1@teximage-colors gl_sluminance8_alpha8:
- Statuses : 1 fail(s)
- Exec time: [0.34] s

* spec@!opengl 1.1@teximage-colors gl_srgb8:
- Statuses : 1 fail(s)
- Exec time: [0.39] s

* spec@!opengl 1.1@teximage-colors gl_srgb8_alpha8:
- Statuses : 1 fail(s)
- Exec time: [0.29] s

* spec@!opengl 1.1@texsubimage-unpack:
- Statuses : 1 fail(s)
- Exec time: [7.96] s

* spec@!opengl 1.1@texture-al:
- Statuses : 1 fail(s)
- Exec time: [0.10] s

* spec@!opengl 1.1@texwrap formats:
- Statuses : 1 fail(s)
- Exec time: [0.31] s

* spec@!opengl 1.1@texwrap formats bordercolor:
- Statuses : 1 fail(s)
- Exec time: [0.16] s

* spec@!opengl 1.1@texwrap formats bordercolor-swizzled:
- Statuses : 1 fail(s)
- Exec time: [0.18] s

* spec@!opengl 1.1@texwrap formats offset:
- Statuses : 1 fail(s)
- Exec time: [0.32] s

* spec@!opengl 1.2@copyteximage 3d:
- Statuses : 1 fail(s)
- Exec time: [0.31] s

* spec@!opengl 1.2@draw-elements-vs-inputs:
- Statuses : 1 fail(s)
- Exec time: [0.12] s

* spec@!opengl 1.2@getteximage-targets 3d:
- Statuses : 1 fail(s)
- Exec time: [0.13] s

* spec@!opengl 1.2@levelclamp:
- Statuses : 1 fail(s)
- Exec time: [0.19] s

* spec@!opengl 1.2@lodclamp:
- Statuses : 1 fail(s)
- Exec time: [0.21] s

* spec@!opengl 1.2@mipmap-setup:
- Statuses : 1 fail(s)
- Exec time: [0.09] s

* spec@!opengl 1.2@tex3d:
- Statuses : 1 fail(s)
- Exec time: [0.07] s

* spec@!opengl 1.2@texture-packed-formats:
- Statuses : 1 fail(s)
- Exec time: [2.39] s

* spec@!opengl 1.2@texwrap 3d:
- Statuses : 1 fail(s)
- Exec time: [0.09] s

* spec@!opengl 1.4@draw-batch:
- Statuses : 1 fail(s)
- Exec time: [0.09] s

* spec@!opengl [email protected]:
- Statuses : 1 fail(s)
- Exec time: [0.11] s

* spec@!opengl [email protected]:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s

* spec@!opengl 1.4@tex-miplevel-selection-lod:
- Statuses : 1 fail(s)
- Exec time: [0.15] s

* spec@!opengl 1.4@tex-miplevel-selection-lod-bias:
- Statuses : 1 fail(s)
- Exec time: [1.06] s

* spec@!opengl 1.5@depth-tex-compare:
- Statuses : 1 fail(s)
- Exec time: [0.26] s

* spec@!opengl 1.5@draw-elements:
- Statuses : 1 fail(s)
- Exec time: [0.11] s

* spec@!opengl 1.5@draw-vertices:
- Statuses : 1 fail(s)
- Exec time: [0.13] s

* spec@!opengl 1.5@draw-vertices-user:
- Statuses : 1 fail(s)
- Exec time: [0.18] s

* spec@!opengl 2.0@attribs:
- Statuses : 1 fail(s)
- Exec time: [0.65] s

* spec@!opengl [email protected]:
- Statuses : 1 fail(s)
- Exec time: [0.09] s

* spec@!opengl [email protected]:
- Statuses : 1 fail(s)
- Exec time: [0.10] s

* spec@!opengl 2.0@incomplete-texture-glsl:
- Statuses : 1 fail(s)
- Exec time: [0.09] s

* spec@!opengl 2.0@max-samplers:
- Statuses : 1 fail(s)
- Exec time: [0.41] s

* spec@!opengl 2.0@max-samplers border:
- Statuses : 1 fail(s)
- Exec time: [0.41] s

* spec@!opengl 2.0@tex3d-npot:
- Statuses : 1 fail(s)
- Exec time: [0.33] s

* spec@!opengl 2.1@pbo:
- Statuses : 1 fail(s)
- Exec time: [0.17] s

* spec@!opengl 3.0@attribs:
- Statuses : 1 fail(s)
- Exec time: [0.23] s

* spec@!opengl 3.0@clearbuffer-depth:
- Statuses : 1 fail(s)
- Exec time: [0.17] s

* spec@!opengl 3.0@clearbuffer-depth-stencil:
- Statuses : 1 fail(s)
- Exec time: [0.17] s

* spec@!opengl 3.0@clearbuffer-display-lists:
- Statuses : 1 fail(s)
- Exec time: [0.07] s

* spec@!opengl 3.0@clearbuffer-mixed-format:
- Statuses : 1 fail(s)
- Exec time: [0.30] s

* spec@!opengl 3.0@clearbuffer-stencil:
- Statuses : 1 fail(s)
- Exec time: [0.31] s

* spec@!opengl 3.0@depth-cube-map:
- Statuses : 1 fail(s)
- Exec time: [0.08] s

* spec@!opengl [email protected]:
- Statuses : 1 fail(s)
- Exec time: [0.08] s

* spec@!opengl 3.0@render-integer:
- Statuses : 1 fail(s)
- Exec time: [0.21] s

* spec@!opengl 3.0@sampler-cube-shadow:
- Statuses : 1 fail(s)
- Exec time: [0.11] s

* spec@!opengl 3.2@coord-replace-doesnt-eliminate-frag-tex-coords:
- Statuses : 1 fail(s)
- Exec time: [0.69] s

* spec@!opengl 3.2@layered-rendering@clear-color-all-types 1d_array mipmapped:
- Statuses : 1 fail(s)
- Exec time: [0.09] s

* spec@!opengl 3.2@layered-rendering@clear-color-all-types cube_map_array single_level:
- Statuses : 1 fail(s)
- Exec time: [0.07] s

* spec@!opengl 3.2@layered-rendering@gl-layer-render:
- Statuses : 1 fail(s)
- Exec time: [0.11] s

* spec@!opengl 3.2@layered-rendering@gl-layer-render-clipped:
- Statuses : 1 fail(s)
- Exec time: [0.08] s

* spec@!opengl 3.2@layered-rendering@gl-layer-render-storage:
- Statuses : 1 fail(s)
- Exec time: [0.09] s

* spec@3dfx_texture_compression_fxt1@fxt1-teximage:
- Statuses : 1 fail(s)
- Exec time: [0.11] s

* spec@amd_shader_trinary_minmax@execution@built-in-functions@fs-min3-ivec3-ivec3-ivec3:
- Statuses : 1 fail(s)
- Exec time: [0.13] s

* spec@amd_shader_trinary_minmax@execution@built-in-functions@tcs-max3-uint-uint-uint:
- Statuses : 1 fail(s)
- Exec time: [0.22] s

* spec@arb_base_instance@arb_base_instance-drawarrays:
- Statuses : 1 fail(s)
- Exec time: [0.20] s

* spec@arb_blend_func_extended@arb_blend_func_extended-fbo-extended-blend:
- Statuses : 1 fail(s)
- Exec time: [0.15] s

* spec@arb_blend_func_extended@arb_blend_func_extended-fbo-extended-blend-explicit:
- Statuses : 1 fail(s)
- Exec time: [0.15] s

* spec@arb_blend_func_extended@arb_blend_func_extended-fbo-extended-blend-explicit_gles3:
- Statuses : 1 fail(s)
- Exec time: [0.10] s

* spec@arb_blend_func_extended@arb_blend_func_extended-fbo-extended-blend_gles3:
- Statuses : 1 fail(s)
- Exec time: [0.13] s

* spec@arb_clear_texture@arb_clear_texture-clear-max-level:
- Statuses : 1 fail(s)
- Exec time: [0.11] s

* spec@arb_clip_control@arb_clip_control-clip-control:
- Statuses : 1 fail(s)
- Exec time: [0.23] s

* spec@arb_clip_control@arb_clip_control-depth-precision:
- Statuses : 1 fail(s)
- Exec time: [0.15] s

* spec@arb_color_buffer_float@gl_rgba16f-render:
- Statuses : 1 fail(s)
- Exec time: [0.66] s

* spec@arb_color_buffer_float@gl_rgba16f-render-fog:
- Statuses : 1 fail(s)
- Exec time: [0.79] s

* spec@arb_color_buffer_float@gl_rgba16f-render-sanity:
- Statuses : 1 fail(s)
- Exec time: [0.18] s

* spec@arb_color_buffer_float@gl_rgba32f-render:
- Statuses : 1 fail(s)
- Exec time: [0.64] s

* spec@arb_color_buffer_float@gl_rgba32f-render-fog:
- Statuses : 1 fail(s)
- Exec time: [0.66] s

* spec@arb_color_buffer_float@gl_rgba32f-render-sanity:
- Statuses : 1 fail(s)
- Exec time: [0.23] s

* spec@arb_color_buffer_float@gl_rgba32f-render-sanity-fog:
- Statuses : 1 fail(s)
- Exec time: [0.21] s

* spec@arb_color_buffer_float@gl_rgba8-render:
- Statuses : 1 fail(s)
- Exec time: [0.69] s

* spec@arb_color_buffer_float@gl_rgba8-render-fog:
- Statuses : 1 fail(s)
- Exec time: [0.69] s

* spec@arb_color_buffer_float@gl_rgba8-render-sanity:
- Statuses : 1 fail(s)
- Exec time: [0.18] s

* spec@arb_color_buffer_float@gl_rgba8-render-sanity-fog:
- Statuses : 1 fail(s)
- Exec time: [0.20] s

* spec@arb_color_buffer_float@gl_rgba8_snorm-drawpixels:
- Statuses : 1 fail(s)
- Exec time: [0.10] s

* spec@arb_color_buffer_float@gl_rgba8_snorm-render:
- Statuses : 1 fail(s)
- Exec time: [0.73] s

* spec@arb_color_buffer_float@gl_rgba8_snorm-render-fog:
- Statuses : 1 fail(s)
- Exec time: [0.79] s

* spec@arb_color_buffer_float@gl_rgba8_snorm-render-sanity-fog:
- Statuses : 1 fail(s)
- Exec time: [0.20] s

* spec@arb_compute_shader@indirect-compute:
- Statuses : 1 fail(s)
- Exec time: [0.12] s

* spec@arb_copy_buffer@overlap:
- Statuses : 1 fail(s)
- Exec time: [0.12] s

* spec@arb_copy_buffer@targets:
- Statuses : 1 fail(s)
- Exec time: [0.12] s

* spec@arb_copy_image@arb_copy_image-format-swizzle:
- Statuses : 1 fail(s)
- Exec time: [0.28] s

* spec@arb_copy_image@arb_copy_image-formats --samples=2:
- Statuses : 1 fail(s)
- Exec time: [1.46] s

* spec@arb_copy_image@arb_copy_image-formats --samples=4:
- Statuses : 1 fail(s)
- Exec time: [1.52] s

* spec@arb_copy_image@arb_copy_image-targets gl_texture_1d 32 1 1 gl_texture_2d_array 32 32 10 11 0 0 5 13 4 14 1 1:
- Statuses : 1 fail(s)
- Exec time: [0.14] s

* spec@arb_copy_image@arb_copy_image-targets gl_texture_1d_array 32 1 12 gl_texture_2d 32 16 1 11 0 3 5 7 0 14 1 1:
- Statuses : 1 fail(s)
- Exec time: [0.10] s

* spec@arb_copy_image@arb_copy_image-targets gl_texture_1d_array 32 1 12 gl_texture_2d_array 32 16 18 11 0 3 5 9 7 14 1 8:
- Statuses : 1 fail(s)
- Exec time: [0.22] s

* spec@arb_copy_image@arb_copy_image-targets gl_texture_1d_array 32 1 12 gl_texture_3d 32 16 18 11 0 3 5 9 2 14 1 7:
- Statuses : 1 fail(s)
- Exec time: [0.22] s

* spec@arb_copy_image@arb_copy_image-targets gl_texture_1d_array 32 1 12 gl_texture_cube_map 32 32 6 11 0 3 5 17 2 14 1 3:
- Statuses : 1 fail(s)
- Exec time: [0.13] s

* spec@arb_copy_image@arb_copy_image-targets gl_texture_1d_array 32 1 12 gl_texture_cube_map_array 32 32 18 11 0 3 5 17 2 14 1 7:
- Statuses : 1 fail(s)
- Exec time: [0.26] s

* spec@arb_copy_image@arb_copy_image-targets gl_texture_1d_array 32 1 12 gl_texture_rectangle 32 16 1 11 0 3 5 7 0 14 1 1:
- Statuses : 1 fail(s)
- Exec time: [0.10] s

* spec@arb_copy_image@arb_copy_image-targets gl_texture_2d 32 32 1 gl_texture_2d 32 16 1 11 12 0 5 7 0 14 9 1:
- Statuses : 1 fail(s)
- Exec time: [0.10] s

* spec@arb_copy_image@arb_copy_image-targets gl_texture_2d 32 32 1 gl_texture_3d 32 16 18 11 5 0 5 9 7 14 7 1:
- Statuses : 1 fail(s)
- Exec time: [0.15] s

* spec@arb_copy_image@arb_copy_image-targets gl_texture_2d 32 32 1 gl_texture_cube_map_array 32 32 18 11 5 0 5 9 7 14 7 1:
- Statuses : 1 fail(s)
- Exec time: [0.14] s

* spec@arb_copy_image@arb_copy_image-targets gl_texture_2d_array 32 32 15 gl_texture_1d 32 1 1 11 23 7 5 0 0 14 1 1:
- Statuses : 1 fail(s)
- Exec time: [0.11] s

* spec@arb_copy_image@arb_copy_image-targets gl_texture_2d_array 32 32 15 gl_texture_2d_array 32 16 15 11 12 5 5 7 2 14 9 9:
- Statuses : 1 fail(s)
- Exec time: [0.18] s

* spec@arb_copy_image@arb_copy_image-targets gl_texture_2d_array 32 32 15 gl_texture_3d 32 16 18 11 5 2 5 9 7 14 7 11:
- Statuses : 1 fail(s)
- Exec time: [0.28] s

* spec@arb_copy_image@arb_copy_image-targets gl_texture_2d_array 32 32 15 gl_texture_cube_map_array 32 32 18 11 5 2 5 9 7 14 7 11:
- Statuses : 1 fail(s)
- Exec time: [0.15] s

* spec@arb_copy_image@arb_copy_image-targets gl_texture_3d 32 32 17 gl_texture_3d 32 16 18 11 5 2 5 9 7 14 7 11:
- Statuses : 1 fail(s)
- Exec time: [0.23] s

* spec@arb_copy_image@arb_copy_image-targets gl_texture_3d 32 32 17 gl_texture_cube_map_array 16 16 18 11 5 2 5 9 7 5 7 11:
- Statuses : 1 fail(s)
- Exec time: [0.34] s

* spec@arb_copy_image@arb_copy_image-targets gl_texture_cube_map 32 32 6 gl_texture_1d_array 32 1 16 11 2 3 5 0 7 14 1 2:
- Statuses : 1 fail(s)
- Exec time: [0.11] s

* spec@arb_copy_image@arb_copy_image-targets gl_texture_cube_map_array 32 32 18 gl_texture_2d_array 32 16 15 11 12 5 5 1 2 14 15 9:
- Statuses : 1 fail(s)
- Exec time: [0.16] s

* spec@arb_copy_image@arb_copy_image-targets gl_texture_cube_map_array 32 32 18 gl_texture_3d 32 16 18 11 5 2 5 9 7 14 7 11:
- Statuses : 1 fail(s)
- Exec time: [0.26] s

* spec@arb_copy_image@arb_copy_image-targets gl_texture_cube_map_array 32 32 18 gl_texture_cube_map_array 16 16 18 11 5 2 5 9 7 5 7 11:
- Statuses : 1 fail(s)
- Exec time: [0.14] s

* spec@arb_copy_image@arb_copy_image-targets gl_texture_rectangle 32 32 1 gl_texture_cube_map_array 32 32 18 11 5 0 5 9 7 14 7 1:
- Statuses : 1 fail(s)
- Exec time: [0.13] s

* spec@arb_copy_image@arb_copy_image-texview:
- Statuses : 1 fail(s)
- Exec time: [0.10] s

* spec@arb_depth_buffer_float@depthstencil-render-miplevels 1024 d=z32f:
- Statuses : 1 fail(s)
- Exec time: [0.13] s

* spec@arb_depth_buffer_float@depthstencil-render-miplevels 1024 s=z24_s8_d=z32f:
- Statuses : 1 fail(s)
- Exec time: [0.31] s

* spec@arb_depth_buffer_float@depthstencil-render-miplevels 273 d=z32f_s=z24_s8:
- Statuses : 1 fail(s)
- Exec time: [0.10] s

* spec@arb_depth_buffer_float@depthstencil-render-miplevels 273 s=z24_s8_d=z32f:
- Statuses : 1 fail(s)
- Exec time: [0.10] s

* spec@arb_depth_buffer_float@depthstencil-render-miplevels 585 d=z32f_s=z24_s8:
- Statuses : 1 fail(s)
- Exec time: [0.17] s

* spec@arb_depth_texture@depth-tex-modes:
- Statuses : 1 fail(s)
- Exec time: [0.18] s

* spec@arb_depth_texture@depthstencil-render-miplevels 1024 d=z16:
- Statuses : 1 fail(s)
- Exec time: [0.12] s

* spec@arb_depth_texture@depthstencil-render-miplevels 1024 d=z24:
- Statuses : 1 fail(s)
- Exec time: [0.12] s

* spec@arb_depth_texture@depthstencil-render-miplevels 146 d=z16:
- Statuses : 1 fail(s)
- Exec time: [0.08] s

* spec@arb_depth_texture@depthstencil-render-miplevels 146 d=z24:
- Statuses : 1 fail(s)
- Exec time: [0.08] s

* spec@arb_depth_texture@depthstencil-render-miplevels 273 d=z16:
- Statuses : 1 fail(s)
- Exec time: [0.09] s

* spec@arb_depth_texture@depthstencil-render-miplevels 292 d=z16:
- Statuses : 1 fail(s)
- Exec time: [0.08] s

* spec@arb_depth_texture@depthstencil-render-miplevels 585 d=z16:
- Statuses : 1 fail(s)
- Exec time: [0.11] s

* spec@arb_depth_texture@fbo-depth-gl_depth_component16-tex1d:
- Statuses : 1 fail(s)
- Exec time: [0.14] s

* spec@arb_depth_texture@texdepth:
- Statuses : 1 fail(s)
- Exec time: [0.08] s

* spec@arb_depth_texture@texwrap formats offset:
- Statuses : 1 fail(s)
- Exec time: [0.13] s

* spec@arb_direct_state_access@copytexturesubimage:
- Statuses : 1 fail(s)
- Exec time: [0.23] s

* spec@arb_direct_state_access@gettextureimage-targets:
- Statuses : 1 fail(s)
- Exec time: [0.15] s

* spec@arb_draw_elements_base_vertex@arb_draw_elements_base_vertex-drawelements:
- Statuses : 1 fail(s)
- Exec time: [0.19] s

* spec@arb_draw_elements_base_vertex@arb_draw_elements_base_vertex-drawelements-instanced:
- Statuses : 1 fail(s)
- Exec time: [0.18] s

* spec@arb_draw_elements_base_vertex@arb_draw_elements_base_vertex-drawelements-user_varrays:
- Statuses : 1 fail(s)
- Exec time: [0.22] s

* spec@arb_draw_elements_base_vertex@arb_draw_elements_base_vertex-negative-index:
- Statuses : 1 fail(s)
- Exec time: [0.20] s

* spec@arb_explicit_attrib_location@overlapping-locations-input-attribs api:
- Statuses : 1 fail(s)
- Exec time: [0.06] s

* spec@arb_fragment_program@fp-incomplete-tex:
- Statuses : 1 fail(s)
- Exec time: [0.09] s

* spec@arb_fragment_program@fp-set-01:
- Statuses : 1 fail(s)
- Exec time: [0.12] s

* spec@arb_framebuffer_no_attachments@arb_framebuffer_no_attachments-query:
- Statuses : 1 fail(s)
- Exec time: [0.09] s

* spec@arb_framebuffer_object@fbo-blit-stretch:
- Statuses : 1 fail(s)
- Exec time: [0.26] s

* spec@arb_framebuffer_object@fbo-drawbuffers-none gl_fragcolor:
- Statuses : 1 fail(s)
- Exec time: [0.13] s

* spec@arb_framebuffer_object@fbo-drawbuffers-none glclear:
- Statuses : 1 fail(s)
- Exec time: [0.13] s

* spec@arb_framebuffer_object@fbo-drawbuffers-none glclearbuffer:
- Statuses : 1 fail(s)
- Exec time: [0.13] s

* spec@arb_framebuffer_object@fbo-generatemipmap-cubemap rgb9_e5:
- Statuses : 1 fail(s)
- Exec time: [0.17] s

* spec@arb_framebuffer_object@fbo-generatemipmap-cubemap s3tc_dxt1:
- Statuses : 1 fail(s)
- Exec time: [0.15] s

* spec@arb_framebuffer_object@fbo-mipmap-copypix:
- Statuses : 1 fail(s)
- Exec time: [0.42] s

* spec@arb_framebuffer_object@fbo-viewport:
- Statuses : 1 fail(s)
- Exec time: [0.08] s

* spec@arb_framebuffer_srgb@fbo-fast-clear:
- Statuses : 1 fail(s)
- Exec time: [0.12] s

* spec@arb_get_texture_sub_image@arb_get_texture_sub_image-get:
- Statuses : 1 fail(s)
- Exec time: [0.73] s

* spec@arb_gpu_shader5@execution@sampler_array_indexing@fs-struct-nonconst-sampler-const:
- Statuses : 1 fail(s)
- Exec time: [0.12] s

* spec@arb_gpu_shader5@texturegather@vs-r-0-float-2d:
- Statuses : 1 fail(s)
- Exec time: [1.67] s

* spec@arb_gpu_shader5@texturegather@vs-r-0-float-2darray:
- Statuses : 1 fail(s)
- Exec time: [7.02] s

* spec@arb_gpu_shader5@texturegather@vs-r-0-float-2drect:
- Statuses : 1 fail(s)
- Exec time: [1.61] s

* spec@arb_gpu_shader5@texturegather@vs-r-0-float-cube:
- Statuses : 1 fail(s)
- Exec time: [1.76] s

* spec@arb_gpu_shader5@texturegather@vs-r-0-float-cubearray:
- Statuses : 1 fail(s)
- Exec time: [1.70] s

* spec@arb_gpu_shader5@texturegather@vs-r-0-int-2d:
- Statuses : 1 fail(s)
- Exec time: [1.65] s

* spec@arb_gpu_shader5@texturegather@vs-r-0-int-2darray:
- Statuses : 1 fail(s)
- Exec time: [1.75] s

* spec@arb_gpu_shader5@texturegather@vs-r-0-int-2drect:
- Statuses : 1 fail(s)
- Exec time: [1.71] s

* spec@arb_gpu_shader5@texturegather@vs-r-0-int-cube:
- Statuses : 1 fail(s)
- Exec time: [1.66] s

* spec@arb_gpu_shader5@texturegather@vs-r-0-int-cubearray:
- Statuses : 1 fail(s)
- Exec time: [1.58] s

* spec@arb_gpu_shader5@texturegather@vs-r-0-uint-2d:
- Statuses : 1 fail(s)
- Exec time: [1.74] s

* spec@arb_gpu_shader5@texturegather@vs-r-0-uint-2darray:
- Statuses : 1 fail(s)
- Exec time: [1.65] s

* spec@arb_gpu_shader5@texturegather@vs-r-0-uint-2drect:
- Statuses : 1 fail(s)
- Exec time: [1.68] s

* spec@arb_gpu_shader5@texturegather@vs-r-0-unorm-2d:
- Statuses : 1 fail(s)
- Exec time: [1.61] s

* spec@arb_gpu_shader5@texturegather@vs-r-0-unorm-2darray:
- Statuses : 1 fail(s)
- Exec time: [1.67] s

* spec@arb_gpu_shader5@texturegather@vs-r-0-unorm-2drect:
- Statuses : 1 fail(s)
- Exec time: [1.69] s

* spec@arb_gpu_shader5@texturegather@vs-r-0-unorm-cube:
- Statuses : 1 fail(s)
- Exec time: [1.67] s

* spec@arb_gpu_shader5@texturegather@vs-r-0-unorm-cubearray:
- Statuses : 1 fail(s)
- Exec time: [1.71] s

* spec@arb_gpu_shader5@texturegather@vs-rg-0-float-2d:
- Statuses : 1 fail(s)
- Exec time: [1.79] s

* spec@arb_gpu_shader5@texturegather@vs-rg-0-float-2darray:
- Statuses : 1 fail(s)
- Exec time: [1.65] s

* spec@arb_gpu_shader5@texturegather@vs-rg-0-float-2drect:
- Statuses : 1 fail(s)
- Exec time: [1.70] s

* spec@arb_gpu_shader5@texturegather@vs-rg-0-float-cube:
- Statuses : 1 fail(s)
- Exec time: [1.62] s

* spec@arb_gpu_shader5@texturegather@vs-rg-0-float-cubearray:
- Statuses : 1 fail(s)
- Exec time: [1.74] s

* spec@arb_gpu_shader5@texturegather@vs-rg-0-int-2d:
- Statuses : 1 fail(s)
- Exec time: [1.76] s

* spec@arb_gpu_shader5@texturegather@vs-rg-0-int-2darray:
- Statuses : 1 fail(s)
- Exec time: [1.81] s

* spec@arb_gpu_shader5@texturegather@vs-rg-0-int-2drect:
- Statuses : 1 fail(s)
- Exec time: [1.76] s

* spec@arb_gpu_shader5@texturegather@vs-rg-0-int-cube:
- Statuses : 1 fail(s)
- Exec time: [1.64] s

* spec@arb_gpu_shader5@texturegather@vs-rg-0-int-cubearray:
- Statuses : 1 fail(s)
- Exec time: [1.72] s

* spec@arb_gpu_shader5@texturegather@vs-rg-0-uint-2d:
- Statuses : 1 fail(s)
- Exec time: [1.74] s

* spec@arb_gpu_shader5@texturegather@vs-rg-0-uint-2darray:
- Statuses : 1 fail(s)
- Exec time: [1.63] s

* spec@arb_gpu_shader5@texturegather@vs-rg-0-uint-2drect:
- Statuses : 1 fail(s)
- Exec time: [1.66] s

* spec@arb_gpu_shader5@texturegather@vs-rg-0-uint-cube:
- Statuses : 1 fail(s)
- Exec time: [1.70] s

* spec@arb_gpu_shader5@texturegather@vs-rg-0-unorm-2d:
- Statuses : 1 fail(s)
- Exec time: [1.71] s

* spec@arb_gpu_shader5@texturegather@vs-rg-0-unorm-2darray:
- Statuses : 1 fail(s)
- Exec time: [1.77] s

* spec@arb_gpu_shader5@texturegather@vs-rg-0-unorm-2drect:
- Statuses : 1 fail(s)
- Exec time: [1.65] s

* spec@arb_gpu_shader5@texturegather@vs-rg-0-unorm-cube:
- Statuses : 1 fail(s)
- Exec tim

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15806/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v3 1/1
#3 lore raw
In reply to Juston Li
Quoted 9 lines · Juston Li

From: Daniel Stone <[email protected]>

getfb2 allows us to pass multiple planes and modifiers, just like addfb2 over addfb.

Changes since v2:
- add privilege checks from getfb1 since handles should only be returned to master/root

Quoted 7 lines

Changes since v1:
- unused modifiers set to 0 instead of DRM_FORMAT_MOD_INVALID
- update ioctl number

lgtm

Quoted 188 lines
---
 drivers/gpu/drm/drm_crtc_internal.h |   2 +
 drivers/gpu/drm/drm_framebuffer.c   | 122 ++++++++++++++++++++++++++++
 drivers/gpu/drm/drm_ioctl.c         |   1 +
 include/uapi/drm/drm.h              |   2 +
 4 files changed, 127 insertions(+)
drivers/gpu/drm/drm_crtc_internal.h +2 -0
index c7d5e4c21423..16f2413403aa 100644
@@ -216,6 +216,8 @@ int drm_mode_rmfb_ioctl(struct drm_device *dev,
 			void *data, struct drm_file *file_priv);
 int drm_mode_getfb(struct drm_device *dev,
 		   void *data, struct drm_file *file_priv);
+int drm_mode_getfb2_ioctl(struct drm_device *dev,
+			  void *data, struct drm_file *file_priv);
 int drm_mode_dirtyfb_ioctl(struct drm_device *dev,
 			   void *data, struct drm_file *file_priv);
 
drivers/gpu/drm/drm_framebuffer.c +122 -0
index 57564318ceea..57ac94ce9b9e 100644
@@ -31,6 +31,7 @@
 #include <drm/drm_file.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
+#include <drm/drm_gem.h>
 #include <drm/drm_print.h>
 #include <drm/drm_util.h>
 
@@ -548,7 +549,128 @@ int drm_mode_getfb(struct drm_device *dev,
 
 out:
 	drm_framebuffer_put(fb);
+	return ret;
+}
+
+/**
+ * drm_mode_getfb2 - get extended FB info
+ * @dev: drm device for the ioctl
+ * @data: data pointer for the ioctl
+ * @file_priv: drm file for the ioctl call
+ *
+ * Lookup the FB given its ID and return info about it.
+ *
+ * Called by the user via ioctl.
+ *
+ * Returns:
+ * Zero on success, negative errno on failure.
+ */
+int drm_mode_getfb2_ioctl(struct drm_device *dev,
+			  void *data, struct drm_file *file_priv)
+{
+	struct drm_mode_fb_cmd2 *r = data;
+	struct drm_framebuffer *fb;
+	unsigned int i;
+	int ret;
+
+	if (!drm_core_check_feature(dev, DRIVER_MODESET))
+		return -EINVAL;
+
+	fb = drm_framebuffer_lookup(dev, file_priv, r->fb_id);
+	if (!fb)
+		return -ENOENT;
+
+	/* For multi-plane framebuffers, we require the driver to place the
+	 * GEM objects directly in the drm_framebuffer. For single-plane
+	 * framebuffers, we can fall back to create_handle.
+	 */
+	if (!fb->obj[0] &&
+	    (fb->format->num_planes > 1 || !fb->funcs->create_handle)) {
+		ret = -ENODEV;
+		goto out;
+	}
+
+	r->height = fb->height;
+	r->width = fb->width;
+	r->pixel_format = fb->format->format;
+
+	r->flags = 0;
+	if (dev->mode_config.allow_fb_modifiers)
+		r->flags |= DRM_MODE_FB_MODIFIERS;
+
+	for (i = 0; i < ARRAY_SIZE(r->handles); i++) {
+		r->handles[i] = 0;
+		r->pitches[i] = 0;
+		r->offsets[i] = 0;
+		r->modifier[i] = 0;
+	}
+
+	for (i = 0; i < fb->format->num_planes; i++) {
+		r->pitches[i] = fb->pitches[i];
+		r->offsets[i] = fb->offsets[i];
+		if (dev->mode_config.allow_fb_modifiers)
+			r->modifier[i] = fb->modifier;
+	}
+
+	/* GET_FB2() is an unprivileged ioctl so we must not return a
+	 * buffer-handle to non master/root processes! To match GET_FB()
+	 * just return invalid handles (0) for non masters/root
+	 * rather than making GET_FB2() privileged.
+	 */
+	if (!drm_is_current_master(file_priv) && !capable(CAP_SYS_ADMIN)) {
+		ret = 0;
+		goto out;
+	}
 
+	for (i = 0; i < fb->format->num_planes; i++) {
+		int j;
+
+		/* If we reuse the same object for multiple planes, also
+		 * return the same handle.
+		 */
+		for (j = 0; j < i; j++) {
+			if (fb->obj[i] == fb->obj[j]) {
+				r->handles[i] = r->handles[j];
+				break;
+			}
+		}
+
+		if (r->handles[i])
+			continue;
+
+		if (fb->obj[i]) {
+			ret = drm_gem_handle_create(file_priv, fb->obj[i],
+						    &r->handles[i]);
+		} else {
+			WARN_ON(i > 0);
+			ret = fb->funcs->create_handle(fb, file_priv,
+						       &r->handles[i]);
+		}
+
+		if (ret != 0)
+			goto out;
+	}
+
+out:
+	if (ret != 0) {
+		/* Delete any previously-created handles on failure. */
+		for (i = 0; i < ARRAY_SIZE(r->handles); i++) {
+			int j;
+
+			if (r->handles[i])
+				drm_gem_handle_delete(file_priv, r->handles[i]);
+
+			/* Zero out any handles identical to the one we just
+			 * deleted.
+			 */
+			for (j = i + 1; j < ARRAY_SIZE(r->handles); j++) {
+				if (r->handles[j] == r->handles[i])
+					r->handles[j] = 0;
+			}
+		}
+	}
+
+	drm_framebuffer_put(fb);
 	return ret;
 }
 
drivers/gpu/drm/drm_ioctl.c +1 -0
index 5afb39688b55..9e41972c4bbc 100644
@@ -671,6 +671,7 @@ static const struct drm_ioctl_desc drm_ioctls[] = {
 	DRM_IOCTL_DEF(DRM_IOCTL_MODE_SETPROPERTY, drm_connector_property_set_ioctl, DRM_MASTER),
 	DRM_IOCTL_DEF(DRM_IOCTL_MODE_GETPROPBLOB, drm_mode_getblob_ioctl, 0),
 	DRM_IOCTL_DEF(DRM_IOCTL_MODE_GETFB, drm_mode_getfb, 0),
+	DRM_IOCTL_DEF(DRM_IOCTL_MODE_GETFB2, drm_mode_getfb2_ioctl, 0),
 	DRM_IOCTL_DEF(DRM_IOCTL_MODE_ADDFB, drm_mode_addfb_ioctl, 0),
 	DRM_IOCTL_DEF(DRM_IOCTL_MODE_ADDFB2, drm_mode_addfb2_ioctl, 0),
 	DRM_IOCTL_DEF(DRM_IOCTL_MODE_RMFB, drm_mode_rmfb_ioctl, 0),
include/uapi/drm/drm.h +2 -0
index 868bf7996c0f..808b48a93330 100644
@@ -948,6 +948,8 @@ extern "C" {
 #define DRM_IOCTL_SYNCOBJ_TRANSFER	DRM_IOWR(0xCC, struct drm_syncobj_transfer)
 #define DRM_IOCTL_SYNCOBJ_TIMELINE_SIGNAL	DRM_IOWR(0xCD, struct drm_syncobj_timeline_array)
 
+#define DRM_IOCTL_MODE_GETFB2		DRM_IOWR(0xCE, struct drm_mode_fb_cmd2)
+
 /**
  * Device specific ioctls should only be in their respective headers
  * The device specific ioctl range is from 0x40 to 0x9f.
Signature · 1 line
2.21.0
Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx