Skip to contentSkip to conversation

ath11k: mask out vht beamforming if a fixed rate is set

PATCH In review John Crispin 2 participants 3 messages Dec 17, 2019 – Jan 15, 2020 Qualcomm Atheros ATH11K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath11k: mask out vht beamforming if a fixed rate is set

From: Ritesh Singh <[email protected]>

After setting a fixed vht-rate we see a FW assert if a STA tries to (re)assoc with the mu_bfee cap set. This patch masks out the capability bits if a fixed rate is set.

---
 drivers/net/wireless/ath/ath11k/mac.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/net/wireless/ath/ath11k/mac.c +3 -0
index b8be78dc295d..7f17d0e4cb96 100644
@@ -1126,6 +1126,9 @@ static void ath11k_peer_assoc_h_vht(struct ath11k *ar,
 	arg->tx_mcs_set &= ~IEEE80211_VHT_MCS_SUPPORT_0_11_MASK;
 	arg->tx_mcs_set |= IEEE80211_DISABLE_VHT_MCS_SUPPORT_0_11;
 
+	if ((arg->tx_mcs_set & 0x3) == 0x3)
+		arg->peer_vht_caps &= ~IEEE80211_VHT_CAP_MU_BEAMFORMEE_CAPABLE;
+
 	/* TODO:  Check */
 	arg->tx_max_mcs_nss = 0xFF;
 
Signature · 1 line
2.20.1
#1 lore raw
Quoted 8 lines · John Crispin

From: Ritesh Singh <[email protected]>

After setting a fixed vht-rate we see a FW assert if a STA tries to (re)assoc with the mu_bfee cap set. This patch masks out the capability bits if a fixed rate is set.

John's s-o-b missing. Also no magic numbers, please. Isn't there a proper define for 0x3?

Signature · 8 lines
https://patchwork.kernel.org/patch/11298287/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#2 lore raw
In reply to John Crispin
Quoted 8 lines · John Crispin

From: Ritesh Singh <[email protected]>

After setting a fixed vht-rate we see a FW assert if a STA tries to (re)assoc with the mu_bfee cap set. This patch masks out the capability bits if a fixed rate is set.

John's s-o-b missing. Also no magic numbers, please. Isn't there a proper define for 0x3?

Signature · 3 lines
https://patchwork.kernel.org/patch/11298287/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches