random: don't forget compat_ioctl on unrandom
Jason A. Donenfeld
maintainerPATCH 1/1 random: don't forget compat_ioctl on unrandom
Recently, there's been some compat ioctl cleanup, in which large hardcoded lists were replaced with compat_ptr_ioctl. One of these changes involved removing the random.c hardcoded list entries and adding a compat ioctl function pointer to the random.c fops. In the process, urandom was forgotten about, so this commit fixes that oversight.
--- drivers/char/random.c | 1 + 1 file changed, 1 insertion(+)
drivers/char/random.c +1 -0
@@ -2175,6 +2175,7 @@ const struct file_operations urandom_fops = { .read = urandom_read, .write = random_write, .unlocked_ioctl = random_ioctl, + .compat_ioctl = compat_ptr_ioctl, .fasync = random_fasync, .llseek = noop_llseek, };
Signature · 1 line
2.24.1
Jason A. Donenfeld
maintainerOoof, typing too fast. "unrandom" in the subject should be "urandom", of course.
Quoted 29 lines · Jason A. Donenfeld
Recently, there's been some compat ioctl cleanup, in which large hardcoded lists were replaced with
compat_ptr_ioctl. One of these changes involved removing therandom.chardcoded list entries and adding a compat ioctl function pointer to therandom.cfops. In the process, urandom was forgotten about, so this commit fixes that oversight.Fixes 507e4e2b430b ("compat_ioctl: remove /dev/random commands")Cc Arnd Bergmann <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Signed-off-by Jason A. Donenfeld <[email protected]>--- drivers/char/random.c | 1 + 1 file changed, 1 insertion(+)drivers/char/random.c +1
-1@@ -2175,6 +2175,7 @@ const struct file_operations urandom_fops = { .read = urandom_read, .write = random_write, .unlocked_ioctl = random_ioctl, + .compat_ioctl = compat_ptr_ioctl, .fasync = random_fasync, .llseek = noop_llseek, }; --2.24.1
Quoted 11 lines · Jason A. Donenfeld
Recently, there's been some compat ioctl cleanup, in which large hardcoded lists were replaced with
compat_ptr_ioctl. One of these changes involved removing therandom.chardcoded list entries and adding a compat ioctl function pointer to therandom.cfops. In the process, urandom was forgotten about, so this commit fixes that oversight.Fixes 507e4e2b430b ("compat_ioctl: remove /dev/random commands")Cc Arnd Bergmann <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Signed-off-by Jason A. Donenfeld <[email protected]>
Thanks for debugging this. I had already sent the same patch a few days ago after the first report:
https://lore.kernel.org/lkml/[email protected]/
Greg, can you please apply one of these and send it to Linus for 5.5-rc3?
Arnd
Quoted 19 lines
--- drivers/char/random.c | 1 + 1 file changed, 1 insertion(+)drivers/char/random.c +1
-1@@ -2175,6 +2175,7 @@ const struct file_operations urandom_fops = { .read = urandom_read, .write = random_write, .unlocked_ioctl = random_ioctl, + .compat_ioctl = compat_ptr_ioctl, .fasync = random_fasync, .llseek = noop_llseek, }; --2.24.1
Quoted 13 lines · Arnd Bergmann
Quoted 11 lines · Jason A. Donenfeld
Recently, there's been some compat ioctl cleanup, in which large hardcoded lists were replaced with
compat_ptr_ioctl. One of these changes involved removing therandom.chardcoded list entries and adding a compat ioctl function pointer to therandom.cfops. In the process, urandom was forgotten about, so this commit fixes that oversight.Fixes 507e4e2b430b ("compat_ioctl: remove /dev/random commands")Cc Arnd Bergmann <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Signed-off-by Jason A. Donenfeld <[email protected]>
Quoted 6 lines
Thanks for debugging this. I had already sent the same patch a few days ago after the first report:
https://lore.kernel.org/lkml/[email protected]/
Greg, can you please apply one of these and send it to Linus for 5.5-rc3?
Ugh, I missed your first one, sorry, I thought that was for Ted and missed that it was due to a patch that came from my tree. I've queued Jason's patch up now.
thanks,
greg k-h