Skip to contentSkip to conversation

Microblaze cleanup 3

PATCH New Giulio Benetti 3 participants 8 messages Dec 17, 2019 – Dec 31, 2019

lore
Share & tools
lore
#0 lore raw

cover Microblaze cleanup 3

Drop some workaround since binutils and gcc fixed previous bugs

Giulio Benetti (3):
package/sqlite: remove workaround when building with gcc version <=

    4.9

package/libnss: remove ld segfault workaround
package/kmod: remove ld segfault workaround

 package/kmod/kmod.mk     |  6 ------
 package/libnss/libnss.mk | 10 ----------
 package/sqlite/sqlite.mk |  6 ------
 3 files changed, 22 deletions(-)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/3 package/sqlite: remove workaround when building with gcc version <= 4.9

Gcc version 4.9 is not supported anymore by Buildroot so let's remove the check for using a work-around.

---
 package/sqlite/sqlite.mk | 6 ------
 1 file changed, 6 deletions(-)
package/sqlite/sqlite.mk +0 -6
index ba5b5c5d00..673d91ccd9 100644
@@ -39,14 +39,8 @@ ifeq ($(BR2_PACKAGE_SQLITE_NO_SYNC),y)
 SQLITE_CFLAGS += -DSQLITE_NO_SYNC
 endif
 
-# Building with Microblaze Gcc 4.9 makes compiling to hang.
-# Work around using -O0
-ifeq ($(BR2_microblaze):$(BR2_TOOLCHAIN_GCC_AT_LEAST_5),y:)
-SQLITE_CFLAGS += $(TARGET_CFLAGS) -O0
-else
 # fallback to standard -O3 when -Ofast is present to avoid -ffast-math
 SQLITE_CFLAGS += $(subst -Ofast,-O3,$(TARGET_CFLAGS))
-endif
 
 SQLITE_CONF_ENV = CFLAGS="$(SQLITE_CFLAGS)"
 
Signature · 1 line
2.20.1
#2 lore raw

PATCH 1/3 package/sqlite: remove workaround when building with gcc version <= 4.9

Quoted 2 lines · On Tue, 17 Dec 2019 15:37:02 +0100 Giulio Benetti…

Gcc version 4.9 is not supported anymore by Buildroot so let's remove the check for using a work-around.

This is not quite true: we no longer support building a toolchain with gcc 4.9, but we do support external toolchains that use gcc 4.9 or older. For example, the br-arm-full.config toolchain fragment is testing a gcc 4.9 based toolchain in the autobuilders.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/3 package/sqlite: remove workaround when building with gcc version <= 4.9

Quoted 10 lines · Thomas Petazzoni
Quoted 2 lines · On Tue, 17 Dec 2019 15:37:02 +0100 Giulio Benetti…

Gcc version 4.9 is not supported anymore by Buildroot so let's remove the check for using a work-around.

This is not quite true: we no longer support building a toolchain with gcc 4.9, but we do support external toolchains that use gcc 4.9 or older. For example, the br-arm-full.config toolchain fragment is testing a gcc 4.9 based toolchain in the autobuilders.

Oops, I've just check now in toolchain/Config.in that it's supported gcc version >= 4.3

So let's drop this patch, sorry for the noise.

Best regards

Signature · 2 lines
Giulio Benetti
Benetti Engineering sas
#4 lore raw

PATCH 2/3 package/libnss: remove ld segfault workaround

In reply to Giulio Benetti

This ld bug has been fixed with binutils version 2.27 and Buildroot at the moment provides binutils > 2.27, so let's remove the workaround.

---
This patch must be applied after patch:
https://patchwork.ozlabs.org/patch/1210535/

---
 package/libnss/libnss.mk | 10 ----------
 1 file changed, 10 deletions(-)
package/libnss/libnss.mk +0 -10
index 9349276a90..7c49ac1b25 100644
@@ -27,16 +27,6 @@ endef
 
 LIBNSS_PRE_CONFIGURE_HOOKS += LIBNSS_FIXUP_LINUX_MK
 
-# --gc-sections triggers binutils ld segfault
-# https://sourceware.org/bugzilla/show_bug.cgi?id=21180
-ifeq ($(BR2_microblaze),y)
-define LIBNSS_DROP_GC_SECTIONS
-	sed -i 's:-Wl,--gc-sections::g' $(@D)/nss/coreconf/Linux.mk
-endef
-
-LIBNSS_PRE_CONFIGURE_HOOKS += LIBNSS_DROP_GC_SECTIONS
-endif
-
 ifeq ($(BR2_aarch64_be),y)
 LIBNSS_ARCH = aarch64
 else
Signature · 1 line
2.20.1
#5 lore raw

PATCH 2/3 package/libnss: remove ld segfault workaround

Giulio, All,

On 2019-12-17 15:37 +0100, Giulio Benetti spake thusly:

Quoted 2 lines

This ld bug has been fixed with binutils version 2.27 and Buildroot at the moment provides binutils > 2.27, so let's remove the workaround.

Even though Buildroot only has binutils > 2.27, there might still exist pre-built, external toolchains that use a version older than 2.27.

Since we support gcc back to at least 4.3, I believe we must still support binutils versions that were contemporary to that.

gcc-4.3 was releaswed in 2008, so the current binutils at the time was 2.18

However, for microblaze, in practice, I'm not sure what the oldest binutils version makes sense... :-/

Unless another maintainer is happy to take those two patches, I'll reject then next year (woot, you have a one year delay! ;-] ).

Regards,
Yann E. MORIN.

Quoted 36 lines

---
This patch must be applied after patch:
https://patchwork.ozlabs.org/patch/1210535/

---
 package/libnss/libnss.mk | 10 ----------
 1 file changed, 10 deletions(-)
package/libnss/libnss.mk +0 -10
index 9349276a90..7c49ac1b25 100644
@@ -27,16 +27,6 @@ endef
 
 LIBNSS_PRE_CONFIGURE_HOOKS += LIBNSS_FIXUP_LINUX_MK
 
-# --gc-sections triggers binutils ld segfault
-# https://sourceware.org/bugzilla/show_bug.cgi?id=21180
-ifeq ($(BR2_microblaze),y)
-define LIBNSS_DROP_GC_SECTIONS
-	sed -i 's:-Wl,--gc-sections::g' $(@D)/nss/coreconf/Linux.mk
-endef
-
-LIBNSS_PRE_CONFIGURE_HOOKS += LIBNSS_DROP_GC_SECTIONS
-endif
-
 ifeq ($(BR2_aarch64_be),y)
 LIBNSS_ARCH = aarch64
 else
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#6 lore raw

PATCH 2/3 package/libnss: remove ld segfault workaround

Hi Yann,

Quoted 12 lines · Yann E. MORIN

Giulio, All,

On 2019-12-17 15:37 +0100, Giulio Benetti spake thusly:

Quoted 2 lines

This ld bug has been fixed with binutils version 2.27 and Buildroot at the moment provides binutils > 2.27, so let's remove the workaround.

Even though Buildroot only has binutils > 2.27, there might still exist pre-built, external toolchains that use a version older than 2.27.

Since we support gcc back to at least 4.3, I believe we must still support binutils versions that were contemporary to that.

Quoted 8 lines

gcc-4.3 was releaswed in 2008, so the current binutils at the time was 2.18

However, for microblaze, in practice, I'm not sure what the oldest binutils version makes sense... :-/

Unless another maintainer is happy to take those two patches, I'll reject then next year (woot, you have a one year delay! ;-] ).

Yes :-) But it wouldn't make sense since we have to garantuee up to binutils 2.18 and bug is fixed on 2.27 only.

I'm going to set this and kmod patch as Rejected.

Best regards

Signature · 2 lines
Giulio Benetti
Benetti Engineering sas
Quoted 40 lines

Regards,
Yann E. MORIN.

Quoted 36 lines

---
This patch must be applied after patch:
https://patchwork.ozlabs.org/patch/1210535/

---
  package/libnss/libnss.mk | 10 ----------
  1 file changed, 10 deletions(-)
package/libnss/libnss.mk +0 -10
index 9349276a90..7c49ac1b25 100644
@@ -27,16 +27,6 @@ endef
 
  LIBNSS_PRE_CONFIGURE_HOOKS += LIBNSS_FIXUP_LINUX_MK
 
-# --gc-sections triggers binutils ld segfault
-# https://sourceware.org/bugzilla/show_bug.cgi?id=21180
-ifeq ($(BR2_microblaze),y)
-define LIBNSS_DROP_GC_SECTIONS
-	sed -i 's:-Wl,--gc-sections::g' $(@D)/nss/coreconf/Linux.mk
-endef
-
-LIBNSS_PRE_CONFIGURE_HOOKS += LIBNSS_DROP_GC_SECTIONS
-endif
-
  ifeq ($(BR2_aarch64_be),y)
  LIBNSS_ARCH = aarch64
  else
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
#7 lore raw

PATCH 3/3 package/kmod: remove ld segfault workaround

In reply to Giulio Benetti

This ld bug has been fixed with binutils version 2.27 and Buildroot at the moment provides binutils > 2.27, so let's remove the workaround.

---
 package/kmod/kmod.mk | 6 ------
 1 file changed, 6 deletions(-)
package/kmod/kmod.mk +0 -6
index e21f40a845..6d94e833ac 100644
@@ -17,12 +17,6 @@ HOST_KMOD_DEPENDENCIES = host-pkgconf
 KMOD_LICENSE = LGPL-2.1+ (library)
 KMOD_LICENSE_FILES = libkmod/COPYING
 
-# --gc-sections triggers binutils ld segfault
-# https://sourceware.org/bugzilla/show_bug.cgi?id=21180
-ifeq ($(BR2_microblaze),y)
-KMOD_CONF_ENV += cc_cv_LDFLAGS__Wl___gc_sections=false
-endif
-
 # static linking not supported, see
 # https://git.kernel.org/cgit/utils/kernel/kmod/kmod.git/commit/?id=b7016153ec8
 KMOD_CONF_OPTS = --disable-static --enable-shared
Signature · 1 line
2.20.1