net: mvpp2: cycle comphy to power it down
Subsystems (3)
PATCH 1/1 net: mvpp2: cycle comphy to power it down
Presently, at boot time, the comphys are enabled. For firmware compatibility reasons, the comphy driver does not power down the comphys at boot. Consequently, the ethernet comphys are left active until the network interfaces are brought through an up/down cycle.
If the port is never used, the port wastes power needlessly. Arrange for the ethernet comphys to be cycled by the mvpp2 driver as if the interface went through an up/down cycle during driver probe, thereby powering them down.
This saves:
270mW per 10G SFP+ port on the Macchiatobin Single Shot (eth0/eth1) 370mW per 10G PHY port on the Macchiatobin Double Shot (eth0/eth1) 160mW on the SFP port on either Macchiatobin flavour (eth3)
--- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +10 -0
@@ -5546,6 +5546,16 @@ static int mvpp2_port_probe(struct platform_device *pdev, port->phylink =NULL ; } +/* Cycle the comphy to power it down, saving 270mW per port - +* don't worry about an error powering it up. When the comphy +* driver does this, we can remove this code. +*/ +if (port->comphy) { + err =mvpp22_comphy_init (port); +if (err ==0 ) +phy_power_off (port->comphy); + } + err =register_netdev (dev);if (err <0 ) {dev_err (&pdev->dev,"failed to register netdev\n" );
Signature · 1 line
2.20.1
Hi Russell,
Quoted 10 lines · Russell King
Presently, at boot time, the comphys are enabled. For firmware compatibility reasons, the comphy driver does not power down the comphys at boot. Consequently, the ethernet comphys are left active until the network interfaces are brought through an up/down cycle.
If the port is never used, the port wastes power needlessly. Arrange for the ethernet comphys to be cycled by the mvpp2 driver as if the interface went through an up/down cycle during driver probe, thereby powering them down.
Quoted 6 lines
This saves:
270mW per 10G SFP+ port on the Macchiatobin Single Shot (eth0/eth1) 370mW per 10G PHY port on the Macchiatobin Double Shot (eth0/eth1) 160mW on the SFP port on either Macchiatobin flavour (eth3)Signed-off-by Russell King <[email protected]>
Thanks!
Antoine
Quoted 28 lines
--- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 10 ++++++++++ 1 file changed, 10 insertions(+)drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +10
-0@@ -5546,6 +5546,16 @@ static int mvpp2_port_probe(struct platform_device *pdev, port->phylink =NULL ; } +/* Cycle the comphy to power it down, saving 270mW per port - +* don't worry about an error powering it up. When the comphy +* driver does this, we can remove this code. +*/ +if (port->comphy) { + err =mvpp22_comphy_init (port); +if (err ==0 ) +phy_power_off (port->comphy); + } + err =register_netdev (dev);if (err <0 ) {dev_err (&pdev->dev,"failed to register netdev\n" );Signature · 1 line
2.20.1
Signature · 3 lines
Antoine Ténart, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
From: Russell King <[email protected]>
Date: Tue, 17 Dec 2019 15:47:36 +0000
Quoted 10 lines
Presently, at boot time, the comphys are enabled. For firmware compatibility reasons, the comphy driver does not power down the comphys at boot. Consequently, the ethernet comphys are left active until the network interfaces are brought through an up/down cycle.
If the port is never used, the port wastes power needlessly. Arrange for the ethernet comphys to be cycled by the mvpp2 driver as if the interface went through an up/down cycle during driver probe, thereby powering them down.
Quoted 6 lines
This saves:
270mW per 10G SFP+ port on the Macchiatobin Single Shot (eth0/eth1) 370mW per 10G PHY port on the Macchiatobin Double Shot (eth0/eth1) 160mW on the SFP port on either Macchiatobin flavour (eth3)Signed-off-by Russell King <[email protected]>
Applied, thanks.