bdev: reset first_open when looping in __blkget_dev
PATCH 1/1 bdev: reset first_open when looping in __blkget_dev
It is not clear that no other thread cannot open the block device when __blkget_dev drops it and loop to restart label. Reset first_open to false when looping.
Signed-off-by Michal Suchanek <[email protected]>
--- fs/block_dev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/block_dev.c +2 -1
@@ -1560,7 +1560,7 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, int for_part)int ret;int partno;int perm =0 ; -bool first_open = false; +bool first_open;if (mode &FMODE_READ ) perm |=MAY_READ ;
@@ -1580,6 +1580,7 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, int for_part) restart: ret = -ENXIO ; + first_open = false; disk =bdev_get_gendisk (bdev, &partno);if (!disk) goto out;
Signature · 1 line
2.23.0
Quoted 5 lines · Michal Suchanek
It is not clear that no other thread cannot open the block device when
__blkget_devdrops it and loop to restart label. Resetfirst_opento false when looping.Signed-off-by Michal Suchanek <[email protected]>
Yeah, good catch. Thanks for the patch. You can add:
Reviewed-by Jan Kara <[email protected]>
Honza
Quoted 28 lines
--- fs/block_dev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)fs/block_dev.c +2
-1@@ -1560,7 +1560,7 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, int for_part)int ret;int partno;int perm =0 ; -bool first_open = false; +bool first_open;if (mode &FMODE_READ ) perm |=MAY_READ ;@@ -1580,6 +1580,7 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, int for_part) restart: ret = -ENXIO ; + first_open = false; disk =bdev_get_gendisk (bdev, &partno);if (!disk) goto out;Signature · 1 line
2.23.0
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR