phy: qualcomm: Adjust indentation in read_poll_timeout
Subsystems (2)
PATCH 1/1 phy: qualcomm: Adjust indentation in read_poll_timeout
Clang warns:
../drivers/phy/qualcomm/phy-qcom-apq8064-sata.c:83:4: warning:
misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
usleep_range(DELAY_INTERVAL_US, DELAY_INTERVAL_US + 50);
^../drivers/phy/qualcomm/phy-qcom-apq8064-sata.c:80:3: note: previous statement is here
if (readl_relaxed(addr) & mask)
^
1 warning generated.
This warning occurs because there is a space after the tab on this line. Remove it so that the indentation is consistent with the Linux kernel coding style and clang no longer warns.
--- drivers/phy/qualcomm/phy-qcom-apq8064-sata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/qualcomm/phy-qcom-apq8064-sata.c +1 -1
@@ -80,7 +80,7 @@ static int read_poll_timeout(void __iomem *addr, u32 mask)if (readl_relaxed (addr) & mask)return 0 ; -usleep_range (DELAY_INTERVAL_US ,DELAY_INTERVAL_US +50 ); +usleep_range (DELAY_INTERVAL_US ,DELAY_INTERVAL_US +50 ); }while (!time_after (jiffies, timeout));return (readl_relaxed (addr) & mask) ?0 : -ETIMEDOUT ;
Signature · 1 line
2.24.1
Quoted 13 lines · Nathan Chancellor
Clang warns:
../drivers/phy/qualcomm/phy-qcom-apq8064-sata.c:83:4: warning:
misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]usleep_range(DELAY_INTERVAL_US, DELAY_INTERVAL_US + 50); ^
../drivers/phy/qualcomm/phy-qcom-apq8064-sata.c:80:3: note: previous statement is here
if (readl_relaxed(addr)& mask)
^
1 warning generated.
Quoted 4 lines
This warning occurs because there is a space after the tab on this line. Remove it so that the indentation is consistent with the Linux kernel coding style and clang no longer warns.
Quoted 23 lines
Fixes 1de990d8a169 ("phy: qcom: Add driver for QCOM APQ8064 SATA PHY")Signed-off-by Nathan Chancellor <[email protected]>--- drivers/phy/qualcomm/phy-qcom-apq8064-sata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/phy/qualcomm/phy-qcom-apq8064-sata.c +1
-1@@ -80,7 +80,7 @@ static int read_poll_timeout(void __iomem *addr, u32 mask)if (readl_relaxed (addr) & mask)return 0 ; -usleep_range (DELAY_INTERVAL_US ,DELAY_INTERVAL_US +50 ); +usleep_range (DELAY_INTERVAL_US ,DELAY_INTERVAL_US +50 ); }while (!time_after (jiffies, timeout));return (readl_relaxed (addr) & mask) ?0 : -ETIMEDOUT ;Signature · 1 line
2.24.1
Kishon Vijay Abraham I
AppliedQuoted 15 lines · Bjorn Andersson
Quoted 13 lines · Nathan Chancellor
Clang warns:
../drivers/phy/qualcomm/phy-qcom-apq8064-sata.c:83:4: warning:
misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]usleep_range(DELAY_INTERVAL_US, DELAY_INTERVAL_US + 50); ^
../drivers/phy/qualcomm/phy-qcom-apq8064-sata.c:80:3: note: previous statement is here
if (readl_relaxed(addr)& mask)
^
1 warning generated.
Quoted 6 lines
Quoted 4 lines
This warning occurs because there is a space after the tab on this line. Remove it so that the indentation is consistent with the Linux kernel coding style and clang no longer warns.
Reviewed-by Bjorn Andersson <[email protected]>
merged, thanks!
-Kishon
Quoted 24 lines
Quoted 24 lines
Fixes 1de990d8a169 ("phy: qcom: Add driver for QCOM APQ8064 SATA PHY")Signed-off-by Nathan Chancellor <[email protected]>--- drivers/phy/qualcomm/phy-qcom-apq8064-sata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/phy/qualcomm/phy-qcom-apq8064-sata.c +1
-1@@ -80,7 +80,7 @@ static int read_poll_timeout(void __iomem *addr, u32 mask)if (readl_relaxed (addr) & mask)return 0 ; -usleep_range (DELAY_INTERVAL_US ,DELAY_INTERVAL_US +50 ); +usleep_range (DELAY_INTERVAL_US ,DELAY_INTERVAL_US +50 ); }while (!time_after (jiffies, timeout));return (readl_relaxed (addr) & mask) ?0 : -ETIMEDOUT ;Signature · 1 line
2.24.1