Skip to contentSkip to conversation

vfs: Adjust indentation in remap_verify_area

PATCH Superseded Nathan Chancellor 3 participants 5 messages Dec 18, 2019 – Dec 22, 2019 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vfs: Adjust indentation in remap_verify_area

Clang warns:

../fs/read_write.c:1760:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]

         if (unlikely((loff_t) (pos + len) < 0))
         ^
../fs/read_write.c:1757:2: note: previous statement is here
        if (unlikely(pos < 0 || len < 0))
        ^

1 warning generated.

This warning occurs because there is a space after the tab on this line. Remove it so that the indentation is consistent with the Linux kernel coding style and clang no longer warns.

Fixes 04b38d601239 ("vfs: pull btrfs clone API to vfs layer")
---
 fs/read_write.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/read_write.c +1 -1
index 5bbf587f5bc1..c71e863163bd 100644
@@ -1757,7 +1757,7 @@ static int remap_verify_area(struct file *file, loff_t pos, loff_t len,
 	if (unlikely(pos < 0 || len < 0))
 		return -EINVAL;
 
-	 if (unlikely((loff_t) (pos + len) < 0))
+	if (unlikely((loff_t) (pos + len) < 0))
 		return -EINVAL;
 
 	if (unlikely(inode->i_flctx && mandatory_lock(inode))) {
Signature · 1 line
2.24.1
maintainer
#1 lore raw
Quoted 11 lines · Nathan Chancellor

Clang warns:

../fs/read_write.c:1760:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]

         if (unlikely((loff_t) (pos + len) < 0))
         ^
../fs/read_write.c:1757:2: note: previous statement is here
        if (unlikely(pos < 0 || len < 0))
        ^

1 warning generated.

Quoted 7 lines

This warning occurs because there is a space after the tab on this line. Remove it so that the indentation is consistent with the Linux kernel coding style and clang no longer warns.

Fixes 04b38d601239 ("vfs: pull btrfs clone API to vfs layer")

Egads... This commit message is way, way over the top.

1) the warning is more obscure than the problem it points to.

2) simple "statement accidentally indented one column too deep" would do just fine

3) crediting the tool is generally a good idea, but in situation when the quality of warning is that low you'd be better paraphrasing it and mentioning the tool that has pointed it out. No need to quote the verbiage.

#2 lore raw

PATCH v2 1/1 vfs: Adjust indentation in remap_verify_area

Clang's -Wmisleading-indentation caught an instance in remap_verify_area where there was a trailing space after a tab. Remove it to get rid of the warning.

Fixes 04b38d601239 ("vfs: pull btrfs clone API to vfs layer")

---

v1 -> v2:

* Trim warning and simplify patch explanation.

 fs/read_write.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/read_write.c +1 -1
index 5bbf587f5bc1..c71e863163bd 100644
@@ -1757,7 +1757,7 @@ static int remap_verify_area(struct file *file, loff_t pos, loff_t len,
 	if (unlikely(pos < 0 || len < 0))
 		return -EINVAL;
 
-	 if (unlikely((loff_t) (pos + len) < 0))
+	if (unlikely((loff_t) (pos + len) < 0))
 		return -EINVAL;
 
 	if (unlikely(inode->i_flctx && mandatory_lock(inode))) {
Signature · 1 line
2.24.1
#3 lore raw
Quoted 21 lines · Nathan Chancellor

Clang's -Wmisleading-indentation caught an instance in remap_verify_area where there was a trailing space after a tab. Remove it to get rid of the warning.

Fixes 04b38d601239 ("vfs: pull btrfs clone API to vfs layer")

---

v1 -> v2:

* Trim warning and simplify patch explanation.

 fs/read_write.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/read_write.c +0 -0
index 5bbf587f5bc1..c71e863163bd 100644

fs/read_write.c static int remap_verify_area(struct file *file, loff_t pos, loff_t len, · line 1760

Quoted 5 lines
fs/read_write.c +1 -1
@@ -1757,7 +1757,7 @@ static int remap_verify_area(struct file *file, loff_t pos, loff_t len,
 	if (unlikely(pos < 0 || len < 0))
 		return -EINVAL;
 
-	 if (unlikely((loff_t) (pos + len) < 0))
+	if (unlikely((loff_t) (pos + len) < 0))

Instead of just fixing whitespace, can we please fix the undefined behaviour on this line? pos and len are signed types, there's a helper to do that in a way that's UB-safe.

And btw here's a patch:

https://lore.kernel.org/linux-fsdevel/[email protected]/

#4 lore raw
Quoted 32 lines · David Sterba
Quoted 21 lines · Nathan Chancellor

Clang's -Wmisleading-indentation caught an instance in remap_verify_area where there was a trailing space after a tab. Remove it to get rid of the warning.

Fixes 04b38d601239 ("vfs: pull btrfs clone API to vfs layer")

---

v1 -> v2:

* Trim warning and simplify patch explanation.

 fs/read_write.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/read_write.c +0 -0
index 5bbf587f5bc1..c71e863163bd 100644

fs/read_write.c static int remap_verify_area(struct file *file, loff_t pos, loff_t len, · line 1760

Quoted 5 lines
fs/read_write.c +1 -1
@@ -1757,7 +1757,7 @@ static int remap_verify_area(struct file *file, loff_t pos, loff_t len,
 	if (unlikely(pos < 0 || len < 0))
 		return -EINVAL;
 
-	 if (unlikely((loff_t) (pos + len) < 0))
+	if (unlikely((loff_t) (pos + len) < 0))

Instead of just fixing whitespace, can we please fix the undefined behaviour on this line? pos and len are signed types, there's a helper to do that in a way that's UB-safe.

Quoted 3 lines

And btw here's a patch:

https://lore.kernel.org/linux-fsdevel/[email protected]/

I do not particularly care how this warning gets fixed, just that it does. I will review that patch like Nick did.

Cheers,
Nathan