Skip to contentSkip to conversation

drm/amdgpu: correctly report gpu recover status

PATCH NAK Evan Quan 3 participants 4 messages Dec 18, 2019 – Jan 1, 2020

Subsystems (2)
lore
Share & tools
lore

Evan Quan

author
#0 lore raw

PATCH 1/1 drm/amdgpu: correctly report gpu recover status

Knowing whether gpu recovery was performed successfully or not is important for our BACO development.

Change-Id I0e3ca4dcb65a053eb26bc55ad7431e4a42e160de
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c +1 -3
index e9efee04ca23..5dff5c0dd882 100644
@@ -743,9 +743,7 @@ static int amdgpu_debugfs_gpu_recover(struct seq_file *m, void *data)
 	struct amdgpu_device *adev = dev->dev_private;
 
 	seq_printf(m, "gpu recover\n");
-	amdgpu_device_gpu_recover(adev, NULL);
-
-	return 0;
+	return amdgpu_device_gpu_recover(adev, NULL);
 }
 
 static const struct drm_info_list amdgpu_debugfs_fence_list[] = {
Signature · 6 lines
2.24.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
#1 lore raw

Am 18.12.19 um 04:25 schrieb Evan Quan:

Quoted 14 lines

Knowing whether gpu recovery was performed successfully or not is important for our BACO development.

Change-Id I0e3ca4dcb65a053eb26bc55ad7431e4a42e160de
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c +0 -0
index e9efee04ca23..5dff5c0dd882 100644

drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c static int amdgpu_debugfs_gpu_recover(struct seq_file *m, void *data) · line 746

Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c +1 -3
@@ -743,9 +743,7 @@ static int amdgpu_debugfs_gpu_recover(struct seq_file *m, void *data)
  	struct amdgpu_device *adev = dev->dev_private;
 
  	seq_printf(m, "gpu recover\n");
-	amdgpu_device_gpu_recover(adev, NULL);
-
-	return 0;
+	return amdgpu_device_gpu_recover(adev, NULL);

NAK, what we could do here is the following:

r = amdgpu_device_gpu_recover(....);
seq_printf(m, "gpu recover %d\n", r);

But returning the error code from the GPU recovery to userspace doesn't make to much sense.

Christian.

drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c static int amdgpu_debugfs_gpu_recover(struct seq_file *m, void *data) · line 749

Quoted 3 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c +0 -0
  }
 
  static const struct drm_info_list amdgpu_debugfs_fence_list[] = {

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

author
#2 lore raw

Hi Christian,

Here is some background for this change:
I'm debugging a random failure issue on baco reset.
I used a while loop to run the continuous baco reset tests and hope it can exit immediately on failure occurred. However, due to wrong return value, it did not. And as you can image, the failure scene was ruined.

I can add this "seq_printf(m, "gpu recover %d\n", r);".
But still what I care more(which is also the easiest way to me) is the correct return value of the API.

Regards,
Evan

Quoted 33 lines

-----Original Message-----
From: Christian König <[email protected]>
Sent: Wednesday, December 18, 2019 5:57 PM
To: Quan, Evan <[email protected]>; [email protected]
Subject: Re: [PATCH] drm/amdgpu: correctly report gpu recover status

Am 18.12.19 um 04:25 schrieb Evan Quan:

drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c static int amdgpu_debugfs_gpu_recover(struct

Quoted 15 lines

Knowing whether gpu recovery was performed successfully or not is important for our BACO development.

Change-Id I0e3ca4dcb65a053eb26bc55ad7431e4a42e160de
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c +0 -0
index e9efee04ca23..5dff5c0dd882 100644
@@ -743,9 +743,7 @@ static int amdgpu_debugfs_gpu_recover(struct

seq_file *m, void *data)

drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c static int amdgpu_debugfs_gpu_recover(struct seq_file *m, void *data) · line 746

Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c +1 -3
  	struct amdgpu_device *adev = dev->dev_private;
 
  	seq_printf(m, "gpu recover\n");
-	amdgpu_device_gpu_recover(adev, NULL);
-
-	return 0;
+	return amdgpu_device_gpu_recover(adev, NULL);

NAK, what we could do here is the following:

Quoted 11 lines

r = amdgpu_device_gpu_recover(....);
seq_printf(m, "gpu recover %d\n", r);

But returning the error code from the GPU recovery to userspace doesn't make to much sense.

Christian.

Quoted 3 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c +0 -0
  }
 
  static const struct drm_info_list amdgpu_debugfs_fence_list[] = {

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

maintainer
#3 lore raw

Hi Evan,

Quoted 1 line

But still what I care more(which is also the easiest way to me) is the correct return value of the API.

Well exactly that's the point ther return value is not correct for the API.

For example when the GPU reset function would return -EFAULT your program which reads the debugfs file would crash with a segmentation fault. That is not correct behavior.

In other words the result of the GPU reset can't be used as result of the debugfs read.

Regards,
Christian.

Am 19.12.19 um 02:48 schrieb Quan, Evan:

Quoted 7 lines

Hi Christian,

Here is some background for this change:
I'm debugging a random failure issue on baco reset.
I used a while loop to run the continuous baco reset tests and hope it can exit immediately on failure occurred. However, due to wrong return value, it did not. And as you can image, the failure scene was ruined.

Quoted 48 lines

I can add this "seq_printf(m, "gpu recover %d\n", r);".
But still what I care more(which is also the easiest way to me) is the correct return value of the API.

Regards,
Evan

Quoted 43 lines

-----Original Message-----
From: Christian König <[email protected]>
Sent: Wednesday, December 18, 2019 5:57 PM
To: Quan, Evan <[email protected]>; [email protected]
Subject: Re: [PATCH] drm/amdgpu: correctly report gpu recover status

Am 18.12.19 um 04:25 schrieb Evan Quan:

drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c static int amdgpu_debugfs_gpu_recover(struct

Quoted 15 lines

Knowing whether gpu recovery was performed successfully or not is important for our BACO development.

Change-Id I0e3ca4dcb65a053eb26bc55ad7431e4a42e160de
---
   drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 4 +---
   1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c +0 -0
index e9efee04ca23..5dff5c0dd882 100644
@@ -743,9 +743,7 @@ static int amdgpu_debugfs_gpu_recover(struct

seq_file *m, void *data)

drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c static int amdgpu_debugfs_gpu_recover(struct seq_file *m, void *data) · line 746

Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c +1 -3
   	struct amdgpu_device *adev = dev->dev_private;
 
   	seq_printf(m, "gpu recover\n");
-	amdgpu_device_gpu_recover(adev, NULL);
-
-	return 0;
+	return amdgpu_device_gpu_recover(adev, NULL);

NAK, what we could do here is the following:

r = amdgpu_device_gpu_recover(....);
seq_printf(m, "gpu recover %d\n", r);

But returning the error code from the GPU recovery to userspace doesn't make to much sense.

Christian.

Quoted 3 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c +0 -0
   }
 
   static const struct drm_info_list amdgpu_debugfs_fence_list[] = {

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx