clk: qcom: smd: Add missing bimc clock
Subsystems (3)
PATCH 1/1 clk: qcom: smd: Add missing bimc clock
It turns out booting the modem is dependent on a bimc vote from Linux on msm8998. To make the modem happy, add the bimc clock to rely on the default vote from rpmcc. Once we have interconnect support, bimc should be controlled properly.
--- drivers/clk/qcom/clk-smd-rpm.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/clk/qcom/clk-smd-rpm.c +3 -0
@@ -648,6 +648,7 @@ static const struct rpm_smd_clk_desc rpm_clk_qcs404 = { };/* msm8998 */ +DEFINE_CLK_SMD_RPM (msm8998, bimc_clk, bimc_a_clk,QCOM_SMD_RPM_MEM_CLK ,0 );DEFINE_CLK_SMD_RPM (msm8998, pcnoc_clk, pcnoc_a_clk,QCOM_SMD_RPM_BUS_CLK ,0 );DEFINE_CLK_SMD_RPM (msm8998, snoc_clk, snoc_a_clk,QCOM_SMD_RPM_BUS_CLK ,1 );DEFINE_CLK_SMD_RPM (msm8998, cnoc_clk, cnoc_a_clk,QCOM_SMD_RPM_BUS_CLK ,2 );
@@ -671,6 +672,8 @@ DEFINE_CLK_SMD_RPM_XO_BUFFER_PINCTRL(msm8998, rf_clk2_pin, rf_clk2_a_pin, 5);DEFINE_CLK_SMD_RPM_XO_BUFFER (msm8998, rf_clk3, rf_clk3_a,6 );DEFINE_CLK_SMD_RPM_XO_BUFFER_PINCTRL (msm8998, rf_clk3_pin, rf_clk3_a_pin,6 );static struct clk_smd_rpm *msm8998_clks[] = { + [RPM_SMD_BIMC_CLK ] = &msm8998_bimc_clk, + [RPM_SMD_BIMC_A_CLK ] = &msm8998_bimc_a_clk, [RPM_SMD_PCNOC_CLK ] = &msm8998_pcnoc_clk, [RPM_SMD_PCNOC_A_CLK ] = &msm8998_pcnoc_a_clk, [RPM_SMD_SNOC_CLK ] = &msm8998_snoc_clk,
Signature · 1 line
2.17.1
Quoted 6 lines · Jeffrey Hugo
It turns out booting the modem is dependent on a bimc vote from Linux on msm8998. To make the modem happy, add the bimc clock to rely on the default vote from rpmcc. Once we have interconnect support, bimc should be controlled properly.
Fixes 6131dc81211c ("clk: qcom: smd: Add support for MSM8998 rpm clocks")
Quoted 29 lines
Signed-off-by Jeffrey Hugo <[email protected]>--- drivers/clk/qcom/clk-smd-rpm.c | 3 +++ 1 file changed, 3 insertions(+)drivers/clk/qcom/clk-smd-rpm.c +3
-0@@ -648,6 +648,7 @@ static const struct rpm_smd_clk_desc rpm_clk_qcs404 = { };/* msm8998 */ +DEFINE_CLK_SMD_RPM (msm8998, bimc_clk, bimc_a_clk,QCOM_SMD_RPM_MEM_CLK ,0 );DEFINE_CLK_SMD_RPM (msm8998, pcnoc_clk, pcnoc_a_clk,QCOM_SMD_RPM_BUS_CLK ,0 );DEFINE_CLK_SMD_RPM (msm8998, snoc_clk, snoc_a_clk,QCOM_SMD_RPM_BUS_CLK ,1 );DEFINE_CLK_SMD_RPM (msm8998, cnoc_clk, cnoc_a_clk,QCOM_SMD_RPM_BUS_CLK ,2 );@@ -671,6 +672,8 @@ DEFINE_CLK_SMD_RPM_XO_BUFFER_PINCTRL(msm8998, rf_clk2_pin, rf_clk2_a_pin, 5);DEFINE_CLK_SMD_RPM_XO_BUFFER (msm8998, rf_clk3, rf_clk3_a,6 );DEFINE_CLK_SMD_RPM_XO_BUFFER_PINCTRL (msm8998, rf_clk3_pin, rf_clk3_a_pin,6 );static struct clk_smd_rpm *msm8998_clks[] = { + [RPM_SMD_BIMC_CLK ] = &msm8998_bimc_clk, + [RPM_SMD_BIMC_A_CLK ] = &msm8998_bimc_a_clk, [RPM_SMD_PCNOC_CLK ] = &msm8998_pcnoc_clk, [RPM_SMD_PCNOC_A_CLK ] = &msm8998_pcnoc_a_clk, [RPM_SMD_SNOC_CLK ] = &msm8998_snoc_clk,Signature · 1 line
2.17.1
Quoting Jeffrey Hugo (2019-12-17 08:54:09)
Quoted 8 lines
It turns out booting the modem is dependent on a bimc vote from Linux on msm8998. To make the modem happy, add the bimc clock to rely on the default vote from rpmcc. Once we have interconnect support, bimc should be controlled properly.
Fixes 6131dc81211c ("clk: qcom: smd: Add support for MSM8998 rpm clocks")Signed-off-by Jeffrey Hugo <[email protected]>---
Applied to clk-next