workqueue: dexpose worker
Subsystems (2)
RFC 1/1 workqueue: dexpose worker
It does not make much sense to expose worker, workqueue's internal object, to outsiders, and whatever field inside worker as well. Nor does worker pool rather than workqueue and work.
Signed-off-by Hillf Danton <[email protected]>
---
kernel/workqueue_internal.h +7 -0
@@ -69,6 +69,13 @@ static inline struct worker *current_wq_return NULL ; } +static inline bool current_is_executing (work_func_t func) +{ +struct worker *worker =current_wq_worker (); + +return worker && worker->current_func == func; +} +/* * Scheduler hooks for concurrency managed workqueue. Only to be used from * sched/ and workqueue.c.
kernel/async.c +1 -3
@@ -327,8 +327,6 @@ EXPORT_SYMBOL_GPL(async_synchronize_cook*/ bool current_is_async (void ) { -struct worker *worker =current_wq_worker (); - -return worker && worker->current_func == async_run_entry_fn; +return current_is_executing (async_run_entry_fn); }EXPORT_SYMBOL_GPL (current_is_async);
You probably wanted to Cc maintainers.
Quoted 4 lines · Hillf Danton
It does not make much sense to expose worker, workqueue's internal object, to outsiders, and whatever field inside worker as well. Nor does worker pool rather than workqueue and work.
But I have to say that this doesn't really make much sense to me. What is the problem you are trying to solve?
current_is_executing is a really ambiguous name without any relation to WQ. Also this seems like a pointless code churn to me. Anyway for maintainers to judge.
Quoted 33 lines
Signed-off-by Hillf Danton <[email protected]>---
kernel/workqueue_internal.h +7
-0@@ -69,6 +69,13 @@ static inline struct worker *current_wq_return NULL ; } +static inline bool current_is_executing (work_func_t func) +{ +struct worker *worker =current_wq_worker (); + +return worker && worker->current_func == func; +} +/* * Scheduler hooks for concurrency managed workqueue. Only to be used from * sched/ and workqueue.c. kernel/async.c +1
-3@@ -327,8 +327,6 @@ EXPORT_SYMBOL_GPL(async_synchronize_cook*/ bool current_is_async (void ) { -struct worker *worker =current_wq_worker (); - -return worker && worker->current_func == async_run_entry_fn; +return current_is_executing (async_run_entry_fn); }EXPORT_SYMBOL_GPL (current_is_async);
Signature · 2 lines
Michal Hocko SUSE Labs