Skip to contentSkip to conversation

brcmfmac: set interface carrier to off by default

PATCH In review Rafał Miłecki 2 participants 2 messages Dec 10, 2019 – Dec 18, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 brcmfmac: set interface carrier to off by default

From: Rafał Miłecki <[email protected]>

It's important as brcmfmac creates one main interface for each PHY and doesn't allow deleting it. Not setting carrier could result in other subsystems misbehaving (e.g. LEDs "netdev" trigger turning LED on).

---
I noticed this problem when using "netdev" LED trigger with "wlan0" set as "device_name". While my interface was down (unused) the "netdev" trigger was checking it with netif_carrier_ok() and assuming it's up.

This solution affects initial state of all brcmfmac interfaces (not only the first non-removable one) but I think it should be fine. Later on brcmfmac takes care of updating carrier as needed.

---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c +2 -0
index 85cf96461dde..d3ddd97fe768 100644
@@ -661,6 +661,8 @@ int brcmf_net_attach(struct brcmf_if *ifp, bool rtnl_locked)
 		goto fail;
 	}
 
+	netif_carrier_off(ndev);
+
 	ndev->priv_destructor = brcmf_cfg80211_free_netdev;
 	brcmf_dbg(INFO, "%s: Broadcom Dongle Host Driver\n", ndev->name);
 	return 0;
Signature · 1 line
2.21.0
#1 lore raw
Quoted 7 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

It's important as brcmfmac creates one main interface for each PHY and doesn't allow deleting it. Not setting carrier could result in other subsystems misbehaving (e.g. LEDs "netdev" trigger turning LED on).

Patch applied to wireless-drivers-next.git, thanks.

8d9627b05b2c brcmfmac: set interface carrier to off by default

Signature · 3 lines
https://patchwork.kernel.org/patch/11281933/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches