Skip to contentSkip to conversation

package/kf5/kf5-kcoreaddons: don't treat ld warnings as errors

PATCH New Giulio Benetti 3 participants 3 messages Dec 18, 2019 – Dec 23, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/kf5/kf5-kcoreaddons: don't treat ld warnings as errors

Microblaze ld emits warnings like:
'
FDE encoding in CMakeFiles/KF5CoreAddons.dir/KF5CoreAddons_autogen/mocs_compilation.cpp.o(.eh_frame) prevents .eh_frame_hdr table being created
'
Since '-Wl,--fatal-warnings' is passed by default, build fails, so don't treat warnings as errors by appending "-Wl,--no-fatal-warnings" to CMAKE_SHARED_LINKER_FLAGS that is previously defined in package dependency kf5-extra-cmake-modules.

Fixes:
http://autobuild.buildroot.net/results/f19/f198c86930535c50393e17fc7a70fb4f27b096ee/

---
 package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk | 5 +++++
 1 file changed, 5 insertions(+)
package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk +5 -0
index 164bad1225..5b3e9acd90 100644
@@ -21,4 +21,9 @@ endif
 
 KF5_KCOREADDONS_CONF_OPTS = -DCMAKE_CXX_FLAGS="$(KF5_KCOREADDONS_CXXFLAGS)"
 
+ifeq ($(BR2_microblaze),y)
+# Microblaze ld emits warnings, make warnings not to be treated as errors
+KF5_KCOREADDONS_CONF_OPTS = -DCMAKE_SHARED_LINKER_FLAGS="-Wl,--no-fatal-warnings"
+endif
+
 $(eval $(cmake-package))
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/kf5/kf5-kcoreaddons: don't treat ld warnings as errors

Quoted 11 lines · On Wed, 18 Dec 2019 17:19:57 +0100 Giulio Benetti…

Microblaze ld emits warnings like:
'
FDE encoding in CMakeFiles/KF5CoreAddons.dir/KF5CoreAddons_autogen/mocs_compilation.cpp.o(.eh_frame) prevents .eh_frame_hdr table being created
'
Since '-Wl,--fatal-warnings' is passed by default, build fails, so don't treat warnings as errors by appending "-Wl,--no-fatal-warnings" to CMAKE_SHARED_LINKER_FLAGS that is previously defined in package dependency kf5-extra-cmake-modules.

Quoted 7 lines

Fixes:
http://autobuild.buildroot.net/results/f19/f198c86930535c50393e17fc7a70fb4f27b096ee/

---
 package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk | 5 +++++
 1 file changed, 5 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/kf5/kf5-kcoreaddons: don't treat ld warnings as errors

In reply to Giulio Benetti
Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Giulio" == Giulio Benetti <[email protected]> writes:

Microblaze ld emits warnings like:
'
FDE encoding in CMakeFiles/KF5CoreAddons.dir/KF5CoreAddons_autogen/mocs_compilation.cpp.o(.eh_frame) prevents .eh_frame_hdr table being created
'
Since '-Wl,--fatal-warnings' is passed by default, build fails, so don't treat warnings as errors by appending "-Wl,--no-fatal-warnings" to CMAKE_SHARED_LINKER_FLAGS that is previously defined in package dependency kf5-extra-cmake-modules.

Quoted 4 lines

Fixes:
http://autobuild.buildroot.net/results/f19/f198c86930535c50393e17fc7a70fb4f27b096ee/

Committed to 2019.02.x and 2019.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard