Skip to contentSkip to conversation

peap: Ignore Crypto-Binding TLVs with invalid compound MACs

PATCH Applied Tim Kourt 2 participants 2 messages Dec 19, 2019

lore
Share & tools
lore

Tim Kourt

author
#0 lore raw

PATCH 1/1 peap: Ignore Crypto-Binding TLVs with invalid compound MACs

Some server implementation don't seem to provide the valid compound MACs. In the meantime, iwd will ignore the invalid Crypto-Binding TLVs as their usage is optional.

---
 src/eap-peap.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
src/eap-peap.c +5 -2
index 273a206f..005eacc4 100644
@@ -231,8 +231,11 @@ static int eap_extensions_handle_cryptobinding_tlv(struct eap_state *eap,
 					cryptobinding_compound_mac_len)) {
 		l_error("PEAP: Generated compound MAC and server compound MAC "
 							"don't match.");
-
-		return -EIO;
+		/*
+		 * Ignore the Crypto-Binding TLV in the case of unmatched
+		 * compound MACs.
+		 */
+		return 0;
 	}
 
 	/* Build response Crypto-Binding TLV */
Signature · 1 line
2.13.6
#1 lore raw

Hi Tim,

Quoted 7 lines · Tim Kourt

Some server implementation don't seem to provide the valid compound MACs. In the meantime, iwd will ignore the invalid Crypto-Binding TLVs as their usage is optional.

---
  src/eap-peap.c | 7 +++++--
  1 file changed, 5 insertions(+), 2 deletions(-)

Applied, thanks.

Regards,
-Denis