Skip to contentSkip to conversation

mtd: spi-nor: make s25fl129p1 skip SFDP parsing

PATCH In review Jiwei Sun 2 participants 2 messages Dec 19, 2019 – Dec 24, 2019

Subsystems (2)
lore
Share & tools
lore

Jiwei Sun

author
#0 lore raw

PATCH 1/1 mtd: spi-nor: make s25fl129p1 skip SFDP parsing

From: jsun4 <[email protected]>

The right page size of S25FL129P has been gotten in the function spi_nor_info_init_params() before invoking spi_nor_parse_bfpt(), it is 256-bytes, but the size will be changed to 512 bytes in the following function spi_nor_parse_bfpt(). And there is no explanation of the SFDP according to the datasheet of S25FL129P. So we can skip SFDP parsing.

---
 drivers/mtd/spi-nor/spi-nor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/spi-nor/spi-nor.c +1 -1
index f4afe123e9dc..dcb4471c735c 100644
@@ -2504,7 +2504,7 @@ static const struct flash_info spi_nor_ids[] = {
 	{ "s25sl12800", INFO(0x012018, 0x0300, 256 * 1024,  64, 0) },
 	{ "s25sl12801", INFO(0x012018, 0x0301,  64 * 1024, 256, 0) },
 	{ "s25fl129p0", INFO(0x012018, 0x4d00, 256 * 1024,  64, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
-	{ "s25fl129p1", INFO(0x012018, 0x4d01,  64 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
+	{ "s25fl129p1", INFO(0x012018, 0x4d01,  64 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR | SPI_NOR_SKIP_SFDP) },
 	{ "s25sl004a",  INFO(0x010212,      0,  64 * 1024,   8, 0) },
 	{ "s25sl008a",  INFO(0x010213,      0,  64 * 1024,  16, 0) },
 	{ "s25sl016a",  INFO(0x010214,      0,  64 * 1024,  32, 0) },
Signature · 1 line
2.20.1
#1 lore raw

Hi, Jiwei,

Quoted 11 lines · Jiwei Sun

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

From: jsun4 <[email protected]>

The right page size of S25FL129P has been gotten in the function spi_nor_info_init_params() before invoking spi_nor_parse_bfpt(), it is 256-bytes, but the size will be changed to 512 bytes in the following function spi_nor_parse_bfpt(). And there is no explanation of the SFDP according to the datasheet of S25FL129P. So we can skip SFDP parsing.

Would you please dump the sfdp so that we can check what's going on? If the BFPT table has the page size param wrong, we can use the post_bfpt hook to correct it. This way we will still benefit of the rest of the info from BFPT.

Cheers,
ta