Skip to contentSkip to conversation

libbpf: Fix printing of ulimit value

PATCH Applied Toke Høiland-Jørgensen 2 participants 2 messages Dec 19, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 libbpf: Fix printing of ulimit value

Naresh pointed out that libbpf builds fail on 32-bit architectures because rlimit.rlim_cur is defined as 'unsigned long long' on those architectures. Fix this by using %zu in printf and casting to size_t.

Fixes dc3a2d254782 ("libbpf: Print hint about ulimit when getting permission denied error")

---
v2:
- Use %zu instead of PRIu64

 tools/lib/bpf/libbpf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/lib/bpf/libbpf.c +1 -1
index c69a3745ecb0..59bae2cac449 100644
@@ -117,7 +117,7 @@ static void pr_perm_msg(int err)
 		return;
 
 	if (limit.rlim_cur < 1024)
-		snprintf(buf, sizeof(buf), "%lu bytes", limit.rlim_cur);
+		snprintf(buf, sizeof(buf), "%zu bytes", (size_t)limit.rlim_cur);
 	else if (limit.rlim_cur < 1024*1024)
 		snprintf(buf, sizeof(buf), "%.1f KiB", (double)limit.rlim_cur / 1024);
 	else
Signature · 1 line
2.24.1
maintainer Applied
#1 lore raw
Quoted 7 lines · Toke Høiland-Jørgensen

Naresh pointed out that libbpf builds fail on 32-bit architectures because rlimit.rlim_cur is defined as 'unsigned long long' on those architectures. Fix this by using %zu in printf and casting to size_t.

Fixes dc3a2d254782 ("libbpf: Print hint about ulimit when getting permission denied error")

Applied, thanks!