4.4.207-stable review
Subsystems (7)
Greg Kroah-Hartman
maintainercover 4.4.207-stable review
This is the start of the stable review cycle for the 4.4.207 release. There are 162 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat, 21 Dec 2019 18:24:44 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.207-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <[email protected]>
Linux 4.4.207-rc1
Aaro Koskinen <[email protected]>
net: stmmac: don't stop NAPI processing when dropping a packet
Aaro Koskinen <[email protected]>
net: stmmac: use correct DMA buffer size in the RX descriptor
Mathias Nyman <[email protected]>
xhci: fix USB3 device initiated resume race with roothub autosuspend
Alex Deucher <[email protected]>
drm/radeon: fix r1xx/r2xx register checker for POT textures
Hou Tao <[email protected]>
dm btree: increase rebalance threshold in __rebalance2()
Jiang Yi <[email protected]>
vfio/pci: call irq_bypass_unregister_producer() before freeing irq
Dmitry Osipenko <[email protected]>
ARM: tegra: Fix FLOW_CTLR_HALT register clobbering by tegra_resume()
Lihua Yao <[email protected]>
ARM: dts: s3c64xx: Fix init order of clock providers
Pavel Shilovsky <[email protected]>
CIFS: Respect O_SYNC and O_DIRECT flags during reconnect
Max Filippov <[email protected]>
xtensa: fix TLB sanity checker
Jian-Hong Pan <[email protected]>
PCI/MSI: Fix incorrect MSI-X masking on resume
Steffen Liebergeld <[email protected]>
PCI: Fix Intel ACS quirk UPDCR register address
Grygorii Strashko <[email protected]>
net: ethernet: ti: cpsw: fix extra rx interrupt
Guillaume Nault <[email protected]>
tcp: Protect accesses to .ts_recent_stamp with {READ,WRITE}_ONCE()
Guillaume Nault <[email protected]>
tcp: tighten acceptance of ACKs not matching a child socket
Guillaume Nault <[email protected]>
tcp: fix rejected syncookies due to stale timestamps
Eric Dumazet <[email protected]>
inet: protect against too small mtu values.
Taehee Yoo <[email protected]>
tipc: fix ordering of tipc module init and exit routine
Eric Dumazet <[email protected]>
tcp: md5: fix potential overestimation of TCP option space
Nikolay Aleksandrov <[email protected]>
net: bridge: deny dev_set_mac_address() when unregistering
Konstantin Khorenko <[email protected]>
kernel/module.c: wakeup processes in module_wq on module unload
Pavel Tikhomirov <[email protected]>
sunrpc: fix crash when cache_head become valid before update
Tejun Heo <[email protected]>
workqueue: Fix missing kfree(rescuer) in destroy_workqueue()
Ming Lei <[email protected]>
blk-mq: make sure that line break can be printed
Chen Jun <[email protected]>
mm/shmem.c: cast the type of unmap_start to u64
Vincenzo Frascino <[email protected]>
powerpc: Fix vDSO clock_getres()
Bart Van Assche <[email protected]>
scsi: qla2xxx: Always check the qla2x00_wait_for_hba_online() return value
Bart Van Assche <[email protected]>
scsi: qla2xxx: Fix qla24xx_process_bidir_cmd()
Himanshu Madhani <[email protected]>
scsi: qla2xxx: Fix DMA unmap leak
Krzysztof Kozlowski <[email protected]>
pinctrl: samsung: Fix device node refcount leaks in S3C64xx wakeup controller init
Jarkko Nikula <[email protected]>
ARM: dts: omap3-tao3530: Fix incorrect MMC card detection GPIO polarity
Shirish S <[email protected]>
x86/MCE/AMD: Turn off MC4_MISC thresholding on all family 0x15 models
YueHaibing <[email protected]>
e100: Fix passing zero to 'PTR_ERR' warning in e100_load_ucode_wait
James Smart <[email protected]>
scsi: lpfc: Cap NPIV vports to 256
Filipe Manana <[email protected]>
Btrfs: fix negative subv_writers counter and data space leak after buffered write
Nuno Sá <[email protected]>
iio: adis16480: Add debugfs_reg_access entry
Mathias Nyman <[email protected]>
xhci: make sure interrupts are restored to correct state
Mika Westerberg <[email protected]>
xhci: Fix memory leak in xhci_add_in_port()
Henry Lin <[email protected]>
usb: xhci: only set D3hot for pci device
Steffen Maier <[email protected]>
scsi: zfcp: trace channel log even for FCP command responses
Dmitry Monakhov <[email protected]>
quota: fix livelock in dquot_writeback_dquots
Dmitry Monakhov <[email protected]>
quota: Check that quota is not dirty before release
Ville Syrjälä <[email protected]>
video/hdmi: Fix AVI bar unpack
Alastair D'Silva <[email protected]>
powerpc: Allow 64bit VDSO __kernel_sync_dicache to work across ranges >4GB
Krzysztof Kozlowski <[email protected]>
pinctrl: samsung: Fix device node refcount leaks in init code
Krzysztof Kozlowski <[email protected]>
pinctrl: samsung: Fix device node refcount leaks in S3C24xx wakeup controller init
Rafael J. Wysocki <[email protected]>
ACPI: PM: Avoid attaching ACPI PM domain to certain devices
Vamshi K Sthambamkadi <[email protected]>
ACPI: bus: Fix NULL pointer check in acpi_bus_get_private_data()
Francesco Ruggeri <[email protected]>
ACPI: OSL: only free map once in osl.c
Zhenzhong Duan <[email protected]>
cpuidle: Do not unset the driver if it is there already
Johan Hovold <[email protected]>
media: radio: wl1273: fix interrupt masking on release
Johan Hovold <[email protected]>
media: bdisp: fix memleak on release
Denis Efremov <[email protected]>
ar5523: check NULL before memcpy() in ar5523_cmd()
Aleksa Sarai <[email protected]>
cgroup: pids: use atomic64_t for pids->limit
Ming Lei <[email protected]>
blk-mq: avoid sysfs buffer overflow with too many CPU cores
Pawel Harlozinski <[email protected]>
ASoC: Jack: Fix NULL pointer dereference in snd_soc_jack_report
Tejun Heo <[email protected]>
workqueue: Fix pwq ref leak in rescuer_thread()
Tejun Heo <[email protected]>
workqueue: Fix spurious sanity check failures in destroy_workqueue()
Greg Kroah-Hartman <[email protected]>
lib: raid6: fix awk build warnings
Larry Finger <[email protected]>
rtlwifi: rtl8192de: Fix missing enable interrupt flag
Larry Finger <[email protected]>
rtlwifi: rtl8192de: Fix missing callback that tests for hw release of buffer
Larry Finger <[email protected]>
rtlwifi: rtl8192de: Fix missing code to retrieve RX buffer address
Qu Wenruo <[email protected]>
btrfs: Remove btrfs_bio::flags member
Josef Bacik <[email protected]>
btrfs: check page->mapping when loading free space cache
David Hildenbrand <[email protected]>
virtio-balloon: fix managed page counts when migrating pages between zones
Miquel Raynal <[email protected]>
mtd: spear_smi: Fix Write Burst mode
Pete Zaitcev <[email protected]>
usb: mon: Fix a deadlock in usbmon between mmap and read
Emiliano Ingrassia <[email protected]>
usb: core: urb: fix URB structure initialization function
Johan Hovold <[email protected]>
USB: adutux: fix interface sanity check
Johan Hovold <[email protected]>
USB: serial: io_edgeport: fix epic endpoint lookup
Johan Hovold <[email protected]>
USB: idmouse: fix interface sanity checks
Johan Hovold <[email protected]>
USB: atm: ueagle-atm: add missing endpoint check
Chris Lesiak <[email protected]>
iio: humidity: hdc100x: fix IIO_HUMIDITYRELATIVE channel reporting
Kai-Heng Feng <[email protected]>
xhci: Increase STS_HALT timeout in xhci_suspend()
Johan Hovold <[email protected]>
staging: gigaset: add endpoint-type sanity check
Johan Hovold <[email protected]>
staging: gigaset: fix illegal free on probe errors
Johan Hovold <[email protected]>
staging: gigaset: fix general protection fault on probe
Johan Hovold <[email protected]>
staging: rtl8712: fix interface sanity check
Johan Hovold <[email protected]>
staging: rtl8188eu: fix interface sanity check
Kai-Heng Feng <[email protected]>
usb: Allow USB device to be warm reset in suspended state
Wei Yongjun <[email protected]>
usb: gadget: configfs: Fix missing spin_lock_init()
John Ogness <[email protected]>
fs/proc/array.c: allow reporting eip/esp for all coredumping threads
Alexey Dobriyan <[email protected]>
proc: fix coredump vs read /proc/*/stat race
John Ogness <[email protected]>
fs/proc: Report eip/esp in /prod/PID/stat for coredumping
Andy Lutomirski <[email protected]>
fs/proc: Stop reporting eip and esp in /proc/PID/stat
Heiko Carstens <[email protected]>
sched/core, x86: Make struct thread_info arch specific again
Andy Lutomirski <[email protected]>
sched/core: Add try_get_task_stack() and put_task_stack()
Andy Lutomirski <[email protected]>
sched/core: Allow putting thread_info into task_struct
Takashi Iwai <[email protected]>
ALSA: hda - Fix pending unsol events at shutdown
YueHaibing <[email protected]>
appletalk: Set error code if register_snap_client failed
YueHaibing <[email protected]>
appletalk: Fix potential NULL pointer dereference in unregister_snap_client
Paolo Bonzini <[email protected]>
KVM: x86: fix out-of-bounds write in KVM_GET_EMULATED_CPUID (CVE-2019-19332)
Wei Wang <[email protected]>
thermal: Fix deadlock in thermal thermal_zone_device_check
Viresh Kumar <[email protected]>
RDMA/qib: Validate ->show()/store() callbacks before calling them
Gregory CLEMENT <[email protected]>
spi: atmel: Fix CS high support
Navid Emamdoost <[email protected]>
crypto: user - fix memory leak in crypto_report
Christian Lamparter <[email protected]>
crypto: crypto4xx - fix double-free in crypto4xx_destroy_sdr
Paolo Bonzini <[email protected]>
KVM: x86: fix presentation of TSX feature in ARCH_CAPABILITIES
Paolo Bonzini <[email protected]>
KVM: x86: do not modify masked bits of shared MSRs
Dan Carpenter <[email protected]>
drm/i810: Prevent underflow in ioctl
Jan Kara <[email protected]>
jbd2: Fix possible overflow in jbd2_log_space_left()
Jouni Hogander <[email protected]>
can: slcan: Fix use-after-free Read in slcan_open
Dmitry Torokhov <[email protected]>
tty: vt: keyboard: reject invalid keycodes
Pavel Shilovsky <[email protected]>
CIFS: Fix SMB2 oplock break processing
Pavel Shilovsky <[email protected]>
CIFS: Fix NULL-pointer dereference in smb2_push_mandatory_locks
Hans de Goede <[email protected]>
Input: goodix - add upside-down quirk for Teclast X89 tablet
Takashi Iwai <[email protected]>
ALSA: pcm: oss: Avoid potential buffer overflows
Miklos Szeredi <[email protected]>
fuse: verify attributes
Miklos Szeredi <[email protected]>
fuse: verify nlink
Xuewei Zhang <[email protected]>
sched/fair: Scale bandwidth quota and period without losing quota/period ratio precision
Rob Herring <[email protected]>
ARM: dts: sunxi: Fix PMU compatible strings
Qian Cai <[email protected]>
mlx4: Use snprintf instead of complicated strcpy
zhengbin <[email protected]>
nfsd: Return EPERM, not EACCES, in some SETATTR cases
Aaro Koskinen <[email protected]>
MIPS: OCTEON: cvmx_pko_mem_debug8: use oldest forward compatible definition
Joel Stanley <[email protected]>
powerpc/math-emu: Update macros from GCC
David Teigland <[email protected]>
dlm: fix invalid cluster name warning
Daniel Mack <[email protected]>
ARM: dts: pxa: clean up USB controller nodes
Masahiro Yamada <[email protected]>
kbuild: fix single target build for external module
Paul Walmsley <[email protected]>
modpost: skip ELF local symbols during section mismatch check
Yuchung Cheng <[email protected]>
tcp: fix off-by-one bug on aborting window-probing socket
Lubomir Rintel <[email protected]>
ARM: dts: mmp2: fix the gpio interrupt cell number
Martin Schiller <[email protected]>
net/x25: fix null_x25_address handling
Martin Schiller <[email protected]>
net/x25: fix called/calling length calculation in x25_parse_address_block
Aaro Koskinen <[email protected]>
ARM: OMAP1/2: fix SoC name printing
Scott Mayhew <[email protected]>
nfsd: fix a warning in __cld_pipe_upcall()
Wen Yang <[email protected]>
dlm: NULL check before kmem_cache_destroy is not needed
Lucas Stach <[email protected]>
i2c: imx: don't print error message on probe defer
Stefan Agner <[email protected]>
serial: imx: fix error handling in console_setup
Colin Ian King <[email protected]>
altera-stapl: check for a null key before strcasecmp'ing it
Niklas Söderlund <[email protected]>
dma-mapping: fix return type of dma_set_max_seg_size()
Alexey Dobriyan <[email protected]>
ACPI: fix acpi_find_child_device() invocation in acpi_preset_companion()
Vinod Koul <[email protected]>
dmaengine: coh901318: Remove unused variable
Jia-Ju Bai <[email protected]>
dmaengine: coh901318: Fix a double-lock bug
Marek Szyprowski <[email protected]>
ARM: dts: exynos: Use Samsung SoC specific compatible for DWC2 module
Baruch Siach <[email protected]>
rtc: dt-binding: abx80x: fix resistance scale
Christophe JAILLET <[email protected]>
rtc: max8997: Fix the returned value in case of error in 'max8997_rtc_read_alarm()'
Vincent Chen <[email protected]>
math-emu/soft-fp.h: (_FP_ROUND_ZERO) cast 0 to void to fix warning
Aaro Koskinen <[email protected]>
MIPS: OCTEON: octeon-platform: fix typing
Mark Brown <[email protected]>
regulator: Fix return value of _set_load() stub
Shreeya Patel <[email protected]>
Staging: iio: adt7316: Fix i2c data reading, set the data field
Brian Masney <[email protected]>
pinctrl: qcom: ssbi-gpio: fix gpio-hog related boot issues
Steffen Maier <[email protected]>
scsi: zfcp: drop default switch case which might paper over missing case
Maciej W. Rozycki <[email protected]>
MIPS: SiByte: Enable ZONE_DMA32 for LittleSur
David Teigland <[email protected]>
dlm: fix missing idr_destroy for recover_idr
Heiko Stuebner <[email protected]>
clk: rockchip: fix rk3188 sclk_mac_lbtest parameter ordering
Finley Xiao <[email protected]>
clk: rockchip: fix rk3188 sclk_smc gate data
Marek Szyprowski <[email protected]>
extcon: max8997: Fix lack of path setting in USB device mode
Vincent Whitchurch <[email protected]>
ARM: 8813/1: Make aligned 2-byte getuser()/putuser() atomic on ARMv6+
Andrei Otcheretianski <[email protected]>
iwlwifi: mvm: Send non offchannel traffic via AP sta
Douglas Anderson <[email protected]>
serial: core: Allow processing sysrq at port unlock time
Chuhong Yuan <[email protected]>
net: ep93xx_eth: fix mismatch of request_mem_region in remove
Chuhong Yuan <[email protected]>
rsxx: add missed destroy_workqueue calls in remove
paulhsia <[email protected]>
ALSA: pcm: Fix stream lock usage in snd_pcm_period_elapsed()
Pan Bian <[email protected]>
Input: cyttsp4_core - fix use after free bug
Stephan Gerhold <[email protected]>
NFC: nxp-nci: Fix NULL pointer dereference after I2C communication error
Al Viro <[email protected]>
autofs: fix a leak in autofs_expire_indirect()
Chuhong Yuan <[email protected]>
serial: ifx6x60: add missed pm_runtime_disable
Jiangfeng Xiao <[email protected]>
serial: serial_core: Perform NULL checks for break_ctl ops
Kai-Heng Feng <[email protected]>
x86/PCI: Avoid AMD FCH XHCI USB PME# from D0 defect
Jeffrey Hugo <[email protected]>
tty: serial: msm_serial: Fix flow control
Michał Mirosław <[email protected]>
usb: gadget: u_serial: add missing port entry locking
Jan Beulich <[email protected]>
x86/apic/32: Avoid bogus LDR warnings
-------------
Diffstat:
.../devicetree/bindings/rtc/abracon,abx80x.txt | 2 +- Makefile | 15 ++-- arch/arm/boot/dts/exynos3250.dtsi | 2 +- arch/arm/boot/dts/mmp2.dtsi | 2 +- arch/arm/boot/dts/omap3-tao3530.dtsi | 2 +- arch/arm/boot/dts/pxa27x.dtsi | 2 +- arch/arm/boot/dts/pxa2xx.dtsi | 7 -- arch/arm/boot/dts/pxa3xx.dtsi | 2 +- arch/arm/boot/dts/s3c6410-mini6410.dts | 4 + arch/arm/boot/dts/s3c6410-smdk6410.dts | 4 + arch/arm/boot/dts/sun6i-a31.dtsi | 2 +- arch/arm/boot/dts/sun7i-a20.dtsi | 2 +- arch/arm/include/asm/uaccess.h | 18 +++++ arch/arm/lib/getuser.S | 11 +++ arch/arm/lib/putuser.S | 20 ++--- arch/arm/mach-omap1/id.c | 6 +- arch/arm/mach-omap2/id.c | 4 +- arch/arm/mach-tegra/reset-handler.S | 6 +- arch/mips/Kconfig | 1 + arch/mips/cavium-octeon/executive/cvmx-cmd-queue.c | 2 +- arch/mips/cavium-octeon/octeon-platform.c | 2 +- arch/mips/include/asm/octeon/cvmx-pko.h | 2 +- arch/powerpc/include/asm/sfp-machine.h | 92 +++++++--------------- arch/powerpc/include/asm/vdso_datapage.h | 2 + arch/powerpc/kernel/asm-offsets.c | 2 +- arch/powerpc/kernel/time.c | 1 + arch/powerpc/kernel/vdso32/gettimeofday.S | 7 +- arch/powerpc/kernel/vdso64/cacheflush.S | 4 +- arch/powerpc/kernel/vdso64/gettimeofday.S | 7 +- arch/x86/kernel/apic/apic.c | 25 +++--- arch/x86/kernel/cpu/mcheck/mce.c | 5 +- arch/x86/kvm/cpuid.c | 5 +- arch/x86/kvm/x86.c | 14 +++- arch/x86/pci/fixup.c | 11 +++ arch/xtensa/mm/tlb.c | 4 +- block/blk-mq-sysfs.c | 15 ++-- crypto/crypto_user.c | 4 +- drivers/acpi/bus.c | 2 +- drivers/acpi/device_pm.c | 12 ++- drivers/acpi/osl.c | 28 ++++--- drivers/block/rsxx/core.c | 2 + drivers/clk/rockchip/clk-rk3188.c | 8 +- drivers/cpuidle/driver.c | 15 ++-- drivers/crypto/amcc/crypto4xx_core.c | 6 +- drivers/dma/coh901318.c | 5 -- drivers/extcon/extcon-max8997.c | 10 +-- drivers/gpu/drm/i810/i810_dma.c | 4 +- drivers/gpu/drm/radeon/r100.c | 4 +- drivers/gpu/drm/radeon/r200.c | 4 +- drivers/i2c/busses/i2c-imx.c | 3 +- drivers/iio/humidity/hdc100x.c | 2 +- drivers/iio/imu/adis16480.c | 1 + drivers/infiniband/hw/mlx4/sysfs.c | 12 +-- drivers/infiniband/hw/qib/qib_sysfs.c | 6 ++ drivers/input/touchscreen/cyttsp4_core.c | 7 -- drivers/input/touchscreen/goodix.c | 9 +++ drivers/isdn/gigaset/usb-gigaset.c | 23 ++++-- drivers/md/persistent-data/dm-btree-remove.c | 8 +- drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 3 +- drivers/media/radio/radio-wl1273.c | 3 +- drivers/misc/altera-stapl/altera.c | 3 +- drivers/mtd/devices/spear_smi.c | 38 ++++++++- drivers/net/can/slcan.c | 1 + drivers/net/ethernet/cirrus/ep93xx_eth.c | 5 +- drivers/net/ethernet/intel/e100.c | 4 +- drivers/net/ethernet/stmicro/stmmac/common.h | 2 +- drivers/net/ethernet/stmicro/stmmac/descs_com.h | 14 +++- drivers/net/ethernet/stmicro/stmmac/enh_desc.c | 10 ++- drivers/net/ethernet/stmicro/stmmac/norm_desc.c | 10 ++- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 16 ++-- drivers/net/ethernet/ti/cpsw.c | 2 +- drivers/net/wireless/ath/ar5523/ar5523.c | 3 +- drivers/net/wireless/iwlwifi/mvm/mac80211.c | 15 ++++ .../net/wireless/realtek/rtlwifi/rtl8192de/hw.c | 9 ++- .../net/wireless/realtek/rtlwifi/rtl8192de/sw.c | 1 + .../net/wireless/realtek/rtlwifi/rtl8192de/trx.c | 25 +++++- .../net/wireless/realtek/rtlwifi/rtl8192de/trx.h | 2 + drivers/nfc/nxp-nci/i2c.c | 6 +- drivers/pci/msi.c | 2 +- drivers/pci/quirks.c | 2 +- drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c | 23 ++++-- drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 6 +- drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 3 + drivers/pinctrl/samsung/pinctrl-samsung.c | 10 ++- drivers/rtc/rtc-max8997.c | 2 +- drivers/s390/scsi/zfcp_dbf.c | 8 +- drivers/s390/scsi/zfcp_erp.c | 3 - drivers/scsi/lpfc/lpfc.h | 3 +- drivers/scsi/lpfc/lpfc_attr.c | 12 ++- drivers/scsi/lpfc/lpfc_init.c | 3 + drivers/scsi/qla2xxx/qla_attr.c | 3 +- drivers/scsi/qla2xxx/qla_bsg.c | 15 ++-- drivers/scsi/qla2xxx/qla_target.c | 7 +- drivers/spi/spi-atmel.c | 6 +- drivers/staging/iio/addac/adt7316-i2c.c | 2 + drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +- drivers/staging/rtl8712/usb_intf.c | 2 +- drivers/thermal/thermal_core.c | 4 +- drivers/tty/serial/ifx6x60.c | 3 + drivers/tty/serial/imx.c | 2 +- drivers/tty/serial/msm_serial.c | 6 +- drivers/tty/serial/serial_core.c | 2 +- drivers/tty/vt/keyboard.c | 2 +- drivers/usb/atm/ueagle-atm.c | 18 +++-- drivers/usb/core/hub.c | 5 +- drivers/usb/core/urb.c | 1 + drivers/usb/gadget/configfs.c | 1 + drivers/usb/gadget/function/u_serial.c | 2 + drivers/usb/host/xhci-hub.c | 16 +++- drivers/usb/host/xhci-mem.c | 4 + drivers/usb/host/xhci-pci.c | 13 +++ drivers/usb/host/xhci-ring.c | 6 +- drivers/usb/host/xhci.c | 7 +- drivers/usb/host/xhci.h | 2 + drivers/usb/misc/adutux.c | 2 +- drivers/usb/misc/idmouse.c | 2 +- drivers/usb/mon/mon_bin.c | 32 +++++--- drivers/usb/serial/io_edgeport.c | 10 ++- drivers/vfio/pci/vfio_pci_intrs.c | 2 +- drivers/video/hdmi.c | 8 +- drivers/virtio/virtio_balloon.c | 11 +++ fs/autofs4/expire.c | 5 +- fs/btrfs/file.c | 2 +- fs/btrfs/free-space-cache.c | 6 ++ fs/btrfs/volumes.h | 1 - fs/cifs/file.c | 14 +++- fs/cifs/smb2misc.c | 7 +- fs/dlm/lockspace.c | 1 + fs/dlm/memory.c | 9 +-- fs/dlm/user.c | 3 +- fs/fuse/dir.c | 27 +++++-- fs/fuse/fuse_i.h | 2 + fs/nfsd/nfs4recover.c | 17 ++-- fs/nfsd/vfs.c | 17 +++- fs/ocfs2/quota_global.c | 2 +- fs/proc/array.c | 18 ++++- fs/quota/dquot.c | 11 +-- include/linux/acpi.h | 2 +- include/linux/atalk.h | 2 +- include/linux/dma-mapping.h | 3 +- include/linux/init_task.h | 9 +++ include/linux/jbd2.h | 4 +- include/linux/netdevice.h | 5 ++ include/linux/quotaops.h | 10 +++ include/linux/regulator/consumer.h | 2 +- include/linux/sched.h | 52 +++++++++++- include/linux/serial_core.h | 37 ++++++++- include/linux/thread_info.h | 4 + include/linux/time.h | 12 +++ include/math-emu/soft-fp.h | 2 +- include/net/ip.h | 5 ++ include/net/tcp.h | 18 +++-- init/Kconfig | 10 +++ init/init_task.c | 7 +- kernel/cgroup_pids.c | 11 +-- kernel/module.c | 2 + kernel/sched/fair.c | 36 +++++---- kernel/sched/sched.h | 4 + kernel/workqueue.c | 38 +++++++-- lib/raid6/unroll.awk | 2 +- mm/shmem.c | 2 +- net/appletalk/aarp.c | 15 +++- net/appletalk/ddp.c | 21 +++-- net/bridge/br_device.c | 6 ++ net/core/dev.c | 3 +- net/ipv4/devinet.c | 5 -- net/ipv4/ip_output.c | 14 ++-- net/ipv4/tcp_output.c | 5 +- net/ipv4/tcp_timer.c | 2 +- net/sunrpc/cache.c | 6 -- net/tipc/core.c | 29 +++---- net/x25/af_x25.c | 18 +++-- scripts/mod/modpost.c | 12 +++ sound/core/oss/linear.c | 2 + sound/core/oss/mulaw.c | 2 + sound/core/oss/route.c | 2 + sound/core/pcm_lib.c | 8 +- sound/pci/hda/hda_bind.c | 4 + sound/pci/hda/hda_intel.c | 3 + sound/soc/soc-jack.c | 3 +- 180 files changed, 1022 insertions(+), 493 deletions(-)
Greg Kroah-Hartman
maintainerPATCH 1/162 x86/apic/32: Avoid bogus LDR warnings
From: Jan Beulich <[email protected]>
commit fe6f85ca121e9c74e7490fe66b0c5aae38e332c3 upstream.
The removal of the LDR initialization in the bigsmp_32 APIC code unearthed a problem in setup_local_APIC().
The code checks unconditionally for a mismatch of the logical APIC id by comparing the early APIC id which was initialized in get_smp_config() with the actual LDR value in the APIC.
Due to the removal of the bogus LDR initialization the check now can trigger on bigsmp_32 APIC systems emitting a warning for every booting CPU. This is of course a false positive because the APIC is not using logical destination mode.
Restrict the check and the possibly resulting fixup to systems which are actually using the APIC in logical destination mode.
[ tglx: Massaged changelog and added Cc stable ]
--- arch/x86/kernel/apic/apic.c | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-)
arch/x86/kernel/apic/apic.c +15 -10
@@ -1298,16 +1298,21 @@ void setup_local_APIC(void) apic->init_apic_ldr ();#ifdef CONFIG_X86_32 -/* -* APIC LDR is initialized. If logical_apicid mapping was -* initialized during get_smp_config(), make sure it matches the -* actual value. -*/ - i =early_per_cpu (x86_cpu_to_logical_apicid, cpu); -WARN_ON (i !=BAD_APICID && i !=logical_smp_processor_id ()); -/* always use the value from LDR */ -early_per_cpu (x86_cpu_to_logical_apicid, cpu) = -logical_smp_processor_id (); +if (apic->dest_logical) { +int logical_apicid, ldr_apicid; + +/* +* APIC LDR is initialized. If logical_apicid mapping was +* initialized during get_smp_config(), make sure it matches +* the actual value. +*/ + logical_apicid =early_per_cpu (x86_cpu_to_logical_apicid, cpu); + ldr_apicid =GET_APIC_LOGICAL_ID (apic_read (APIC_LDR )); +if (logical_apicid !=BAD_APICID ) +WARN_ON (logical_apicid != ldr_apicid); +/* Always use the value from LDR. */ +early_per_cpu (x86_cpu_to_logical_apicid, cpu) = ldr_apicid; + }#endif /*
Greg Kroah-Hartman
maintainerPATCH 2/162 usb: gadget: u_serial: add missing port entry locking
In reply to Greg Kroah-HartmanFrom: Michał Mirosław <[email protected]>
commit daf82bd24e308c5a83758047aff1bd81edda4f11 upstream.
gserial_alloc_line() misses locking (for a release barrier) while resetting port entry on TTY allocation failure. Fix this.
--- drivers/usb/gadget/function/u_serial.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/usb/gadget/function/u_serial.c +2 -0
@@ -1137,8 +1137,10 @@ int gserial_alloc_line(unsigned char *li __func__, port_num, PTR_ERR(tty_dev)); ret =PTR_ERR (tty_dev); +mutex_lock (&ports[port_num].lock); port = ports[port_num].port; ports[port_num].port =NULL ; +mutex_unlock (&ports[port_num].lock);gserial_free_port (port); goto err; }
Greg Kroah-Hartman
maintainerPATCH 3/162 tty: serial: msm_serial: Fix flow control
In reply to Greg Kroah-HartmanFrom: Jeffrey Hugo <[email protected]>
commit b027ce258369cbfa88401a691c23dad01deb9f9b upstream.
hci_qca interfaces to the wcn3990 via a uart_dm on the msm8998 mtp and Lenovo Miix 630 laptop. As part of initializing the wcn3990, hci_qca disables flow, configures the uart baudrate, and then reenables flow - at which point an event is expected to be received over the uart from the wcn3990. It is observed that this event comes after the baudrate change but before hci_qca re-enables flow. This is unexpected, and is a result of msm_reset() being broken.
According to the uart_dm hardware documentation, it is recommended that automatic hardware flow control be enabled by setting RX_RDY_CTL. Auto hw flow control will manage RFR based on the configured watermark. When there is space to receive data, the hw will assert RFR. When the watermark is hit, the hw will de-assert RFR.
The hardware documentation indicates that RFR can me manually managed via CR when RX_RDY_CTL is not set. SET_RFR asserts RFR, and RESET_RFR de-asserts RFR.
msm_reset() is broken because after resetting the hardware, it unconditionally asserts RFR via SET_RFR. This enables flow regardless of the current configuration, and would undo a previous flow disable operation. It should instead de-assert RFR via RESET_RFR to block flow until the hardware is reconfigured. msm_serial should rely on the client to specify that flow should be enabled, either via mctrl() or the termios structure, and only assert RFR in response to those triggers.
--- drivers/tty/serial/msm_serial.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/tty/serial/msm_serial.c +5 -1
@@ -823,6 +823,7 @@ static unsigned int msm_get_mctrl(structstatic void msm_reset (struct uart_port *port) {struct msm_port *msm_port =UART_TO_MSM (port); +unsigned int mr;/* reset everything */ msm_write (port,UART_CR_CMD_RESET_RX ,UART_CR );
@@ -830,7 +831,10 @@ static void msm_reset(struct uart_port *msm_write (port,UART_CR_CMD_RESET_ERR ,UART_CR );msm_write (port,UART_CR_CMD_RESET_BREAK_INT ,UART_CR );msm_write (port,UART_CR_CMD_RESET_CTS ,UART_CR ); -msm_write (port,UART_CR_CMD_SET_RFR ,UART_CR ); +msm_write (port,UART_CR_CMD_RESET_RFR ,UART_CR ); + mr =msm_read (port,UART_MR1 ); + mr &= ~UART_MR1_RX_RDY_CTL ; +msm_write (port, mr,UART_MR1 );/* Disable DM modes */ if (msm_port->is_uartdm)
Greg Kroah-Hartman
maintainerPATCH 4/162 x86/PCI: Avoid AMD FCH XHCI USB PME# from D0 defect
In reply to Greg Kroah-HartmanFrom: Kai-Heng Feng <[email protected]>
commit 7e8ce0e2b036dbc6617184317983aea4f2c52099 upstream.
The AMD FCH USB XHCI Controller advertises support for generating PME# while in D0. When in D0, it does signal PME# for USB 3.0 connect events, but not for USB 2.0 or USB 1.1 connect events, which means the controller doesn't wake correctly for those events.
00:10.0 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] FCH USB XHCI Controller [1022:7914] (rev 20) (prog-if 30 [XHCI])
Subsystem: Dell FCH USB XHCI Controller [1028:087e]
Capabilities: [50] Power Management version 3
Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
Clear PCI_PM_CAP_PME_D0 in dev->pme_support to indicate the device will not assert PME# from D0 so we don't rely on it.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=203673
--- arch/x86/pci/fixup.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
arch/x86/pci/fixup.c +11 -0
@@ -542,6 +542,17 @@ static void twinhead_reserve_killing_zonDECLARE_PCI_FIXUP_HEADER (PCI_VENDOR_ID_INTEL ,0x27B9 , twinhead_reserve_killing_zone);/* +* Device [1022:7914] +* When in D0, PME# doesn't get asserted when plugging USB 2.0 device. +*/ +static void pci_fixup_amd_fch_xhci_pme (struct pci_dev *dev) +{ +dev_info (&dev->dev,"PME# does not work under D0, disabling it\n" ); + dev->pme_support &= ~(PCI_PM_CAP_PME_D0 >>PCI_PM_CAP_PME_SHIFT ); +} +DECLARE_PCI_FIXUP_FINAL (PCI_VENDOR_ID_AMD ,0x7914 , pci_fixup_amd_fch_xhci_pme); + +/* * Broadwell EP Home Agent BARs erroneously return non-zero values when read. * * See http://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v4-spec-update.html
Greg Kroah-Hartman
maintainerPATCH 5/162 serial: serial_core: Perform NULL checks for break_ctl ops
In reply to Greg Kroah-HartmanFrom: Jiangfeng Xiao <[email protected]>
commit 7d73170e1c282576419f8b50a771f1fcd2b81a94 upstream.
Doing fuzz test on sbsa uart device, causes a kernel crash due to NULL pointer dereference:
------------[ cut here ]------------ Unable to handle kernel paging request at virtual address fffffffffffffffc pgd = ffffffe331723000 [fffffffffffffffc] *pgd=0000002333595003, *pud=0000002333595003, *pmd=00000 Internal error: Oops: 96000005 [#1] PREEMPT SMP Modules linked in: ping(O) jffs2 rtos_snapshot(O) pramdisk(O) hisi_sfc(O)
Drv_Nandc_K(O) Drv_SysCtl_K(O) Drv_SysClk_K(O) bsp_reg(O) hns3(O) hns3_uio_enet(O) hclgevf(O) hclge(O) hnae3(O) mdio_factory(O) mdio_registry(O) mdio_dev(O) mdio(O) hns3_info(O) rtos_kbox_panic(O) uart_suspend(O) rsm(O) stp llc tunnel4 xt_tcpudp ipt_REJECT nf_reject_ipv4 iptable_filter ip_tables x_tables sd_mod xhci_plat_hcd xhci_pci xhci_hcd usbmon usbhid usb_storage ohci_platform ohci_pci ohci_hcd hid_generic hid ehci_platform ehci_pci ehci_hcd vfat fat usbcore usb_common scsi_mod yaffs2multi(O) ext4 jbd2 ext2 mbcache ofpart i2c_dev i2c_core uio ubi nand nand_ecc nand_ids cfi_cmdset_0002 cfi_cmdset_0001 cfi_probe gen_probe cmdlinepart chipreg mtdblock mtd_blkdevs mtd nfsd auth_rpcgss oid_registry nfsv3 nfs nfs_acl lockd sunrpc grace autofs4
CPU: 2 PID: 2385 Comm: tty_fuzz_test Tainted: G O 4.4.193 #1 task: ffffffe32b23f110 task.stack: ffffffe32bda4000 PC is at uart_break_ctl+0x44/0x84 LR is at uart_break_ctl+0x34/0x84 pc : [<ffffff8393196098>] lr : [<ffffff8393196088>] pstate: 80000005
sp : ffffffe32bda7cc0
x29: ffffffe32bda7cc0 x28: ffffffe32b23f110
x27: ffffff8393402000 x26: 0000000000000000
x25: ffffffe32b233f40 x24: ffffffc07a8ec680
x23: 0000000000005425 x22: 00000000ffffffff
x21: ffffffe33ed73c98 x20: 0000000000000000
x19: ffffffe33ed94168 x18: 0000000000000004
x17: 0000007f92ae9d30 x16: ffffff8392fa6064
x15: 0000000000000010 x14: 0000000000000000
x13: 0000000000000000 x12: 0000000000000000
x11: 0000000000000020 x10: 0000007ffdac1708
x9 : 0000000000000078 x8 : 000000000000001d
x7 : 0000000052a64887 x6 : ffffffe32bda7e08
x5 : ffffffe32b23c000 x4 : 0000005fbc5b0000
x3 : ffffff83938d5018 x2 : 0000000000000080
x1 : ffffffe32b23c040 x0 : ffffff83934428f8
virtual start addr offset is 38ac00000
module base offset is 2cd4cf1000
linear region base offset is : 0
Process tty_fuzz_test (pid: 2385, stack limit = 0xffffffe32bda4000)
Stack: (0xffffffe32bda7cc0 to 0xffffffe32bda8000)
7cc0: ffffffe32bda7cf0 ffffff8393177718 ffffffc07a8ec680 ffffff8393196054 7ce0: 000000001739f2e0 0000007ffdac1978 ffffffe32bda7d20 ffffff8393179a1c 7d00: 0000000000000000 ffffff8393c0a000 ffffffc07a8ec680 cb88537fdc8ba600 7d20: ffffffe32bda7df0 ffffff8392fa5a40 ffffff8393c0a000 0000000000005425 7d40: 0000007ffdac1978 ffffffe32b233f40 ffffff8393178dcc 0000000000000003 7d60: 000000000000011d 000000000000001d ffffffe32b23f110 000000000000029e 7d80: ffffffe34fe8d5d0 0000000000000000 ffffffe32bda7e14 cb88537fdc8ba600 7da0: ffffffe32bda7e30 ffffff8393042cfc ffffff8393c41720 ffffff8393c46410 7dc0: ffffff839304fa68 ffffffe32b233f40 0000000000005425 0000007ffdac1978 7de0: 000000000000011d cb88537fdc8ba600 ffffffe32bda7e70 ffffff8392fa60cc 7e00: 0000000000000000 ffffffe32b233f40 ffffffe32b233f40 0000000000000003 7e20: 0000000000005425 0000007ffdac1978 ffffffe32bda7e70 ffffff8392fa60b0 7e40: 0000000000000280 ffffffe32b233f40 ffffffe32b233f40 0000000000000003 7e60: 0000000000005425 cb88537fdc8ba600 0000000000000000 ffffff8392e02e78 7e80: 0000000000000280 0000005fbc5b0000 ffffffffffffffff 0000007f92ae9d3c 7ea0: 0000000060000000 0000000000000015 0000000000000003 0000000000005425 7ec0: 0000007ffdac1978 0000000000000000 00000000a54c910e 0000007f92b95014 7ee0: 0000007f92b95090 0000000052a64887 000000000000001d 0000000000000078 7f00: 0000007ffdac1708 0000000000000020 0000000000000000 0000000000000000 7f20: 0000000000000000 0000000000000010 000000556acf0090 0000007f92ae9d30 7f40: 0000000000000004 000000556acdef10 0000000000000000 000000556acdebd0 7f60: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 7f80: 0000000000000000 0000000000000000 0000000000000000 0000007ffdac1840 7fa0: 000000556acdedcc 0000007ffdac1840 0000007f92ae9d3c 0000000060000000 7fc0: 0000000000000000 0000000000000000 0000000000000003 000000000000001d 7fe0: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
Call trace: Exception stack(0xffffffe32bda7ab0 to 0xffffffe32bda7bf0)
7aa0: 0000000000001000 0000007fffffffff
7ac0: ffffffe32bda7cc0 ffffff8393196098 0000000080000005 0000000000000025 7ae0: ffffffe32b233f40 ffffff83930d777c ffffffe32bda7b30 ffffff83930d777c 7b00: ffffffe32bda7be0 ffffff83938d5000 ffffffe32bda7be0 ffffffe32bda7c20 7b20: ffffffe32bda7b60 ffffff83930d777c ffffffe32bda7c10 ffffff83938d5000 7b40: ffffffe32bda7c10 ffffffe32bda7c50 ffffff8393c0a000 ffffffe32b23f110 7b60: ffffffe32bda7b70 ffffff8392e09df4 ffffffe32bda7bb0 cb88537fdc8ba600 7b80: ffffff83934428f8 ffffffe32b23c040 0000000000000080 ffffff83938d5018 7ba0: 0000005fbc5b0000 ffffffe32b23c000 ffffffe32bda7e08 0000000052a64887 7bc0: 000000000000001d 0000000000000078 0000007ffdac1708 0000000000000020 7be0: 0000000000000000 0000000000000000
[<ffffff8393196098>] uart_break_ctl+0x44/0x84 [<ffffff8393177718>] send_break+0xa0/0x114 [<ffffff8393179a1c>] tty_ioctl+0xc50/0xe84 [<ffffff8392fa5a40>] do_vfs_ioctl+0xc4/0x6e8 [<ffffff8392fa60cc>] SyS_ioctl+0x68/0x9c [<ffffff8392e02e78>] __sys_trace_return+0x0/0x4 Code: b9410ea0 34000160 f9408aa0 f9402814 (b85fc280) ---[ end trace 8606094f1960c5e0 ]--- Kernel panic - not syncing: Fatal exception
Fix this problem by adding NULL checks prior to calling break_ctl ops.
--- drivers/tty/serial/serial_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/serial_core.c +1 -1
@@ -1015,7 +1015,7 @@ static int uart_break_ctl(struct tty_strmutex_lock (&port->mutex); -if (uport->type !=PORT_UNKNOWN ) +if (uport->type !=PORT_UNKNOWN && uport->ops->break_ctl) uport->ops->break_ctl (uport, break_state);mutex_unlock (&port->mutex);
Greg Kroah-Hartman
maintainerPATCH 6/162 serial: ifx6x60: add missed pm_runtime_disable
In reply to Greg Kroah-HartmanFrom: Chuhong Yuan <[email protected]>
commit 50b2b571c5f3df721fc81bf9a12c521dfbe019ba upstream.
The driver forgets to call pm_runtime_disable in remove. Add the missed calls to fix it.
--- drivers/tty/serial/ifx6x60.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/tty/serial/ifx6x60.c +3 -0
@@ -1241,6 +1241,9 @@ static int ifx_spi_spi_remove(struct spistruct ifx_spi_device *ifx_dev =spi_get_drvdata (spi);/* stop activity */ tasklet_kill (&ifx_dev->io_work_tasklet); + +pm_runtime_disable (&spi->dev); +/* free irq */ free_irq (gpio_to_irq (ifx_dev->gpio.reset_out), ifx_dev);free_irq (gpio_to_irq (ifx_dev->gpio.srdy), ifx_dev);
Greg Kroah-Hartman
maintainerPATCH 7/162 autofs: fix a leak in autofs_expire_indirect()
In reply to Greg Kroah-HartmanFrom: Al Viro <[email protected]>
[ Upstream commit 03ad0d703df75c43f78bd72e16124b5b94a95188 ]
if the second call of should_expire() in there ends up grabbing and returning a new reference to dentry, we need to drop it before continuing.
--- fs/autofs4/expire.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
fs/autofs4/expire.c +3 -2
@@ -467,9 +467,10 @@ struct dentry *autofs4_expire_indirect(struct super_block *sb,*/ flags &= ~AUTOFS_EXP_LEAVES ; found =should_expire (expired, mnt, timeout, how); -if (!found || found != expired) -/* Something has changed, continue */ +if (found != expired) {// something has changed, continue +dput (found); goto next; + }if (expired != dentry)dput (dentry);
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 8/162 NFC: nxp-nci: Fix NULL pointer dereference after I2C communication error
In reply to Greg Kroah-HartmanFrom: Stephan Gerhold <[email protected]>
[ Upstream commit a71a29f50de1ef97ab55c151a1598eb12dde379d ]
I2C communication errors (-EREMOTEIO) during the IRQ handler of nxp-nci result in a NULL pointer dereference at the moment:
BUG: kernel NULL pointer dereference, address: 0000000000000000
Oops: 0002 [#1] PREEMPT SMP NOPTI
CPU: 1 PID: 355 Comm: irq/137-nxp-nci Not tainted 5.4.0-rc6 #1
RIP: 0010:skb_queue_tail+0x25/0x50
Call Trace:
nci_recv_frame+0x36/0x90 [nci]
nxp_nci_i2c_irq_thread_fn+0xd1/0x285 [nxp_nci_i2c]
? preempt_count_add+0x68/0xa0
? irq_forced_thread_fn+0x80/0x80
irq_thread_fn+0x20/0x60
irq_thread+0xee/0x180
? wake_threads_waitq+0x30/0x30
kthread+0xfb/0x130
? irq_thread_check_affinity+0xd0/0xd0
? kthread_park+0x90/0x90
ret_from_fork+0x1f/0x40Afterward the kernel must be rebooted to work properly again.
This happens because it attempts to call nci_recv_frame() with skb == NULL. However, unlike nxp_nci_fw_recv_frame(), nci_recv_frame() does not have any NULL checks for skb, causing the NULL pointer dereference.
Change the code to call only nxp_nci_fw_recv_frame() in case of an error. Make sure to log it so it is obvious that a communication error occurred. The error above then becomes:
nxp-nci_i2c i2c-NXP1001:00: NFC: Read failed with error -121
nci: __nci_request: wait_for_completion_interruptible_timeout failed 0
nxp-nci_i2c i2c-NXP1001:00: NFC: Read failed with error -121--- drivers/nfc/nxp-nci/i2c.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/nfc/nxp-nci/i2c.c +4 -2
@@ -239,8 +239,10 @@ static irqreturn_t nxp_nci_i2c_irq_thread_fn(int irq, void *phy_id)if (r == -EREMOTEIO ) { phy->hard_fault = r; - skb =NULL ; - }else if (r <0 ) { +if (info->mode ==NXP_NCI_MODE_FW ) +nxp_nci_fw_recv_frame (phy->ndev,NULL ); + } +if (r <0 ) {nfc_err (&client->dev,"Read failed with error %d\n" , r); goto exit_irq_handled; }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 9/162 Input: cyttsp4_core - fix use after free bug
In reply to Greg Kroah-HartmanFrom: Pan Bian <[email protected]>
[ Upstream commit 79aae6acbef16f720a7949f8fc6ac69816c79d62 ]
The device md->input is used after it is released. Setting the device data to NULL is unnecessary as the device is never used again. Instead, md->input should be assigned NULL to avoid accessing the freed memory accidently. Besides, checking md->si against NULL is superfluous as it points to a variable address, which cannot be NULL.
--- drivers/input/touchscreen/cyttsp4_core.c | 7 ------- 1 file changed, 7 deletions(-)
drivers/input/touchscreen/cyttsp4_core.c +0 -7
@@ -1972,11 +1972,6 @@ static int cyttsp4_mt_probe(struct cyttsp4 *cd)/* get sysinfo */ md->si = &cd->sysinfo; -if (!md->si) { -dev_err (dev,"%s: Fail get sysinfo pointer from core p=%p\n" , - __func__, md->si); - goto error_get_sysinfo; - } rc =cyttsp4_setup_input_device (cd);if (rc)
@@ -1986,8 +1981,6 @@ static int cyttsp4_mt_probe(struct cyttsp4 *cd) error_init_input:input_free_device (md->input); -error_get_sysinfo: -input_set_drvdata (md->input,NULL ); error_alloc_failed:dev_err (dev,"%s failed.\n" , __func__);return rc;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 10/162 ALSA: pcm: Fix stream lock usage in snd_pcm_period_elapsed()
In reply to Greg Kroah-HartmanFrom: paulhsia <[email protected]>
[ Upstream commit f5cdc9d4003a2f66ea57b3edd3e04acc2b1a4439 ]
If the nullity check for substream->runtime is outside of the lock region, it is possible to have a null runtime in the critical section if snd_pcm_detach_substream is called right before the lock.
--- sound/core/pcm_lib.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
sound/core/pcm_lib.c +6 -2
@@ -1877,11 +1877,14 @@ void snd_pcm_period_elapsed(struct snd_pcm_substream *substream)struct snd_pcm_runtime *runtime;unsigned long flags; -if (PCM_RUNTIME_CHECK (substream)) +if (snd_BUG_ON (!substream))return ; - runtime = substream->runtime;snd_pcm_stream_lock_irqsave (substream, flags); +if (PCM_RUNTIME_CHECK (substream)) + goto _unlock; + runtime = substream->runtime; +if (!snd_pcm_running (substream) ||snd_pcm_update_hw_ptr0 (substream,1 ) <0 ) goto _end;
@@ -1892,6 +1895,7 @@ void snd_pcm_period_elapsed(struct snd_pcm_substream *substream)#endif _end:kill_fasync (&runtime->fasync,SIGIO ,POLL_IN ); + _unlock:snd_pcm_stream_unlock_irqrestore (substream, flags); }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 11/162 rsxx: add missed destroy_workqueue calls in remove
In reply to Greg Kroah-HartmanFrom: Chuhong Yuan <[email protected]>
[ Upstream commit dcb77e4b274b8f13ac6482dfb09160cd2fae9a40 ]
The driver misses calling destroy_workqueue in remove like what is done when probe fails.
Add the missed calls to fix it.
--- drivers/block/rsxx/core.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/block/rsxx/core.c +2 -0
@@ -1028,8 +1028,10 @@ static void rsxx_pci_remove(struct pci_dev *dev)cancel_work_sync (&card->event_work); +destroy_workqueue (card->event_wq);rsxx_destroy_dev (card);rsxx_dma_destroy (card); +destroy_workqueue (card->creg_ctrl.creg_wq);spin_lock_irqsave (&card->irq_lock, flags);rsxx_disable_ier_and_isr (card,CR_INTR_ALL );
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 12/162 net: ep93xx_eth: fix mismatch of request_mem_region in remove
In reply to Greg Kroah-HartmanFrom: Chuhong Yuan <[email protected]>
[ Upstream commit 3df70afe8d33f4977d0e0891bdcfb639320b5257 ]
The driver calls release_resource in remove to match request_mem_region in probe, which is incorrect.
Fix it by using the right one, release_mem_region.
--- drivers/net/ethernet/cirrus/ep93xx_eth.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/ethernet/cirrus/ep93xx_eth.c +3 -2
@@ -776,6 +776,7 @@ static int ep93xx_eth_remove(struct platform_device *pdev) {struct net_device *dev;struct ep93xx_priv *ep; +struct resource *mem; dev =platform_get_drvdata (pdev);if (dev ==NULL )
@@ -791,8 +792,8 @@ static int ep93xx_eth_remove(struct platform_device *pdev)iounmap (ep->base_addr);if (ep->res !=NULL ) { -release_resource (ep->res); -kfree (ep->res); + mem =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); +release_mem_region (mem->start,resource_size (mem)); }free_netdev (dev);
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 13/162 serial: core: Allow processing sysrq at port unlock time
In reply to Greg Kroah-HartmanFrom: Douglas Anderson <[email protected]>
[ Upstream commit d6e1935819db0c91ce4a5af82466f3ab50d17346 ]
Right now serial drivers process sysrq keys deep in their character receiving code. This means that they've already grabbed their port->lock spinlock. This can end up getting in the way if we've go to do serial stuff (especially kgdb) in response to the sysrq.
Serial drivers have various hacks in them to handle this. Looking at '8250_port.c' you can see that the console_write() skips locking if we're in the sysrq handler. Looking at 'msm_serial.c' you can see that the port lock is dropped around uart_handle_sysrq_char().
It turns out that these hacks aren't exactly perfect. If you have lockdep turned on and use something like the 8250_port hack you'll get a splat that looks like:
WARNING: possible circular locking dependency detected [...] is trying to acquire lock:
... (console_owner){-.-.}, at: console_unlock+0x2e0/0x5e4
but task is already holding lock:
... (&port_lock_key){-.-.}, at: serial8250_handle_irq+0x30/0xe4
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&port_lock_key){-.-.}:
_raw_spin_lock_irqsave+0x58/0x70
serial8250_console_write+0xa8/0x250
univ8250_console_write+0x40/0x4c
console_unlock+0x528/0x5e4
register_console+0x2c4/0x3b0
uart_add_one_port+0x350/0x478
serial8250_register_8250_port+0x350/0x3a8
dw8250_probe+0x67c/0x754
platform_drv_probe+0x58/0xa4
really_probe+0x150/0x294
driver_probe_device+0xac/0xe8
__driver_attach+0x98/0xd0
bus_for_each_dev+0x84/0xc8
driver_attach+0x2c/0x34
bus_add_driver+0xf0/0x1ec
driver_register+0xb4/0x100
__platform_driver_register+0x60/0x6c
dw8250_platform_driver_init+0x20/0x28
...-> #0 (console_owner){-.-.}:
lock_acquire+0x1e8/0x214
console_unlock+0x35c/0x5e4
vprintk_emit+0x230/0x274
vprintk_default+0x7c/0x84
vprintk_func+0x190/0x1bc
printk+0x80/0xa0
__handle_sysrq+0x104/0x21c
handle_sysrq+0x30/0x3c
serial8250_read_char+0x15c/0x18c
serial8250_rx_chars+0x34/0x74
serial8250_handle_irq+0x9c/0xe4
dw8250_handle_irq+0x98/0xcc
serial8250_interrupt+0x50/0xe8
...other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&port_lock_key);
lock(console_owner);
lock(&port_lock_key);
lock(console_owner);*** DEADLOCK ***
The hack used in 'msm_serial.c' doesn't cause the above splats but it seems a bit ugly to unlock / lock our spinlock deep in our irq handler.
It seems like we could defer processing the sysrq until the end of the interrupt handler right after we've unlocked the port. With this scheme if a whole batch of sysrq characters comes in one irq then we won't handle them all, but that seems like it should be a fine compromise.
--- include/linux/serial_core.h | 37 ++++++++++++++++++++++++++++++++++++- 1 file changed, 36 insertions(+), 1 deletion(-)
include/linux/serial_core.h +36 -1
@@ -159,6 +159,7 @@ struct uart_port {struct console *cons;/* struct console, if any */ #if defined(CONFIG_SERIAL_CORE_CONSOLE ) || defined(SUPPORT_SYSRQ )unsigned long sysrq;/* sysrq timeout */ +unsigned int sysrq_ch;/* char for sysrq */ #endif /* flags must be updated while holding port mutex */
@@ -440,8 +441,42 @@ uart_handle_sysrq_char(struct uart_port *port, unsigned int ch) }return 0 ; } +static inline int +uart_prepare_sysrq_char (struct uart_port *port,unsigned int ch) +{ +if (port->sysrq) { +if (ch &&time_before (jiffies, port->sysrq)) { + port->sysrq_ch = ch; + port->sysrq =0 ; +return 1 ; + } + port->sysrq =0 ; + } +return 0 ; +} +static inline void +uart_unlock_and_check_sysrq (struct uart_port *port,unsigned long irqflags) +{ +int sysrq_ch; + + sysrq_ch = port->sysrq_ch; + port->sysrq_ch =0 ; + +spin_unlock_irqrestore (&port->lock, irqflags); + +if (sysrq_ch) +handle_sysrq (sysrq_ch); +}#else -#define uart_handle_sysrq_char (port,ch) ({ (void)port; 0; }) +static inline int +uart_handle_sysrq_char (struct uart_port *port,unsigned int ch) {return 0 ; } +static inline int +uart_prepare_sysrq_char (struct uart_port *port,unsigned int ch) {return 0 ; } +static inline void +uart_unlock_and_check_sysrq (struct uart_port *port,unsigned long irqflags) +{ +spin_unlock_irqrestore (&port->lock, irqflags); +}#endif /*
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 14/162 iwlwifi: mvm: Send non offchannel traffic via AP sta
In reply to Greg Kroah-HartmanFrom: Andrei Otcheretianski <[email protected]>
[ Upstream commit dc1aca22f8f38b7e2ad7b118db87404d11e68771 ]
TDLS discovery response frame is a unicast direct frame to the peer. Since we don't have a STA for this peer, this frame goes through iwl_tx_skb_non_sta(). As the result aux_sta and some completely arbitrary queue would be selected for this frame, resulting in a queue hang. Fix that by sending such frames through AP sta instead.
--- drivers/net/wireless/iwlwifi/mvm/mac80211.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
drivers/net/wireless/iwlwifi/mvm/mac80211.c +15 -0
@@ -741,6 +741,21 @@ static void iwl_mvm_mac_tx(struct ieee80211_hw *hw, !ieee80211_is_action(hdr->frame_control))) sta =NULL ; +/* If there is no sta, and it's not offchannel - send through AP */ +if (info->control.vif->type ==NL80211_IFTYPE_STATION && + info->hw_queue !=IWL_MVM_OFFCHANNEL_QUEUE && !sta) { +struct iwl_mvm_vif *mvmvif = +iwl_mvm_vif_from_mac80211 (info->control.vif); +u8 ap_sta_id =READ_ONCE (mvmvif->ap_sta_id); + +if (ap_sta_id <IWL_MVM_STATION_COUNT ) { +/* mac80211 holds rcu read lock */ + sta =rcu_dereference (mvm->fw_id_to_mac_id[ap_sta_id]); +if (IS_ERR_OR_NULL (sta)) + goto drop; + } + } +if (sta) {if (iwl_mvm_defer_tx (mvm, sta, skb))return ;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 15/162 ARM: 8813/1: Make aligned 2-byte getuser()/putuser() atomic on ARMv6+
In reply to Greg Kroah-HartmanFrom: Vincent Whitchurch <[email protected]>
[ Upstream commit 344eb5539abf3e0b6ce22568c03e86450073e097 ]
getuser() and putuser() (and there underscored variants) use two strb[t]/ldrb[t] instructions when they are asked to get/put 16-bits. This means that the read/write is not atomic even when performed to a 16-bit-aligned address.
This leads to problems with vhost: vhost uses __getuser() to read the vring's 16-bit avail.index field, and if it happens to observe a partial update of the index, wrong descriptors will be used which will lead to a breakdown of the virtio communication. A similar problem exists for __putuser() which is used to write to the vring's used.index field.
The reason these functions use strb[t]/ldrb[t] is because strht/ldrht instructions did not exist until ARMv6T2/ARMv7. So we should be easily able to fix this on ARMv7. Also, since all ARMv6 processors also don't actually use the unprivileged instructions anymore for uaccess (since CONFIG_CPU_USE_DOMAINS is not used) we can easily fix them too.
--- arch/arm/include/asm/uaccess.h | 18 ++++++++++++++++++ arch/arm/lib/getuser.S | 11 +++++++++++ arch/arm/lib/putuser.S | 20 ++++++++++---------- 3 files changed, 39 insertions(+), 10 deletions(-)
arch/arm/include/asm/uaccess.h +18 -0
@@ -387,6 +387,13 @@ do { \#define __get_user_asm_byte (x, addr, err) \ __get_user_asm(x, addr, err, ldrb) +#if __LINUX_ARM_ARCH__ >=6 + +#define __get_user_asm_half (x, addr, err) \ + __get_user_asm(x, addr, err, ldrh) + +#else +#ifndef __ARMEB__#define __get_user_asm_half (x, __gu_addr, err) \ ({ \
@@ -405,6 +412,8 @@ do { \ })#endif +#endif /* __LINUX_ARM_ARCH__ >= 6 */ +#define __get_user_asm_word (x, addr, err) \ __get_user_asm(x, addr, err, ldr)#endif
@@ -480,6 +489,13 @@ do { \#define __put_user_asm_byte (x, __pu_addr, err) \ __put_user_asm(x, __pu_addr, err, strb) +#if __LINUX_ARM_ARCH__ >=6 + +#define __put_user_asm_half (x, __pu_addr, err) \ + __put_user_asm(x, __pu_addr, err, strh) + +#else +#ifndef __ARMEB__#define __put_user_asm_half (x, __pu_addr, err) \ ({ \
@@ -496,6 +512,8 @@ do { \ })#endif +#endif /* __LINUX_ARM_ARCH__ >= 6 */ +#define __put_user_asm_word (x, __pu_addr, err) \ __put_user_asm(x, __pu_addr, err, str)
arch/arm/lib/getuser.S +11 -0
@@ -42,6 +42,12 @@ _ASM_NOKPROBE(__get_user_1) ENTRY(__get_user_2) check_uaccess r0, 2, r1, r2, __get_user_bad +#if __LINUX_ARM_ARCH__ >= 6 + +2: TUSER(ldrh) r2, [r0] + +#else + #ifdef CONFIG_CPU_USE_DOMAINS rb .req ip 2: ldrbt r2, [r0], #1
@@ -56,6 +62,9 @@ rb .req r0 #else orr r2, rb, r2, lsl #8 #endif + +#endif /* __LINUX_ARM_ARCH__ >= 6 */ + mov r0, #0 ret lr ENDPROC(__get_user_2)
@@ -145,7 +154,9 @@ _ASM_NOKPROBE(__get_user_bad8) .pushsection __ex_table, "a" .long 1b, __get_user_bad .long 2b, __get_user_bad +#if __LINUX_ARM_ARCH__ < 6 .long 3b, __get_user_bad +#endif .long 4b, __get_user_bad .long 5b, __get_user_bad8 .long 6b, __get_user_bad8
arch/arm/lib/putuser.S +10 -10
@@ -41,16 +41,13 @@ ENDPROC(__put_user_1) ENTRY(__put_user_2) check_uaccess r0, 2, r1, ip, __put_user_bad - mov ip, r2, lsr #8 -#ifdef CONFIG_THUMB2_KERNEL -#ifndef __ARMEB__ -2: TUSER(strb) r2, [r0] -3: TUSER(strb) ip, [r0, #1] +#if __LINUX_ARM_ARCH__ >= 6 + +2: TUSER(strh) r2, [r0] + #else -2: TUSER(strb) ip, [r0] -3: TUSER(strb) r2, [r0, #1] -#endif -#else /* !CONFIG_THUMB2_KERNEL */ + + mov ip, r2, lsr #8 #ifndef __ARMEB__ 2: TUSER(strb) r2, [r0], #1 3: TUSER(strb) ip, [r0]
@@ -58,7 +55,8 @@ ENTRY(__put_user_2) 2: TUSER(strb) ip, [r0], #1 3: TUSER(strb) r2, [r0] #endif -#endif /* CONFIG_THUMB2_KERNEL */ + +#endif /* __LINUX_ARM_ARCH__ >= 6 */ mov r0, #0 ret lr ENDPROC(__put_user_2)
@@ -91,7 +89,9 @@ ENDPROC(__put_user_bad) .pushsection __ex_table, "a" .long 1b, __put_user_bad .long 2b, __put_user_bad +#if __LINUX_ARM_ARCH__ < 6 .long 3b, __put_user_bad +#endif .long 4b, __put_user_bad .long 5b, __put_user_bad .long 6b, __put_user_bad
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 16/162 extcon: max8997: Fix lack of path setting in USB device mode
In reply to Greg Kroah-HartmanFrom: Marek Szyprowski <[email protected]>
[ Upstream commit a2dc50914744eea9f83a70a5db0486be625e5dc0 ]
MAX8997 driver disables automatic path selection from MicroUSB connector and manually sets path to either UART or USB lines. However the code for setting USB path worked only for USB host mode (when ID pin is set to ground). When standard USB cable (USB device mode) is connected, path registers are not touched. This means that once the non-USB accessory is connected to MAX8997-operated micro USB port, the path is no longer set to USB and USB device mode doesn't work. This patch fixes it by setting USB path both for USB and USB host modes.
--- drivers/extcon/extcon-max8997.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/extcon/extcon-max8997.c +4 -6
@@ -320,12 +320,10 @@ static int max8997_muic_handle_usb(struct max8997_muic_info *info, {int ret =0 ; -if (usb_type ==MAX8997_USB_HOST ) { - ret =max8997_muic_set_path (info, info->path_usb, attached); -if (ret <0 ) { -dev_err (info->dev,"failed to update muic register\n" ); -return ret; - } + ret =max8997_muic_set_path (info, info->path_usb, attached); +if (ret <0 ) { +dev_err (info->dev,"failed to update muic register\n" ); +return ret; }switch (usb_type) {
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 17/162 clk: rockchip: fix rk3188 sclk_smc gate data
In reply to Greg Kroah-HartmanFrom: Finley Xiao <[email protected]>
[ Upstream commit a9f0c0e563717b9f63b3bb1c4a7c2df436a206d9 ]
Fix sclk_smc gate data.
Change variable order, flags come before the register address.
--- drivers/clk/rockchip/clk-rk3188.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/rockchip/clk-rk3188.c +2 -2
@@ -360,8 +360,8 @@ static struct rockchip_clk_branch common_clk_branches[] __initdata = {* Clock-Architecture Diagram 4 */ -GATE (SCLK_SMC ,"sclk_smc" ,"hclk_peri" , -RK2928_CLKGATE_CON (2 ),4 ,0 ,GFLAGS ), +GATE (SCLK_SMC ,"sclk_smc" ,"hclk_peri" ,0 , +RK2928_CLKGATE_CON (2 ),4 ,GFLAGS ), COMPOSITE_NOMUX(SCLK_SPI0, "sclk_spi0", "pclk_peri", 0, RK2928_CLKSEL_CON(25), 0, 7, DFLAGS,
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 18/162 clk: rockchip: fix rk3188 sclk_mac_lbtest parameter ordering
In reply to Greg Kroah-HartmanFrom: Heiko Stuebner <[email protected]>
[ Upstream commit ac8cb53829a6ba119082e067f5bc8fab3611ce6a ]
Similar to commit a9f0c0e56371 ("clk: rockchip: fix rk3188 sclk_smc gate data") there is one other gate clock in the rk3188 clock driver with a similar wrong ordering, the sclk_mac_lbtest. So fix it as well.
--- drivers/clk/rockchip/clk-rk3188.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/rockchip/clk-rk3188.c +2 -2
@@ -329,8 +329,8 @@ static struct rockchip_clk_branch common_clk_branches[] __initdata = { RK2928_CLKGATE_CON(2), 5, GFLAGS),MUX (SCLK_MAC ,"sclk_macref" , mux_sclk_macref_p,CLK_SET_RATE_PARENT ,RK2928_CLKSEL_CON (21 ),4 ,1 ,MFLAGS ), -GATE (0 ,"sclk_mac_lbtest" ,"sclk_macref" , -RK2928_CLKGATE_CON (2 ),12 ,0 ,GFLAGS ), +GATE (0 ,"sclk_mac_lbtest" ,"sclk_macref" ,0 , +RK2928_CLKGATE_CON (2 ),12 ,GFLAGS ), COMPOSITE(0, "hsadc_src", mux_pll_src_gpll_cpll_p, 0, RK2928_CLKSEL_CON(22), 0, 1, MFLAGS, 8, 8, DFLAGS,
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 19/162 dlm: fix missing idr_destroy for recover_idr
In reply to Greg Kroah-HartmanFrom: David Teigland <[email protected]>
[ Upstream commit 8fc6ed9a3508a0435b9270c313600799d210d319 ]
Which would leak memory for the idr internals.
--- fs/dlm/lockspace.c | 1 + 1 file changed, 1 insertion(+)
fs/dlm/lockspace.c +1 -0
@@ -800,6 +800,7 @@ static int release_lockspace(struct dlm_ls *ls, int force)dlm_delete_debug_file (ls); +idr_destroy (&ls->ls_recover_idr);kfree (ls->ls_recover_buf);/*
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 20/162 MIPS: SiByte: Enable ZONE_DMA32 for LittleSur
In reply to Greg Kroah-HartmanFrom: Maciej W. Rozycki <[email protected]>
[ Upstream commit 756d6d836dbfb04a5a486bc2ec89397aa4533737 ]
The LittleSur board is marked for high memory support and therefore clearly must provide a way to have enough memory installed for some to be present outside the low 4GiB physical address range. With the memory map of the BCM1250 SOC it has been built around it means over 1GiB of actual DRAM, as only the first 1GiB is mapped in the low 4GiB physical address range[1].
Complement commit cce335ae47e2 ("[MIPS] 64-bit Sibyte kernels need DMA32.") then and also enable ZONE_DMA32 for LittleSur.
[1] "BCM1250/BCM1125/BCM1125H User Manual", Revision 1250_1125-UM100-R, Broadcom Corporation, 21 Oct 2002, Section 3: "System Overview", "Memory Map", pp. 34-38
Patchwork: https://patchwork.linux-mips.org/patch/21107/
--- arch/mips/Kconfig | 1 + 1 file changed, 1 insertion(+)
arch/mips/Kconfig +1 -0
@@ -773,6 +773,7 @@ config SIBYTE_LITTLESUR select SYS_SUPPORTS_BIG_ENDIAN select SYS_SUPPORTS_HIGHMEM select SYS_SUPPORTS_LITTLE_ENDIAN + select ZONE_DMA32 if 64BIT config SIBYTE_SENTOSA bool "Sibyte BCM91250E-Sentosa"
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 21/162 scsi: zfcp: drop default switch case which might paper over missing case
In reply to Greg Kroah-HartmanFrom: Steffen Maier <[email protected]>
[ Upstream commit 0c902936e55cff9335b27ed632fc45e7115ced75 ]
This was introduced with v4.18 commit 8c3d20aada70 ("scsi: zfcp: fix missing REC trigger trace for all objects in ERP_FAILED") but would now suppress helpful -Wswitch compiler warnings when building with W=1 such as the following forced example:
drivers/s390/scsi/zfcp_erp.c: In function 'zfcp_erp_handle_failed':drivers/s390/scsi/zfcp_erp.c:126:2: warning: enumeration value 'ZFCP_ERP_ACTION_REOPEN_PORT_FORCED' not handled in switch [-Wswitch]
switch (want) {
^~~~~~
But then again, only with W=1 we would notice unhandled enum cases. Without the default cases and a missed unhandled enum case, the code might perform unforeseen things we might not want...
As of today, we never run through the removed default case, so removing it is no functional change. In the future, we never should run through a default case but introduce the necessary specific case(s) to handle new functionality.
--- drivers/s390/scsi/zfcp_erp.c | 3 --- 1 file changed, 3 deletions(-)
drivers/s390/scsi/zfcp_erp.c +0 -3
@@ -178,9 +178,6 @@ static int zfcp_erp_handle_failed(int want, struct zfcp_adapter *adapter, adapter, ZFCP_STATUS_COMMON_ERP_FAILED); }break ; -default : - need =0 ; -break ; }return need;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 22/162 pinctrl: qcom: ssbi-gpio: fix gpio-hog related boot issues
In reply to Greg Kroah-HartmanFrom: Brian Masney <[email protected]>
[ Upstream commit 7ed07855773814337b9814f1c3e866df52ebce68 ]
When attempting to setup up a gpio hog, device probing will repeatedly fail with -EPROBE_DEFERED errors. It is caused by a circular dependency between the gpio and pinctrl frameworks. If the gpio-ranges property is present in device tree, then the gpio framework will handle the gpio pin registration and eliminate the circular dependency.
See Christian Lamparter's commit a86caa9ba5d7 ("pinctrl: msm: fix gpio-hog related boot issues") for a detailed commit message that explains the issue in much more detail. The code comment in this commit came from Christian's commit.
I did not test this change against any hardware supported by this particular driver, however I was able to validate this same fix works for pinctrl-spmi-gpio.c using a LG Nexus 5 (hammerhead) phone.
--- drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-)
drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c +17 -6
@@ -755,12 +755,23 @@ static int pm8xxx_gpio_probe(struct platform_device *pdev) goto unregister_pinctrl; } - ret =gpiochip_add_pin_range (&pctrl->chip, -dev_name (pctrl->dev), -0 ,0 , pctrl->chip.ngpio); -if (ret) { -dev_err (pctrl->dev,"failed to add pin range\n" ); - goto unregister_gpiochip; +/* +* For DeviceTree-supported systems, the gpio core checks the +* pinctrl's device node for the "gpio-ranges" property. +* If it is present, it takes care of adding the pin ranges +* for the driver. In this case the driver can skip ahead. +* +* In order to remain compatible with older, existing DeviceTree +* files which don't set the "gpio-ranges" property or systems that +* utilize ACPI the driver has to call gpiochip_add_pin_range(). +*/ +if (!of_property_read_bool (pctrl->dev->of_node,"gpio-ranges" )) { + ret =gpiochip_add_pin_range (&pctrl->chip,dev_name (pctrl->dev), +0 ,0 , pctrl->chip.ngpio); +if (ret) { +dev_err (pctrl->dev,"failed to add pin range\n" ); + goto unregister_gpiochip; + } }platform_set_drvdata (pdev, pctrl);
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 23/162 Staging: iio: adt7316: Fix i2c data reading, set the data field
In reply to Greg Kroah-HartmanFrom: Shreeya Patel <[email protected]>
[ Upstream commit 688cd642ba0c393344c802647848da5f0d925d0e ]
adt7316_i2c_read function nowhere sets the data field. It is necessary to have an appropriate value for it. Hence, assign the value stored in 'ret' variable to data field.
This is an ancient bug, and as no one seems to have noticed, probably no sense in applying it to stable.
--- drivers/staging/iio/addac/adt7316-i2c.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/staging/iio/addac/adt7316-i2c.c +2 -0
@@ -35,6 +35,8 @@ static int adt7316_i2c_read(void *client, u8 reg, u8 *data)return ret; } + *data = ret; +return 0 ; }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 24/162 regulator: Fix return value of _set_load() stub
In reply to Greg Kroah-HartmanFrom: Mark Brown <[email protected]>
[ Upstream commit f1abf67217de91f5cd3c757ae857632ca565099a ]
The stub implementation of _set_load() returns a mode value which is within the bounds of valid return codes for success (the documentation just says that failures are negative error codes) but not sensible or what the actual implementation does. Fix it to just return 0.
--- include/linux/regulator/consumer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/regulator/consumer.h +1 -1
@@ -485,7 +485,7 @@ static inline unsigned int regulator_get_mode(struct regulator *regulator)static inline int regulator_set_load (struct regulator *regulator,int load_uA) { -return REGULATOR_MODE_NORMAL ; +return 0 ; } static inline int regulator_allow_bypass(struct regulator *regulator,
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 25/162 MIPS: OCTEON: octeon-platform: fix typing
In reply to Greg Kroah-HartmanFrom: Aaro Koskinen <[email protected]>
[ Upstream commit 2cf1c8933dd93088cfb5f8f58b3bb9bbdf1781b9 ]
Use correct type for fdt_property nameoff field.
Patchwork: https://patchwork.linux-mips.org/patch/21204/
--- arch/mips/cavium-octeon/octeon-platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/cavium-octeon/octeon-platform.c +1 -1
@@ -485,7 +485,7 @@ static void __init octeon_fdt_set_phy(int eth, int phy_addr)if (phy_addr >=256 && alt_phy >0 ) {const struct fdt_property *phy_prop;struct fdt_property *alt_prop; -u32 phy_handle_name; +fdt32_t phy_handle_name;/* Use the alt phy node instead.*/ phy_prop =fdt_get_property (initial_boot_params, eth,"phy-handle" ,NULL );
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 26/162 math-emu/soft-fp.h: (_FP_ROUND_ZERO) cast 0 to void to fix warning
In reply to Greg Kroah-HartmanFrom: Vincent Chen <[email protected]>
[ Upstream commit 83312f1b7ae205dca647bf52bbe2d51303cdedfb ]
_FP_ROUND_ZERO is defined as 0 and used as a statemente in macro _FP_ROUND. This generates "error: statement with no effect [-Werror=unused-value]" from gcc. Defining _FP_ROUND_ZERO as (void)0 to fix it.
This modification is quoted from glibc 'commit <In libc/:> (8ed1e7d5894000c155acbd06f)'
--- include/math-emu/soft-fp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/math-emu/soft-fp.h +1 -1
@@ -138,7 +138,7 @@ do { \ _FP_FRAC_ADDI_##wc(X, _FP_WORK_ROUND); \ } while (0) -#define _FP_ROUND_ZERO (wc,X ) 0 +#define _FP_ROUND_ZERO (wc,X ) (void)0#define _FP_ROUND_PINF (wc,X ) \ do { \
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 27/162 rtc: max8997: Fix the returned value in case of error in max8997_rtc_read_alarm()
In reply to Greg Kroah-HartmanFrom: Christophe JAILLET <[email protected]>
[ Upstream commit 41ef3878203cd9218d92eaa07df4b85a2cb128fb ]
In case of error, we return 0.
This is spurious and not consistent with the other functions of the driver. Propagate the error code instead.
--- drivers/rtc/rtc-max8997.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/rtc-max8997.c +1 -1
@@ -221,7 +221,7 @@ static int max8997_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) out:mutex_unlock (&info->lock); -return 0 ; +return ret; }static int max8997_rtc_stop_alarm (struct max8997_rtc_info *info)
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 28/162 rtc: dt-binding: abx80x: fix resistance scale
In reply to Greg Kroah-HartmanFrom: Baruch Siach <[email protected]>
[ Upstream commit 73852e56827f5cb5db9d6e8dd8191fc2f2e8f424 ]
The abracon,tc-resistor property value is in kOhm.
--- Documentation/devicetree/bindings/rtc/abracon,abx80x.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/rtc/abracon,abx80x.txt +1 -1
@@ -27,4 +27,4 @@ and valid to enable charging: - "abracon,tc-diode": should be "standard" (0.6V) or "schottky" (0.3V) - "abracon,tc-resistor": should be <0>, <3>, <6> or <11>. 0 disables the output - resistor, the other values are in ohm. + resistor, the other values are in kOhm.
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 29/162 ARM: dts: exynos: Use Samsung SoC specific compatible for DWC2 module
In reply to Greg Kroah-HartmanFrom: Marek Szyprowski <[email protected]>
[ Upstream commit 6035cbcceb069f87296b3cd0bc4736ad5618bf47 ]
DWC2 hardware module integrated in Samsung SoCs requires some quirks to operate properly, so use Samsung SoC specific compatible to notify driver to apply respective fixes.
--- arch/arm/boot/dts/exynos3250.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos3250.dtsi +1 -1
@@ -325,7 +325,7 @@ }; hsotg: hsotg@12480000 { - compatible = "snps,dwc2"; + compatible = "samsung,s3c6400-hsotg", "snps,dwc2"; reg = <0x12480000 0x20000>; interrupts = <0 141 0>; clocks = <&cmu CLK_USBOTG>;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 30/162 dmaengine: coh901318: Fix a double-lock bug
In reply to Greg Kroah-HartmanFrom: Jia-Ju Bai <[email protected]>
[ Upstream commit 627469e4445b9b12e0229b3bdf8564d5ce384dd7 ]
The function coh901318_alloc_chan_resources() calls spin_lock_irqsave() before calling coh901318_config().
But coh901318_config() calls spin_lock_irqsave() again in its definition, which may cause a double-lock bug.
Because coh901318_config() is only called by coh901318_alloc_chan_resources(), the bug fix is to remove the calls to spin-lock and -unlock functions in coh901318_config().
--- drivers/dma/coh901318.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/dma/coh901318.c +0 -4
@@ -1815,8 +1815,6 @@ static int coh901318_config(struct coh90int channel = cohc->id;void __iomem *virtbase = cohc->base->virtbase; -spin_lock_irqsave (&cohc->lock, flags); -if (param) p = param;else
@@ -1836,8 +1834,6 @@ static int coh901318_config(struct coh90coh901318_set_conf (cohc, p->config);coh901318_set_ctrl (cohc, p->ctrl_lli_last); -spin_unlock_irqrestore (&cohc->lock, flags); -return 0 ; }
Greg Kroah-Hartman
maintainerPATCH 31/162 dmaengine: coh901318: Remove unused variable
In reply to Greg Kroah-HartmanFrom: Vinod Koul <[email protected]>
commit 35faaf0df42d285b40f8a6310afbe096720f7758 upstream.
Commit 627469e4445b ("dmaengine: coh901318: Fix a double-lock bug") left flags variable unused, so remove it to fix the warning.
drivers/dma/coh901318.c: In function 'coh901318_config':drivers/dma/coh901318.c:1805:16: warning: unused variable 'flags' [-Wunused-variable]
unsigned long flags;
^~~~~--- drivers/dma/coh901318.c | 1 - 1 file changed, 1 deletion(-)
drivers/dma/coh901318.c +0 -1
@@ -1810,7 +1810,6 @@ static struct dma_chan *coh901318_xlate(static int coh901318_config (struct coh901318_chan *cohc,struct coh901318_params *param) { -unsigned long flags;const struct coh901318_params *p;int channel = cohc->id;void __iomem *virtbase = cohc->base->virtbase;
Greg Kroah-Hartman
maintainerPATCH 32/162 ACPI: fix acpi_find_child_device() invocation in acpi_preset_companion()
In reply to Greg Kroah-HartmanFrom: Alexey Dobriyan <[email protected]>
[ Upstream commit f8c6d1402b89f22a3647705d63cbd171aa19a77e ]
acpi_find_child_device() accepts boolean not pointer as last argument.
--- include/linux/acpi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/acpi.h +1 -1
@@ -75,7 +75,7 @@ static inline bool has_acpi_companion(struct device *dev)static inline void acpi_preset_companion (struct device *dev,struct acpi_device *parent,u64 addr) { -ACPI_COMPANION_SET (dev,acpi_find_child_device (parent, addr,NULL )); +ACPI_COMPANION_SET (dev,acpi_find_child_device (parent, addr, false)); }static inline const char *acpi_dev_name (struct acpi_device *adev)
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 33/162 dma-mapping: fix return type of dma_set_max_seg_size()
In reply to Greg Kroah-HartmanFrom: Niklas Söderlund <[email protected]>
[ Upstream commit c9d76d0655c06b8c1f944e46c4fd9e9cf4b331c0 ]
The function dma_set_max_seg_size() can return either 0 on success or -EIO on error. Change its return type from unsigned int to int to capture this.
--- include/linux/dma-mapping.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
include/linux/dma-mapping.h +1 -2
@@ -151,8 +151,7 @@ static inline unsigned int dma_get_max_seg_size(struct device *dev)return SZ_64K ; } -static inline unsigned int dma_set_max_seg_size (struct device *dev, -unsigned int size) +static inline int dma_set_max_seg_size (struct device *dev,unsigned int size) {if (dev->dma_parms) { dev->dma_parms->max_segment_size = size;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 34/162 altera-stapl: check for a null key before strcasecmping it
In reply to Greg Kroah-HartmanFrom: Colin Ian King <[email protected]>
[ Upstream commit 9ccb645683ef46e3c52c12c088a368baa58447d4 ]
Currently the null check on key is occurring after the strcasecmp on the key, hence there is a potential null pointer dereference on key. Fix this by checking if key is null first. Also replace the == 0 check on strcasecmp with just the ! operator.
Detected by CoverityScan, CID#1248787 ("Dereference before null check")
--- drivers/misc/altera-stapl/altera.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/misc/altera-stapl/altera.c +1 -2
@@ -2176,8 +2176,7 @@ static int altera_get_note(u8 *p, s32 program_size, key_ptr = &p[note_strings +get_unaligned_be32 ( &p[note_table + (8 * i)])]; -if ((strncasecmp (key, key_ptr,strlen (key_ptr)) ==0 ) && - (key !=NULL )) { +if (key && !strncasecmp (key, key_ptr,strlen (key_ptr))) { status =0 ; value_ptr = &p[note_strings +
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 35/162 serial: imx: fix error handling in console_setup
In reply to Greg Kroah-HartmanFrom: Stefan Agner <[email protected]>
[ Upstream commit 63fd4b94b948c14eeb27a3bbf50ea0f7f0593bad ]
The ipg clock only needs to be unprepared in case preparing per clock fails. The ipg clock has already disabled at the point.
--- drivers/tty/serial/imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/imx.c +1 -1
@@ -1784,7 +1784,7 @@ imx_console_setup(struct console *co, char *options) retval =clk_prepare (sport->clk_per);if (retval) -clk_disable_unprepare (sport->clk_ipg); +clk_unprepare (sport->clk_ipg); error_console:return retval;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 36/162 i2c: imx: dont print error message on probe defer
In reply to Greg Kroah-HartmanFrom: Lucas Stach <[email protected]>
[ Upstream commit fece4978510e43f09c8cd386fee15210e8c68493 ]
Probe deferral is a normal operating condition in the probe function, so don't spam the log with an error in this case.
--- drivers/i2c/busses/i2c-imx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/i2c/busses/i2c-imx.c +2 -1
@@ -1076,7 +1076,8 @@ static int i2c_imx_probe(struct platform_device *pdev)/* Get I2C clock */ i2c_imx->clk =devm_clk_get (&pdev->dev,NULL );if (IS_ERR (i2c_imx->clk)) { -dev_err (&pdev->dev,"can't get I2C clock\n" ); +if (PTR_ERR (i2c_imx->clk) != -EPROBE_DEFER ) +dev_err (&pdev->dev,"can't get I2C clock\n" );return PTR_ERR (i2c_imx->clk); }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 37/162 dlm: NULL check before kmem_cache_destroy is not needed
In reply to Greg Kroah-HartmanFrom: Wen Yang <[email protected]>
[ Upstream commit f31a89692830061bceba8469607e4e4b0f900159 ]
kmem_cache_destroy(NULL) is safe, so removes NULL check before freeing the mem. This patch also fix ifnullfree.cocci warnings.
--- fs/dlm/memory.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
fs/dlm/memory.c +3 -6
@@ -38,10 +38,8 @@ int __init dlm_memory_init(void)void dlm_memory_exit (void ) { -if (lkb_cache) -kmem_cache_destroy (lkb_cache); -if (rsb_cache) -kmem_cache_destroy (rsb_cache); +kmem_cache_destroy (lkb_cache); +kmem_cache_destroy (rsb_cache); }char *dlm_allocate_lvb (struct dlm_ls *ls)
@@ -86,8 +84,7 @@ void dlm_free_lkb(struct dlm_lkb *lkb)struct dlm_user_args *ua; ua = lkb->lkb_ua;if (ua) { -if (ua->lksb.sb_lvbptr) -kfree (ua->lksb.sb_lvbptr); +kfree (ua->lksb.sb_lvbptr);kfree (ua); } }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 38/162 nfsd: fix a warning in __cld_pipe_upcall()
In reply to Greg Kroah-HartmanFrom: Scott Mayhew <[email protected]>
[ Upstream commit b493fd31c0b89d9453917e977002de58bebc3802 ]
__cld_pipe_upcall() emits a "do not call blocking ops when !TASK_RUNNING" warning due to the dput() call in rpc_queue_upcall(). Fix it by using a completion instead of hand coding the wait.
--- fs/nfsd/nfs4recover.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-)
fs/nfsd/nfs4recover.c +6 -11
@@ -655,7 +655,7 @@ struct cld_net {struct cld_upcall {struct list_head cu_list;struct cld_net *cu_net; -struct task_struct *cu_task; +struct completion cu_done;struct cld_msg cu_msg; };
@@ -664,23 +664,18 @@ __cld_pipe_upcall(struct rpc_pipe *pipe, struct cld_msg *cmsg) {int ret;struct rpc_pipe_msg msg; + struct cld_upcall *cup = container_of(cmsg, struct cld_upcall, cu_msg);memset (&msg,0 ,sizeof (msg)); msg.data = cmsg; msg.len =sizeof (*cmsg); -/* -* Set task state before we queue the upcall. That prevents -* wake_up_process in the downcall from racing with schedule. -*/ -set_current_state (TASK_UNINTERRUPTIBLE ); ret =rpc_queue_upcall (pipe, &msg);if (ret <0 ) { -set_current_state (TASK_RUNNING ); goto out; } -schedule (); +wait_for_completion (&cup->cu_done);if (msg.errno <0 ) ret = msg.errno;
@@ -747,7 +742,7 @@ cld_pipe_downcall(struct file *filp, const char __user *src, size_t mlen)if (copy_from_user (&cup->cu_msg, src, mlen) !=0 )return -EFAULT ; -wake_up_process (cup->cu_task); +complete (&cup->cu_done);return mlen; }
@@ -762,7 +757,7 @@ cld_pipe_destroy_msg(struct rpc_pipe_msg *msg)if (msg->errno >=0 )return ; -wake_up_process (cup->cu_task); +complete (&cup->cu_done); }static const struct rpc_pipe_ops cld_upcall_ops = {
@@ -893,7 +888,7 @@ restart_search: goto restart_search; } } - new->cu_task = current; +init_completion (&new->cu_done); new->cu_msg.cm_vers =CLD_UPCALL_VERSION ;put_unaligned (cn->cn_xid++, &new->cu_msg.cm_xid); new->cu_net = cn;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 39/162 ARM: OMAP1/2: fix SoC name printing
In reply to Greg Kroah-HartmanFrom: Aaro Koskinen <[email protected]>
[ Upstream commit 04a92358b3964988c78dfe370a559ae550383886 ]
Currently we get extra newlines on OMAP1/2 when the SoC name is printed:
[ 0.000000] OMAP1510 [ 0.000000] revision 2 handled as 15xx id: bc058c9b93111a16
[ 0.000000] OMAP2420 [ 0.000000]
Fix by using pr_cont.
--- arch/arm/mach-omap1/id.c | 6 +++--- arch/arm/mach-omap2/id.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-)
arch/arm/mach-omap1/id.c +3 -3
@@ -200,10 +200,10 @@ void __init omap_check_revision(void)printk (KERN_INFO "Unknown OMAP cpu type: 0x%02x\n" , cpu_type); } -printk (KERN_INFO "OMAP%04x" , omap_revision >>16 ); +pr_info ("OMAP%04x" , omap_revision >>16 );if ((omap_revision >>8 ) &0xff ) -printk (KERN_INFO "%x" , (omap_revision >>8 ) &0xff ); -printk (KERN_INFO " revision %i handled as %02xxx id: %08x%08x\n" , +pr_cont ("%x" , (omap_revision >>8 ) &0xff ); +pr_cont (" revision %i handled as %02xxx id: %08x%08x\n" , die_rev, omap_revision &0xff , system_serial_low, system_serial_high); }
arch/arm/mach-omap2/id.c +2 -2
@@ -199,8 +199,8 @@ void __init omap2xxx_check_revision(void)pr_info ("%s" , soc_name);if ((omap_rev () >>8 ) &0x0f ) -pr_info ("%s" , soc_rev); -pr_info ("\n" ); +pr_cont ("%s" , soc_rev); +pr_cont ("\n" ); }#define OMAP3_SHOW_FEATURE (feat) \
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 40/162 net/x25: fix called/calling length calculation in x25_parse_address_block
In reply to Greg Kroah-HartmanFrom: Martin Schiller <[email protected]>
[ Upstream commit d449ba3d581ed29f751a59792fdc775572c66904 ]
The length of the called and calling address was not calculated correctly (BCD encoding).
--- net/x25/af_x25.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/x25/af_x25.c +1 -1
@@ -100,7 +100,7 @@ int x25_parse_address_block(struct sk_buff *skb, } len = *skb->data; - needed =1 + (len >>4 ) + (len &0x0f ); + needed =1 + ((len >>4 ) + (len &0x0f ) +1 ) /2 ;if (!pskb_may_pull (skb, needed)) {/* packet is too short to hold the addresses it claims
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 41/162 net/x25: fix null_x25_address handling
In reply to Greg Kroah-HartmanFrom: Martin Schiller <[email protected]>
[ Upstream commit 06137619f061f498c2924f6543fa45b7d39f0501 ]
o x25_find_listener(): the compare for the null_x25_address was wrong. We have to check the x25_addr of the listener socket instead of the x25_addr of the incomming call.
o x25_bind(): it was not possible to bind a socket to null_x25_address
--- net/x25/af_x25.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)
net/x25/af_x25.c +10 -6
@@ -288,7 +288,7 @@ static struct sock *x25_find_listener(struct x25_address *addr,sk_for_each (s, &x25_list)if ((!strcmp (addr->x25_addr,x25_sk (s)->source_addr.x25_addr) || - !strcmp (addr->x25_addr, + !strcmp (x25_sk (s)->source_addr.x25_addr, null_x25_address.x25_addr)) && s->sk_state ==TCP_LISTEN ) {/*
@@ -684,11 +684,15 @@ static int x25_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len) goto out; } - len =strlen (addr->sx25_addr.x25_addr); -for (i =0 ; i < len; i++) { -if (!isdigit (addr->sx25_addr.x25_addr[i])) { - rc = -EINVAL ; - goto out; +/* check for the null_x25_address */ +if (strcmp (addr->sx25_addr.x25_addr, null_x25_address.x25_addr)) { + + len =strlen (addr->sx25_addr.x25_addr); +for (i =0 ; i < len; i++) { +if (!isdigit (addr->sx25_addr.x25_addr[i])) { + rc = -EINVAL ; + goto out; + } } }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 42/162 ARM: dts: mmp2: fix the gpio interrupt cell number
In reply to Greg Kroah-HartmanFrom: Lubomir Rintel <[email protected]>
[ Upstream commit 400583983f8a8e95ec02c9c9e2b50188753a87fb ]
gpio-pxa uses two cell to encode the interrupt source: the pin number and the trigger type. Adjust the device node accordingly.
--- arch/arm/boot/dts/mmp2.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/mmp2.dtsi +1 -1
@@ -180,7 +180,7 @@ clocks = <&soc_clocks MMP2_CLK_GPIO>; resets = <&soc_clocks MMP2_CLK_GPIO>; interrupt-controller; - #interrupt-cells = <1>; + #interrupt-cells = <2>; ranges; gcb0: gpio@d4019000 {
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 43/162 tcp: fix off-by-one bug on aborting window-probing socket
In reply to Greg Kroah-HartmanFrom: Yuchung Cheng <[email protected]>
[ Upstream commit 3976535af0cb9fe34a55f2ffb8d7e6b39a2f8188 ]
Previously there is an off-by-one bug on determining when to abort a stalled window-probing socket. This patch fixes that so it is consistent with tcp_write_timeout().
--- net/ipv4/tcp_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv4/tcp_timer.c +1 -1
@@ -336,7 +336,7 @@ static void tcp_probe_timer(struct sock *sk)return ; } -if (icsk->icsk_probes_out > max_probes) { +if (icsk->icsk_probes_out >= max_probes) { abort:tcp_write_err (sk); }else {/* Only send another probe if we didn't close things up. */
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 44/162 modpost: skip ELF local symbols during section mismatch check
In reply to Greg Kroah-HartmanFrom: Paul Walmsley <[email protected]>
[ Upstream commit a4d26f1a0958bb1c2b60c6f1e67c6f5d43e2647b ]
During development of a serial console driver with a gcc 8.2.0 toolchain for RISC-V, the following modpost warning appeared:
----
WARNING: vmlinux.o(.data+0x19b10): Section mismatch in reference from the variable .LANCHOR1 to the function .init.text:sifive_serial_console_setup() The variable .LANCHOR1 references
the function __init sifive_serial_console_setup()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
----
".LANCHOR1" is an ELF local symbol, automatically created by gcc's section anchor generation code:
https://gcc.gnu.org/onlinedocs/gccint/Anchored-Addresses.html
This was verified by compiling the kernel with -fno-section-anchors and observing that the ".LANCHOR1" ELF local symbol disappeared, and modpost no longer warned about the section mismatch. The serial driver code idiom triggering the warning is standard Linux serial driver practice that has a specific whitelist inclusion in modpost.c.
I'm neither a modpost nor an ELF expert, but naively, it doesn't seem useful for modpost to report section mismatch warnings caused by ELF local symbols by default. Local symbols have compiler-generated names, and thus bypass modpost's whitelisting algorithm, which relies on the presence of a non-autogenerated symbol name. This increases the likelihood that false positive warnings will be generated (as in the above case).
Thus, disable section mismatch reporting on ELF local symbols. The rationale here is similar to that of commit 2e3a10a1551d ("ARM: avoid ARM binutils leaking ELF local symbols") and of similar code already present in modpost.c:
This third version of the patch implements a suggestion from Masahiro Yamada <[email protected]> to restructure the code as an additional pattern matching step inside secref_whitelist(), and further improves the patch description.
--- scripts/mod/modpost.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
scripts/mod/modpost.c +12 -0
@@ -1156,6 +1156,14 @@ static const struct sectioncheck *section_mismatch(* fromsec = text section * refsymname = *.constprop.* * +* Pattern 6: +* Hide section mismatch warnings for ELF local symbols. The goal +* is to eliminate false positive modpost warnings caused by +* compiler-generated ELF local symbol names such as ".LANCHOR1". +* Autogenerated symbol names bypass modpost's "Pattern 2" +* whitelisting, which relies on pattern-matching against symbol +* names to work. (One situation where gcc can autogenerate ELF +* local symbols is when "-fsection-anchors" is used.) **/ static int secref_whitelist(const struct sectioncheck *mismatch, const char *fromsec, const char *fromsym,
@@ -1194,6 +1202,10 @@ static int secref_whitelist(const struct sectioncheck *mismatch, match(fromsym, optim_symbols))return 0 ; +/* Check for pattern 6 */ +if (strstarts (fromsym,".L" )) +return 0 ; +return 1 ; }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 45/162 kbuild: fix single target build for external module
In reply to Greg Kroah-HartmanFrom: Masahiro Yamada <[email protected]>
[ Upstream commit e07db28eea38ed4e332b3a89f3995c86b713cb5b ]
Building a single target in an external module fails due to missing .tmp_versions directory.
For example,
$ make -C /lib/modules/$(uname -r)/build M=$PWD foo.o
will fail in the following way:
CC [M] /home/masahiro/foo/foo.o/bin/sh: 1: cannot create /home/masahiro/foo/.tmp_versions/foo.mod: Directory nonexistent
This is because $(cmd_crmodverdir) is executed only before building /, %/, %.ko single targets of external modules. Create .tmp_versions in the 'prepare' target.
--- Makefile | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)
Makefile +3 -8
@@ -1424,9 +1424,6 @@ else # KBUILD_EXTMOD # We are always building modules KBUILD_MODULES := 1 -PHONY += crmodverdir -crmodverdir: - $(cmd_crmodverdir) PHONY += $(objtree)/Module.symvers $(objtree)/Module.symvers:
@@ -1438,7 +1435,7 @@ $(objtree)/Module.symvers: module-dirs := $(addprefix _module_,$(KBUILD_EXTMOD)) PHONY += $(module-dirs) modules -$(module-dirs): crmodverdir $(objtree)/Module.symvers +$(module-dirs): prepare $(objtree)/Module.symvers $(Q)$(MAKE) $(build)=$(patsubst _module_%,%,$@) modules: $(module-dirs)
@@ -1478,7 +1475,8 @@ help: # Dummies... PHONY += prepare scripts -prepare: ; +prepare: + $(cmd_crmodverdir) scripts: ; endif # KBUILD_EXTMOD
@@ -1602,17 +1600,14 @@ endif # Modules /: prepare scripts FORCE - $(cmd_crmodverdir) $(Q)$(MAKE) KBUILD_MODULES=$(if $(CONFIG_MODULES),1) \ $(build)=$(build-dir) # Make sure the latest headers are built for Documentation Documentation/: headers_install %/: prepare scripts FORCE - $(cmd_crmodverdir) $(Q)$(MAKE) KBUILD_MODULES=$(if $(CONFIG_MODULES),1) \ $(build)=$(build-dir) %.ko: prepare scripts FORCE - $(cmd_crmodverdir) $(Q)$(MAKE) KBUILD_MODULES=$(if $(CONFIG_MODULES),1) \ $(build)=$(build-dir) $(@:.ko=.o) $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modpost
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 46/162 ARM: dts: pxa: clean up USB controller nodes
In reply to Greg Kroah-HartmanFrom: Daniel Mack <[email protected]>
[ Upstream commit c40ad24254f1dbd54f2df5f5f524130dc1862122 ]
PXA25xx SoCs don't have a USB controller, so drop the node from the common pxa2xx.dtsi base file. Both pxa27x and pxa3xx have a dedicated node already anyway.
While at it, unify the names for the nodes across all pxa platforms.
--- arch/arm/boot/dts/pxa27x.dtsi | 2 +- arch/arm/boot/dts/pxa2xx.dtsi | 7 ------- arch/arm/boot/dts/pxa3xx.dtsi | 2 +- 3 files changed, 2 insertions(+), 9 deletions(-)
arch/arm/boot/dts/pxa27x.dtsi +1 -1
@@ -27,7 +27,7 @@ clocks = <&clks CLK_NONE>; }; - pxa27x_ohci: usb@4c000000 { + usb0: usb@4c000000 { compatible = "marvell,pxa-ohci"; reg = <0x4c000000 0x10000>; interrupts = <3>;
arch/arm/boot/dts/pxa2xx.dtsi +0 -7
@@ -117,13 +117,6 @@ status = "disabled"; }; - usb0: ohci@4c000000 { - compatible = "marvell,pxa-ohci"; - reg = <0x4c000000 0x10000>; - interrupts = <3>; - status = "disabled"; - }; - mmc0: mmc@41100000 { compatible = "marvell,pxa-mmc"; reg = <0x41100000 0x1000>;
arch/arm/boot/dts/pxa3xx.dtsi +1 -1
@@ -88,7 +88,7 @@ status = "disabled"; }; - pxa3xx_ohci: usb@4c000000 { + usb0: usb@4c000000 { compatible = "marvell,pxa-ohci"; reg = <0x4c000000 0x10000>; interrupts = <3>;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 47/162 dlm: fix invalid cluster name warning
In reply to Greg Kroah-HartmanFrom: David Teigland <[email protected]>
[ Upstream commit 3595c559326d0b660bb088a88e22e0ca630a0e35 ]
The warning added in commit 3b0e761ba83
"dlm: print log message when cluster name is not set"
did not account for the fact that lockspaces created from userland do not supply a cluster name, so bogus warnings are printed every time a userland lockspace is created.
--- fs/dlm/user.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/dlm/user.c +2 -1
@@ -25,6 +25,7 @@#include "lvb_table.h" #include "user.h" #include "ast.h" +#include "config.h" static const char name_prefix[] ="dlm" ;static const struct file_operations device_fops;
@@ -402,7 +403,7 @@ static int device_create_lockspace(struct dlm_lspace_params *params)if (!capable (CAP_SYS_ADMIN ))return -EPERM ; - error =dlm_new_lockspace (params->name,NULL , params->flags, + error =dlm_new_lockspace (params->name, dlm_config.ci_cluster_name, params->flags,DLM_USER_LVB_LEN ,NULL ,NULL ,NULL , &lockspace);if (error)
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 48/162 powerpc/math-emu: Update macros from GCC
In reply to Greg Kroah-HartmanFrom: Joel Stanley <[email protected]>
[ Upstream commit b682c8692442711684befe413cf93cf01c5324ea ]
The add_ssaaaa, sub_ddmmss, umul_ppmm and udiv_qrnnd macros originate from GCC's longlong.h which in turn was copied from GMP's longlong.h a few decades ago.
This was found when compiling with clang:
arch/powerpc/math-emu/fnmsub.c:46:2: error: invalid use of a cast in a inline asm context requiring an l-value: remove the cast or build with -fheinous-gnu-extensions
FP_ADD_D(R, T, B);
^~~~~~~~~~~~~~~~~...
./arch/powerpc/include/asm/sfp-machine.h:283:27: note: expanded from
macro 'sub_ddmmss'
: "=r" ((USItype)(sh)), \
~~~~~~~~~~^~~Segher points out: this was fixed in GCC over 16 years ago ( https://gcc.gnu.org/r56600 ), and in GMP (where it comes from) presumably before that.
Update the add_ssaaaa, sub_ddmmss, umul_ppmm and udiv_qrnnd macros to the latest GCC version in order to git rid of the invalid casts. These were taken as-is from GCC's longlong in order to make future syncs obvious. Other parts of sfp-machine.h were left as-is as the file contains more features than present in longlong.h.
--- arch/powerpc/include/asm/sfp-machine.h | 92 ++++++++------------------ 1 file changed, 29 insertions(+), 63 deletions(-)
arch/powerpc/include/asm/sfp-machine.h +29 -63
@@ -213,30 +213,18 @@* respectively. The result is placed in HIGH_SUM and LOW_SUM. Overflow * (i.e. carry out) is not stored anywhere, and is lost. */ -#define add_ssaaaa (sh, sl, ah, al, bh, bl) \ +#define add_ssaaaa (sh, sl, ah, al, bh, bl) \ do { \ if (__builtin_constant_p (bh) && (bh) == 0) \ - __asm__ ("{a%I4|add%I4c} %1,%3,%4\n\t{aze|addze} %0,%2" \ - : "=r" ((USItype)(sh)), \ - "=&r" ((USItype)(sl)) \ - : "%r" ((USItype)(ah)), \ - "%r" ((USItype)(al)), \ - "rI" ((USItype)(bl))); \ - else if (__builtin_constant_p (bh) && (bh) ==~(USItype) 0) \ - __asm__ ("{a%I4|add%I4c} %1,%3,%4\n\t{ame|addme} %0,%2" \ - : "=r" ((USItype)(sh)), \ - "=&r" ((USItype)(sl)) \ - : "%r" ((USItype)(ah)), \ - "%r" ((USItype)(al)), \ - "rI" ((USItype)(bl))); \ + __asm__ ("add%I4c %1,%3,%4\n\taddze %0,%2" \ + : "=r" (sh), "=&r" (sl) : "r" (ah), "%r" (al), "rI" (bl));\ + else if (__builtin_constant_p (bh) && (bh) == ~(USItype) 0) \ + __asm__ ("add%I4c %1,%3,%4\n\taddme %0,%2" \ + : "=r" (sh), "=&r" (sl) : "r" (ah), "%r" (al), "rI" (bl));\ else \ - __asm__ ("{a%I5|add%I5c} %1,%4,%5\n\t{ae|adde} %0,%2,%3" \ - : "=r" ((USItype)(sh)), \ - "=&r" ((USItype)(sl)) \ - : "%r" ((USItype)(ah)), \ - "r" ((USItype)(bh)), \ - "%r" ((USItype)(al)), \ - "rI" ((USItype)(bl))); \ + __asm__ ("add%I5c %1,%4,%5\n\tadde %0,%2,%3" \ + : "=r" (sh), "=&r" (sl) \ + : "%r" (ah), "r" (bh), "%r" (al), "rI" (bl)); \ } while (0)/* sub_ddmmss is used in op-2.h and udivmodti4.c and should be equivalent to
@@ -248,44 +236,24 @@* and LOW_DIFFERENCE. Overflow (i.e. carry out) is not stored anywhere, * and is lost. */ -#define sub_ddmmss (sh, sl, ah, al, bh, bl) \ +#define sub_ddmmss (sh, sl, ah, al, bh, bl) \ do { \ if (__builtin_constant_p (ah) && (ah) == 0) \ - __asm__ ("{sf%I3|subf%I3c} %1,%4,%3\n\t{sfze|subfze} %0,%2" \ - : "=r" ((USItype)(sh)), \ - "=&r" ((USItype)(sl)) \ - : "r" ((USItype)(bh)), \ - "rI" ((USItype)(al)), \ - "r" ((USItype)(bl))); \ - else if (__builtin_constant_p (ah) && (ah) ==~(USItype) 0) \ - __asm__ ("{sf%I3|subf%I3c} %1,%4,%3\n\t{sfme|subfme} %0,%2" \ - : "=r" ((USItype)(sh)), \ - "=&r" ((USItype)(sl)) \ - : "r" ((USItype)(bh)), \ - "rI" ((USItype)(al)), \ - "r" ((USItype)(bl))); \ + __asm__ ("subf%I3c %1,%4,%3\n\tsubfze %0,%2" \ + : "=r" (sh), "=&r" (sl) : "r" (bh), "rI" (al), "r" (bl));\ + else if (__builtin_constant_p (ah) && (ah) == ~(USItype) 0) \ + __asm__ ("subf%I3c %1,%4,%3\n\tsubfme %0,%2" \ + : "=r" (sh), "=&r" (sl) : "r" (bh), "rI" (al), "r" (bl));\ else if (__builtin_constant_p (bh) && (bh) == 0) \ - __asm__ ("{sf%I3|subf%I3c} %1,%4,%3\n\t{ame|addme} %0,%2" \ - : "=r" ((USItype)(sh)), \ - "=&r" ((USItype)(sl)) \ - : "r" ((USItype)(ah)), \ - "rI" ((USItype)(al)), \ - "r" ((USItype)(bl))); \ - else if (__builtin_constant_p (bh) && (bh) ==~(USItype) 0) \ - __asm__ ("{sf%I3|subf%I3c} %1,%4,%3\n\t{aze|addze} %0,%2" \ - : "=r" ((USItype)(sh)), \ - "=&r" ((USItype)(sl)) \ - : "r" ((USItype)(ah)), \ - "rI" ((USItype)(al)), \ - "r" ((USItype)(bl))); \ + __asm__ ("subf%I3c %1,%4,%3\n\taddme %0,%2" \ + : "=r" (sh), "=&r" (sl) : "r" (ah), "rI" (al), "r" (bl));\ + else if (__builtin_constant_p (bh) && (bh) == ~(USItype) 0) \ + __asm__ ("subf%I3c %1,%4,%3\n\taddze %0,%2" \ + : "=r" (sh), "=&r" (sl) : "r" (ah), "rI" (al), "r" (bl));\ else \ - __asm__ ("{sf%I4|subf%I4c} %1,%5,%4\n\t{sfe|subfe} %0,%3,%2" \ - : "=r" ((USItype)(sh)), \ - "=&r" ((USItype)(sl)) \ - : "r" ((USItype)(ah)), \ - "r" ((USItype)(bh)), \ - "rI" ((USItype)(al)), \ - "r" ((USItype)(bl))); \ + __asm__ ("subf%I4c %1,%5,%4\n\tsubfe %0,%3,%2" \ + : "=r" (sh), "=&r" (sl) \ + : "r" (ah), "r" (bh), "rI" (al), "r" (bl)); \ } while (0)/* asm fragments for mul and div */
@@ -294,13 +262,10 @@* UWtype integers MULTIPLER and MULTIPLICAND, and generates a two UWtype * word product in HIGH_PROD and LOW_PROD. */ -#define umul_ppmm (ph, pl, m0, m1) \ +#define umul_ppmm (ph, pl, m0, m1) \ do { \ USItype __m0 = (m0), __m1 = (m1); \ - __asm__ ("mulhwu %0,%1,%2" \ - : "=r" ((USItype)(ph)) \ - : "%r" (__m0), \ - "r" (__m1)); \ + __asm__ ("mulhwu %0,%1,%2" : "=r" (ph) : "%r" (m0), "r" (m1)); \ (pl) = __m0 * __m1; \ } while (0)
@@ -312,9 +277,10 @@* significant bit of DENOMINATOR must be 1, then the pre-processor symbol * UDIV_NEEDS_NORMALIZATION is defined to 1. */ -#define udiv_qrnnd (q, r, n1, n0, d) \ +#define udiv_qrnnd (q, r, n1, n0, d) \ do { \ - UWtype __d1, __d0, __q1, __q0, __r1, __r0, __m; \ + UWtype __d1, __d0, __q1, __q0; \ + UWtype __r1, __r0, __m; \ __d1 = __ll_highpart (d); \ __d0 = __ll_lowpart (d); \ \
@@ -325,7 +291,7 @@if (__r1 < __m) \ { \ __q1--, __r1 += (d); \ -if (__r1 >= (d))/* we didn't get carry when adding to __r1 */ \ +if (__r1 >= (d))/* i.e. we didn't get carry when adding to __r1 */ \if (__r1 < __m) \ __q1--, __r1 += (d); \ } \
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 49/162 MIPS: OCTEON: cvmx_pko_mem_debug8: use oldest forward compatible definition
In reply to Greg Kroah-HartmanFrom: Aaro Koskinen <[email protected]>
[ Upstream commit 1c6121c39677175bd372076020948e184bad4b6b ]
cn58xx is compatible with cn50xx, so use the latter.
--- arch/mips/cavium-octeon/executive/cvmx-cmd-queue.c | 2 +- arch/mips/include/asm/octeon/cvmx-pko.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
arch/mips/cavium-octeon/executive/cvmx-cmd-queue.c +1 -1
@@ -266,7 +266,7 @@ int cvmx_cmd_queue_length(cvmx_cmd_queue_id_t queue_id) }else {union cvmx_pko_mem_debug8 debug8; debug8.u64 =cvmx_read_csr (CVMX_PKO_MEM_DEBUG8 ); -return debug8.cn58xx.doorbell; +return debug8.cn50xx.doorbell; }case CVMX_CMD_QUEUE_ZIP :case CVMX_CMD_QUEUE_DFA :
arch/mips/include/asm/octeon/cvmx-pko.h +1 -1
@@ -611,7 +611,7 @@ static inline void cvmx_pko_get_port_status(uint64_t port_num, uint64_t clear, pko_reg_read_idx.s.index =cvmx_pko_get_base_queue (port_num);cvmx_write_csr (CVMX_PKO_REG_READ_IDX , pko_reg_read_idx.u64); debug8.u64 =cvmx_read_csr (CVMX_PKO_MEM_DEBUG8 ); - status->doorbell = debug8.cn58xx.doorbell; + status->doorbell = debug8.cn50xx.doorbell; } }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 50/162 nfsd: Return EPERM, not EACCES, in some SETATTR cases
In reply to Greg Kroah-HartmanFrom: zhengbin <[email protected]>
[ Upstream commit 255fbca65137e25b12bced18ec9a014dc77ecda0 ]
As the man(2) page for utime/utimes states, EPERM is returned when the second parameter of utime or utimes is not NULL, the caller's effective UID does not match the owner of the file, and the caller is not privileged.
However, in a NFS directory mounted from knfsd, it will return EACCES (from nfsd_setattr-> fh_verify->nfsd_permission). This patch fixes that.
--- fs/nfsd/vfs.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-)
fs/nfsd/vfs.c +15 -2
@@ -387,10 +387,23 @@ nfsd_setattr(struct svc_rqst *rqstp, struct svc_fh *fhp, struct iattr *iap,bool get_write_count;bool size_change = (iap->ia_valid &ATTR_SIZE ); -if (iap->ia_valid & (ATTR_ATIME |ATTR_MTIME |ATTR_SIZE )) +if (iap->ia_valid &ATTR_SIZE ) { accmode |=NFSD_MAY_WRITE |NFSD_MAY_OWNER_OVERRIDE ; -if (iap->ia_valid &ATTR_SIZE ) ftype =S_IFREG ; + } + +/* +* If utimes(2) and friends are called with times not NULL, we should +* not set NFSD_MAY_WRITE bit. Otherwise fh_verify->nfsd_permission +* will return EACCESS, when the caller's effective UID does not match +* the owner of the file, and the caller is not privileged. In this +* situation, we should return EPERM(notify_change will return this). +*/ +if (iap->ia_valid & (ATTR_ATIME |ATTR_MTIME )) { + accmode |=NFSD_MAY_OWNER_OVERRIDE ; +if (!(iap->ia_valid & (ATTR_ATIME_SET |ATTR_MTIME_SET ))) + accmode |=NFSD_MAY_WRITE ; + }/* Callers that do fh_verify should do the fh_want_write: */ get_write_count = !fhp->fh_dentry;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 51/162 mlx4: Use snprintf instead of complicated strcpy
In reply to Greg Kroah-HartmanFrom: Qian Cai <[email protected]>
[ Upstream commit 0fbc9b8b4ea3f688a5da141a64f97aa33ad02ae9 ]
This fixes a compilation warning in sysfs.c
drivers/infiniband/hw/mlx4/sysfs.c:360:2: warning: 'strncpy' output may be truncated copying 8 bytes from a string of length 31 [-Wstringop-truncation]
By eliminating the temporary stack buffer.
--- drivers/infiniband/hw/mlx4/sysfs.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
drivers/infiniband/hw/mlx4/sysfs.c +4 -8
@@ -352,16 +352,12 @@ err:static void get_name (struct mlx4_ib_dev *dev,char *name,int i,int max) { -char base_name[9 ]; - -/* pci_name format is: bus:dev:func -> xxxx:yy:zz.n */ -strlcpy (name,pci_name (dev->dev->persist->pdev), max); -strncpy (base_name, name,8 );/*till xxxx:yy:*/ - base_name[8 ] ='\0' ; -/* with no ARI only 3 last bits are used so when the fn is higher than 8 +/* pci_name format is: bus:dev:func -> xxxx:yy:zz.n +* with no ARI only 3 last bits are used so when the fn is higher than 8 * need to add it to the dev num, so count in the last number will be * modulo 8 */ -sprintf (name,"%s%.2d.%d" , base_name, (i/8 ), (i%8 )); +snprintf (name, max,"%.8s%.2d.%d" ,pci_name (dev->dev->persist->pdev), + i /8 , i %8 ); }struct mlx4_port {
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 52/162 ARM: dts: sunxi: Fix PMU compatible strings
In reply to Greg Kroah-HartmanFrom: Rob Herring <[email protected]>
[ Upstream commit 5719ac19fc32d892434939c1756c2f9a8322e6ef ]
"arm,cortex-a15-pmu" is not a valid fallback compatible string for an Cortex-A7 PMU, so drop it.
--- arch/arm/boot/dts/sun6i-a31.dtsi | 2 +- arch/arm/boot/dts/sun7i-a20.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/sun6i-a31.dtsi +1 -1
@@ -167,7 +167,7 @@ }; pmu { - compatible = "arm,cortex-a7-pmu", "arm,cortex-a15-pmu"; + compatible = "arm,cortex-a7-pmu"; interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>,
arch/arm/boot/dts/sun7i-a20.dtsi +1 -1
@@ -167,7 +167,7 @@ }; pmu { - compatible = "arm,cortex-a7-pmu", "arm,cortex-a15-pmu"; + compatible = "arm,cortex-a7-pmu"; interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>; };
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 53/162 sched/fair: Scale bandwidth quota and period without losing quota/period ratio precision
In reply to Greg Kroah-HartmanFrom: Xuewei Zhang <[email protected]>
commit 4929a4e6faa0f13289a67cae98139e727f0d4a97 upstream.
The quota/period ratio is used to ensure a child task group won't get more bandwidth than the parent task group, and is calculated as:
normalized_cfs_quota() = [(quota_us << 20) / period_us]
If the quota/period ratio was changed during this scaling due to precision loss, it will cause inconsistency between parent and child task groups.
See below example:
A userspace container manager (kubelet) does three operations:
1) Create a parent cgroup, set quota to 1,000us and period to 10,000us.
2) Create a few children cgroups.
3) Set quota to 1,000us and period to 10,000us on a child cgroup.
These operations are expected to succeed. However, if the scaling of 147/128 happens before step 3, quota and period of the parent cgroup will be changed:
new_quota: 1148437ns, 1148us
new_period: 11484375ns, 11484us
And when step 3 comes in, the ratio of the child cgroup will be 104857, which will be larger than the parent cgroup ratio (104821), and will fail.
Scaling them by a factor of 2 will fix the problem.
--- kernel/sched/fair.c | 34 +++++++++++++++++++++------------- 1 file changed, 21 insertions(+), 13 deletions(-)
kernel/sched/fair.c +21 -13
@@ -4055,20 +4055,28 @@ static enum hrtimer_restart sched_cfs_peif (++count >3 ) {u64 new, old =ktime_to_ns (cfs_b->period); - new = (old *147 ) /128 ;/* ~115% */ - new =min (new, max_cfs_quota_period); +/* +* Grow period by a factor of 2 to avoid losing precision. +* Precision loss in the quota/period ratio can cause __cfs_schedulable +* to fail. +*/ + new = old *2 ; +if (new < max_cfs_quota_period) { + cfs_b->period =ns_to_ktime (new); + cfs_b->quota *=2 ; - cfs_b->period =ns_to_ktime (new); - -/* since max is 1s, this is limited to 1e9^2, which fits in u64 */ - cfs_b->quota *= new; - cfs_b->quota =div64_u64 (cfs_b->quota, old); - -pr_warn_ratelimited ( -"cfs_period_timer[cpu%d]: period too short, scaling up (new cfs_period_us %lld, cfs_quota_us = %lld)\n" , -smp_processor_id (), -div_u64 (new,NSEC_PER_USEC ), -div_u64 (cfs_b->quota,NSEC_PER_USEC )); +pr_warn_ratelimited ( +"cfs_period_timer[cpu%d]: period too short, scaling up (new cfs_period_us = %lld, cfs_quota_us = %lld)\n" , +smp_processor_id (), +div_u64 (new,NSEC_PER_USEC ), +div_u64 (cfs_b->quota,NSEC_PER_USEC )); + }else { +pr_warn_ratelimited ( +"cfs_period_timer[cpu%d]: period too short, but cannot scale up without losing precision (cfs_period_us = %lld, cfs_quota_us = %lld)\n" , +smp_processor_id (), +div_u64 (old,NSEC_PER_USEC ), +div_u64 (cfs_b->quota,NSEC_PER_USEC )); + }/* reset count so we don't come right back in here */ count =0 ;
Greg Kroah-Hartman
maintainerPATCH 54/162 fuse: verify nlink
In reply to Greg Kroah-HartmanFrom: Miklos Szeredi <[email protected]>
commit c634da718db9b2fac201df2ae1b1b095344ce5eb upstream.
When adding a new hard link, make sure that i_nlink doesn't overflow.
--- fs/fuse/dir.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/fuse/dir.c +2 -1
@@ -812,7 +812,8 @@ static int fuse_link(struct dentry *entrspin_lock (&fc->lock); fi->attr_version = ++fc->attr_version; -inc_nlink (inode); +if (likely (inode->i_nlink <UINT_MAX )) +inc_nlink (inode);spin_unlock (&fc->lock);fuse_invalidate_attr (inode);fuse_update_ctime (inode);
Greg Kroah-Hartman
maintainerPATCH 55/162 fuse: verify attributes
In reply to Greg Kroah-HartmanFrom: Miklos Szeredi <[email protected]>
commit eb59bd17d2fa6e5e84fba61a5ebdea984222e6d5 upstream.
If a filesystem returns negative inode sizes, future reads on the file were causing the cpu to spin on truncate_pagecache.
Create a helper to validate the attributes. This now does two things:
- check the file mode
- check if the file size fits in i_size without overflowing
--- fs/fuse/dir.c | 24 +++++++++++++++++------- fs/fuse/fuse_i.h | 2 ++ 2 files changed, 19 insertions(+), 7 deletions(-)
fs/fuse/dir.c +17 -7
@@ -240,7 +240,8 @@ static int fuse_dentry_revalidate(structkfree (forget);if (ret == -ENOMEM ) goto out; -if (ret || (outarg.attr.mode ^ inode->i_mode) &S_IFMT ) +if (ret ||fuse_invalid_attr (&outarg.attr) || + (outarg.attr.mode ^ inode->i_mode) &S_IFMT ) goto invalid; fuse_change_attributes(inode, &outarg.attr,
@@ -282,6 +283,12 @@ int fuse_valid_type(int m)S_ISBLK (m) ||S_ISFIFO (m) ||S_ISSOCK (m); } +bool fuse_invalid_attr (struct fuse_attr *attr) +{ +return !fuse_valid_type (attr->mode) || + attr->size >LLONG_MAX ; +} +int fuse_lookup_name (struct super_block *sb,u64 nodeid,struct qstr *name,struct fuse_entry_out *outarg,struct inode **inode) {
@@ -313,7 +320,7 @@ int fuse_lookup_name(struct super_block err = -EIO ;if (!outarg->nodeid) goto out_put_forget; -if (!fuse_valid_type (outarg->attr.mode)) +if (fuse_invalid_attr (&outarg->attr)) goto out_put_forget; *inode = fuse_iget(sb, outarg->nodeid, outarg->generation,
@@ -433,7 +440,8 @@ static int fuse_create_open(struct inode goto out_free_ff; err = -EIO ; -if (!S_ISREG (outentry.attr.mode) ||invalid_nodeid (outentry.nodeid)) +if (!S_ISREG (outentry.attr.mode) ||invalid_nodeid (outentry.nodeid) || +fuse_invalid_attr (&outentry.attr)) goto out_free_ff; ff->fh = outopen.fh;
@@ -539,7 +547,7 @@ static int create_new_entry(struct fuse_ goto out_put_forget_req; err = -EIO ; -if (invalid_nodeid (outarg.nodeid)) +if (invalid_nodeid (outarg.nodeid) ||fuse_invalid_attr (&outarg.attr)) goto out_put_forget_req;if ((outarg.attr.mode ^ mode) &S_IFMT )
@@ -893,7 +901,8 @@ static int fuse_do_getattr(struct inode args.out.args[0 ].value = &outarg; err =fuse_simple_request (fc, &args);if (!err) { -if ((inode->i_mode ^ outarg.attr.mode) &S_IFMT ) { +if (fuse_invalid_attr (&outarg.attr) || + (inode->i_mode ^ outarg.attr.mode) &S_IFMT ) {make_bad_inode (inode); err = -EIO ; }else {
@@ -1198,7 +1207,7 @@ static int fuse_direntplus_link(struct fif (invalid_nodeid (o->nodeid))return -EIO ; -if (!fuse_valid_type (o->attr.mode)) +if (fuse_invalid_attr (&o->attr))return -EIO ; fc =get_fuse_conn (dir);
@@ -1670,7 +1679,8 @@ int fuse_do_setattr(struct inode *inode, goto error; } -if ((inode->i_mode ^ outarg.attr.mode) &S_IFMT ) { +if (fuse_invalid_attr (&outarg.attr) || + (inode->i_mode ^ outarg.attr.mode) &S_IFMT ) {make_bad_inode (inode); err = -EIO ; goto error;
fs/fuse/fuse_i.h +2 -0
@@ -887,6 +887,8 @@ void fuse_ctl_remove_conn(struct fuse_co*/ int fuse_valid_type (int m); +bool fuse_invalid_attr (struct fuse_attr *attr); +/** * Is current process allowed to perform filesystem operation? */
Greg Kroah-Hartman
maintainerPATCH 56/162 ALSA: pcm: oss: Avoid potential buffer overflows
In reply to Greg Kroah-HartmanFrom: Takashi Iwai <[email protected]>
commit 4cc8d6505ab82db3357613d36e6c58a297f57f7c upstream.
syzkaller reported an invalid access in PCM OSS read, and this seems to be an overflow of the internal buffer allocated for a plugin. Since the rate plugin adjusts its transfer size dynamically, the calculation for the chained plugin might be bigger than the given buffer size in some extreme cases, which lead to such an buffer overflow as caught by KASAN.
Fix it by limiting the max transfer size properly by checking against the destination size in each plugin transfer callback.
--- sound/core/oss/linear.c | 2 ++ sound/core/oss/mulaw.c | 2 ++ sound/core/oss/route.c | 2 ++ 3 files changed, 6 insertions(+)
sound/core/oss/linear.c +2 -0
@@ -107,6 +107,8 @@ static snd_pcm_sframes_t linear_transfer } }#endif +if (frames > dst_channels[0 ].frames) + frames = dst_channels[0 ].frames;convert (plugin, src_channels, dst_channels, frames);return frames; }
sound/core/oss/mulaw.c +2 -0
@@ -269,6 +269,8 @@ static snd_pcm_sframes_t mulaw_transfer( } }#endif +if (frames > dst_channels[0 ].frames) + frames = dst_channels[0 ].frames; data = (struct mulaw_priv *)plugin->extra_data; data->func (plugin, src_channels, dst_channels, frames);return frames;
sound/core/oss/route.c +2 -0
@@ -57,6 +57,8 @@ static snd_pcm_sframes_t route_transfer(return -ENXIO ;if (frames ==0 )return 0 ; +if (frames > dst_channels[0 ].frames) + frames = dst_channels[0 ].frames; nsrcs = plugin->src_format.channels; ndsts = plugin->dst_format.channels;
Greg Kroah-Hartman
maintainerPATCH 57/162 Input: goodix - add upside-down quirk for Teclast X89 tablet
In reply to Greg Kroah-HartmanFrom: Hans de Goede <[email protected]>
commit df5b5e555b356662a5e4a23c6774fdfce8547d54 upstream.
The touchscreen on the Teclast X89 is mounted upside down in relation to the display orientation (the touchscreen itself is mounted upright, but the display is mounted upside-down). Add a quirk for this so that we send coordinates which match the display orientation.
--- drivers/input/touchscreen/goodix.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/input/touchscreen/goodix.c +9 -0
@@ -69,6 +69,15 @@ static const unsigned long goodix_irq_flstatic const struct dmi_system_id rotated_screen[] = { #if defined(CONFIG_DMI) && defined(CONFIG_X86) { + .ident ="Teclast X89" , + .matches = { +/* tPAD is too generic, also match on bios date */ +DMI_MATCH (DMI_BOARD_VENDOR ,"TECLAST" ), +DMI_MATCH (DMI_BOARD_NAME ,"tPAD" ), +DMI_MATCH (DMI_BIOS_DATE ,"12/19/2014" ), + }, + }, + { .ident ="WinBook TW100" , .matches = {DMI_MATCH (DMI_SYS_VENDOR ,"WinBook" ),
Greg Kroah-Hartman
maintainerPATCH 58/162 CIFS: Fix NULL-pointer dereference in smb2_push_mandatory_locks
In reply to Greg Kroah-HartmanFrom: Pavel Shilovsky <[email protected]>
commit 6f582b273ec23332074d970a7fb25bef835df71f upstream.
Currently when the client creates a cifsFileInfo structure for a newly opened file, it allocates a list of byte-range locks with a pointer to the new cfile and attaches this list to the inode's lock list. The latter happens before initializing all other fields, e.g. cfile->tlink. Thus a partially initialized cifsFileInfo structure becomes available to other threads that walk through the inode's lock list. One example of such a thread may be an oplock break worker thread that tries to push all cached byte-range locks. This causes NULL-pointer dereference in smb2_push_mandatory_locks() when accessing cfile->tlink:
[598428.945633] BUG: kernel NULL pointer dereference, address: 0000000000000038 ... [598428.945749] Workqueue: cifsoplockd cifs_oplock_break [cifs] [598428.945793] RIP: 0010:smb2_push_mandatory_locks+0xd6/0x5a0 [cifs] ... [598428.945834] Call Trace: [598428.945870] ? cifs_revalidate_mapping+0x45/0x90 [cifs] [598428.945901] cifs_oplock_break+0x13d/0x450 [cifs] [598428.945909] process_one_work+0x1db/0x380 [598428.945914] worker_thread+0x4d/0x400 [598428.945921] kthread+0x104/0x140 [598428.945925] ? process_one_work+0x380/0x380 [598428.945931] ? kthread_park+0x80/0x80 [598428.945937] ret_from_fork+0x35/0x40
Fix this by reordering initialization steps of the cifsFileInfo
structure: initialize all the fields first and then add the new byte-range lock list to the inode's lock list.
--- fs/cifs/file.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
fs/cifs/file.c +4 -3
@@ -312,9 +312,6 @@ cifs_new_fileinfo(struct cifs_fid *fid,INIT_LIST_HEAD (&fdlocks->locks); fdlocks->cfile = cfile; cfile->llist = fdlocks; -cifs_down_write (&cinode->lock_sem); -list_add (&fdlocks->llist, &cinode->llist); -up_write (&cinode->lock_sem); cfile->count =1 ; cfile->pid = current->tgid;
@@ -338,6 +335,10 @@ cifs_new_fileinfo(struct cifs_fid *fid, oplock =0 ; } +cifs_down_write (&cinode->lock_sem); +list_add (&fdlocks->llist, &cinode->llist); +up_write (&cinode->lock_sem); +spin_lock (&tcon->open_file_lock);if (fid->pending_open->oplock !=CIFS_OPLOCK_NO_CHANGE && oplock) oplock = fid->pending_open->oplock;
Greg Kroah-Hartman
maintainerPATCH 59/162 CIFS: Fix SMB2 oplock break processing
In reply to Greg Kroah-HartmanFrom: Pavel Shilovsky <[email protected]>
commit fa9c2362497fbd64788063288dc4e74daf977ebb upstream.
Even when mounting modern protocol version the server may be configured without supporting SMB2.1 leases and the client uses SMB2 oplock to optimize IO performance through local caching.
However there is a problem in oplock break handling that leads to missing a break notification on the client who has a file opened. It latter causes big latencies to other clients that are trying to open the same file.
The problem reproduces when there are multiple shares from the same server mounted on the client. The processing code tries to match persistent and volatile file ids from the break notification with an open file but it skips all share besides the first one. Fix this by looking up in all shares belonging to the server that issued the oplock break.
--- fs/cifs/smb2misc.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
fs/cifs/smb2misc.c +3 -4
@@ -582,10 +582,10 @@ smb2_is_valid_oplock_break(char *buffer,spin_lock (&cifs_tcp_ses_lock);list_for_each (tmp, &server->smb_ses_list) { ses = list_entry(tmp, struct cifs_ses, smb_ses_list); +list_for_each (tmp1, &ses->tcon_list) { tcon = list_entry(tmp1, struct cifs_tcon, tcon_list); -cifs_stats_inc (&tcon->stats.cifs_stats.num_oplock_brks);spin_lock (&tcon->open_file_lock);list_for_each (tmp2, &tcon->openFileList) { cfile = list_entry(tmp2, struct cifsFileInfo,
@@ -597,6 +597,8 @@ smb2_is_valid_oplock_break(char *buffer,continue ;cifs_dbg (FYI ,"file id match, oplock break\n" ); +cifs_stats_inc ( + &tcon->stats.cifs_stats.num_oplock_brks); cinode =CIFS_I (d_inode (cfile->dentry));spin_lock (&cfile->file_info_lock); if (!CIFS_CACHE_WRITE(cinode) &&
@@ -628,9 +630,6 @@ smb2_is_valid_oplock_break(char *buffer,return true; }spin_unlock (&tcon->open_file_lock); -spin_unlock (&cifs_tcp_ses_lock); -cifs_dbg (FYI ,"No matching file for oplock break\n" ); -return true; } }spin_unlock (&cifs_tcp_ses_lock);
Greg Kroah-Hartman
maintainerPATCH 60/162 tty: vt: keyboard: reject invalid keycodes
In reply to Greg Kroah-HartmanFrom: Dmitry Torokhov <[email protected]>
commit b2b2dd71e0859436d4e05b2f61f86140250ed3f8 upstream.
Do not try to handle keycodes that are too big, otherwise we risk doing out-of-bounds writes:
BUG: KASAN: global-out-of-bounds in clear_bit include/asm-generic/bitops-instrumented.h:56 [inline] BUG: KASAN: global-out-of-bounds in kbd_keycode drivers/tty/vt/keyboard.c:1411 [inline] BUG: KASAN: global-out-of-bounds in kbd_event+0xe6b/0x3790 drivers/tty/vt/keyboard.c:1495 Write of size 8 at addr ffffffff89a1b2d8 by task syz-executor108/1722 ... kbd_keycode drivers/tty/vt/keyboard.c:1411 [inline] kbd_event+0xe6b/0x3790 drivers/tty/vt/keyboard.c:1495 input_to_handler+0x3b6/0x4c0 drivers/input/input.c:118 input_pass_values.part.0+0x2e3/0x720 drivers/input/input.c:145 input_pass_values drivers/input/input.c:949 [inline] input_set_keycode+0x290/0x320 drivers/input/input.c:954 evdev_handle_set_keycode_v2+0xc4/0x120 drivers/input/evdev.c:882 evdev_do_ioctl drivers/input/evdev.c:1150 [inline]
In this case we were dealing with a fuzzed HID device that declared over 12K buttons, and while HID layer should not be reporting to us such big keycodes, we should also be defensive and reject invalid data ourselves as well.
--- drivers/tty/vt/keyboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/vt/keyboard.c +1 -1
@@ -1460,7 +1460,7 @@ static void kbd_event(struct input_handlif (event_type ==EV_MSC && event_code ==MSC_RAW &&HW_RAW (handle->dev))kbd_rawcode (value); -if (event_type ==EV_KEY ) +if (event_type ==EV_KEY && event_code <=KEY_MAX )kbd_keycode (event_code, value,HW_RAW (handle->dev));spin_unlock (&kbd_event_lock);
Greg Kroah-Hartman
maintainerPATCH 61/162 can: slcan: Fix use-after-free Read in slcan_open
In reply to Greg Kroah-HartmanFrom: Jouni Hogander <[email protected]>
commit 9ebd796e24008f33f06ebea5a5e6aceb68b51794 upstream.
Slcan_open doesn't clean-up device which registration failed from the slcan_devs device list. On next open this list is iterated and freed device is accessed. Fix this by calling slc_free_netdev in error path.
Driver/net/can/slcan.c is derived from slip.c. Use-after-free error was identified in slip_open by syzboz. Same bug is in slcan.c. Here is the trace from the Syzbot slip report:
__dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x197/0x210 lib/dump_stack.c:118 print_address_description.constprop.0.cold+0xd4/0x30b mm/kasan/report.c:374 __kasan_report.cold+0x1b/0x41 mm/kasan/report.c:506 kasan_report+0x12/0x20 mm/kasan/common.c:634 __asan_report_load8_noabort+0x14/0x20 mm/kasan/generic_report.c:132 sl_sync drivers/net/slip/slip.c:725 [inline] slip_open+0xecd/0x11b7 drivers/net/slip/slip.c:801 tty_ldisc_open.isra.0+0xa3/0x110 drivers/tty/tty_ldisc.c:469 tty_set_ldisc+0x30e/0x6b0 drivers/tty/tty_ldisc.c:596 tiocsetd drivers/tty/tty_io.c:2334 [inline] tty_ioctl+0xe8d/0x14f0 drivers/tty/tty_io.c:2594 vfs_ioctl fs/ioctl.c:46 [inline] file_ioctl fs/ioctl.c:509 [inline] do_vfs_ioctl+0xdb6/0x13e0 fs/ioctl.c:696 ksys_ioctl+0xab/0xd0 fs/ioctl.c:713 __do_sys_ioctl fs/ioctl.c:720 [inline] __se_sys_ioctl fs/ioctl.c:718 [inline] __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:718 do_syscall_64+0xfa/0x760 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x49/0xbe
--- drivers/net/can/slcan.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/can/slcan.c +1 -0
@@ -613,6 +613,7 @@ err_free_chan: sl->tty =NULL ; tty->disc_data =NULL ;clear_bit (SLF_INUSE , &sl->flags); +slc_free_netdev (sl->dev);free_netdev (sl->dev); err_exit:
Greg Kroah-Hartman
maintainerPATCH 62/162 jbd2: Fix possible overflow in jbd2_log_space_left()
In reply to Greg Kroah-HartmanFrom: Jan Kara <[email protected]>
commit add3efdd78b8a0478ce423bb9d4df6bd95e8b335 upstream.
When number of free space in the journal is very low, the arithmetic in jbd2_log_space_left() could underflow resulting in very high number of free blocks and thus triggering assertion failure in transaction commit code complaining there's not enough space in the journal:
J_ASSERT(journal->j_free > 1);
Properly check for the low number of free blocks.
--- include/linux/jbd2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/jbd2.h +2 -2
@@ -1440,7 +1440,7 @@ static inline int jbd2_space_needed(jour static inline unsigned long jbd2_log_space_left(journal_t *journal) { /* Allow for rounding errors */ - unsigned long free = journal->j_free - 32; + long free = journal->j_free - 32; if (journal->j_committing_transaction) { unsigned long committing = atomic_read(&journal->
@@ -1449,7 +1449,7 @@ static inline unsigned long jbd2_log_spa/* Transaction + control blocks */ free -= committing + (committing >>JBD2_CONTROL_BLOCKS_SHIFT ); } -return free; +return max_t (long, free,0 ); }/*
Greg Kroah-Hartman
maintainerPATCH 63/162 drm/i810: Prevent underflow in ioctl
In reply to Greg Kroah-HartmanFrom: Dan Carpenter <[email protected]>
commit 4f69851fbaa26b155330be35ce8ac393e93e7442 upstream.
The "used" variables here come from the user in the ioctl and it can be negative. It could result in an out of bounds write.
--- drivers/gpu/drm/i810/i810_dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i810/i810_dma.c +2 -2
@@ -723,7 +723,7 @@ static void i810_dma_dispatch_vertex(strif (nbox >I810_NR_SAREA_CLIPRECTS ) nbox =I810_NR_SAREA_CLIPRECTS ; -if (used >4 *1024 ) +if (used <0 || used >4 *1024 ) used =0 ;if (sarea_priv->dirty)
@@ -1043,7 +1043,7 @@ static void i810_dma_dispatch_mc(structif (u !=I810_BUF_CLIENT )DRM_DEBUG ("MC found buffer that isn't mine!\n" ); -if (used >4 *1024 ) +if (used <0 || used >4 *1024 ) used =0 ; sarea_priv->dirty =0x7f ;
Greg Kroah-Hartman
maintainerPATCH 64/162 KVM: x86: do not modify masked bits of shared MSRs
In reply to Greg Kroah-HartmanFrom: Paolo Bonzini <[email protected]>
commit de1fca5d6e0105c9d33924e1247e2f386efc3ece upstream.
"Shared MSRs" are guest MSRs that are written to the host MSRs but keep their value until the next return to userspace. They support a mask, so that some bits keep the host value, but this mask is only used to skip an unnecessary MSR write and the value written to the MSR is always the guest MSR.
Fix this and, while at it, do not update smsr->values[slot].curr if for whatever reason the wrmsr fails. This should only happen due to reserved bits, so the value written to smsr->values[slot].curr will not match when the user-return notifier and the host value will always be restored. However, it is untidy and in rare cases this can actually avoid spurious WRMSRs on return to userspace.
--- arch/x86/kvm/x86.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
arch/x86/kvm/x86.c +3 -2
@@ -260,13 +260,14 @@ int kvm_set_shared_msr(unsigned slot, u6struct kvm_shared_msrs *smsr =per_cpu_ptr (shared_msrs, cpu);int err; -if (((value ^ smsr->values[slot].curr) & mask) ==0 ) + value = (value & mask) | (smsr->values[slot].host & ~mask); +if (value == smsr->values[slot].curr)return 0 ; - smsr->values[slot].curr = value; err =wrmsrl_safe (shared_msrs_global.msrs[slot], value);if (err)return 1 ; + smsr->values[slot].curr = value;if (!smsr->registered) { smsr->urn.on_user_return = kvm_on_user_return;user_return_notifier_register (&smsr->urn);
Greg Kroah-Hartman
maintainerPATCH 65/162 KVM: x86: fix presentation of TSX feature in ARCH_CAPABILITIES
In reply to Greg Kroah-HartmanFrom: Paolo Bonzini <[email protected]>
commit cbbaa2727aa3ae9e0a844803da7cef7fd3b94f2b upstream.
KVM does not implement MSR_IA32_TSX_CTRL, so it must not be presented to the guests. It is also confusing to have !ARCH_CAP_TSX_CTRL_MSR && !RTM && ARCH_CAP_TAA_NO: lack of MSR_IA32_TSX_CTRL suggests TSX was not hidden (it actually was), yet the value says that TSX is not vulnerable to microarchitectural data sampling. Fix both.
--- arch/x86/kvm/x86.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
arch/x86/kvm/x86.c +7 -2
@@ -1024,10 +1024,15 @@ u64 kvm_get_arch_capabilities(void)* If TSX is disabled on the system, guests are also mitigated against * TAA and clear CPU buffer mitigation is not required for guests. */ -if (boot_cpu_has_bug (X86_BUG_TAA ) &&boot_cpu_has (X86_FEATURE_RTM ) && - (data &ARCH_CAP_TSX_CTRL_MSR )) +if (!boot_cpu_has (X86_FEATURE_RTM )) + data &= ~ARCH_CAP_TAA_NO ; +else if (!boot_cpu_has_bug (X86_BUG_TAA )) + data |=ARCH_CAP_TAA_NO ; +else if (data &ARCH_CAP_TSX_CTRL_MSR ) data &= ~ARCH_CAP_MDS_NO ; +/* KVM does not emulate MSR_IA32_TSX_CTRL. */ + data &= ~ARCH_CAP_TSX_CTRL_MSR ;return data; }
Greg Kroah-Hartman
maintainerPATCH 66/162 crypto: crypto4xx - fix double-free in crypto4xx_destroy_sdr
In reply to Greg Kroah-HartmanFrom: Christian Lamparter <[email protected]>
commit 746c908c4d72e49068ab216c3926d2720d71a90d upstream.
This patch fixes a crash that can happen during probe when the available dma memory is not enough (this can happen if the crypto4xx is built as a module).
The descriptor window mapping would end up being free'd twice, once in crypto4xx_build_pdr() and the second time in crypto4xx_destroy_sdr().
--- drivers/crypto/amcc/crypto4xx_core.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/crypto/amcc/crypto4xx_core.c +1 -5
@@ -399,12 +399,8 @@ static u32 crypto4xx_build_sdr(struct crdma_alloc_coherent (dev->core_dev->device, dev->scatter_buffer_size *PPC4XX_NUM_SD , &dev->scatter_buffer_pa,GFP_ATOMIC ); -if (!dev->scatter_buffer_va) { -dma_free_coherent (dev->core_dev->device, -sizeof (struct ce_sd ) *PPC4XX_NUM_SD , - dev->sdr, dev->sdr_pa); +if (!dev->scatter_buffer_va)return -ENOMEM ; - } sd_array = dev->sdr;
Greg Kroah-Hartman
maintainerPATCH 67/162 crypto: user - fix memory leak in crypto_report
In reply to Greg Kroah-HartmanFrom: Navid Emamdoost <[email protected]>
commit ffdde5932042600c6807d46c1550b28b0db6a3bc upstream.
In crypto_report, a new skb is created via nlmsg_new(). This skb should be released if crypto_report_alg() fails.
--- crypto/crypto_user.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
crypto/crypto_user.c +3 -1
@@ -249,8 +249,10 @@ static int crypto_report(struct sk_buff drop_alg:crypto_mod_put (alg); -if (err) +if (err) { +kfree_skb (skb);return err; + }return nlmsg_unicast (crypto_nlsk, skb,NETLINK_CB (in_skb).portid); }
Greg Kroah-Hartman
maintainerPATCH 68/162 spi: atmel: Fix CS high support
In reply to Greg Kroah-HartmanFrom: Gregory CLEMENT <[email protected]>
commit 7cbb16b2122c09f2ae393a1542fed628505b9da6 upstream.
Until a few years ago, this driver was only used with CS GPIO. The only exception is CS0 on AT91RM9200 which has to use internal CS. A limitation of the internal CS is that they don't support CS High.
So by using the CS GPIO the CS high configuration was available except for the particular case CS0 on RM9200.
When the support for the internal chip-select was added, the check of the CS high support was not updated. Due to this the driver accepts this configuration for all the SPI controller v2 (used by all SoCs excepting the AT91RM9200) whereas the hardware doesn't support it for infernal CS.
This patch fixes the test to match the hardware capabilities.
--- drivers/spi/spi-atmel.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/spi/spi-atmel.c +2 -4
@@ -1209,10 +1209,8 @@ static int atmel_spi_setup(struct spi_de as =spi_master_get_devdata (spi->master);/* see notes above re chipselect */ -if (!atmel_spi_is_v2 (as) - && spi->chip_select ==0 - && (spi->mode &SPI_CS_HIGH )) { -dev_dbg (&spi->dev,"setup: can't be active-high\n" ); +if (!as->use_cs_gpios && (spi->mode &SPI_CS_HIGH )) { +dev_warn (&spi->dev,"setup: non GPIO CS can't be active-high\n" );return -EINVAL ; }
Greg Kroah-Hartman
maintainerPATCH 69/162 RDMA/qib: Validate ->show()/store() callbacks before calling them
In reply to Greg Kroah-HartmanFrom: Viresh Kumar <[email protected]>
commit 7ee23491b39259ae83899dd93b2a29ef0f22f0a7 upstream.
The permissions of the read-only or write-only sysfs files can be changed (as root) and the user can then try to read a write-only file or write to a read-only file which will lead to kernel crash here.
Protect against that by always validating the show/store callbacks.
--- drivers/infiniband/hw/qib/qib_sysfs.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/infiniband/hw/qib/qib_sysfs.c +6 -0
@@ -301,6 +301,9 @@ static ssize_t qib_portattr_show(structstruct qib_pportdata *ppd = container_of(kobj, struct qib_pportdata, pport_kobj); +if (!pattr->show) +return -EIO ; +return pattr->show (ppd, buf); }
@@ -312,6 +315,9 @@ static ssize_t qib_portattr_store(structstruct qib_pportdata *ppd = container_of(kobj, struct qib_pportdata, pport_kobj); +if (!pattr->store) +return -EIO ; +return pattr->store (ppd, buf, len); }
Greg Kroah-Hartman
maintainerPATCH 70/162 thermal: Fix deadlock in thermal thermal_zone_device_check
In reply to Greg Kroah-HartmanFrom: Wei Wang <[email protected]>
commit 163b00cde7cf2206e248789d2780121ad5e6a70b upstream.
1851799e1d29 ("thermal: Fix use-after-free when unregistering thermal zone device") changed cancel_delayed_work to cancel_delayed_work_sync to avoid a use-after-free issue. However, cancel_delayed_work_sync could be called insides the WQ causing deadlock.
[54109.642398] c0 1162 kworker/u17:1 D 0 11030 2 0x00000000 [54109.642437] c0 1162 Workqueue: thermal_passive_wq thermal_zone_device_check [54109.642447] c0 1162 Call trace: [54109.642456] c0 1162 __switch_to+0x138/0x158 [54109.642467] c0 1162 __schedule+0xba4/0x1434 [54109.642480] c0 1162 schedule_timeout+0xa0/0xb28 [54109.642492] c0 1162 wait_for_common+0x138/0x2e8 [54109.642511] c0 1162 flush_work+0x348/0x40c [54109.642522] c0 1162 __cancel_work_timer+0x180/0x218 [54109.642544] c0 1162 handle_thermal_trip+0x2c4/0x5a4 [54109.642553] c0 1162 thermal_zone_device_update+0x1b4/0x25c [54109.642563] c0 1162 thermal_zone_device_check+0x18/0x24 [54109.642574] c0 1162 process_one_work+0x3cc/0x69c [54109.642583] c0 1162 worker_thread+0x49c/0x7c0 [54109.642593] c0 1162 kthread+0x17c/0x1b0 [54109.642602] c0 1162 ret_from_fork+0x10/0x18 [54109.643051] c0 1162 kworker/u17:2 D 0 16245 2 0x00000000 [54109.643067] c0 1162 Workqueue: thermal_passive_wq thermal_zone_device_check [54109.643077] c0 1162 Call trace: [54109.643085] c0 1162 __switch_to+0x138/0x158 [54109.643095] c0 1162 __schedule+0xba4/0x1434 [54109.643104] c0 1162 schedule_timeout+0xa0/0xb28 [54109.643114] c0 1162 wait_for_common+0x138/0x2e8 [54109.643122] c0 1162 flush_work+0x348/0x40c [54109.643131] c0 1162 __cancel_work_timer+0x180/0x218 [54109.643141] c0 1162 handle_thermal_trip+0x2c4/0x5a4 [54109.643150] c0 1162 thermal_zone_device_update+0x1b4/0x25c [54109.643159] c0 1162 thermal_zone_device_check+0x18/0x24 [54109.643167] c0 1162 process_one_work+0x3cc/0x69c [54109.643177] c0 1162 worker_thread+0x49c/0x7c0 [54109.643186] c0 1162 kthread+0x17c/0x1b0 [54109.643195] c0 1162 ret_from_fork+0x10/0x18 [54109.644500] c0 1162 cat D 0 7766 1 0x00000001 [54109.644515] c0 1162 Call trace: [54109.644524] c0 1162 __switch_to+0x138/0x158 [54109.644536] c0 1162 __schedule+0xba4/0x1434 [54109.644546] c0 1162 schedule_preempt_disabled+0x80/0xb0 [54109.644555] c0 1162 __mutex_lock+0x3a8/0x7f0 [54109.644563] c0 1162 __mutex_lock_slowpath+0x14/0x20 [54109.644575] c0 1162 thermal_zone_get_temp+0x84/0x360 [54109.644586] c0 1162 temp_show+0x30/0x78 [54109.644609] c0 1162 dev_attr_show+0x5c/0xf0 [54109.644628] c0 1162 sysfs_kf_seq_show+0xcc/0x1a4 [54109.644636] c0 1162 kernfs_seq_show+0x48/0x88 [54109.644656] c0 1162 seq_read+0x1f4/0x73c [54109.644664] c0 1162 kernfs_fop_read+0x84/0x318 [54109.644683] c0 1162 __vfs_read+0x50/0x1bc [54109.644692] c0 1162 vfs_read+0xa4/0x140 [54109.644701] c0 1162 SyS_read+0xbc/0x144 [54109.644708] c0 1162 el0_svc_naked+0x34/0x38 [54109.845800] c0 1162 D 720.000s 1->7766->7766 cat [panic]
--- drivers/thermal/thermal_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/thermal/thermal_core.c +2 -2
@@ -402,7 +402,7 @@ static void thermal_zone_device_set_pollmod_delayed_work (system_freezable_wq, &tz->poll_queue,msecs_to_jiffies (delay)); else - cancel_delayed_work_sync(&tz->poll_queue); + cancel_delayed_work(&tz->poll_queue); }static void monitor_thermal_zone (struct thermal_zone_device *tz)
@@ -2002,7 +2002,7 @@ void thermal_zone_device_unregister(strumutex_unlock (&thermal_list_lock); -thermal_zone_device_set_polling (tz,0 ); +cancel_delayed_work_sync (&tz->poll_queue);if (tz->type[0 ])device_remove_file (&tz->device, &dev_attr_type);
Greg Kroah-Hartman
maintainerPATCH 71/162 KVM: x86: fix out-of-bounds write in KVM_GET_EMULATED_CPUID (CVE-2019-19332)
In reply to Greg Kroah-HartmanFrom: Paolo Bonzini <[email protected]>
commit 433f4ba1904100da65a311033f17a9bf586b287e upstream.
The bounds check was present in KVM_GET_SUPPORTED_CPUID but not KVM_GET_EMULATED_CPUID.
--- arch/x86/kvm/cpuid.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
arch/x86/kvm/cpuid.c +4 -1
@@ -373,7 +373,7 @@ static inline int __do_cpuid_ent(struct r = -E2BIG ; -if (*nent >= maxnent) +if (WARN_ON (*nent >= maxnent)) goto out;do_cpuid_1_ent (entry, function, index);
@@ -669,6 +669,9 @@ out:static int do_cpuid_ent (struct kvm_cpuid_entry2 *entry,u32 func,u32 idx,int *nent,int maxnent,unsigned int type) { +if (*nent >= maxnent) +return -E2BIG ; +if (type ==KVM_GET_EMULATED_CPUID )return __do_cpuid_ent_emulated (entry, func, idx, nent, maxnent);
Greg Kroah-Hartman
maintainerPATCH 72/162 appletalk: Fix potential NULL pointer dereference in unregister_snap_client
In reply to Greg Kroah-HartmanFrom: YueHaibing <[email protected]>
commit 9804501fa1228048857910a6bf23e085aade37cc upstream.
register_snap_client may return NULL, all the callers check it, but only print a warning. This will result in NULL pointer dereference in unregister_snap_client and other places.
It has always been used like this since v2.6
--- include/linux/atalk.h | 2 +- net/appletalk/aarp.c | 15 ++++++++++++--- net/appletalk/ddp.c | 20 ++++++++++++-------- 3 files changed, 25 insertions(+), 12 deletions(-)
include/linux/atalk.h +1 -1
@@ -107,7 +107,7 @@ static __inline__ struct elapaarp *aarp_#define AARP_RESOLVE_TIME (10 * HZ)extern struct datalink_proto *ddp_dl, *aarp_dl; -extern void aarp_proto_init (void ); +extern int aarp_proto_init (void );/* Inter module exports */
net/appletalk/aarp.c +12 -3
@@ -879,15 +879,24 @@ static struct notifier_block aarp_notifistatic unsigned char aarp_snap_id[] = {0x00 ,0x00 ,0x00 ,0x80 ,0xF3 }; -void __init aarp_proto_init (void ) +int __init aarp_proto_init (void ) { +int rc; + aarp_dl =register_snap_client (aarp_snap_id, aarp_rcv); -if (!aarp_dl) +if (!aarp_dl) {printk (KERN_CRIT "Unable to register AARP with SNAP.\n" ); +return -ENOMEM ; + }setup_timer (&aarp_timer, aarp_expire_timeout,0 ); aarp_timer.expires = jiffies + sysctl_aarp_expiry_time;add_timer (&aarp_timer); -register_netdevice_notifier (&aarp_notifier); + rc =register_netdevice_notifier (&aarp_notifier); +if (rc) { +del_timer_sync (&aarp_timer); +unregister_snap_client (aarp_dl); + } +return rc; }/* Remove the AARP entries associated with a device. */
net/appletalk/ddp.c +12 -8
@@ -1911,9 +1911,6 @@ static unsigned char ddp_snap_id[] = { 0EXPORT_SYMBOL (atrtr_get_dev);EXPORT_SYMBOL (atalk_find_dev_addr); -static const char atalk_err_snap[]__initconst = -KERN_CRIT "Unable to register DDP with SNAP.\n" ; -/* Called by proto.c on kernel start up */ static int __init atalk_init (void ) {
@@ -1928,17 +1925,22 @@ static int __init atalk_init(void) goto out_proto; ddp_dl =register_snap_client (ddp_snap_id, atalk_rcv); -if (!ddp_dl) -printk (atalk_err_snap); +if (!ddp_dl) { +pr_crit ("Unable to register DDP with SNAP.\n" ); + goto out_sock; + }dev_add_pack (<alk_packet_type);dev_add_pack (&ppptalk_packet_type); rc =register_netdevice_notifier (&ddp_notifier);if (rc) - goto out_sock; + goto out_snap; + + rc =aarp_proto_init (); +if (rc) + goto out_dev; -aarp_proto_init (); rc =atalk_proc_init ();if (rc) goto out_aarp;
@@ -1952,11 +1954,13 @@ out_proc:atalk_proc_exit (); out_aarp:aarp_cleanup_module (); +out_dev:unregister_netdevice_notifier (&ddp_notifier); -out_sock: +out_snap:dev_remove_pack (&ppptalk_packet_type);dev_remove_pack (<alk_packet_type);unregister_snap_client (ddp_dl); +out_sock:sock_unregister (PF_APPLETALK ); out_proto:proto_unregister (&ddp_proto);
Greg Kroah-Hartman
maintainerPATCH 73/162 appletalk: Set error code if register_snap_client failed
In reply to Greg Kroah-HartmanFrom: YueHaibing <[email protected]>
commit c93ad1337ad06a718890a89cdd85188ff9a5a5cc upstream.
If register_snap_client fails in atalk_init, error code should be set, otherwise it will triggers NULL pointer dereference while unloading module.
--- net/appletalk/ddp.c | 1 + 1 file changed, 1 insertion(+)
net/appletalk/ddp.c +1 -0
@@ -1927,6 +1927,7 @@ static int __init atalk_init(void) ddp_dl =register_snap_client (ddp_snap_id, atalk_rcv);if (!ddp_dl) {pr_crit ("Unable to register DDP with SNAP.\n" ); + rc = -ENOMEM ; goto out_sock; }
Greg Kroah-Hartman
maintainerPATCH 74/162 ALSA: hda - Fix pending unsol events at shutdown
In reply to Greg Kroah-HartmanFrom: Takashi Iwai <[email protected]>
[ Upstream commit ca58f55108fee41d87c9123f85ad4863e5de7f45 ]
This is an alternative fix attemp for the issue reported in the commit caa8422d01e9 ("ALSA: hda: Flush interrupts on disabling") that was reverted later due to regressions. Instead of tweaking the hardware disablement order and the enforced irq flushing, do calling cancel_work_sync() of the unsol work early enough, and explicitly ignore the unsol events during the shutdown by checking the bus->shutdown flag.
--- sound/pci/hda/hda_bind.c | 4 ++++ sound/pci/hda/hda_intel.c | 3 +++ 2 files changed, 7 insertions(+)
sound/pci/hda/hda_bind.c +4 -0
@@ -42,6 +42,10 @@ static void hda_codec_unsol_event(struct hdac_device *dev, unsigned int ev) { struct hda_codec *codec = container_of(dev, struct hda_codec, core); +/* ignore unsol events during shutdown */ +if (codec->bus->shutdown) +return ; +if (codec->patch_ops.unsol_event) codec->patch_ops.unsol_event (codec, ev); }
sound/pci/hda/hda_intel.c +3 -0
@@ -1310,8 +1310,11 @@ static int azx_free(struct azx *chip)static int azx_dev_disconnect (struct snd_device *device) {struct azx *chip = device->device_data; +struct hdac_bus *bus =azx_bus (chip); chip->bus.shutdown =1 ; +cancel_work_sync (&bus->unsol_work); +return 0 ; }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 75/162 sched/core: Allow putting thread_info into task_struct
In reply to Greg Kroah-HartmanFrom: Andy Lutomirski <[email protected]>
commit c65eacbe290b8141554c71b2c94489e73ade8c8d upstream.
If an arch opts in by setting CONFIG_THREAD_INFO_IN_TASK_STRUCT, then thread_info is defined as a single 'u32 flags' and is the first entry of task_struct. thread_info::task is removed (it serves no purpose if thread_info is embedded in task_struct), and thread_info::cpu gets its own slot in task_struct.
This is heavily based on a patch written by Linus.
Originally-from: Linus Torvalds <[email protected]>
--- include/linux/init_task.h | 9 +++++++++ include/linux/sched.h | 36 ++++++++++++++++++++++++++++++++++-- include/linux/thread_info.h | 15 +++++++++++++++ init/Kconfig | 7 +++++++ init/init_task.c | 7 +++++-- kernel/sched/sched.h | 4 ++++ 6 files changed, 74 insertions(+), 4 deletions(-)
include/linux/init_task.h +9 -0
@@ -15,6 +15,8 @@#include <net/net_namespace.h> #include <linux/sched/rt.h> +#include <asm/thread_info.h> +#ifdef CONFIG_SMP # define INIT_PUSHABLE_TASKS (tsk) \ .pushable_tasks = PLIST_NODE_INIT(tsk.pushable_tasks, MAX_PRIO),
@@ -183,12 +185,19 @@ extern struct task_group root_task_group# define INIT_KASAN (tsk)#endif +#ifdef CONFIG_THREAD_INFO_IN_TASK +# define INIT_TASK_TI (tsk) .thread_info = INIT_THREAD_INFO(tsk), +#else +# define INIT_TASK_TI (tsk) +#endif +/* * INIT_TASK is used to set up the first task table, touch at * your own risk!. Base=0, limit=0x1fffff (=2MB) */ #define INIT_TASK (tsk) \ { \ + INIT_TASK_TI(tsk) \ .state = 0, \ .stack = &init_thread_info, \ .usage = ATOMIC_INIT(2), \
include/linux/sched.h +34 -2
@@ -1389,6 +1389,13 @@ struct tlbflush_unmap_batch { };struct task_struct { +#ifdef CONFIG_THREAD_INFO_IN_TASK +/* +* For reasons of header soup (see current_thread_info()), this +* must be the first element of task_struct. +*/ +struct thread_info thread_info; +#endif volatile long state;/* -1 unrunnable, 0 runnable, >0 stopped */ void *stack;atomic_t usage;
@@ -1398,6 +1405,9 @@ struct task_struct {#ifdef CONFIG_SMP struct llist_node wake_entry;int on_cpu; +#ifdef CONFIG_THREAD_INFO_IN_TASK +unsigned int cpu;/* current CPU */ +#endif unsigned int wakee_flips;unsigned long wakee_flip_decay_ts;struct task_struct *last_wakee;
@@ -2440,7 +2450,9 @@ extern void set_curr_task(int cpu, strucvoid yield (void );union thread_union { +#ifndef CONFIG_THREAD_INFO_IN_TASK struct thread_info thread_info; +#endif unsigned long stack[THREAD_SIZE /sizeof (long )]; };
@@ -2840,10 +2852,26 @@ static inline void threadgroup_change_encgroup_threadgroup_change_end (tsk); } -#ifndef __HAVE_THREAD_FUNCTIONS +#ifdef CONFIG_THREAD_INFO_IN_TASK + +static inline struct thread_info *task_thread_info (struct task_struct *task) +{ +return &task->thread_info; +} +static inline void *task_stack_page (const struct task_struct *task) +{ +return task->stack; +} +#define setup_thread_stack (new,old) do { } while(0) +static inline unsigned long *end_of_stack (const struct task_struct *task) +{ +return task->stack; +} + +#elif !defined(__HAVE_THREAD_FUNCTIONS)#define task_thread_info (task) ((struct thread_info *)(task)->stack) -#define task_stack_page (task) ((task)->stack) +#define task_stack_page (task) ((void *)(task)->stack)static inline void setup_thread_stack (struct task_struct *p,struct task_struct *org) {
@@ -3135,7 +3163,11 @@ static inline void ptrace_signal_wake_upstatic inline unsigned int task_cpu (const struct task_struct *p) { +#ifdef CONFIG_THREAD_INFO_IN_TASK +return p->cpu; +#else return task_thread_info (p)->cpu; +#endif }static inline int task_node (const struct task_struct *p)
include/linux/thread_info.h +15 -0
@@ -13,6 +13,21 @@struct timespec ;struct compat_timespec ; +#ifdef CONFIG_THREAD_INFO_IN_TASK +struct thread_info { +u32 flags;/* low level flags */ +}; + +#define INIT_THREAD_INFO (tsk) \ +{ \ + .flags = 0, \ +} +#endif + +#ifdef CONFIG_THREAD_INFO_IN_TASK +#define current_thread_info () ((struct thread_info *)current) +#endif +/* * System call restart block. */
init/Kconfig +7 -0
@@ -26,6 +26,13 @@ config IRQ_WORK config BUILDTIME_EXTABLE_SORT bool +config THREAD_INFO_IN_TASK + bool + help + Select this to move thread_info off the stack into task_struct. To + make this work, an arch will need to remove all thread_info fields + except flags and fix any runtime bugs. + menu "General setup" config BROKEN
init/init_task.c +5 -2
@@ -22,5 +22,8 @@ EXPORT_SYMBOL(init_task);* Initial thread structure. Alignment of this is handled by a special * linker map entry. */ -union thread_union init_thread_union __init_task_data = - {INIT_THREAD_INFO (init_task) }; +union thread_union init_thread_union __init_task_data = { +#ifndef CONFIG_THREAD_INFO_IN_TASK +INIT_THREAD_INFO (init_task) +#endif +};
kernel/sched/sched.h +4 -0
@@ -978,7 +978,11 @@ static inline void __set_task_cpu(struct* per-task data have been completed by this moment. */ smp_wmb (); +#ifdef CONFIG_THREAD_INFO_IN_TASK + p->cpu = cpu; +#else task_thread_info (p)->cpu = cpu; +#endif p->wake_cpu = cpu;#endif }
Greg Kroah-Hartman
maintainerPATCH 76/162 sched/core: Add try_get_task_stack() and put_task_stack()
In reply to Greg Kroah-HartmanFrom: Andy Lutomirski <[email protected]>
commit c6c314a613cd7d03fb97713e0d642b493de42e69 upstream.
There are a few places in the kernel that access stack memory belonging to a different task. Before we can start freeing task stacks before the task_struct is freed, we need a way for those code paths to pin the stack.
--- include/linux/sched.h | 16 ++++++++++++++++ init/Kconfig | 3 +++ 2 files changed, 19 insertions(+)
include/linux/sched.h +16 -0
@@ -2858,11 +2858,19 @@ static inline struct thread_info *task_t {return &task->thread_info; } + +/* +* When accessing the stack of a non-current task that might exit, use +* try_get_task_stack() instead. task_stack_page will return a pointer +* that could get freed out from under you. +*/ static inline void *task_stack_page (const struct task_struct *task) {return task->stack; } +#define setup_thread_stack (new,old) do { } while(0) +static inline unsigned long *end_of_stack (const struct task_struct *task) {return task->stack;
@@ -2898,6 +2906,14 @@ static inline unsigned long *end_of_stac }#endif + +static inline void *try_get_task_stack (struct task_struct *tsk) +{ +return task_stack_page (tsk); +} + +static inline void put_task_stack (struct task_struct *tsk) {} +#define task_stack_end_corrupted (task) \ (*(end_of_stack(task)) != STACK_END_MAGIC)
init/Kconfig +3 -0
@@ -33,6 +33,9 @@ config THREAD_INFO_IN_TASK make this work, an arch will need to remove all thread_info fields except flags and fix any runtime bugs. + One subtle change that will be needed is to use try_get_task_stack() + and put_task_stack() in save_thread_stack_tsk() and get_wchan(). + menu "General setup" config BROKEN
Greg Kroah-Hartman
maintainerPATCH 77/162 sched/core, x86: Make struct thread_info arch specific again
In reply to Greg Kroah-HartmanFrom: Heiko Carstens <[email protected]>
commit c8061485a0d7569a865a3cc3c63347b0f42b3765 upstream.
The following commit:
c65eacbe290b ("sched/core: Allow putting thread_info into task_struct")
... made 'struct thread_info' a generic struct with only a single ::flags member, if CONFIG_THREAD_INFO_IN_TASK_STRUCT=y is selected.
This change however seems to be quite x86 centric, since at least the generic preemption code (asm-generic/preempt.h) assumes that struct thread_info also has a preempt_count member, which apparently was not true for x86.
We could add a bit more #ifdefs to solve this problem too, but it seems to be much simpler to make struct thread_info arch specific again. This also makes the conversion to THREAD_INFO_IN_TASK_STRUCT a bit easier for architectures that have a couple of arch specific stuff in their thread_info definition.
The arch specific stuff _could_ be moved to thread_struct. However keeping them in thread_info makes it easier: accessing thread_info members is simple, since it is at the beginning of the task_struct, while the thread_struct is at the end. At least on s390 the offsets needed to access members of the thread_struct (with task_struct as base) are too large for various asm instructions. This is not a problem when keeping these members within thread_info.
--- include/linux/thread_info.h | 11 ----------- 1 file changed, 11 deletions(-)
include/linux/thread_info.h +0 -11
@@ -14,17 +14,6 @@ struct timespec;struct compat_timespec ;#ifdef CONFIG_THREAD_INFO_IN_TASK -struct thread_info { -u32 flags;/* low level flags */ -}; - -#define INIT_THREAD_INFO (tsk) \ -{ \ - .flags = 0, \ -} -#endif - -#ifdef CONFIG_THREAD_INFO_IN_TASK #define current_thread_info () ((struct thread_info *)current)#endif
Greg Kroah-Hartman
maintainerPATCH 78/162 fs/proc: Stop reporting eip and esp in /proc/PID/stat
In reply to Greg Kroah-HartmanFrom: Andy Lutomirski <[email protected]>
commit 0a1eb2d474edfe75466be6b4677ad84e5e8ca3f5 upstream.
Reporting these fields on a non-current task is dangerous. If the task is in any state other than normal kernel code, they may contain garbage or even kernel addresses on some architectures. (x86_64 used to do this. I bet lots of architectures still do.) With CONFIG_THREAD_INFO_IN_TASK=y, it can OOPS, too.
As far as I know, there are no use programs that make any material use of these fields, so just get rid of them.
--- fs/proc/array.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
fs/proc/array.c +5 -4
@@ -425,10 +425,11 @@ static int do_task_stat(struct seq_file mm =get_task_mm (task);if (mm) { vsize =task_vsize (mm); -if (permitted) { - eip =KSTK_EIP (task); - esp =KSTK_ESP (task); - } +/* +* esp and eip are intentionally zeroed out. There is no +* non-racy way to read them without freezing the task. +* Programs that need reliable values can use ptrace(2). +*/ }get_task_comm (tcomm, task);
Greg Kroah-Hartman
maintainerPATCH 79/162 fs/proc: Report eip/esp in /prod/PID/stat for coredumping
In reply to Greg Kroah-HartmanFrom: John Ogness <[email protected]>
commit fd7d56270b526ca3ed0c224362e3c64a0f86687a upstream.
Commit 0a1eb2d474ed ("fs/proc: Stop reporting eip and esp in /proc/PID/stat") stopped reporting eip/esp because it is racy and dangerous for executing tasks. The comment adds:
As far as I know, there are no use programs that make any material use of these fields, so just get rid of them.
However, existing userspace core-dump-handler applications (for example, minicoredumper) are using these fields since they provide an excellent cross-platform interface to these valuable pointers. So that commit introduced a user space visible regression.
Partially revert the change and make the readout possible for tasks with the proper permissions and only if the target task has the PF_DUMPCORE flag set.
--- fs/proc/array.c | 8 ++++++++ 1 file changed, 8 insertions(+)
fs/proc/array.c +8 -0
@@ -429,7 +429,15 @@ static int do_task_stat(struct seq_file* esp and eip are intentionally zeroed out. There is no * non-racy way to read them without freezing the task. * Programs that need reliable values can use ptrace(2). +* +* The only exception is if the task is core dumping because +* a program is not able to use ptrace(2) in that case. It is +* safe because the task has stopped executing permanently. */ +if (permitted && (task->flags &PF_DUMPCORE )) { + eip =KSTK_EIP (task); + esp =KSTK_ESP (task); + } }get_task_comm (tcomm, task);
Greg Kroah-Hartman
maintainerPATCH 80/162 proc: fix coredump vs read /proc/*/stat race
In reply to Greg Kroah-HartmanFrom: Alexey Dobriyan <[email protected]>
commit 8bb2ee192e482c5d500df9f2b1b26a560bd3026f upstream.
do_task_stat() accesses IP and SP of a task without bumping reference count of a stack (which became an entity with independent lifetime at some point).
Steps to reproduce:
#include <stdio.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <sys/time.h>
#include <sys/resource.h>
#include <unistd.h>
#include <sys/wait.h>
int main(void)
{
setrlimit(RLIMIT_CORE, &(struct rlimit){});
while (1) {
char buf[64];
char buf2[4096];
pid_t pid;
int fd;
pid = fork();
if (pid == 0) {
*(volatile int *)0 = 0;
}
snprintf(buf, sizeof(buf), "/proc/%u/stat", pid);
fd = open(buf, O_RDONLY);
read(fd, buf2, sizeof(buf2));
close(fd);
waitpid(pid, NULL, 0);
}
return 0;
}
BUG: unable to handle kernel paging request at 0000000000003fd8
IP: do_task_stat+0x8b4/0xaf0
PGD 800000003d73e067 P4D 800000003d73e067 PUD 3d558067 PMD 0
Oops: 0000 [#1] PREEMPT SMP PTI
CPU: 0 PID: 1417 Comm: a.out Not tainted 4.15.0-rc8-dirty #2
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1.fc27 04/01/2014
RIP: 0010:do_task_stat+0x8b4/0xaf0
Call Trace:
proc_single_show+0x43/0x70
seq_read+0xe6/0x3b0
__vfs_read+0x1e/0x120
vfs_read+0x84/0x110
SyS_read+0x3d/0xa0
entry_SYSCALL_64_fastpath+0x13/0x6c
RIP: 0033:0x7f4d7928cba0
RSP: 002b:00007ffddb245158 EFLAGS: 00000246
Code: 03 b7 a0 01 00 00 4c 8b 4c 24 70 4c 8b 44 24 78 4c 89 74 24 18 e9 91 f9 ff ff f6 45 4d 02 0f 84 fd f7 ff ff 48 8b 45 40 48 89 ef <48> 8b 80 d8 3f 00 00 48 89 44 24 20 e8 9b 97 eb ff 48 89 44 24
RIP: do_task_stat+0x8b4/0xaf0 RSP: ffffc90000607cc8
CR2: 0000000000003fd8John Ogness said: for my tests I added an else case to verify that the race is hit and correctly mitigated.
--- fs/proc/array.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
fs/proc/array.c +5 -2
@@ -435,8 +435,11 @@ static int do_task_stat(struct seq_file* safe because the task has stopped executing permanently. */ if (permitted && (task->flags &PF_DUMPCORE )) { - eip =KSTK_EIP (task); - esp =KSTK_ESP (task); +if (try_get_task_stack (task)) { + eip =KSTK_EIP (task); + esp =KSTK_ESP (task); +put_task_stack (task); + } } }
Greg Kroah-Hartman
maintainerPATCH 81/162 fs/proc/array.c: allow reporting eip/esp for all coredumping threads
In reply to Greg Kroah-HartmanFrom: John Ogness <[email protected]>
commit cb8f381f1613cafe3aec30809991cd56e7135d92 upstream.
0a1eb2d474ed ("fs/proc: Stop reporting eip and esp in /proc/PID/stat") stopped reporting eip/esp and fd7d56270b52 ("fs/proc: Report eip/esp in /prod/PID/stat for coredumping") reintroduced the feature to fix a regression with userspace core dump handlers (such as minicoredumper).
Because PF_DUMPCORE is only set for the primary thread, this didn't fix the original problem for secondary threads. Allow reporting the eip/esp for all threads by checking for PF_EXITING as well. This is set for all the other threads when they are killed. coredump_wait() waits for all the tasks to become inactive before proceeding to invoke a core dumper.
--- fs/proc/array.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/proc/array.c +1 -1
@@ -434,7 +434,7 @@ static int do_task_stat(struct seq_file* a program is not able to use ptrace(2) in that case. It is * safe because the task has stopped executing permanently. */ -if (permitted && (task->flags &PF_DUMPCORE )) { +if (permitted && (task->flags & (PF_EXITING |PF_DUMPCORE ))) {if (try_get_task_stack (task)) { eip =KSTK_EIP (task); esp =KSTK_ESP (task);
Greg Kroah-Hartman
maintainerPATCH 82/162 usb: gadget: configfs: Fix missing spin_lock_init()
In reply to Greg Kroah-HartmanFrom: Wei Yongjun <[email protected]>
commit 093edc2baad2c258b1f55d1ab9c63c2b5ae67e42 upstream.
The driver allocates the spinlock but not initialize it. Use spin_lock_init() on it to initialize it correctly.
This is detected by Coccinelle semantic patch.
--- drivers/usb/gadget/configfs.c | 1 + 1 file changed, 1 insertion(+)
drivers/usb/gadget/configfs.c +1 -0
@@ -1542,6 +1542,7 @@ static struct config_group *gadgets_make gi->composite.resume =NULL ; gi->composite.max_speed =USB_SPEED_SUPER ; +spin_lock_init (&gi->spinlock);mutex_init (&gi->lock);INIT_LIST_HEAD (&gi->string_list);INIT_LIST_HEAD (&gi->available_func);
Greg Kroah-Hartman
maintainerPATCH 83/162 usb: Allow USB device to be warm reset in suspended state
In reply to Greg Kroah-HartmanFrom: Kai-Heng Feng <[email protected]>
commit e76b3bf7654c3c94554c24ba15a3d105f4006c80 upstream.
On Dell WD15 dock, sometimes USB ethernet cannot be detected after plugging cable to the ethernet port, the hub and roothub get runtime resumed and runtime suspended immediately:
...
[ 433.315169] xhci_hcd 0000:3a:00.0: hcd_pci_runtime_resume: 0 [ 433.315204] usb usb4: usb auto-resume [ 433.315226] hub 4-0:1.0: hub_resume [ 433.315239] xhci_hcd 0000:3a:00.0: Get port status 4-1 read: 0x10202e2, return 0x10343 [ 433.315264] usb usb4-port1: status 0343 change 0001 [ 433.315279] xhci_hcd 0000:3a:00.0: clear port1 connect change, portsc: 0x10002e2 [ 433.315293] xhci_hcd 0000:3a:00.0: Get port status 4-2 read: 0x2a0, return 0x2a0 [ 433.317012] xhci_hcd 0000:3a:00.0: xhci_hub_status_data: stopping port polling. [ 433.422282] xhci_hcd 0000:3a:00.0: Get port status 4-1 read: 0x10002e2, return 0x343 [ 433.422307] usb usb4-port1: do warm reset [ 433.422311] usb 4-1: device reset not allowed in state 8 [ 433.422339] hub 4-0:1.0: state 7 ports 2 chg 0002 evt 0000 [ 433.422346] xhci_hcd 0000:3a:00.0: Get port status 4-1 read: 0x10002e2, return 0x343 [ 433.422356] usb usb4-port1: do warm reset [ 433.422358] usb 4-1: device reset not allowed in state 8 [ 433.422428] xhci_hcd 0000:3a:00.0: set port remote wake mask, actual port 0 status = 0xf0002e2 [ 433.422455] xhci_hcd 0000:3a:00.0: set port remote wake mask, actual port 1 status = 0xe0002a0 [ 433.422465] hub 4-0:1.0: hub_suspend [ 433.422475] usb usb4: bus auto-suspend, wakeup 1 [ 433.426161] xhci_hcd 0000:3a:00.0: xhci_hub_status_data: stopping port polling. [ 433.466209] xhci_hcd 0000:3a:00.0: port 0 polling in bus suspend, waiting [ 433.510204] xhci_hcd 0000:3a:00.0: port 0 polling in bus suspend, waiting [ 433.554051] xhci_hcd 0000:3a:00.0: port 0 polling in bus suspend, waiting [ 433.598235] xhci_hcd 0000:3a:00.0: port 0 polling in bus suspend, waiting [ 433.642154] xhci_hcd 0000:3a:00.0: port 0 polling in bus suspend, waiting [ 433.686204] xhci_hcd 0000:3a:00.0: port 0 polling in bus suspend, waiting [ 433.730205] xhci_hcd 0000:3a:00.0: port 0 polling in bus suspend, waiting [ 433.774203] xhci_hcd 0000:3a:00.0: port 0 polling in bus suspend, waiting [ 433.818207] xhci_hcd 0000:3a:00.0: port 0 polling in bus suspend, waiting [ 433.862040] xhci_hcd 0000:3a:00.0: port 0 polling in bus suspend, waiting [ 433.862053] xhci_hcd 0000:3a:00.0: xhci_hub_status_data: stopping port polling. [ 433.862077] xhci_hcd 0000:3a:00.0: xhci_suspend: stopping port polling. [ 433.862096] xhci_hcd 0000:3a:00.0: // Setting command ring address to 0x8578fc001 [ 433.862312] xhci_hcd 0000:3a:00.0: hcd_pci_runtime_suspend: 0 [ 433.862445] xhci_hcd 0000:3a:00.0: PME# enabled [ 433.902376] xhci_hcd 0000:3a:00.0: restoring config space at offset 0xc (was 0x0, writing 0x20) [ 433.902395] xhci_hcd 0000:3a:00.0: restoring config space at offset 0x4 (was 0x100000, writing 0x100403) [ 433.902490] xhci_hcd 0000:3a:00.0: PME# disabled [ 433.902504] xhci_hcd 0000:3a:00.0: enabling bus mastering [ 433.902547] xhci_hcd 0000:3a:00.0: // Setting command ring address to 0x8578fc001 [ 433.902649] pcieport 0000:00:1b.0: PME: Spurious native interrupt! [ 433.902839] xhci_hcd 0000:3a:00.0: Port change event, 4-1, id 3, portsc: 0xb0202e2 [ 433.902842] xhci_hcd 0000:3a:00.0: resume root hub [ 433.902845] xhci_hcd 0000:3a:00.0: handle_port_status: starting port polling. [ 433.902877] xhci_hcd 0000:3a:00.0: xhci_resume: starting port polling. [ 433.902889] xhci_hcd 0000:3a:00.0: xhci_hub_status_data: stopping port polling. [ 433.902891] xhci_hcd 0000:3a:00.0: hcd_pci_runtime_resume: 0 [ 433.902919] usb usb4: usb wakeup-resume [ 433.902942] usb usb4: usb auto-resume [ 433.902966] hub 4-0:1.0: hub_resume
...
As Mathias pointed out, the hub enters Cold Attach Status state and requires a warm reset. However usb_reset_device() bails out early when the device is in suspended state, as its callers port_event() and hub_event() don't always resume the device.
Since there's nothing wrong to reset a suspended device, allow usb_reset_device() to do so to solve the issue.
--- drivers/usb/core/hub.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/usb/core/hub.c +2 -3
@@ -5554,7 +5554,7 @@ re_enumerate_no_bos:/** * usb_reset_device - warn interface drivers and perform a USB port reset -* @udev: device to reset (not in SUSPENDED or NOTATTACHED state) +* @udev: device to reset (not in NOTATTACHED state) * * Warns all drivers bound to registered interfaces (using their pre_reset * method), performs the port reset, and then lets the drivers know that
@@ -5582,8 +5582,7 @@ int usb_reset_device(struct usb_device *struct usb_host_config *config = udev->actconfig;struct usb_hub *hub =usb_hub_to_struct_hub (udev->parent); -if (udev->state ==USB_STATE_NOTATTACHED || - udev->state ==USB_STATE_SUSPENDED ) { +if (udev->state ==USB_STATE_NOTATTACHED ) {dev_dbg (&udev->dev,"device reset not allowed in state %d\n" , udev->state);return -EINVAL ;
Greg Kroah-Hartman
maintainerPATCH 84/162 staging: rtl8188eu: fix interface sanity check
In reply to Greg Kroah-HartmanFrom: Johan Hovold <[email protected]>
commit 74ca34118a0e05793935d804ccffcedd6eb56596 upstream.
Make sure to use the current alternate setting when verifying the interface descriptors to avoid binding to an invalid interface.
Failing to do so could cause the driver to misbehave or trigger a WARN() in usb_submit_urb() that kernels with panic_on_warn set would choke on.
--- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/os_dep/usb_intf.c +1 -1
@@ -82,7 +82,7 @@ static struct dvobj_priv *usb_dvobj_init phost_conf = pusbd->actconfig; pconf_desc = &phost_conf->desc; - phost_iface = &usb_intf->altsetting[0 ]; + phost_iface = usb_intf->cur_altsetting; piface_desc = &phost_iface->desc; pdvobjpriv->NumInterfaces = pconf_desc->bNumInterfaces;
Greg Kroah-Hartman
maintainerPATCH 85/162 staging: rtl8712: fix interface sanity check
In reply to Greg Kroah-HartmanFrom: Johan Hovold <[email protected]>
commit c724f776f048538ecfdf53a52b7a522309f5c504 upstream.
Make sure to use the current alternate setting when verifying the interface descriptors to avoid binding to an invalid interface.
Failing to do so could cause the driver to misbehave or trigger a WARN() in usb_submit_urb() that kernels with panic_on_warn set would choke on.
--- drivers/staging/rtl8712/usb_intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/usb_intf.c +1 -1
@@ -263,7 +263,7 @@ static uint r8712_usb_dvobj_init(struct pdvobjpriv->padapter = padapter; padapter->EepromAddressSize =6 ; - phost_iface = &pintf->altsetting[0 ]; + phost_iface = pintf->cur_altsetting; piface_desc = &phost_iface->desc; pdvobjpriv->nr_endpoint = piface_desc->bNumEndpoints;if (pusbd->speed ==USB_SPEED_HIGH ) {
Greg Kroah-Hartman
maintainerPATCH 86/162 staging: gigaset: fix general protection fault on probe
In reply to Greg Kroah-HartmanFrom: Johan Hovold <[email protected]>
commit 53f35a39c3860baac1e5ca80bf052751cfb24a99 upstream.
Fix a general protection fault when accessing the endpoint descriptors which could be triggered by a malicious device due to missing sanity checks on the number of endpoints.
--- drivers/isdn/gigaset/usb-gigaset.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/isdn/gigaset/usb-gigaset.c +5 -0
@@ -688,6 +688,11 @@ static int gigaset_probe(struct usb_intereturn -ENODEV ; } +if (hostif->desc.bNumEndpoints <2 ) { +dev_err (&interface->dev,"missing endpoints\n" ); +return -ENODEV ; + } +dev_info (&udev->dev,"%s: Device matched ... !\n" , __func__);/* allocate memory for our device state and initialize it */
Greg Kroah-Hartman
maintainerPATCH 87/162 staging: gigaset: fix illegal free on probe errors
In reply to Greg Kroah-HartmanFrom: Johan Hovold <[email protected]>
commit 84f60ca7b326ed8c08582417493982fe2573a9ad upstream.
The driver failed to initialise its receive-buffer pointer, something which could lead to an illegal free on late probe errors.
Fix this by making sure to clear all driver data at allocation.
--- drivers/isdn/gigaset/usb-gigaset.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/isdn/gigaset/usb-gigaset.c +1 -5
@@ -574,8 +574,7 @@ static int gigaset_initcshw(struct cards {struct usb_cardstate *ucs; - cs->hw.usb = ucs = -kmalloc (sizeof (struct usb_cardstate ),GFP_KERNEL ); + cs->hw.usb = ucs =kzalloc (sizeof (struct usb_cardstate ),GFP_KERNEL );if (!ucs) {pr_err ("out of memory\n" );return -ENOMEM ;
@@ -587,9 +586,6 @@ static int gigaset_initcshw(struct cards ucs->bchars[3 ] =0 ; ucs->bchars[4 ] =0x11 ; ucs->bchars[5 ] =0x13 ; - ucs->bulk_out_buffer =NULL ; - ucs->bulk_out_urb =NULL ; - ucs->read_urb =NULL ;tasklet_init (&cs->write_tasklet, gigaset_modem_fill, (unsigned long ) cs);
Greg Kroah-Hartman
maintainerPATCH 88/162 staging: gigaset: add endpoint-type sanity check
In reply to Greg Kroah-HartmanFrom: Johan Hovold <[email protected]>
commit ed9ed5a89acba51b82bdff61144d4e4a4245ec8a upstream.
Add missing endpoint-type sanity checks to probe.
This specifically prevents a warning in USB core on URB submission when fuzzing USB descriptors.
--- drivers/isdn/gigaset/usb-gigaset.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
drivers/isdn/gigaset/usb-gigaset.c +12 -0
@@ -708,6 +708,12 @@ static int gigaset_probe(struct usb_inte endpoint = &hostif->endpoint[0 ].desc; +if (!usb_endpoint_is_bulk_out (endpoint)) { +dev_err (&interface->dev,"missing bulk-out endpoint\n" ); + retval = -ENODEV ; + goto error; + } + buffer_size =le16_to_cpu (endpoint->wMaxPacketSize); ucs->bulk_out_size = buffer_size; ucs->bulk_out_epnum =usb_endpoint_num (endpoint);
@@ -727,6 +733,12 @@ static int gigaset_probe(struct usb_inte endpoint = &hostif->endpoint[1 ].desc; +if (!usb_endpoint_is_int_in (endpoint)) { +dev_err (&interface->dev,"missing int-in endpoint\n" ); + retval = -ENODEV ; + goto error; + } + ucs->busy =0 ; ucs->read_urb =usb_alloc_urb (0 ,GFP_KERNEL );
Greg Kroah-Hartman
maintainerPATCH 89/162 xhci: Increase STS_HALT timeout in xhci_suspend()
In reply to Greg Kroah-HartmanFrom: Kai-Heng Feng <[email protected]>
commit 7c67cf6658cec70d8a43229f2ce74ca1443dc95e upstream.
I've recently observed failed xHCI suspend attempt on AMD Raven Ridge system:
kernel: xhci_hcd 0000:04:00.4: WARN: xHC CMD_RUN timeout
kernel: PM: suspend_common(): xhci_pci_suspend+0x0/0xd0 returns -110
kernel: PM: pci_pm_suspend(): hcd_pci_suspend+0x0/0x30 returns -110
kernel: PM: dpm_run_callback(): pci_pm_suspend+0x0/0x150 returns -110
kernel: PM: Device 0000:04:00.4 failed to suspend async: error -110
Similar to commit ac343366846a ("xhci: Increase STS_SAVE timeout in xhci_suspend()") we also need to increase the HALT timeout to make it be able to suspend again.
--- drivers/usb/host/xhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/host/xhci.c +1 -1
@@ -929,7 +929,7 @@ static bool xhci_pending_portevent(strucint xhci_suspend (struct xhci_hcd *xhci,bool do_wakeup) {int rc =0 ; -unsigned int delay =XHCI_MAX_HALT_USEC ; +unsigned int delay =XHCI_MAX_HALT_USEC *2 ;struct usb_hcd *hcd =xhci_to_hcd (xhci);u32 command;
Greg Kroah-Hartman
maintainerPATCH 90/162 iio: humidity: hdc100x: fix IIO_HUMIDITYRELATIVE channel reporting
In reply to Greg Kroah-HartmanFrom: Chris Lesiak <[email protected]>
commit 342a6928bd5017edbdae376042d8ad6af3d3b943 upstream.
The IIO_HUMIDITYRELATIVE channel was being incorrectly reported back as percent when it should have been milli percent. This is via an incorrect scale value being returned to userspace.
--- drivers/iio/humidity/hdc100x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/humidity/hdc100x.c +1 -1
@@ -215,7 +215,7 @@ static int hdc100x_read_raw(struct iio_d *val2 =65536 ;return IIO_VAL_FRACTIONAL ; }else { - *val =100 ; + *val =100000 ; *val2 =65536 ;return IIO_VAL_FRACTIONAL ; }
Greg Kroah-Hartman
maintainerPATCH 91/162 USB: atm: ueagle-atm: add missing endpoint check
In reply to Greg Kroah-HartmanFrom: Johan Hovold <[email protected]>
commit 09068c1ad53fb077bdac288869dec2435420bdc4 upstream.
Make sure that the interrupt interface has an endpoint before trying to access its endpoint descriptors to avoid dereferencing a NULL pointer.
The driver binds to the interrupt interface with interface number 0, but must not assume that this interface or its current alternate setting are the first entries in the corresponding configuration arrays.
--- drivers/usb/atm/ueagle-atm.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-)
drivers/usb/atm/ueagle-atm.c +12 -6
@@ -2167,10 +2167,11 @@ resubmit:/* * Start the modem : init the data and start kernel thread */ -static int uea_boot (struct uea_softc *sc) +static int uea_boot (struct uea_softc *sc,struct usb_interface *intf) { -int ret, size;struct intr_pkt *intr; +int ret = -ENOMEM ; +int size;uea_enters (INS_TO_USBDEV (sc));
@@ -2195,6 +2196,11 @@ static int uea_boot(struct uea_softc *scif (UEA_CHIP_VERSION (sc) ==ADI930 )load_XILINX_firmware (sc); +if (intf->cur_altsetting->desc.bNumEndpoints <1 ) { + ret = -ENODEV ; + goto err0; + } + intr =kmalloc (size,GFP_KERNEL );if (!intr) { uea_err(INS_TO_USBDEV(sc),
@@ -2211,8 +2217,7 @@ static int uea_boot(struct uea_softc *scusb_fill_int_urb (sc->urb_int, sc->usb_dev,usb_rcvintpipe (sc->usb_dev,UEA_INTR_PIPE ), intr, size, uea_intr, sc, - sc->usb_dev->actconfig->interface[0 ]->altsetting[0 ]. - endpoint[0 ].desc.bInterval); + intf->cur_altsetting->endpoint[0 ].desc.bInterval); ret =usb_submit_urb (sc->urb_int,GFP_KERNEL );if (ret <0 ) {
@@ -2227,6 +2232,7 @@ static int uea_boot(struct uea_softc *sc sc->kthread =kthread_create (uea_kthread, sc,"ueagle-atm" );if (IS_ERR (sc->kthread)) {uea_err (INS_TO_USBDEV (sc),"failed to create thread\n" ); + ret =PTR_ERR (sc->kthread); goto err2; }
@@ -2241,7 +2247,7 @@ err1:kfree (intr); err0:uea_leaves (INS_TO_USBDEV (sc)); -return -ENOMEM ; +return ret; }/*
@@ -2604,7 +2610,7 @@ static int uea_bind(struct usbatm_data *if (ret <0 ) goto error; - ret =uea_boot (sc); + ret =uea_boot (sc, intf);if (ret <0 ) goto error_rm_grp;
Greg Kroah-Hartman
maintainerPATCH 92/162 USB: idmouse: fix interface sanity checks
In reply to Greg Kroah-HartmanFrom: Johan Hovold <[email protected]>
commit 59920635b89d74b9207ea803d5e91498d39e8b69 upstream.
Make sure to use the current alternate setting when verifying the interface descriptors to avoid binding to an invalid interface.
Failing to do so could cause the driver to misbehave or trigger a WARN() in usb_submit_urb() that kernels with panic_on_warn set would choke on.
--- drivers/usb/misc/idmouse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/misc/idmouse.c +1 -1
@@ -342,7 +342,7 @@ static int idmouse_probe(struct usb_inteint result;/* check if we have gotten the data or the hid interface */ - iface_desc = &interface->altsetting[0 ]; + iface_desc = interface->cur_altsetting;if (iface_desc->desc.bInterfaceClass !=0x0A )return -ENODEV ;
Greg Kroah-Hartman
maintainerPATCH 93/162 USB: serial: io_edgeport: fix epic endpoint lookup
In reply to Greg Kroah-HartmanFrom: Johan Hovold <[email protected]>
commit 7c5a2df3367a2c4984f1300261345817d95b71f8 upstream.
Make sure to use the current alternate setting when looking up the endpoints on epic devices to avoid binding to an invalid interface.
Failing to do so could cause the driver to misbehave or trigger a WARN() in usb_submit_urb() that kernels with panic_on_warn set would choke on.
--- drivers/usb/serial/io_edgeport.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/usb/serial/io_edgeport.c +6 -4
@@ -2859,16 +2859,18 @@ static int edge_startup(struct usb_seria response =0 ;if (edge_serial->is_epic) { +struct usb_host_interface *alt; + + alt = serial->interface->cur_altsetting; +/* EPIC thing, set up our interrupt polling now and our read * urb, so that the device knows it really is connected. */ interrupt_in_found = bulk_in_found = bulk_out_found = false; -for (i =0 ; i < serial->interface->altsetting[0 ] - .desc.bNumEndpoints; ++i) { +for (i =0 ; i < alt->desc.bNumEndpoints; ++i) {struct usb_endpoint_descriptor *endpoint;int buffer_size; - endpoint = &serial->interface->altsetting[0 ]. - endpoint[i].desc; + endpoint = &alt->endpoint[i].desc; buffer_size =usb_endpoint_maxp (endpoint);if (!interrupt_in_found && (usb_endpoint_is_int_in (endpoint))) {
Greg Kroah-Hartman
maintainerPATCH 94/162 USB: adutux: fix interface sanity check
In reply to Greg Kroah-HartmanFrom: Johan Hovold <[email protected]>
commit 3c11c4bed02b202e278c0f5c319ae435d7fb9815 upstream.
Make sure to use the current alternate setting when verifying the interface descriptors to avoid binding to an invalid interface.
Failing to do so could cause the driver to misbehave or trigger a WARN() in usb_submit_urb() that kernels with panic_on_warn set would choke on.
--- drivers/usb/misc/adutux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/misc/adutux.c +1 -1
@@ -686,7 +686,7 @@ static int adu_probe(struct usb_interfacinit_waitqueue_head (&dev->read_wait);init_waitqueue_head (&dev->write_wait); - iface_desc = &interface->altsetting[0 ]; + iface_desc = &interface->cur_altsetting[0 ];/* set up the endpoint information */ for (i =0 ; i < iface_desc->desc.bNumEndpoints; ++i) {
Greg Kroah-Hartman
maintainerPATCH 95/162 usb: core: urb: fix URB structure initialization function
In reply to Greg Kroah-HartmanFrom: Emiliano Ingrassia <[email protected]>
commit 1cd17f7f0def31e3695501c4f86cd3faf8489840 upstream.
Explicitly initialize URB structure urb_list field in usb_init_urb(). This field can be potentially accessed uninitialized and its initialization is coherent with the usage of list_del_init() in usb_hcd_unlink_urb_from_ep() and usb_giveback_urb_bh() and its explicit initialization in usb_hcd_submit_urb() error path.
--- drivers/usb/core/urb.c | 1 + 1 file changed, 1 insertion(+)
drivers/usb/core/urb.c +1 -0
@@ -40,6 +40,7 @@ void usb_init_urb(struct urb *urb)if (urb) {memset (urb,0 ,sizeof (*urb));kref_init (&urb->kref); +INIT_LIST_HEAD (&urb->urb_list);INIT_LIST_HEAD (&urb->anchor_list); } }
Greg Kroah-Hartman
maintainerPATCH 96/162 usb: mon: Fix a deadlock in usbmon between mmap and read
In reply to Greg Kroah-HartmanFrom: Pete Zaitcev <[email protected]>
commit 19e6317d24c25ee737c65d1ffb7483bdda4bb54a upstream.
The problem arises because our read() function grabs a lock of the circular buffer, finds something of interest, then invokes copy_to_user() straight from the buffer, which in turn takes mm->mmap_sem. In the same time, the callback mon_bin_vma_fault() is invoked under mm->mmap_sem. It attempts to take the fetch lock and deadlocks.
This patch does away with protecting of our page list with any semaphores, and instead relies on the kernel not close the device while mmap is active in a process.
In addition, we prohibit re-sizing of a buffer while mmap is active. This way, when (now unlocked) fault is processed, it works with the page that is intended to be mapped-in, and not some other random page. Note that this may have an ABI impact, but hopefully no legitimate program is this wrong.
--- drivers/usb/mon/mon_bin.c | 32 +++++++++++++++++++++----------- 1 file changed, 21 insertions(+), 11 deletions(-)
drivers/usb/mon/mon_bin.c +21 -11
@@ -1035,12 +1035,18 @@ static long mon_bin_ioctl(struct file *fmutex_lock (&rp->fetch_lock);spin_lock_irqsave (&rp->b_lock, flags); -mon_free_buff (rp->b_vec, rp->b_size/CHUNK_SIZE ); -kfree (rp->b_vec); - rp->b_vec = vec; - rp->b_size = size; - rp->b_read = rp->b_in = rp->b_out = rp->b_cnt =0 ; - rp->cnt_lost =0 ; +if (rp->mmap_active) { +mon_free_buff (vec, size/CHUNK_SIZE ); +kfree (vec); + ret = -EBUSY ; + }else { +mon_free_buff (rp->b_vec, rp->b_size/CHUNK_SIZE ); +kfree (rp->b_vec); + rp->b_vec = vec; + rp->b_size = size; + rp->b_read = rp->b_in = rp->b_out = rp->b_cnt =0 ; + rp->cnt_lost =0 ; + }spin_unlock_irqrestore (&rp->b_lock, flags);mutex_unlock (&rp->fetch_lock); }
@@ -1212,13 +1218,21 @@ mon_bin_poll(struct file *file, struct pstatic void mon_bin_vma_open (struct vm_area_struct *vma) {struct mon_reader_bin *rp = vma->vm_private_data; +unsigned long flags; + +spin_lock_irqsave (&rp->b_lock, flags); rp->mmap_active++; +spin_unlock_irqrestore (&rp->b_lock, flags); }static void mon_bin_vma_close (struct vm_area_struct *vma) { +unsigned long flags; +struct mon_reader_bin *rp = vma->vm_private_data; +spin_lock_irqsave (&rp->b_lock, flags); rp->mmap_active--; +spin_unlock_irqrestore (&rp->b_lock, flags); }/*
@@ -1230,16 +1244,12 @@ static int mon_bin_vma_fault(struct vm_aunsigned long offset, chunk_idx;struct page *pageptr; -mutex_lock (&rp->fetch_lock); offset = vmf->pgoff <<PAGE_SHIFT ; -if (offset >= rp->b_size) { -mutex_unlock (&rp->fetch_lock); +if (offset >= rp->b_size)return VM_FAULT_SIGBUS ; - } chunk_idx = offset /CHUNK_SIZE ; pageptr = rp->b_vec[chunk_idx].pg;get_page (pageptr); -mutex_unlock (&rp->fetch_lock); vmf->page = pageptr;return 0 ; }
Greg Kroah-Hartman
maintainerPATCH 97/162 mtd: spear_smi: Fix Write Burst mode
In reply to Greg Kroah-HartmanFrom: Miquel Raynal <[email protected]>
commit 69c7f4618c16b4678f8a4949b6bb5ace259c0033 upstream.
Any write with either dd or flashcp to a device driven by the spear_smi.c driver will pass through the spear_smi_cpy_toio() function. This function will get called for chunks of up to 256 bytes. If the amount of data is smaller, we may have a problem if the data length is not 4-byte aligned. In this situation, the kernel panics during the memcpy:
# dd if=/dev/urandom bs=1001 count=1 of=/dev/mtd6
spear_smi_cpy_toio [620] dest c9070000, src c7be8800, len 256
spear_smi_cpy_toio [620] dest c9070100, src c7be8900, len 256
spear_smi_cpy_toio [620] dest c9070200, src c7be8a00, len 256
spear_smi_cpy_toio [620] dest c9070300, src c7be8b00, len 233
Unhandled fault: external abort on non-linefetch (0x808) at 0xc90703e8
[...]
PC is at memcpy+0xcc/0x330The above error occurs because the implementation of memcpy_toio() tries to optimize the number of I/O by writing 4 bytes at a time as much as possible, until there are less than 4 bytes left and then switches to word or byte writes.
Unfortunately, the specification states about the Write Burst mode:
"the next AHB Write request should point to the next incremented address and should have the same size (byte, half-word or word)"
This means ARM architecture implementation of memcpy_toio() cannot reliably be used blindly here. Workaround this situation by update the write path to stick to byte access when the burst length is not multiple of 4.
--- drivers/mtd/devices/spear_smi.c | 38 +++++++++++++++++++++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-)
drivers/mtd/devices/spear_smi.c +37 -1
@@ -595,6 +595,26 @@ static int spear_mtd_read(struct mtd_infreturn 0 ; } +/* +* The purpose of this function is to ensure a memcpy_toio() with byte writes +* only. Its structure is inspired from the ARM implementation of _memcpy_toio() +* which also does single byte writes but cannot be used here as this is just an +* implementation detail and not part of the API. Not mentioning the comment +* stating that _memcpy_toio() should be optimized. +*/ +static void spear_smi_memcpy_toio_b (volatile void __iomem *dest, +const void *src,size_t len) +{ +const unsigned char *from = src; + +while (len) { + len--; +writeb (*from, dest); + from++; + dest++; + } +} +static inline int spear_smi_cpy_toio (struct spear_smi *dev,u32 bank,void __iomem *dest,const void *src,size_t len) {
@@ -617,7 +637,23 @@ static inline int spear_smi_cpy_toio(str ctrlreg1 =readl (dev->io_base +SMI_CR1 );writel ((ctrlreg1 |WB_MODE ) & ~SW_MODE , dev->io_base +SMI_CR1 ); -memcpy_toio (dest, src, len); +/* +* In Write Burst mode (WB_MODE), the specs states that writes must be: +* - incremental +* - of the same size +* The ARM implementation of memcpy_toio() will optimize the number of +* I/O by using as much 4-byte writes as possible, surrounded by +* 2-byte/1-byte access if: +* - the destination is not 4-byte aligned +* - the length is not a multiple of 4-byte. +* Avoid this alternance of write access size by using our own 'byte +* access' helper if at least one of the two conditions above is true. +*/ +if (IS_ALIGNED (len,sizeof (u32)) && +IS_ALIGNED ((uintptr_t )dest,sizeof (u32))) +memcpy_toio (dest, src, len); +else +spear_smi_memcpy_toio_b (dest, src, len);writel (ctrlreg1, dev->io_base +SMI_CR1 );
Greg Kroah-Hartman
maintainerPATCH 98/162 virtio-balloon: fix managed page counts when migrating pages between zones
In reply to Greg Kroah-HartmanFrom: David Hildenbrand <[email protected]>
commit 63341ab03706e11a31e3dd8ccc0fbc9beaf723f0 upstream.
In case we have to migrate a ballon page to a newpage of another zone, the managed page count of both zones is wrong. Paired with memory offlining (which will adjust the managed page count), we can trigger kernel crashes and all kinds of different symptoms.
One way to reproduce:
1. Start a QEMU guest with 4GB, no NUMA
2. Hotplug a 1GB DIMM and online the memory to ZONE_NORMAL
3. Inflate the balloon to 1GB
4. Unplug the DIMM (be quick, otherwise unmovable data ends up on it)
5. Observe /proc/zoneinfo
Node 0, zone Normal
pages free 16810
min 24848885473806
low 18471592959183339
high 36918337032892872
spanned 262144
present 262144
managed 18446744073709533486
6. Do anything that requires some memory (e.g., inflate the balloon some
more). The OOM goes crazy and the system crashes
[ 238.324946] Out of memory: Killed process 537 (login) total-vm:27584kB, anon-rss:860kB, file-rss:0kB, shmem-rss:00
[ 238.338585] systemd invoked oom-killer: gfp_mask=0x100cca(GFP_HIGHUSER_MOVABLE), order=0, oom_score_adj=0
[ 238.339420] CPU: 0 PID: 1 Comm: systemd Tainted: G D W 5.4.0-next-20191204+ #75
[ 238.340139] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.0-59-gc9ba5276e321-prebuilt.qemu4
[ 238.341121] Call Trace:
[ 238.341337] dump_stack+0x8f/0xd0
[ 238.341630] dump_header+0x61/0x5ea
[ 238.341942] oom_kill_process.cold+0xb/0x10
[ 238.342299] out_of_memory+0x24d/0x5a0
[ 238.342625] __alloc_pages_slowpath+0xd12/0x1020
[ 238.343024] __alloc_pages_nodemask+0x391/0x410
[ 238.343407] pagecache_get_page+0xc3/0x3a0
[ 238.343757] filemap_fault+0x804/0xc30
[ 238.344083] ? ext4_filemap_fault+0x28/0x42
[ 238.344444] ext4_filemap_fault+0x30/0x42
[ 238.344789] __do_fault+0x37/0x1a0
[ 238.345087] __handle_mm_fault+0x104d/0x1ab0
[ 238.345450] handle_mm_fault+0x169/0x360
[ 238.345790] do_user_addr_fault+0x20d/0x490
[ 238.346154] do_page_fault+0x31/0x210
[ 238.346468] async_page_fault+0x43/0x50
[ 238.346797] RIP: 0033:0x7f47eba4197e
[ 238.347110] Code: Bad RIP value.
[ 238.347387] RSP: 002b:00007ffd7c0c1890 EFLAGS: 00010293
[ 238.347834] RAX: 0000000000000002 RBX: 000055d196a20a20 RCX: 00007f47eba4197e
[ 238.348437] RDX: 0000000000000033 RSI: 00007ffd7c0c18c0 RDI: 0000000000000004
[ 238.349047] RBP: 00007ffd7c0c1c20 R08: 0000000000000000 R09: 0000000000000033
[ 238.349660] R10: 00000000ffffffff R11: 0000000000000293 R12: 0000000000000001
[ 238.350261] R13: ffffffffffffffff R14: 0000000000000000 R15: 00007ffd7c0c18c0
[ 238.350878] Mem-Info:
[ 238.351085] active_anon:3121 inactive_anon:51 isolated_anon:0
[ 238.351085] active_file:12 inactive_file:7 isolated_file:0
[ 238.351085] unevictable:0 dirty:0 writeback:0 unstable:0
[ 238.351085] slab_reclaimable:5565 slab_unreclaimable:10170
[ 238.351085] mapped:3 shmem:111 pagetables:155 bounce:0
[ 238.351085] free:720717 free_pcp:2 free_cma:0
[ 238.353757] Node 0 active_anon:12484kB inactive_anon:204kB active_file:48kB inactive_file:28kB unevictable:0kB iss
[ 238.355979] Node 0 DMA free:11556kB min:36kB low:48kB high:60kB reserved_highatomic:0KB active_anon:152kB inactivB
[ 238.358345] lowmem_reserve[]: 0 2955 2884 2884 2884
[ 238.358761] Node 0 DMA32 free:2677864kB min:7004kB low:10028kB high:13052kB reserved_highatomic:0KB active_anon:0B
[ 238.361202] lowmem_reserve[]: 0 0 72057594037927865 72057594037927865 72057594037927865
[ 238.361888] Node 0 Normal free:193448kB min:99395541895224kB low:73886371836733356kB high:147673348131571488kB reB
[ 238.364765] lowmem_reserve[]: 0 0 0 0 0
[ 238.365101] Node 0 DMA: 7*4kB (U) 5*8kB (UE) 6*16kB (UME) 2*32kB (UM) 1*64kB (U) 2*128kB (UE) 3*256kB (UME) 2*512B
[ 238.366379] Node 0 DMA32: 0*4kB 1*8kB (U) 2*16kB (UM) 2*32kB (UM) 2*64kB (UM) 1*128kB (U) 1*256kB (U) 1*512kB (U)B
[ 238.367654] Node 0 Normal: 1985*4kB (UME) 1321*8kB (UME) 844*16kB (UME) 524*32kB (UME) 300*64kB (UME) 138*128kB (B
[ 238.369184] Node 0 hugepages_total=0 hugepages_free=0 hugepages_surp=0 hugepages_size=2048kB
[ 238.369915] 130 total pagecache pages
[ 238.370241] 0 pages in swap cache
[ 238.370533] Swap cache stats: add 0, delete 0, find 0/0
[ 238.370981] Free swap = 0kB
[ 238.371239] Total swap = 0kB
[ 238.371488] 1048445 pages RAM
[ 238.371756] 0 pages HighMem/MovableOnly
[ 238.372090] 306992 pages reserved
[ 238.372376] 0 pages cma reserved
[ 238.372661] 0 pages hwpoisonedIn another instance (older kernel), I was able to observe this (negative page count :/):
[ 180.896971] Offlined Pages 32768 [ 182.667462] Offlined Pages 32768 [ 184.408117] Offlined Pages 32768 [ 186.026321] Offlined Pages 32768 [ 187.684861] Offlined Pages 32768 [ 189.227013] Offlined Pages 32768 [ 190.830303] Offlined Pages 32768 [ 190.833071] Built 1 zonelists, mobility grouping on. Total pages: -36920272750453009
In another instance (older kernel), I was no longer able to start any process:
[root@vm ~]# [ 214.348068] Offlined Pages 32768
[ 215.973009] Offlined Pages 32768 cat /proc/meminfo -bash: fork: Cannot allocate memory [root@vm ~]# cat /proc/meminfo -bash: fork: Cannot allocate memory
Fix it by properly adjusting the managed page count when migrating if the zone changed. The managed page count of the zones now looks after unplug of the DIMM (and after deflating the balloon) just like before inflating the balloon (and plugging+onlining the DIMM).
We'll temporarily modify the totalram page count. If this ever becomes a problem, we can fine tune by providing helpers that don't touch the totalram pages (e.g., adjust_zone_managed_page_count()).
Please note that fixing up the managed page count is only necessary when we adjusted the managed page count when inflating - only if we don't have VIRTIO_BALLOON_F_DEFLATE_ON_OOM. With that feature, the managed page count is not touched when inflating/deflating.
--- drivers/virtio/virtio_balloon.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/virtio/virtio_balloon.c +11 -0
@@ -468,6 +468,17 @@ static int virtballoon_migratepage(strucget_page (newpage);/* balloon reference */ +/* +* When we migrate a page to a different zone and adjusted the +* managed page count when inflating, we have to fixup the count of +* both involved zones. +*/ +if (!virtio_has_feature (vb->vdev,VIRTIO_BALLOON_F_DEFLATE_ON_OOM ) && +page_zone (page) !=page_zone (newpage)) { +adjust_managed_page_count (page,1 ); +adjust_managed_page_count (newpage,-1 ); + } +/* balloon's page migration 1st step -- inflate "newpage" */ spin_lock_irqsave (&vb_dev_info->pages_lock, flags);balloon_page_insert (vb_dev_info, newpage);
Greg Kroah-Hartman
maintainerPATCH 99/162 btrfs: check page->mapping when loading free space cache
In reply to Greg Kroah-HartmanFrom: Josef Bacik <[email protected]>
commit 3797136b626ad4b6582223660c041efdea8f26b2 upstream.
While testing 5.2 we ran into the following panic
[52238.017028] BUG: kernel NULL pointer dereference, address: 0000000000000001 [52238.105608] RIP: 0010:drop_buffers+0x3d/0x150 [52238.304051] Call Trace: [52238.308958] try_to_free_buffers+0x15b/0x1b0 [52238.317503] shrink_page_list+0x1164/0x1780 [52238.325877] shrink_inactive_list+0x18f/0x3b0 [52238.334596] shrink_node_memcg+0x23e/0x7d0 [52238.342790] ? do_shrink_slab+0x4f/0x290 [52238.350648] shrink_node+0xce/0x4a0 [52238.357628] balance_pgdat+0x2c7/0x510 [52238.365135] kswapd+0x216/0x3e0 [52238.371425] ? wait_woken+0x80/0x80 [52238.378412] ? balance_pgdat+0x510/0x510 [52238.386265] kthread+0x111/0x130 [52238.392727] ? kthread_create_on_node+0x60/0x60 [52238.401782] ret_from_fork+0x1f/0x30
The page we were trying to drop had a page->private, but had no page->mapping and so called drop_buffers, assuming that we had a buffer_head on the page, and then panic'ed trying to deref 1, which is our page->private for data pages.
This is happening because we're truncating the free space cache while we're trying to load the free space cache. This isn't supposed to happen, and I'll fix that in a followup patch. However we still shouldn't allow those sort of mistakes to result in messing with pages that do not belong to us. So add the page->mapping check to verify that we still own this page after dropping and re-acquiring the page lock.
This page being unlocked as:btrfs_readpage
extent_read_full_page
__extent_read_full_page
__do_readpage
if (!nr)
unlock_page <-- nr can be 0 only if submit_extent_page
returns an error
--- fs/btrfs/free-space-cache.c | 6 ++++++ 1 file changed, 6 insertions(+)
fs/btrfs/free-space-cache.c +6 -0
@@ -391,6 +391,12 @@ static int io_ctl_prepare_pages(struct bif (uptodate && !PageUptodate (page)) {btrfs_readpage (NULL , page);lock_page (page); +if (page->mapping != inode->i_mapping) { +btrfs_err (BTRFS_I (inode)->root->fs_info, +"free space cache page truncated" ); +io_ctl_drop_pages (io_ctl); +return -EIO ; + }if (!PageUptodate (page)) {btrfs_err (BTRFS_I (inode)->root->fs_info,"error reading free space cache" );
Greg Kroah-Hartman
maintainerPATCH 100/162 btrfs: Remove btrfs_bio::flags member
In reply to Greg Kroah-HartmanFrom: Qu Wenruo <[email protected]>
commit 34b127aecd4fe8e6a3903e10f204a7b7ffddca22 upstream.
The last user of btrfs_bio::flags was removed in commit 326e1dbb5736 ("block: remove management of bi_remaining when restoring original bi_end_io"), remove it.
(Tagged for stable as the structure is heavily used and space savings are desirable.)
--- fs/btrfs/volumes.h | 1 - 1 file changed, 1 deletion(-)
fs/btrfs/volumes.h +0 -1
@@ -312,7 +312,6 @@ struct btrfs_bio {u64 map_type;/* get from map_lookup->type */ bio_end_io_t *end_io;struct bio *orig_bio; -unsigned long flags;void *private;atomic_t error;int max_errors;
Greg Kroah-Hartman
maintainerPATCH 101/162 rtlwifi: rtl8192de: Fix missing code to retrieve RX buffer address
In reply to Greg Kroah-HartmanFrom: Larry Finger <[email protected]>
commit 0e531cc575c4e9e3dd52ad287b49d3c2dc74c810 upstream.
In commit 38506ecefab9 ("rtlwifi: rtl_pci: Start modification for new drivers"), a callback to get the RX buffer address was added to the PCI driver. Unfortunately, driver rtl8192de was not modified appropriately and the code runs into a WARN_ONCE() call. The use of an incorrect array is also fixed.
--- drivers/net/wireless/realtek/rtlwifi/rtl8192de/trx.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/net/wireless/realtek/rtlwifi/rtl8192de/trx.c +5 -3
@@ -843,13 +843,15 @@ u32 rtl92de_get_desc(u8 *p_desc, bool isbreak ; } }else { -struct rx_desc_92c *pdesc = (struct rx_desc_92c *)p_desc;switch (desc_name) {case HW_DESC_OWN : - ret =GET_RX_DESC_OWN (pdesc); + ret =GET_RX_DESC_OWN (p_desc);break ;case HW_DESC_RXPKT_LEN : - ret =GET_RX_DESC_PKT_LEN (pdesc); + ret =GET_RX_DESC_PKT_LEN (p_desc); +break ; +case HW_DESC_RXBUFF_ADDR : + ret =GET_RX_DESC_BUFF_ADDR (p_desc);break ;default : RT_ASSERT(false, "ERR rxdesc :%d not process\n",
Greg Kroah-Hartman
maintainerPATCH 102/162 rtlwifi: rtl8192de: Fix missing callback that tests for hw release of buffer
In reply to Greg Kroah-HartmanFrom: Larry Finger <[email protected]>
commit 3155db7613edea8fb943624062baf1e4f9cfbfd6 upstream.
In commit 38506ecefab9 ("rtlwifi: rtl_pci: Start modification for new drivers"), a callback needed to check if the hardware has released a buffer indicating that a DMA operation is completed was not added.
--- drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c | 1 + drivers/net/wireless/realtek/rtlwifi/rtl8192de/trx.c | 17 +++++++++++++++++ drivers/net/wireless/realtek/rtlwifi/rtl8192de/trx.h | 2 ++ 3 files changed, 20 insertions(+)
drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c +1 -0
@@ -242,6 +242,7 @@ static struct rtl_hal_ops rtl8192de_hal_ .led_control = rtl92de_led_control, .set_desc = rtl92de_set_desc, .get_desc = rtl92de_get_desc, + .is_tx_desc_closed = rtl92de_is_tx_desc_closed, .tx_polling = rtl92de_tx_polling, .enable_hw_sec = rtl92de_enable_hw_security_config, .set_key = rtl92de_set_key,
drivers/net/wireless/realtek/rtlwifi/rtl8192de/trx.c +17 -0
@@ -862,6 +862,23 @@ u32 rtl92de_get_desc(u8 *p_desc, bool isreturn ret; } +bool rtl92de_is_tx_desc_closed (struct ieee80211_hw *hw, +u8 hw_queue,u16 index) +{ +struct rtl_pci *rtlpci =rtl_pcidev (rtl_pcipriv (hw)); +struct rtl8192_tx_ring *ring = &rtlpci->tx_ring[hw_queue]; +u8 *entry = (u8 *)(&ring->desc[ring->idx]); +u8 own = (u8 )rtl92de_get_desc (entry, true,HW_DESC_OWN ); + +/* a beacon packet will only use the first +* descriptor by defaut, and the own bit may not +* be cleared by the hardware +*/ +if (own) +return false; +return true; +} +void rtl92de_tx_polling (struct ieee80211_hw *hw,u8 hw_queue) {struct rtl_priv *rtlpriv =rtl_priv (hw);
drivers/net/wireless/realtek/rtlwifi/rtl8192de/trx.h +2 -0
@@ -740,6 +740,8 @@ bool rtl92de_rx_query_desc(struct ieee80void rtl92de_set_desc (struct ieee80211_hw *hw,u8 *pdesc,bool istx,u8 desc_name,u8 *val);u32 rtl92de_get_desc (u8 *pdesc,bool istx,u8 desc_name); +bool rtl92de_is_tx_desc_closed (struct ieee80211_hw *hw, +u8 hw_queue,u16 index);void rtl92de_tx_polling (struct ieee80211_hw *hw,u8 hw_queue); void rtl92de_tx_fill_cmddesc(struct ieee80211_hw *hw, u8 *pdesc, bool b_firstseg, bool b_lastseg,
Greg Kroah-Hartman
maintainerPATCH 103/162 rtlwifi: rtl8192de: Fix missing enable interrupt flag
In reply to Greg Kroah-HartmanFrom: Larry Finger <[email protected]>
commit 330bb7117101099c687e9c7f13d48068670b9c62 upstream.
In commit 38506ecefab9 ("rtlwifi: rtl_pci: Start modification for new drivers"), the flag that indicates that interrupts are enabled was never set.
In addition, there are several places when enable/disable interrupts were commented out are restored. A sychronize_interrupts() call is removed.
--- drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c +5 -4
@@ -1206,6 +1206,7 @@ void rtl92de_enable_interrupt(struct ieertl_write_dword (rtlpriv,REG_HIMR , rtlpci->irq_mask[0 ] &0xFFFFFFFF );rtl_write_dword (rtlpriv,REG_HIMRE , rtlpci->irq_mask[1 ] &0xFFFFFFFF ); + rtlpci->irq_enabled = true; }void rtl92de_disable_interrupt (struct ieee80211_hw *hw)
@@ -1215,7 +1216,7 @@ void rtl92de_disable_interrupt(struct iertl_write_dword (rtlpriv,REG_HIMR ,IMR8190_DISABLED );rtl_write_dword (rtlpriv,REG_HIMRE ,IMR8190_DISABLED ); -synchronize_irq (rtlpci->pdev->irq); + rtlpci->irq_enabled = false; }static void _rtl92de_poweroff_adapter (struct ieee80211_hw *hw)
@@ -1386,7 +1387,7 @@ void rtl92de_set_beacon_related_register bcn_interval = mac->beacon_interval; atim_window =2 ; -/*rtl92de_disable_interrupt(hw); */ +rtl92de_disable_interrupt (hw);rtl_write_word (rtlpriv,REG_ATIMWND , atim_window);rtl_write_word (rtlpriv,REG_BCN_INTERVAL , bcn_interval);rtl_write_word (rtlpriv,REG_BCNTCFG ,0x660f );
@@ -1406,9 +1407,9 @@ void rtl92de_set_beacon_interval(structRT_TRACE (rtlpriv,COMP_BEACON ,DBG_DMESG ,"beacon_interval:%d\n" , bcn_interval); -/* rtl92de_disable_interrupt(hw); */ +rtl92de_disable_interrupt (hw);rtl_write_word (rtlpriv,REG_BCN_INTERVAL , bcn_interval); -/* rtl92de_enable_interrupt(hw); */ +rtl92de_enable_interrupt (hw); } void rtl92de_update_interrupt_mask(struct ieee80211_hw *hw,
Greg Kroah-Hartman
maintainerPATCH 104/162 lib: raid6: fix awk build warnings
In reply to Greg Kroah-HartmanFrom: Greg Kroah-Hartman <[email protected]>
commit 702600eef73033ddd4eafcefcbb6560f3e3a90f7 upstream.
Newer versions of awk spit out these fun warnings:
awk: ../lib/raid6/unroll.awk:16: warning: regexp escape sequence `\#' is not a known regexp operator
As commit 700c1018b86d ("x86/insn: Fix awk regexp warnings") showed, it turns out that there are a number of awk strings that do not need to be escaped and newer versions of awk now warn about this.
Fix the string up so that no warning is produced. The exact same kernel module gets created before and after this patch, showing that it wasn't needed.
--- lib/raid6/unroll.awk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/raid6/unroll.awk +1 -1
@@ -13,7 +13,7 @@ BEGIN { for (i = 0; i < rep; ++i) { tmp = $0 gsub(/\$\$/, i, tmp) - gsub(/\$\#/, n, tmp) + gsub(/\$#/, n, tmp) gsub(/\$\*/, "$", tmp) print tmp }
Greg Kroah-Hartman
maintainerPATCH 105/162 workqueue: Fix spurious sanity check failures in destroy_workqueue()
In reply to Greg Kroah-HartmanFrom: Tejun Heo <[email protected]>
commit def98c84b6cdf2eeea19ec5736e90e316df5206b upstream.
Before actually destrying a workqueue, destroy_workqueue() checks whether it's actually idle. If it isn't, it prints out a bunch of warning messages and leaves the workqueue dangling. It unfortunately has a couple issues.
* Mayday list queueing increments pwq's refcnts which gets detected as busy and fails the sanity checks. However, because mayday list queueing is asynchronous, this condition can happen without any actual work items left in the workqueue.
* Sanity check failure leaves the sysfs interface behind too which can lead to init failure of newer instances of the workqueue.
This patch fixes the above two by
* If a workqueue has a rescuer, disable and kill the rescuer before sanity checks. Disabling and killing is guaranteed to flush the existing mayday list.
* Remove sysfs interface before sanity checks.
--- kernel/workqueue.c | 24 +++++++++++++++++++----- 1 file changed, 19 insertions(+), 5 deletions(-)
kernel/workqueue.c +19 -5
@@ -3949,9 +3949,28 @@ void destroy_workqueue(struct workqueue_struct pool_workqueue *pwq;int node; +/* +* Remove it from sysfs first so that sanity check failure doesn't +* lead to sysfs name conflicts. +*/ +workqueue_sysfs_unregister (wq); +/* drain it before proceeding with destruction */ drain_workqueue (wq); +/* kill rescuer, if sanity checks fail, leave it w/o rescuer */ +if (wq->rescuer) { +struct worker *rescuer = wq->rescuer; + +/* this prevents new queueing */ +spin_lock_irq (&wq_mayday_lock); + wq->rescuer =NULL ; +spin_unlock_irq (&wq_mayday_lock); + +/* rescuer will empty maydays list before exiting */ +kthread_stop (rescuer->task); + } +/* sanity checks */ mutex_lock (&wq->mutex);for_each_pwq (pwq, wq) {
@@ -3981,11 +4000,6 @@ void destroy_workqueue(struct workqueue_list_del_rcu (&wq->list);mutex_unlock (&wq_pool_mutex); -workqueue_sysfs_unregister (wq); - -if (wq->rescuer) -kthread_stop (wq->rescuer->task); -if (!(wq->flags &WQ_UNBOUND )) {/* * The base ref is never dropped on per-cpu pwqs. Directly
Greg Kroah-Hartman
maintainerPATCH 106/162 workqueue: Fix pwq ref leak in rescuer_thread()
In reply to Greg Kroah-HartmanFrom: Tejun Heo <[email protected]>
commit e66b39af00f426b3356b96433d620cb3367ba1ff upstream.
008847f66c3 ("workqueue: allow rescuer thread to do more work.") made the rescuer worker requeue the pwq immediately if there may be more work items which need rescuing instead of waiting for the next mayday timer expiration. Unfortunately, it doesn't check whether the pwq is already on the mayday list and unconditionally gets the ref and moves it onto the list. This doesn't corrupt the list but creates an additional reference to the pwq. It got queued twice but will only be removed once.
This leak later can trigger pwq refcnt warning on workqueue destruction and prevent freeing of the workqueue.
--- kernel/workqueue.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
kernel/workqueue.c +10 -3
@@ -2308,8 +2308,14 @@ repeat:*/ if (need_to_create_worker (pool)) {spin_lock (&wq_mayday_lock); -get_pwq (pwq); -list_move_tail (&pwq->mayday_node, &wq->maydays); +/* +* Queue iff we aren't racing destruction +* and somebody else hasn't queued it already. +*/ +if (wq->rescuer &&list_empty (&pwq->mayday_node)) { +get_pwq (pwq); +list_add_tail (&pwq->mayday_node, &wq->maydays); + }spin_unlock (&wq_mayday_lock); } }
@@ -4276,7 +4282,8 @@ static void show_pwq(struct pool_workquepr_info (" pwq %d:" , pool->id);pr_cont_pool_info (pool); -pr_cont (" active=%d/%d%s\n" , pwq->nr_active, pwq->max_active, +pr_cont (" active=%d/%d refcnt=%d%s\n" , + pwq->nr_active, pwq->max_active, pwq->refcnt, !list_empty (&pwq->mayday_node) ?" MAYDAY" :"" );hash_for_each (pool->busy_hash, bkt, worker, hentry) {
Greg Kroah-Hartman
maintainerPATCH 107/162 ASoC: Jack: Fix NULL pointer dereference in snd_soc_jack_report
In reply to Greg Kroah-HartmanFrom: Pawel Harlozinski <[email protected]>
commit 8f157d4ff039e03e2ed4cb602eeed2fd4687a58f upstream.
Check for existance of jack before tracing.
NULL pointer dereference has been reported by KASAN while unloading machine driver (snd_soc_cnl_rt274).
--- sound/soc/soc-jack.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
sound/soc/soc-jack.c +1 -2
@@ -80,10 +80,9 @@ void snd_soc_jack_report(struct snd_soc_unsigned int sync =0 ;int enable; -trace_snd_soc_jack_report (jack, mask, status); -if (!jack)return ; +trace_snd_soc_jack_report (jack, mask, status); dapm = &jack->card->dapm;
Greg Kroah-Hartman
maintainerPATCH 108/162 blk-mq: avoid sysfs buffer overflow with too many CPU cores
In reply to Greg Kroah-HartmanFrom: Ming Lei <[email protected]>
commit 8962842ca5abdcf98e22ab3b2b45a103f0408b95 upstream.
It is reported that sysfs buffer overflow can be triggered if the system has too many CPU cores(>841 on 4K PAGE_SIZE) when showing CPUs of hctx via /sys/block/$DEV/mq/$N/cpu_list.
Use snprintf to avoid the potential buffer overflow.
This version doesn't change the attribute format, and simply stops showing CPU numbers if the buffer is going to overflow.
--- block/blk-mq-sysfs.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)
block/blk-mq-sysfs.c +10 -5
@@ -231,20 +231,25 @@ static ssize_t blk_mq_hw_sysfs_active_shstatic ssize_t blk_mq_hw_sysfs_cpus_show (struct blk_mq_hw_ctx *hctx,char *page) { +const size_t size =PAGE_SIZE -1 ;unsigned int i, first =1 ; -ssize_t ret =0 ; +int ret =0 , pos =0 ;for_each_cpu (i, hctx->cpumask) {if (first) - ret +=sprintf (ret + page,"%u" , i); + ret =snprintf (pos + page, size - pos,"%u" , i);else - ret +=sprintf (ret + page,", %u" , i); + ret =snprintf (pos + page, size - pos,", %u" , i); + +if (ret >= size - pos) +break ; first =0 ; + pos += ret; } - ret +=sprintf (ret + page,"\n" ); -return ret; + ret =snprintf (pos + page, size - pos,"\n" ); +return pos + ret; }static struct blk_mq_ctx_sysfs_entry blk_mq_sysfs_dispatched = {
Greg Kroah-Hartman
maintainerPATCH 109/162 cgroup: pids: use atomic64_t for pids->limit
In reply to Greg Kroah-HartmanFrom: Aleksa Sarai <[email protected]>
commit a713af394cf382a30dd28a1015cbe572f1b9ca75 upstream.
Because pids->limit can be changed concurrently (but we don't want to take a lock because it would be needlessly expensive), use atomic64_ts instead.
--- kernel/cgroup_pids.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
kernel/cgroup_pids.c +6 -5
@@ -48,7 +48,7 @@ struct pids_cgroup {* %PIDS_MAX = (%PID_MAX_LIMIT + 1). */ atomic64_t counter; -int64_t limit; +atomic64_t limit; };static struct pids_cgroup *css_pids (struct cgroup_subsys_state *css)
@@ -70,8 +70,8 @@ pids_css_alloc(struct cgroup_subsys_statif (!pids)return ERR_PTR (-ENOMEM ); - pids->limit =PIDS_MAX ;atomic64_set (&pids->counter,0 ); +atomic64_set (&pids->limit,PIDS_MAX );return &pids->css; }
@@ -142,13 +142,14 @@ static int pids_try_charge(struct pids_cfor (p = pids;parent_pids (p); p =parent_pids (p)) {int64_t new =atomic64_add_return (num, &p->counter); +int64_t limit =atomic64_read (&p->limit);/* * Since new is capped to the maximum number of pid_t, if * p->limit is %PIDS_MAX then we know that this test will never * fail. */ -if (new > p->limit) +if (new > limit) goto revert; }
@@ -262,7 +263,7 @@ set_limit:* Limit updates don't need to be mutex'd, since it isn't * critical that any racing fork()s follow the new limit. */ - pids->limit = limit; +atomic64_set (&pids->limit, limit);return nbytes; }
@@ -270,7 +271,7 @@ static int pids_max_show(struct seq_file {struct cgroup_subsys_state *css =seq_css (sf);struct pids_cgroup *pids =css_pids (css); -int64_t limit = pids->limit; +int64_t limit =atomic64_read (&pids->limit);if (limit >=PIDS_MAX )seq_printf (sf,"%s\n" ,PIDS_MAX_STR );
Greg Kroah-Hartman
maintainerPATCH 110/162 ar5523: check NULL before memcpy() in ar5523_cmd()
In reply to Greg Kroah-HartmanFrom: Denis Efremov <[email protected]>
commit 315cee426f87658a6799815845788fde965ddaad upstream.
memcpy() call with "idata == NULL && ilen == 0" results in undefined behavior in ar5523_cmd(). For example, NULL is passed in callchain "ar5523_stat_work() -> ar5523_cmd_write() -> ar5523_cmd()". This patch adds ilen check before memcpy() call in ar5523_cmd() to prevent an undefined behavior.
--- drivers/net/wireless/ath/ar5523/ar5523.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/wireless/ath/ar5523/ar5523.c +2 -1
@@ -255,7 +255,8 @@ static int ar5523_cmd(struct ar5523 *ar,if (flags &AR5523_CMD_FLAG_MAGIC ) hdr->magic =cpu_to_be32 (1 <<24 ); -memcpy (hdr +1 , idata, ilen); +if (ilen) +memcpy (hdr +1 , idata, ilen); cmd->odata = odata; cmd->olen = olen;
Greg Kroah-Hartman
maintainerPATCH 111/162 media: bdisp: fix memleak on release
In reply to Greg Kroah-HartmanFrom: Johan Hovold <[email protected]>
commit 11609a7e21f8cea42630350aa57662928fa4dc63 upstream.
If a process is interrupted while accessing the video device and the device lock is contended, release() could return early and fail to free related resources.
Note that the return value of the v4l2 release file operation is ignored.
--- drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/media/platform/sti/bdisp/bdisp-v4l2.c +1 -2
@@ -652,8 +652,7 @@ static int bdisp_release(struct file *fidev_dbg (bdisp->dev,"%s\n" , __func__); -if (mutex_lock_interruptible (&bdisp->lock)) -return -ERESTARTSYS ; +mutex_lock (&bdisp->lock);v4l2_m2m_ctx_release (ctx->fh.m2m_ctx);
Greg Kroah-Hartman
maintainerPATCH 112/162 media: radio: wl1273: fix interrupt masking on release
In reply to Greg Kroah-HartmanFrom: Johan Hovold <[email protected]>
commit 1091eb830627625dcf79958d99353c2391f41708 upstream.
If a process is interrupted while accessing the radio device and the core lock is contended, release() could return early and fail to update the interrupt mask.
Note that the return value of the v4l2 release file operation is ignored.
--- drivers/media/radio/radio-wl1273.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/media/radio/radio-wl1273.c +1 -2
@@ -1149,8 +1149,7 @@ static int wl1273_fm_fops_release(structif (radio->rds_users >0 ) { radio->rds_users--;if (radio->rds_users ==0 ) { -if (mutex_lock_interruptible (&core->lock)) -return -EINTR ; +mutex_lock (&core->lock); radio->irq_flags &= ~WL1273_RDS_EVENT ;
Greg Kroah-Hartman
maintainerPATCH 113/162 cpuidle: Do not unset the driver if it is there already
In reply to Greg Kroah-HartmanFrom: Zhenzhong Duan <[email protected]>
commit 918c1fe9fbbe46fcf56837ff21f0ef96424e8b29 upstream.
Fix __cpuidle_set_driver() to check if any of the CPUs in the mask has a driver different from drv already and, if so, return -EBUSY before updating any cpuidle_drivers per-CPU pointers.
--- drivers/cpuidle/driver.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-)
drivers/cpuidle/driver.c +7 -8
@@ -60,24 +60,23 @@ static inline void __cpuidle_unset_drive* __cpuidle_set_driver - set per CPU driver variables for the given driver. * @drv: a valid pointer to a struct cpuidle_driver * -* For each CPU in the driver's cpumask, unset the registered driver per CPU -* to @drv. -* -* Returns 0 on success, -EBUSY if the CPUs have driver(s) already. +* Returns 0 on success, -EBUSY if any CPU in the cpumask have a driver +* different from drv already. */ static inline int __cpuidle_set_driver (struct cpuidle_driver *drv) {int cpu;for_each_cpu (cpu, drv->cpumask) { +struct cpuidle_driver *old_drv; -if (__cpuidle_get_cpu_driver (cpu)) { -__cpuidle_unset_driver (drv); + old_drv =__cpuidle_get_cpu_driver (cpu); +if (old_drv && old_drv != drv)return -EBUSY ; - } + } +for_each_cpu (cpu, drv->cpumask)per_cpu (cpuidle_drivers, cpu) = drv; - }return 0 ; }
Greg Kroah-Hartman
maintainerPATCH 114/162 ACPI: OSL: only free map once in osl.c
In reply to Greg Kroah-HartmanFrom: Francesco Ruggeri <[email protected]>
commit 833a426cc471b6088011b3d67f1dc4e147614647 upstream.
acpi_os_map_cleanup checks map->refcount outside of acpi_ioremap_lock before freeing the map. This creates a race condition the can result in the map being freed more than once.
A panic can be caused by running
for ((i=0; i<10; i++))
do
for ((j=0; j<100000; j++))
do
cat /sys/firmware/acpi/tables/data/BERT >/dev/null
done &
done
This patch makes sure that only the process that drops the reference to 0 does the freeing.
--- drivers/acpi/osl.c | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-)
drivers/acpi/osl.c +17 -11
@@ -424,24 +424,27 @@ acpi_os_map_memory(acpi_physical_address }EXPORT_SYMBOL_GPL (acpi_os_map_memory); -static void acpi_os_drop_map_ref (struct acpi_ioremap *map) +/* Must be called with mutex_lock(&acpi_ioremap_lock) */ +static unsigned long acpi_os_drop_map_ref (struct acpi_ioremap *map) { -if (!--map->refcount) +unsigned long refcount = --map->refcount; + +if (!refcount)list_del_rcu (&map->list); +return refcount; }static void acpi_os_map_cleanup (struct acpi_ioremap *map) { -if (!map->refcount) { -synchronize_rcu_expedited (); -acpi_unmap (map->phys, map->virt); -kfree (map); - } +synchronize_rcu_expedited (); +acpi_unmap (map->phys, map->virt); +kfree (map); }void __ref acpi_os_unmap_iomem (void __iomem *virt,acpi_size size) {struct acpi_ioremap *map; +unsigned long refcount;if (!acpi_gbl_permanent_mmap) {__acpi_unmap_table (virt, size);
@@ -455,10 +458,11 @@ void __ref acpi_os_unmap_iomem(void __ioWARN (true,PREFIX "%s: bad address %p\n" , __func__, virt);return ; } -acpi_os_drop_map_ref (map); + refcount =acpi_os_drop_map_ref (map);mutex_unlock (&acpi_ioremap_lock); -acpi_os_map_cleanup (map); +if (!refcount) +acpi_os_map_cleanup (map); }EXPORT_SYMBOL_GPL (acpi_os_unmap_iomem);
@@ -499,6 +503,7 @@ void acpi_os_unmap_generic_address(struc {u64 addr;struct acpi_ioremap *map; +unsigned long refcount;if (gas->space_id !=ACPI_ADR_SPACE_SYSTEM_MEMORY )return ;
@@ -514,10 +519,11 @@ void acpi_os_unmap_generic_address(strucmutex_unlock (&acpi_ioremap_lock);return ; } -acpi_os_drop_map_ref (map); + refcount =acpi_os_drop_map_ref (map);mutex_unlock (&acpi_ioremap_lock); -acpi_os_map_cleanup (map); +if (!refcount) +acpi_os_map_cleanup (map); }EXPORT_SYMBOL (acpi_os_unmap_generic_address);
Greg Kroah-Hartman
maintainerPATCH 115/162 ACPI: bus: Fix NULL pointer check in acpi_bus_get_private_data()
In reply to Greg Kroah-HartmanFrom: Vamshi K Sthambamkadi <[email protected]>
commit 627ead724eff33673597216f5020b72118827de4 upstream.
kmemleak reported backtrace:
[<bbee0454>] kmem_cache_alloc_trace+0x128/0x260
[<6677f215>] i2c_acpi_install_space_handler+0x4b/0xe0
[<1180f4fc>] i2c_register_adapter+0x186/0x400
[<6083baf7>] i2c_add_adapter+0x4e/0x70
[<a3ddf966>] intel_gmbus_setup+0x1a2/0x2c0 [i915]
[<84cb69ae>] i915_driver_probe+0x8d8/0x13a0 [i915]
[<81911d4b>] i915_pci_probe+0x48/0x160 [i915]
[<4b159af1>] pci_device_probe+0xdc/0x160
[<b3c64704>] really_probe+0x1ee/0x450
[<bc029f5a>] driver_probe_device+0x142/0x1b0
[<d8829d20>] device_driver_attach+0x49/0x50
[<de71f045>] __driver_attach+0xc9/0x150
[<df33ac83>] bus_for_each_dev+0x56/0xa0
[<80089bba>] driver_attach+0x19/0x20
[<cc73f583>] bus_add_driver+0x177/0x220
[<7b29d8c7>] driver_register+0x56/0xf0In i2c_acpi_remove_space_handler(), a leak occurs whenever the "data" parameter is initialized to 0 before being passed to acpi_bus_get_private_data().
This is because the NULL pointer check in acpi_bus_get_private_data() (condition->if(!*data)) returns EINVAL and, in consequence, memory is never freed in i2c_acpi_remove_space_handler().
Fix the NULL pointer check in acpi_bus_get_private_data() to follow the analogous check in acpi_get_data_full().
--- drivers/acpi/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/bus.c +1 -1
@@ -154,7 +154,7 @@ int acpi_bus_get_private_data(acpi_handl {acpi_status status; -if (!*data) +if (!data)return -EINVAL ; status =acpi_get_data (handle, acpi_bus_private_data_handler, data);
Greg Kroah-Hartman
maintainerPATCH 116/162 ACPI: PM: Avoid attaching ACPI PM domain to certain devices
In reply to Greg Kroah-HartmanFrom: Rafael J. Wysocki <[email protected]>
commit b9ea0bae260f6aae546db224daa6ac1bd9d94b91 upstream.
Certain ACPI-enumerated devices represented as platform devices in Linux, like fans, require special low-level power management handling implemented by their drivers that is not in agreement with the ACPI PM domain behavior. That leads to problems with managing ACPI fans during system-wide suspend and resume.
For this reason, make acpi_dev_pm_attach() skip the affected devices by adding a list of device IDs to avoid to it and putting the IDs of the affected devices into that list.
--- drivers/acpi/device_pm.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)
drivers/acpi/device_pm.c +11 -1
@@ -1094,9 +1094,19 @@ static void acpi_dev_pm_detach(struct de*/ int acpi_dev_pm_attach (struct device *dev,bool power_on) { +/* +* Skip devices whose ACPI companions match the device IDs below, +* because they require special power management handling incompatible +* with the generic ACPI PM domain. +*/ +static const struct acpi_device_id special_pm_ids[] = { + {"PNP0C0B" , },/* Generic ACPI fan */ + {"INT3404" , },/* Fan */ + {} + };struct acpi_device *adev =ACPI_COMPANION (dev); -if (!adev) +if (!adev || !acpi_match_device_ids (adev, special_pm_ids))return -ENODEV ;if (dev->pm_domain)
Greg Kroah-Hartman
maintainerPATCH 117/162 pinctrl: samsung: Fix device node refcount leaks in S3C24xx wakeup controller init
In reply to Greg Kroah-HartmanFrom: Krzysztof Kozlowski <[email protected]>
commit 6fbbcb050802d6ea109f387e961b1dbcc3a80c96 upstream.
In s3c24xx_eint_init() the for_each_child_of_node() loop is used with a break to find a matching child node. Although each iteration of for_each_child_of_node puts the previous node, but early exit from loop misses it. This leads to leak of device node.
--- drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/pinctrl/samsung/pinctrl-s3c24xx.c +5 -1
@@ -495,8 +495,10 @@ static int s3c24xx_eint_init(struct samsreturn -ENODEV ; eint_data =devm_kzalloc (dev,sizeof (*eint_data),GFP_KERNEL ); -if (!eint_data) +if (!eint_data) { +of_node_put (eint_np);return -ENOMEM ; + } eint_data->drvdata = d;
@@ -508,12 +510,14 @@ static int s3c24xx_eint_init(struct sams irq =irq_of_parse_and_map (eint_np, i);if (!irq) {dev_err (dev,"failed to get wakeup EINT IRQ %d\n" , i); +of_node_put (eint_np);return -ENXIO ; } eint_data->parents[i] = irq;irq_set_chained_handler_and_data (irq, handlers[i], eint_data); } +of_node_put (eint_np); bank = d->pin_banks;for (i =0 ; i < d->nr_banks; ++i, ++bank) {
Greg Kroah-Hartman
maintainerPATCH 118/162 pinctrl: samsung: Fix device node refcount leaks in init code
In reply to Greg Kroah-HartmanFrom: Krzysztof Kozlowski <[email protected]>
commit a322b3377f4bac32aa25fb1acb9e7afbbbbd0137 upstream.
Several functions use for_each_child_of_node() loop with a break to find a matching child node. Although each iteration of for_each_child_of_node puts the previous node, but early exit from loop misses it. This leads to leak of device node.
--- drivers/pinctrl/samsung/pinctrl-samsung.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/pinctrl/samsung/pinctrl-samsung.c +8 -2
@@ -286,6 +286,7 @@ static int samsung_dt_node_to_map(struct &reserved_maps, num_maps);if (ret <0 ) {samsung_dt_free_map (pctldev, *map, *num_maps); +of_node_put (np);return ret; } }
@@ -753,8 +754,10 @@ static struct samsung_pmx_func *samsung_if (!of_get_child_count (cfg_np)) { ret =samsung_pinctrl_create_function (dev, drvdata, cfg_np, func); -if (ret <0 ) +if (ret <0 ) { +of_node_put (cfg_np);return ERR_PTR (ret); + }if (ret >0 ) { ++func; ++func_cnt;
@@ -765,8 +768,11 @@ static struct samsung_pmx_func *samsung_for_each_child_of_node (cfg_np, func_np) { ret =samsung_pinctrl_create_function (dev, drvdata, func_np, func); -if (ret <0 ) +if (ret <0 ) { +of_node_put (func_np); +of_node_put (cfg_np);return ERR_PTR (ret); + }if (ret >0 ) { ++func; ++func_cnt;
Greg Kroah-Hartman
maintainerPATCH 119/162 powerpc: Allow 64bit VDSO __kernel_sync_dicache to work across ranges >4GB
In reply to Greg Kroah-HartmanFrom: Alastair D'Silva <[email protected]>
commit f9ec11165301982585e5e5f606739b5bae5331f3 upstream.
When calling __kernel_sync_dicache with a size >4GB, we were masking off the upper 32 bits, so we would incorrectly flush a range smaller than intended.
This patch replaces the 32 bit shifts with 64 bit ones, so that the full size is accounted for.
--- arch/powerpc/kernel/vdso64/cacheflush.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/powerpc/kernel/vdso64/cacheflush.S +2 -2
@@ -39,7 +39,7 @@ V_FUNCTION_BEGIN(__kernel_sync_dicache) subf r8,r6,r4 /* compute length */ add r8,r8,r5 /* ensure we get enough */ lwz r9,CFG_DCACHE_LOGBLOCKSZ(r10) - srw. r8,r8,r9 /* compute line count */ + srd. r8,r8,r9 /* compute line count */ crclr cr0*4+so beqlr /* nothing to do? */ mtctr r8
@@ -56,7 +56,7 @@ V_FUNCTION_BEGIN(__kernel_sync_dicache) subf r8,r6,r4 /* compute length */ add r8,r8,r5 lwz r9,CFG_ICACHE_LOGBLOCKSZ(r10) - srw. r8,r8,r9 /* compute line count */ + srd. r8,r8,r9 /* compute line count */ crclr cr0*4+so beqlr /* nothing to do? */ mtctr r8
Greg Kroah-Hartman
maintainerPATCH 120/162 video/hdmi: Fix AVI bar unpack
In reply to Greg Kroah-HartmanFrom: Ville Syrjälä <[email protected]>
commit 6039f37dd6b76641198e290f26b31c475248f567 upstream.
The bar values are little endian, not big endian. The pack function did it right but the unpack got it wrong. Fix it.
--- drivers/video/hdmi.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/video/hdmi.c +4 -4
@@ -1032,12 +1032,12 @@ static int hdmi_avi_infoframe_unpack(strif (ptr[0 ] &0x10 ) frame->active_aspect = ptr[1 ] &0xf ;if (ptr[0 ] &0x8 ) { - frame->top_bar = (ptr[5 ] <<8 ) + ptr[6 ]; - frame->bottom_bar = (ptr[7 ] <<8 ) + ptr[8 ]; + frame->top_bar = (ptr[6 ] <<8 ) | ptr[5 ]; + frame->bottom_bar = (ptr[8 ] <<8 ) | ptr[7 ]; }if (ptr[0 ] &0x4 ) { - frame->left_bar = (ptr[9 ] <<8 ) + ptr[10 ]; - frame->right_bar = (ptr[11 ] <<8 ) + ptr[12 ]; + frame->left_bar = (ptr[10 ] <<8 ) | ptr[9 ]; + frame->right_bar = (ptr[12 ] <<8 ) | ptr[11 ]; } frame->scan_mode = ptr[0 ] &0x3 ;
Greg Kroah-Hartman
maintainerPATCH 121/162 quota: Check that quota is not dirty before release
In reply to Greg Kroah-HartmanFrom: Dmitry Monakhov <[email protected]>
commit df4bb5d128e2c44848aeb36b7ceceba3ac85080d upstream.
There is a race window where quota was redirted once we drop dq_list_lock inside dqput(), but before we grab dquot->dq_lock inside dquot_release()
TASK1 TASK2 (chowner)
->dqput()
we_slept:
spin_lock(&dq_list_lock)
if (dquot_dirty(dquot)) {
spin_unlock(&dq_list_lock);
dquot->dq_sb->dq_op->write_dquot(dquot);
goto we_slept
if (test_bit(DQ_ACTIVE_B, &dquot->dq_flags)) {
spin_unlock(&dq_list_lock);
dquot->dq_sb->dq_op->release_dquot(dquot);
dqget()
mark_dquot_dirty()
dqput()
goto we_slept;
}So dquot dirty quota will be released by TASK1, but on next we_sleept loop
we detect this and call ->write_dquot() for it.
XFSTEST: https://github.com/dmonakhov/xfstests/commit/440a80d4cbb39e9234df4d7240aee1d551c36107
--- fs/ocfs2/quota_global.c | 2 +- fs/quota/dquot.c | 2 +- include/linux/quotaops.h | 10 ++++++++++ 3 files changed, 12 insertions(+), 2 deletions(-)
fs/ocfs2/quota_global.c +1 -1
@@ -714,7 +714,7 @@ static int ocfs2_release_dquot(struct dqmutex_lock (&dquot->dq_lock);/* Check whether we are not racing with some other dqget() */ -if (atomic_read (&dquot->dq_count) >1 ) +if (dquot_is_busy (dquot)) goto out;/* Running from downconvert thread? Postpone quota processing to wq */ if (current == osb->dc_task) {
fs/quota/dquot.c +1 -1
@@ -472,7 +472,7 @@ int dquot_release(struct dquot *dquot)mutex_lock (&dquot->dq_lock);/* Check whether we are not racing with some other dqget() */ -if (atomic_read (&dquot->dq_count) >1 ) +if (dquot_is_busy (dquot)) goto out_dqlock;mutex_lock (&dqopt->dqio_mutex);if (dqopt->ops[dquot->dq_id.type]->release_dqblk) {
include/linux/quotaops.h +10 -0
@@ -54,6 +54,16 @@ static inline struct dquot *dqgrab(strucatomic_inc (&dquot->dq_count);return dquot; } + +static inline bool dquot_is_busy (struct dquot *dquot) +{ +if (test_bit (DQ_MOD_B , &dquot->dq_flags)) +return true; +if (atomic_read (&dquot->dq_count) >1 ) +return true; +return false; +} +void dqput (struct dquot *dquot); int dquot_scan_active(struct super_block *sb, int (*fn)(struct dquot *dquot, unsigned long priv),
Greg Kroah-Hartman
maintainerPATCH 122/162 quota: fix livelock in dquot_writeback_dquots
In reply to Greg Kroah-HartmanFrom: Dmitry Monakhov <[email protected]>
commit 6ff33d99fc5c96797103b48b7b0902c296f09c05 upstream.
Write only quotas which are dirty at entry.
XFSTEST: https://github.com/dmonakhov/xfstests/commit/b10ad23566a5bf75832a6f500e1236084083cddc
--- fs/quota/dquot.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
fs/quota/dquot.c +5 -4
@@ -604,7 +604,7 @@ EXPORT_SYMBOL(dquot_scan_active);/* Write all dquot structures to quota files */ int dquot_writeback_dquots (struct super_block *sb,int type) { -struct list_head *dirty; +struct list_head dirty;struct dquot *dquot;struct quota_info *dqopt =sb_dqopt (sb);int cnt;
@@ -617,9 +617,10 @@ int dquot_writeback_dquots(struct super_if (!sb_has_quota_active (sb, cnt))continue ;spin_lock (&dq_list_lock); - dirty = &dqopt->info[cnt].dqi_dirty_list; -while (!list_empty (dirty)) { - dquot = list_first_entry(dirty, struct dquot, +/* Move list away to avoid livelock. */ +list_replace_init (&dqopt->info[cnt].dqi_dirty_list, &dirty); +while (!list_empty (&dirty)) { + dquot = list_first_entry(&dirty, struct dquot, dq_dirty);/* Dirty and inactive can be only bad dquot... */ if (!test_bit (DQ_ACTIVE_B , &dquot->dq_flags)) {
Greg Kroah-Hartman
maintainerPATCH 123/162 scsi: zfcp: trace channel log even for FCP command responses
In reply to Greg Kroah-HartmanFrom: Steffen Maier <[email protected]>
[ Upstream commit 100843f176109af94600e500da0428e21030ca7f ]
While v2.6.26 commit b75db73159cc ("[SCSI] zfcp: Add qtcb dump to hba debug trace") is right that we don't want to flood the (payload) trace ring buffer, we don't trace successful FCP command responses by default. So we can include the channel log for problem determination with failed responses of any FSF request type.
--- drivers/s390/scsi/zfcp_dbf.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/s390/scsi/zfcp_dbf.c +3 -5
@@ -93,11 +93,9 @@ void zfcp_dbf_hba_fsf_res(char *tag, int level, struct zfcp_fsf_req *req)memcpy (rec->u.res.fsf_status_qual, &q_head->fsf_status_qual,FSF_STATUS_QUALIFIER_SIZE ); -if (req->fsf_command !=FSF_QTCB_FCP_CMND ) { - rec->pl_len = q_head->log_length; -zfcp_dbf_pl_write (dbf, (char *)q_pref + q_head->log_start, - rec->pl_len,"fsf_res" , req->req_id); - } + rec->pl_len = q_head->log_length; +zfcp_dbf_pl_write (dbf, (char *)q_pref + q_head->log_start, + rec->pl_len,"fsf_res" , req->req_id);debug_event (dbf->hba, level, rec,sizeof (*rec));spin_unlock_irqrestore (&dbf->hba_lock, flags);
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 124/162 usb: xhci: only set D3hot for pci device
In reply to Greg Kroah-HartmanFrom: Henry Lin <[email protected]>
[ Upstream commit f2c710f7dca8457e88b4ac9de2060f011254f9dd ]
Xhci driver cannot call pci_set_power_state() on non-pci xhci host controllers. For example, NVIDIA Tegra XHCI host controller which acts as platform device with XHCI_SPURIOUS_WAKEUP quirk set in some platform hits this issue during shutdown.
--- drivers/usb/host/xhci-pci.c | 13 +++++++++++++ drivers/usb/host/xhci.c | 5 +---- drivers/usb/host/xhci.h | 1 + 3 files changed, 15 insertions(+), 4 deletions(-)
drivers/usb/host/xhci-pci.c +13 -0
@@ -446,6 +446,18 @@ static int xhci_pci_resume(struct usb_hcd *hcd, bool hibernated) }#endif /* CONFIG_PM */ +static void xhci_pci_shutdown (struct usb_hcd *hcd) +{ +struct xhci_hcd *xhci =hcd_to_xhci (hcd); +struct pci_dev *pdev =to_pci_dev (hcd->self.controller); + +xhci_shutdown (hcd); + +/* Yet another workaround for spurious wakeups at shutdown with HSW */ +if (xhci->quirks &XHCI_SPURIOUS_WAKEUP ) +pci_set_power_state (pdev, PCI_D3hot); +} +/*-------------------------------------------------------------------------*/ /* PCI driver selection metadata; PCI hotplugging uses this */
@@ -481,6 +493,7 @@ static int __init xhci_pci_init(void)#ifdef CONFIG_PM xhci_pci_hc_driver.pci_suspend = xhci_pci_suspend; xhci_pci_hc_driver.pci_resume = xhci_pci_resume; + xhci_pci_hc_driver.shutdown = xhci_pci_shutdown;#endif return pci_register_driver (&xhci_pci_driver); }
drivers/usb/host/xhci.c +1 -4
@@ -754,11 +754,8 @@ void xhci_shutdown(struct usb_hcd *hcd)xhci_dbg_trace (xhci, trace_xhci_dbg_init,"xhci_shutdown completed - status = %x" ,readl (&xhci->op_regs->status)); - -/* Yet another workaround for spurious wakeups at shutdown with HSW */ -if (xhci->quirks &XHCI_SPURIOUS_WAKEUP ) -pci_set_power_state (to_pci_dev (hcd->self.controller), PCI_D3hot); } +EXPORT_SYMBOL_GPL (xhci_shutdown);#ifdef CONFIG_PM static void xhci_save_registers (struct xhci_hcd *xhci)
drivers/usb/host/xhci.h +1 -0
@@ -1833,6 +1833,7 @@ int xhci_run(struct usb_hcd *hcd);void xhci_stop (struct usb_hcd *hcd);void xhci_shutdown (struct usb_hcd *hcd);int xhci_gen_setup (struct usb_hcd *hcd,xhci_get_quirks_t get_quirks); +void xhci_shutdown (struct usb_hcd *hcd);void xhci_init_driver (struct hc_driver *drv,const struct xhci_driver_overrides *over);
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 125/162 xhci: Fix memory leak in xhci_add_in_port()
In reply to Greg Kroah-HartmanFrom: Mika Westerberg <[email protected]>
[ Upstream commit ce91f1a43b37463f517155bdfbd525eb43adbd1a ]
When xHCI is part of Alpine or Titan Ridge Thunderbolt controller and the xHCI device is hot-removed as a result of unplugging a dock for example, the driver leaks memory it allocates for xhci->usb3_rhub.psi and xhci->usb2_rhub.psi in xhci_add_in_port() as reported by kmemleak:
unreferenced object 0xffff922c24ef42f0 (size 16):
comm "kworker/u16:2", pid 178, jiffies 4294711640 (age 956.620s) hex dump (first 16 bytes):
21 00 0c 00 12 00 dc 05 23 00 e0 01 00 00 00 00 !.......#.......
backtrace:
[<000000007ac80914>] xhci_mem_init+0xcf8/0xeb7
[<0000000001b6d775>] xhci_init+0x7c/0x160
[<00000000db443fe3>] xhci_gen_setup+0x214/0x340
[<00000000fdffd320>] xhci_pci_setup+0x48/0x110
[<00000000541e1e03>] usb_add_hcd.cold+0x265/0x747
[<00000000ca47a56b>] usb_hcd_pci_probe+0x219/0x3b4
[<0000000021043861>] xhci_pci_probe+0x24/0x1c0
[<00000000b9231f25>] local_pci_probe+0x3d/0x70
[<000000006385c9d7>] pci_device_probe+0xd0/0x150
[<0000000070241068>] really_probe+0xf5/0x3c0
[<0000000061f35c0a>] driver_probe_device+0x58/0x100
[<000000009da11198>] bus_for_each_drv+0x79/0xc0
[<000000009ce45f69>] __device_attach+0xda/0x160
[<00000000df201aaf>] pci_bus_add_device+0x46/0x70
[<0000000088a1bc48>] pci_bus_add_devices+0x27/0x60
[<00000000ad9ee708>] pci_bus_add_devices+0x52/0x60
unreferenced object 0xffff922c24ef3318 (size 8):
comm "kworker/u16:2", pid 178, jiffies 4294711640 (age 956.620s)
hex dump (first 8 bytes):
34 01 05 00 35 41 0a 00 4...5A..
backtrace:
[<000000007ac80914>] xhci_mem_init+0xcf8/0xeb7
[<0000000001b6d775>] xhci_init+0x7c/0x160
[<00000000db443fe3>] xhci_gen_setup+0x214/0x340
[<00000000fdffd320>] xhci_pci_setup+0x48/0x110
[<00000000541e1e03>] usb_add_hcd.cold+0x265/0x747
[<00000000ca47a56b>] usb_hcd_pci_probe+0x219/0x3b4
[<0000000021043861>] xhci_pci_probe+0x24/0x1c0
[<00000000b9231f25>] local_pci_probe+0x3d/0x70
[<000000006385c9d7>] pci_device_probe+0xd0/0x150
[<0000000070241068>] really_probe+0xf5/0x3c0
[<0000000061f35c0a>] driver_probe_device+0x58/0x100
[<000000009da11198>] bus_for_each_drv+0x79/0xc0
[<000000009ce45f69>] __device_attach+0xda/0x160
[<00000000df201aaf>] pci_bus_add_device+0x46/0x70
[<0000000088a1bc48>] pci_bus_add_devices+0x27/0x60
[<00000000ad9ee708>] pci_bus_add_devices+0x52/0x60Fix this by calling kfree() for the both psi objects in xhci_mem_cleanup().
--- drivers/usb/host/xhci-mem.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/usb/host/xhci-mem.c +4 -0
@@ -1928,10 +1928,14 @@ no_bw:kfree (xhci->port_array);kfree (xhci->rh_bw);kfree (xhci->ext_caps); +kfree (xhci->usb2_rhub.psi); +kfree (xhci->usb3_rhub.psi); xhci->usb2_ports =NULL ; xhci->usb3_ports =NULL ; xhci->port_array =NULL ; + xhci->usb2_rhub.psi =NULL ; + xhci->usb3_rhub.psi =NULL ; xhci->rh_bw =NULL ; xhci->ext_caps =NULL ;
Greg Kroah-Hartman
maintainerPATCH 126/162 xhci: make sure interrupts are restored to correct state
In reply to Greg Kroah-HartmanFrom: Mathias Nyman <[email protected]>
[ Upstream commit bd82873f23c9a6ad834348f8b83f3b6a5bca2c65 ]
spin_unlock_irqrestore() might be called with stale flags after reading port status, possibly restoring interrupts to a incorrect state.
If a usb2 port just finished resuming while the port status is read the spin lock will be temporary released and re-acquired in a separate function. The flags parameter is passed as value instead of a pointer, not updating flags properly before the final spin_unlock_irqrestore() is called.
--- drivers/usb/host/xhci-hub.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/usb/host/xhci-hub.c +4 -4
@@ -704,7 +704,7 @@ static u32 xhci_get_port_status(struct usb_hcd *hcd, struct xhci_bus_state *bus_state, __le32 __iomem **port_array, u16 wIndex, u32 raw_port_status, - unsigned long flags) + unsigned long *flags) __releases(&xhci->lock) __acquires(&xhci->lock) {
@@ -786,12 +786,12 @@ static u32 xhci_get_port_status(struct usb_hcd *hcd,xhci_set_link_state (xhci, port_array, wIndex,XDEV_U0 ); -spin_unlock_irqrestore (&xhci->lock, flags); +spin_unlock_irqrestore (&xhci->lock, *flags); time_left =wait_for_completion_timeout ( &bus_state->rexit_done[wIndex],msecs_to_jiffies (XHCI_MAX_REXIT_TIMEOUT_MS )); -spin_lock_irqsave (&xhci->lock, flags); +spin_lock_irqsave (&xhci->lock, *flags);if (time_left) { slot_id = xhci_find_slot_id_by_port(hcd,
@@ -937,7 +937,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,break ; } status =xhci_get_port_status (hcd, bus_state, port_array, - wIndex, temp, flags); + wIndex, temp, &flags);if (status ==0xffffffff ) goto error;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 127/162 iio: adis16480: Add debugfs_reg_access entry
In reply to Greg Kroah-HartmanFrom: Nuno Sá <[email protected]>
[ Upstream commit 4c35b7a51e2f291471f7221d112c6a45c63e83bc ]
The driver is defining debugfs entries by calling adis16480_debugfs_init(). However, those entries are attached to the iio_dev debugfs entry which won't exist if no debugfs_reg_access callback is provided.
--- drivers/iio/imu/adis16480.c | 1 + 1 file changed, 1 insertion(+)
drivers/iio/imu/adis16480.c +1 -0
@@ -724,6 +724,7 @@ static const struct iio_info adis16480_info = { .write_raw = &adis16480_write_raw, .update_scan_mode = adis_update_scan_mode, .driver_module = THIS_MODULE, + .debugfs_reg_access = adis_debugfs_reg_access, };static int adis16480_stop_device (struct iio_dev *indio_dev)
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 128/162 Btrfs: fix negative subv_writers counter and data space leak after buffered write
In reply to Greg Kroah-HartmanFrom: Filipe Manana <[email protected]>
[ Upstream commit a0e248bb502d5165b3314ac3819e888fdcdf7d9f ]
When doing a buffered write it's possible to leave the subv_writers counter of the root, used for synchronization between buffered nocow writers and snapshotting. This happens in an exceptional case like the following:
1) We fail to allocate data space for the write, since there's not enough available data space nor enough unallocated space for allocating a new data block group;
2) Because of that failure, we try to go to NOCOW mode, which succeeds and therefore we set the local variable 'only_release_metadata' to true and set the root's sub_writers counter to 1 through the call to btrfs_start_write_no_snapshotting() made by check_can_nocow();
3) The call to btrfs_copy_from_user() returns zero, which is very unlikely to happen but not impossible;
4) No pages are copied because btrfs_copy_from_user() returned zero;
5) We call btrfs_end_write_no_snapshotting() which decrements the root's subv_writers counter to 0;
6) We don't set 'only_release_metadata' back to 'false' because we do it only if 'copied', the value returned by btrfs_copy_from_user(), is greater than zero;
7) On the next iteration of the while loop, which processes the same page range, we are now able to allocate data space for the write (we got enough data space released in the meanwhile);
8) After this if we fail at btrfs_delalloc_reserve_metadata(), because now there isn't enough free metadata space, or in some other place further below (prepare_pages(), lock_and_cleanup_extent_if_need(), btrfs_dirty_pages()), we break out of the while loop with 'only_release_metadata' having a value of 'true';
9) Because 'only_release_metadata' is 'true' we end up decrementing the root's subv_writers counter to -1 (through a call to btrfs_end_write_no_snapshotting()), and we also end up not releasing the data space previously reserved through btrfs_check_data_free_space(). As a consequence the mechanism for synchronizing NOCOW buffered writes with snapshotting gets broken.
Fix this by always setting 'only_release_metadata' to false at the start of each iteration.
--- fs/btrfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/file.c +1 -1
@@ -1525,6 +1525,7 @@ static noinline ssize_t __btrfs_buffered_write(struct file *file, } reserve_bytes = num_pages <<PAGE_CACHE_SHIFT ; + only_release_metadata = false; if ((BTRFS_I(inode)->flags & (BTRFS_INODE_NODATACOW | BTRFS_INODE_PREALLOC)) &&
@@ -1659,7 +1660,6 @@ again:set_extent_bit (&BTRFS_I (inode)->io_tree, lockstart, lockend,EXTENT_NORESERVE ,NULL ,NULL ,GFP_NOFS ); - only_release_metadata = false; }btrfs_drop_pages (pages, num_pages);
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 129/162 scsi: lpfc: Cap NPIV vports to 256
In reply to Greg Kroah-HartmanFrom: James Smart <[email protected]>
[ Upstream commit 8b47ae69e049ae0b3373859d901f0334322f9fe9 ]
Depending on the chipset, the number of NPIV vports may vary and be in excess of what most switches support (256). To avoid confusion with the users, limit the reported NPIV vports to 256.
Additionally correct the 16G adapter which is reporting a bogus NPIV vport number if the link is down.
--- drivers/scsi/lpfc/lpfc.h | 3 ++- drivers/scsi/lpfc/lpfc_attr.c | 12 ++++++++++-- drivers/scsi/lpfc/lpfc_init.c | 3 +++ 3 files changed, 15 insertions(+), 3 deletions(-)
drivers/scsi/lpfc/lpfc.h +2 -1
@@ -867,7 +867,8 @@ struct lpfc_hba {struct list_head port_list;struct lpfc_vport *pport;/* physical lpfc_vport pointer */ uint16_t max_vpi;/* Maximum virtual nports */ -#define LPFC_MAX_VPI 0xFFFF/* Max number of VPI supported */ +#define LPFC_MAX_VPI 0xFF/* Max number VPI supported 0 - 0xff */ +#define LPFC_MAX_VPORTS 0x100/* Max vports per port, with pport */ uint16_t max_vports;/* * For IOV HBAs max_vpi can change * after a reset. max_vports is max
drivers/scsi/lpfc/lpfc_attr.c +10 -2
@@ -1213,6 +1213,9 @@ lpfc_get_hba_info(struct lpfc_hba *phba, max_vpi = (bf_get (lpfc_mbx_rd_conf_vpi_count, rd_config) >0 ) ? (bf_get (lpfc_mbx_rd_conf_vpi_count, rd_config) -1 ) :0 ; +/* Limit the max we support */ +if (max_vpi >LPFC_MAX_VPI ) + max_vpi =LPFC_MAX_VPI ;if (mvpi) *mvpi = max_vpi;if (avpi)
@@ -1228,8 +1231,13 @@ lpfc_get_hba_info(struct lpfc_hba *phba, *axri = pmb->un.varRdConfig.avail_xri;if (mvpi) *mvpi = pmb->un.varRdConfig.max_vpi; -if (avpi) - *avpi = pmb->un.varRdConfig.avail_vpi; +if (avpi) { +/* avail_vpi is only valid if link is up and ready */ +if (phba->link_state ==LPFC_HBA_READY ) + *avpi = pmb->un.varRdConfig.avail_vpi; +else + *avpi = pmb->un.varRdConfig.max_vpi; + } }mempool_free (pmboxq, phba->mbox_mem_pool);
drivers/scsi/lpfc/lpfc_init.c +3 -0
@@ -6890,6 +6890,9 @@ lpfc_sli4_read_config(struct lpfc_hba *phba)bf_get (lpfc_mbx_rd_conf_xri_base, rd_config); phba->sli4_hba.max_cfg_param.max_vpi =bf_get (lpfc_mbx_rd_conf_vpi_count, rd_config); +/* Limit the max we support */ +if (phba->sli4_hba.max_cfg_param.max_vpi >LPFC_MAX_VPORTS ) + phba->sli4_hba.max_cfg_param.max_vpi =LPFC_MAX_VPORTS ; phba->sli4_hba.max_cfg_param.vpi_base =bf_get (lpfc_mbx_rd_conf_vpi_base, rd_config); phba->sli4_hba.max_cfg_param.max_rpi =
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 130/162 e100: Fix passing zero to PTR_ERR warning in e100_load_ucode_wait
In reply to Greg Kroah-HartmanFrom: YueHaibing <[email protected]>
[ Upstream commit cd0d465bb697a9c7bf66a9fe940f7981232f1676 ]
Fix a static code checker warning:drivers/net/ethernet/intel/e100.c:1349
e100_load_ucode_wait() warn: passing zero to 'PTR_ERR'
--- drivers/net/ethernet/intel/e100.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/e100.c +2 -2
@@ -1370,8 +1370,8 @@ static inline int e100_load_ucode_wait(struct nic *nic) fw =e100_request_firmware (nic);/* If it's NULL, then no ucode is required */ -if (!fw ||IS_ERR (fw)) -return PTR_ERR (fw); +if (IS_ERR_OR_NULL (fw)) +return PTR_ERR_OR_ZERO (fw);if ((err =e100_exec_cb (nic, (void *)fw, e100_setup_ucode))) netif_err(nic, probe, nic->netdev,
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 131/162 x86/MCE/AMD: Turn off MC4_MISC thresholding on all family 0x15 models
In reply to Greg Kroah-HartmanFrom: Shirish S <[email protected]>
[ Upstream commit c95b323dcd3598dd7ef5005d6723c1ba3b801093 ]
MC4_MISC thresholding is not supported on all family 0x15 processors, hence skip the x86_model check when applying the quirk.
[ bp: massage commit message. ]
--- arch/x86/kernel/cpu/mcheck/mce.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
arch/x86/kernel/cpu/mcheck/mce.c +2 -3
@@ -1536,11 +1536,10 @@ static int __mcheck_cpu_apply_quirks(struct cpuinfo_x86 *c) mce_flags.overflow_recov =1 ;/* -* Turn off MC4_MISC thresholding banks on those models since +* Turn off MC4_MISC thresholding banks on all models since * they're not supported there. */ -if (c->x86 ==0x15 && - (c->x86_model >=0x10 && c->x86_model <=0x1f )) { +if (c->x86 ==0x15 ) {int i;u64 hwcr;bool need_toggle;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 132/162 ARM: dts: omap3-tao3530: Fix incorrect MMC card detection GPIO polarity
In reply to Greg Kroah-HartmanFrom: Jarkko Nikula <[email protected]>
[ Upstream commit 287897f9aaa2ad1c923d9875914f57c4dc9159c8 ]
The MMC card detection GPIO polarity is active low on TAO3530, like in many other similar boards. Now the card is not detected and it is unable to mount rootfs from an SD card.
Fix this by using the correct polarity.
This incorrect polarity was defined already in the commit 30d95c6d7092 ("ARM: dts: omap3: Add Technexion TAO3530 SOM omap3-tao3530.dtsi") in v3.18 kernel and later changed to use defined GPIO constants in v4.4 kernel by the commit 3a637e008e54 ("ARM: dts: Use defined GPIO constants in flags cell for OMAP2+ boards").
While the latter commit did not introduce the issue I'm marking it with Fixes tag due the v4.4 kernels still being maintained.
--- arch/arm/boot/dts/omap3-tao3530.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/omap3-tao3530.dtsi +1 -1
@@ -225,7 +225,7 @@ pinctrl-0 = <&mmc1_pins>; vmmc-supply = <&vmmc1>; vmmc_aux-supply = <&vsim>; - cd-gpios = <&twl_gpio 0 GPIO_ACTIVE_HIGH>; + cd-gpios = <&twl_gpio 0 GPIO_ACTIVE_LOW>; bus-width = <8>; };
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 133/162 pinctrl: samsung: Fix device node refcount leaks in S3C64xx wakeup controller init
In reply to Greg Kroah-HartmanFrom: Krzysztof Kozlowski <[email protected]>
[ Upstream commit 7f028caadf6c37580d0f59c6c094ed09afc04062 ]
In s3c64xx_eint_eint0_init() the for_each_child_of_node() loop is used with a break to find a matching child node. Although each iteration of for_each_child_of_node puts the previous node, but early exit from loop misses it. This leads to leak of device node.
--- drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/pinctrl/samsung/pinctrl-s3c64xx.c +3 -0
@@ -713,6 +713,7 @@ static int s3c64xx_eint_eint0_init(struct samsung_pinctrl_drv_data *d) data =devm_kzalloc (dev,sizeof (*data),GFP_KERNEL );if (!data) {dev_err (dev,"could not allocate memory for wkup eint data\n" ); +of_node_put (eint0_np);return -ENOMEM ; } data->drvdata = d;
@@ -723,6 +724,7 @@ static int s3c64xx_eint_eint0_init(struct samsung_pinctrl_drv_data *d) irq =irq_of_parse_and_map (eint0_np, i);if (!irq) {dev_err (dev,"failed to get wakeup EINT IRQ %d\n" , i); +of_node_put (eint0_np);return -ENXIO ; }
@@ -730,6 +732,7 @@ static int s3c64xx_eint_eint0_init(struct samsung_pinctrl_drv_data *d) s3c64xx_eint0_handlers[i], data); } +of_node_put (eint0_np); bank = d->pin_banks;for (i =0 ; i < d->nr_banks; ++i, ++bank) {
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 134/162 scsi: qla2xxx: Fix DMA unmap leak
In reply to Greg Kroah-HartmanFrom: Himanshu Madhani <[email protected]>
[ Upstream commit 5d328de64d89400dcf9911125844d8adc0db697f ]
With debug kernel we see following wanings indicating memory leak.
[28809.523959] WARNING: CPU: 3 PID: 6790 at lib/dma-debug.c:978 dma_debug_device_change+0x166/0x1d0 [28809.523964] pci 0000:0c:00.6: DMA-API: device driver has pending DMA allocations while released from device [count=5] [28809.523964] One of leaked entries details: [device
address=0x00000002aefe4000] [size=8208 bytes] [mapped with DMA_BIDIRECTIONAL] [mapped as coherent]
Fix this by unmapping DMA memory.
--- drivers/scsi/qla2xxx/qla_bsg.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/scsi/qla2xxx/qla_bsg.c +4 -0
@@ -336,6 +336,8 @@ qla2x00_process_els(struct fc_bsg_job *bsg_job)dma_map_sg (&ha->pdev->dev, bsg_job->request_payload.sg_list, bsg_job->request_payload.sg_cnt,DMA_TO_DEVICE );if (!req_sg_cnt) { +dma_unmap_sg (&ha->pdev->dev, bsg_job->request_payload.sg_list, + bsg_job->request_payload.sg_cnt,DMA_TO_DEVICE ); rval = -ENOMEM ; goto done_free_fcport; }
@@ -343,6 +345,8 @@ qla2x00_process_els(struct fc_bsg_job *bsg_job) rsp_sg_cnt =dma_map_sg (&ha->pdev->dev, bsg_job->reply_payload.sg_list, bsg_job->reply_payload.sg_cnt,DMA_FROM_DEVICE );if (!rsp_sg_cnt) { +dma_unmap_sg (&ha->pdev->dev, bsg_job->reply_payload.sg_list, + bsg_job->reply_payload.sg_cnt,DMA_FROM_DEVICE ); rval = -ENOMEM ; goto done_free_fcport; }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 135/162 scsi: qla2xxx: Fix qla24xx_process_bidir_cmd()
In reply to Greg Kroah-HartmanFrom: Bart Van Assche <[email protected]>
[ Upstream commit c29282c65d1cf54daeea63be46243d7f69d72f4d ]
Set the r??_data_len variables before using these instead of after.
This patch fixes the following Coverity complaint:
const: At condition req_data_len != rsp_data_len, the value of req_data_len must be equal to 0.
const: At condition req_data_len != rsp_data_len, the value of rsp_data_len must be equal to 0.dead_error_condition: The condition req_data_len != rsp_data_len cannot be true.
--- drivers/scsi/qla2xxx/qla_bsg.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/scsi/qla2xxx/qla_bsg.c +5 -6
@@ -1743,8 +1743,8 @@ qla24xx_process_bidir_cmd(struct fc_bsg_job *bsg_job)uint16_t nextlid =0 ;uint32_t tot_dsds;srb_t *sp =NULL ; -uint32_t req_data_len =0 ; -uint32_t rsp_data_len =0 ; +uint32_t req_data_len; +uint32_t rsp_data_len;/* Check the type of the adapter */ if (!IS_BIDI_CAPABLE (ha)) {
@@ -1849,6 +1849,9 @@ qla24xx_process_bidir_cmd(struct fc_bsg_job *bsg_job) goto done_unmap_sg; } + req_data_len = bsg_job->request_payload.payload_len; + rsp_data_len = bsg_job->reply_payload.payload_len; +if (req_data_len != rsp_data_len) { rval =EXT_STATUS_BUSY ; ql_log(ql_log_warn, vha, 0x70aa,
@@ -1856,10 +1859,6 @@ qla24xx_process_bidir_cmd(struct fc_bsg_job *bsg_job) goto done_unmap_sg; } - req_data_len = bsg_job->request_payload.payload_len; - rsp_data_len = bsg_job->reply_payload.payload_len; - -/* Alloc SRB structure */ sp =qla2x00_get_sp (vha, &(vha->bidir_fcport),GFP_KERNEL );if (!sp) {
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 136/162 scsi: qla2xxx: Always check the qla2x00_wait_for_hba_online() return value
In reply to Greg Kroah-HartmanFrom: Bart Van Assche <[email protected]>
[ Upstream commit e6803efae5acd109fad9f2f07dab674563441a53 ]
This patch fixes several Coverity complaints about not always checking the qla2x00_wait_for_hba_online() return value.
--- drivers/scsi/qla2xxx/qla_attr.c | 3 ++- drivers/scsi/qla2xxx/qla_target.c | 7 +++++-- 2 files changed, 7 insertions(+), 3 deletions(-)
drivers/scsi/qla2xxx/qla_attr.c +2 -1
@@ -760,7 +760,8 @@ qla2x00_sysfs_write_reset(struct file *filp, struct kobject *kobj,break ; }else {/* Make sure FC side is not in reset */ -qla2x00_wait_for_hba_online (vha); +WARN_ON_ONCE (qla2x00_wait_for_hba_online (vha) != +QLA_SUCCESS );/* Issue MPI reset */ scsi_block_requests (vha->host);
drivers/scsi/qla2xxx/qla_target.c +5 -2
@@ -6026,7 +6026,8 @@ qlt_enable_vha(struct scsi_qla_host *vha) }else {set_bit (ISP_ABORT_NEEDED , &base_vha->dpc_flags);qla2xxx_wake_dpc (base_vha); -qla2x00_wait_for_hba_online (base_vha); +WARN_ON_ONCE (qla2x00_wait_for_hba_online (base_vha) != +QLA_SUCCESS ); } }EXPORT_SYMBOL (qlt_enable_vha);
@@ -6056,7 +6057,9 @@ static void qlt_disable_vha(struct scsi_qla_host *vha)set_bit (ISP_ABORT_NEEDED , &vha->dpc_flags);qla2xxx_wake_dpc (vha); -qla2x00_wait_for_hba_online (vha); +if (qla2x00_wait_for_hba_online (vha) !=QLA_SUCCESS ) +ql_dbg (ql_dbg_tgt, vha,0xe081 , +"qla2x00_wait_for_hba_online() failed\n" ); }/*
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 137/162 powerpc: Fix vDSO clock_getres()
In reply to Greg Kroah-HartmanFrom: Vincenzo Frascino <[email protected]>
[ Upstream commit 552263456215ada7ee8700ce022d12b0cffe4802 ]
clock_getres in the vDSO library has to preserve the same behaviour of posix_get_hrtimer_res().
In particular, posix_get_hrtimer_res() does:
sec = 0;
ns = hrtimer_resolution;and hrtimer_resolution depends on the enablement of the high resolution timers that can happen either at compile or at run time.
Fix the powerpc vdso implementation of clock_getres keeping a copy of hrtimer_resolution in vdso data and using that directly.
--- arch/powerpc/include/asm/vdso_datapage.h | 2 ++ arch/powerpc/kernel/asm-offsets.c | 2 +- arch/powerpc/kernel/time.c | 1 + arch/powerpc/kernel/vdso32/gettimeofday.S | 7 +++++-- arch/powerpc/kernel/vdso64/gettimeofday.S | 7 +++++-- 5 files changed, 14 insertions(+), 5 deletions(-)
arch/powerpc/include/asm/vdso_datapage.h +2 -0
@@ -86,6 +86,7 @@ struct vdso_data {__s32 wtom_clock_nsec;struct timespec stamp_xtime;/* xtime as at tb_orig_stamp */ __u32 stamp_sec_fraction;/* fractional seconds of stamp_xtime */ +__u32 hrtimer_res;/* hrtimer resolution */ __u32 syscall_map_64[SYSCALL_MAP_SIZE ];/* map of syscalls */ __u32 syscall_map_32[SYSCALL_MAP_SIZE ];/* map of syscalls */ };
@@ -107,6 +108,7 @@ struct vdso_data {__s32 wtom_clock_nsec;struct timespec stamp_xtime;/* xtime as at tb_orig_stamp */ __u32 stamp_sec_fraction;/* fractional seconds of stamp_xtime */ +__u32 hrtimer_res;/* hrtimer resolution */ __u32 syscall_map_32[SYSCALL_MAP_SIZE ];/* map of syscalls */ __u32 dcache_block_size;/* L1 d-cache block size */ __u32 icache_block_size;/* L1 i-cache block size */
arch/powerpc/kernel/asm-offsets.c +1 -1
@@ -398,6 +398,7 @@ int main(void)DEFINE (WTOM_CLOCK_NSEC , offsetof(struct vdso_data , wtom_clock_nsec));DEFINE (STAMP_XTIME , offsetof(struct vdso_data , stamp_xtime));DEFINE (STAMP_SEC_FRAC , offsetof(struct vdso_data , stamp_sec_fraction)); +DEFINE (CLOCK_HRTIMER_RES , offsetof(struct vdso_data , hrtimer_res));DEFINE (CFG_ICACHE_BLOCKSZ , offsetof(struct vdso_data , icache_block_size));DEFINE (CFG_DCACHE_BLOCKSZ , offsetof(struct vdso_data , dcache_block_size));DEFINE (CFG_ICACHE_LOGBLOCKSZ , offsetof(struct vdso_data , icache_log_block_size));
@@ -426,7 +427,6 @@ int main(void)DEFINE (CLOCK_REALTIME ,CLOCK_REALTIME );DEFINE (CLOCK_MONOTONIC ,CLOCK_MONOTONIC );DEFINE (NSEC_PER_SEC ,NSEC_PER_SEC ); -DEFINE (CLOCK_REALTIME_RES ,MONOTONIC_RES_NSEC );#ifdef CONFIG_BUG DEFINE (BUG_ENTRY_SIZE ,sizeof (struct bug_entry ));
arch/powerpc/kernel/time.c +1 -0
@@ -829,6 +829,7 @@ void update_vsyscall_old(struct timespec vdso_data->wtom_clock_nsec = wtm->tv_nsec; vdso_data->stamp_xtime = *wall_time; vdso_data->stamp_sec_fraction = frac_sec; + vdso_data->hrtimer_res = hrtimer_resolution;smp_wmb (); ++(vdso_data->tb_update_count); }
arch/powerpc/kernel/vdso32/gettimeofday.S +5 -2
@@ -160,12 +160,15 @@ V_FUNCTION_BEGIN(__kernel_clock_getres) cror cr0*4+eq,cr0*4+eq,cr1*4+eq bne cr0,99f + mflr r12 + .cfi_register lr,r12 + bl __get_datapage@local /* get data page */ + lwz r5, CLOCK_HRTIMER_RES(r3) + mtlr r12 li r3,0 cmpli cr0,r4,0 crclr cr0*4+so beqlr - lis r5,CLOCK_REALTIME_RES@h - ori r5,r5,CLOCK_REALTIME_RES@l stw r3,TSPC32_TV_SEC(r4) stw r5,TSPC32_TV_NSEC(r4) blr
arch/powerpc/kernel/vdso64/gettimeofday.S +5 -2
@@ -145,12 +145,15 @@ V_FUNCTION_BEGIN(__kernel_clock_getres) cror cr0*4+eq,cr0*4+eq,cr1*4+eq bne cr0,99f + mflr r12 + .cfi_register lr,r12 + bl V_LOCAL_FUNC(__get_datapage) + lwz r5, CLOCK_HRTIMER_RES(r3) + mtlr r12 li r3,0 cmpldi cr0,r4,0 crclr cr0*4+so beqlr - lis r5,CLOCK_REALTIME_RES@h - ori r5,r5,CLOCK_REALTIME_RES@l std r3,TSPC64_TV_SEC(r4) std r5,TSPC64_TV_NSEC(r4) blr
Greg Kroah-Hartman
maintainerPATCH 138/162 mm/shmem.c: cast the type of unmap_start to u64
In reply to Greg Kroah-HartmanFrom: Chen Jun <[email protected]>
commit aa71ecd8d86500da6081a72da6b0b524007e0627 upstream.
In 64bit system. sb->s_maxbytes of shmem filesystem is MAX_LFS_FILESIZE, which equal LLONG_MAX.
If offset > LLONG_MAX - PAGE_SIZE, offset + len < LLONG_MAX in shmem_fallocate, which will pass the checking in vfs_fallocate.
/* Check for wrap through zero too */ if (((offset + len) > inode->i_sb->s_maxbytes) || ((offset + len) < 0)) return -EFBIG;
loff_t unmap_start = round_up(offset, PAGE_SIZE) in shmem_fallocate causes a overflow.
Syzkaller reports a overflow problem in mm/shmem:
UBSAN: Undefined behaviour in mm/shmem.c:2014:10
signed integer overflow: '9223372036854775807 + 1' cannot be represented in type 'long long int'
CPU: 0 PID:17076 Comm: syz-executor0 Not tainted 4.1.46+ #1
Hardware name: linux, dummy-virt (DT)
Call trace:
dump_backtrace+0x0/0x2c8 arch/arm64/kernel/traps.c:100
show_stack+0x20/0x30 arch/arm64/kernel/traps.c:238
__dump_stack lib/dump_stack.c:15 [inline]
ubsan_epilogue+0x18/0x70 lib/ubsan.c:164
handle_overflow+0x158/0x1b0 lib/ubsan.c:195
shmem_fallocate+0x6d0/0x820 mm/shmem.c:2104
vfs_fallocate+0x238/0x428 fs/open.c:312
SYSC_fallocate fs/open.c:335 [inline]
SyS_fallocate+0x54/0xc8 fs/open.c:239The highest bit of unmap_start will be appended with sign bit 1 (overflow) when calculate shmem_falloc.start:
shmem_falloc.start = unmap_start >> PAGE_SHIFT.
Fix it by casting the type of unmap_start to u64, when right shifted.
This bug is found in LTS Linux 4.1. It also seems to exist in mainline.
--- mm/shmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/shmem.c +1 -1
@@ -2092,7 +2092,7 @@ static long shmem_fallocate(struct file } shmem_falloc.waitq = &shmem_falloc_waitq; - shmem_falloc.start = unmap_start >>PAGE_SHIFT ; + shmem_falloc.start = (u64 )unmap_start >>PAGE_SHIFT ; shmem_falloc.next = (unmap_end +1 ) >>PAGE_SHIFT ;spin_lock (&inode->i_lock); inode->i_private = &shmem_falloc;
Greg Kroah-Hartman
maintainerPATCH 139/162 blk-mq: make sure that line break can be printed
In reply to Greg Kroah-HartmanFrom: Ming Lei <[email protected]>
commit d2c9be89f8ebe7ebcc97676ac40f8dec1cf9b43a upstream.
8962842ca5ab ("blk-mq: avoid sysfs buffer overflow with too many CPU cores") avoids sysfs buffer overflow, and reserves one character for line break. However, the last snprintf() doesn't get correct 'size' parameter passed in, so fixed it.
--- block/blk-mq-sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
block/blk-mq-sysfs.c +1 -1
@@ -248,7 +248,7 @@ static ssize_t blk_mq_hw_sysfs_cpus_show pos += ret; } - ret =snprintf (pos + page, size - pos,"\n" ); + ret =snprintf (pos + page, size +1 - pos,"\n" );return pos + ret; }
Greg Kroah-Hartman
maintainerPATCH 140/162 workqueue: Fix missing kfree(rescuer) in destroy_workqueue()
In reply to Greg Kroah-HartmanFrom: Tejun Heo <[email protected]>
commit 8efe1223d73c218ce7e8b2e0e9aadb974b582d7f upstream.
--- kernel/workqueue.c | 1 + 1 file changed, 1 insertion(+)
kernel/workqueue.c +1 -0
@@ -3975,6 +3975,7 @@ void destroy_workqueue(struct workqueue_/* rescuer will empty maydays list before exiting */ kthread_stop (rescuer->task); +kfree (rescuer); }/* sanity checks */
Greg Kroah-Hartman
maintainerPATCH 141/162 sunrpc: fix crash when cache_head become valid before update
In reply to Greg Kroah-HartmanFrom: Pavel Tikhomirov <[email protected]>
[ Upstream commit 5fcaf6982d1167f1cd9b264704f6d1ef4c505d54 ]
I was investigating a crash in our Virtuozzo7 kernel which happened in in svcauth_unix_set_client. I found out that we access m_client field in ip_map structure, which was received from sunrpc_cache_lookup (we have a bit older kernel, now the code is in sunrpc_cache_add_entry), and these field looks uninitialized (m_client == 0x74 don't look like a pointer) but in the cache_head in flags we see 0x1 which is CACHE_VALID.
It looks like the problem appeared from our previous fix to sunrpc (1):
commit 4ecd55ea0742 ("sunrpc: fix cache_head leak due to queued request")
And we've also found a patch already fixing our patch (2):
commit d58431eacb22 ("sunrpc: don't mark uninitialised items as VALID.")
Though the crash is eliminated, I think the core of the problem is not completely fixed:
Neil in the patch (2) makes cache_head CACHE_NEGATIVE, before cache_fresh_locked which was added in (1) to fix crash. These way cache_is_valid won't say the cache is valid anymore and in svcauth_unix_set_client the function cache_check will return error instead of 0, and we don't count entry as initialized.
But it looks like we need to remove cache_fresh_locked completely in sunrpc_cache_lookup:
In (1) we've only wanted to make cache_fresh_unlocked->cache_dequeue so that cache_requests with no readers also release corresponding cache_head, to fix their leak. We with Vasily were not sure if cache_fresh_locked and cache_fresh_unlocked should be used in pair or not, so we've guessed to use them in pair.
Now we see that we don't want the CACHE_VALID bit set here by cache_fresh_locked, as "valid" means "initialized" and there is no initialization in sunrpc_cache_add_entry. Both expiry_time and last_refresh are not used in cache_fresh_unlocked code-path and also not required for the initial fix.
So to conclude cache_fresh_locked was called by mistake, and we can just safely remove it instead of crutching it with CACHE_NEGATIVE. It looks ideologically better for me. Hope I don't miss something here.
Here is our crash backtrace:
[13108726.326291] BUG: unable to handle kernel NULL pointer dereference at 0000000000000074 [13108726.326365] IP: [<ffffffffc01f79eb>] svcauth_unix_set_client+0x2ab/0x520 [sunrpc] [13108726.326448] PGD 0 [13108726.326468] Oops: 0002 [#1] SMP [13108726.326497] Modules linked in: nbd isofs xfs loop kpatch_cumulative_81_0_r1(O) xt_physdev nfnetlink_queue bluetooth rfkill ip6table_nat nf_nat_ipv6 ip_vs_wrr ip_vs_wlc ip_vs_sh nf_conntrack_netlink ip_vs_sed ip_vs_pe_sip nf_conntrack_sip ip_vs_nq ip_vs_lc ip_vs_lblcr ip_vs_lblc ip_vs_ftp ip_vs_dh nf_nat_ftp nf_conntrack_ftp iptable_raw xt_recent nf_log_ipv6 xt_hl ip6t_rt nf_log_ipv4 nf_log_common xt_LOG xt_limit xt_TCPMSS xt_tcpmss vxlan ip6_udp_tunnel udp_tunnel xt_statistic xt_NFLOG nfnetlink_log dummy xt_mark xt_REDIRECT nf_nat_redirect raw_diag udp_diag tcp_diag inet_diag netlink_diag af_packet_diag unix_diag rpcsec_gss_krb5 xt_addrtype ip6t_rpfilter ipt_REJECT nf_reject_ipv4 ip6t_REJECT nf_reject_ipv6 ebtable_nat ebtable_broute nf_conntrack_ipv6 nf_defrag_ipv6 ip6table_mangle ip6table_raw nfsv4 [13108726.327173] dns_resolver cls_u32 binfmt_misc arptable_filter arp_tables ip6table_filter ip6_tables devlink fuse_kio_pcs ipt_MASQUERADE nf_nat_masquerade_ipv4 xt_nat iptable_nat nf_nat_ipv4 xt_comment nf_conntrack_ipv4 nf_defrag_ipv4 xt_wdog_tmo xt_multiport bonding xt_set xt_conntrack iptable_filter iptable_mangle kpatch(O) ebtable_filter ebt_among ebtables ip_set_hash_ip ip_set nfnetlink vfat fat skx_edac intel_powerclamp coretemp intel_rapl iosf_mbi kvm_intel kvm irqbypass fuse pcspkr ses enclosure joydev sg mei_me hpwdt hpilo lpc_ich mei ipmi_si shpchp ipmi_devintf ipmi_msghandler xt_ipvs acpi_power_meter ip_vs_rr nfsv3 nfsd auth_rpcgss nfs_acl nfs lockd grace fscache nf_nat cls_fw sch_htb sch_cbq sch_sfq ip_vs em_u32 nf_conntrack tun br_netfilter veth overlay ip6_vzprivnet ip6_vznetstat ip_vznetstat [13108726.327817] ip_vzprivnet vziolimit vzevent vzlist vzstat vznetstat vznetdev vzmon vzdev bridge pio_kaio pio_nfs pio_direct pfmt_raw pfmt_ploop1 ploop ip_tables ext4 mbcache jbd2 sd_mod crc_t10dif crct10dif_generic mgag200 i2c_algo_bit drm_kms_helper scsi_transport_iscsi 8021q syscopyarea sysfillrect garp sysimgblt fb_sys_fops mrp stp ttm llc bnx2x crct10dif_pclmul crct10dif_common crc32_pclmul crc32c_intel drm dm_multipath ghash_clmulni_intel uas aesni_intel lrw gf128mul glue_helper ablk_helper cryptd tg3 smartpqi scsi_transport_sas mdio libcrc32c i2c_core usb_storage ptp pps_core wmi sunrpc dm_mirror dm_region_hash dm_log dm_mod [last unloaded: kpatch_cumulative_82_0_r1] [13108726.328403] CPU: 35 PID: 63742 Comm: nfsd ve: 51332 Kdump: loaded Tainted: G W O ------------ 3.10.0-862.20.2.vz7.73.29 #1 73.29 [13108726.328491] Hardware name: HPE ProLiant DL360 Gen10/ProLiant DL360 Gen10, BIOS U32 10/02/2018 [13108726.328554] task: ffffa0a6a41b1160 ti: ffffa0c2a74bc000 task.ti: ffffa0c2a74bc000 [13108726.328610] RIP: 0010:[<ffffffffc01f79eb>] [<ffffffffc01f79eb>] svcauth_unix_set_client+0x2ab/0x520 [sunrpc] [13108726.328706] RSP: 0018:ffffa0c2a74bfd80 EFLAGS: 00010246 [13108726.328750] RAX: 0000000000000001 RBX: ffffa0a6183ae000 RCX: 0000000000000000 [13108726.328811] RDX: 0000000000000074 RSI: 0000000000000286 RDI: ffffa0c2a74bfcf0 [13108726.328864] RBP: ffffa0c2a74bfe00 R08: ffffa0bab8c22960 R09: 0000000000000001 [13108726.328916] R10: 0000000000000001 R11: 0000000000000001 R12: ffffa0a32aa7f000 [13108726.328969] R13: ffffa0a6183afac0 R14: ffffa0c233d88d00 R15: ffffa0c2a74bfdb4 [13108726.329022] FS: 0000000000000000(0000) GS:ffffa0e17f9c0000(0000) knlGS:0000000000000000 [13108726.329081] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [13108726.332311] CR2: 0000000000000074 CR3: 00000026a1b28000 CR4: 00000000007607e0 [13108726.334606] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [13108726.336754] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [13108726.338908] PKRU: 00000000 [13108726.341047] Call Trace: [13108726.343074] [<ffffffff8a2c78b4>] ? groups_alloc+0x34/0x110 [13108726.344837] [<ffffffffc01f5eb4>] svc_set_client+0x24/0x30 [sunrpc] [13108726.346631] [<ffffffffc01f2ac1>] svc_process_common+0x241/0x710 [sunrpc] [13108726.348332] [<ffffffffc01f3093>] svc_process+0x103/0x190 [sunrpc] [13108726.350016] [<ffffffffc07d605f>] nfsd+0xdf/0x150 [nfsd] [13108726.351735] [<ffffffffc07d5f80>] ? nfsd_destroy+0x80/0x80 [nfsd] [13108726.353459] [<ffffffff8a2bf741>] kthread+0xd1/0xe0 [13108726.355195] [<ffffffff8a2bf670>] ? create_kthread+0x60/0x60 [13108726.356896] [<ffffffff8a9556dd>] ret_from_fork_nospec_begin+0x7/0x21 [13108726.358577] [<ffffffff8a2bf670>] ? create_kthread+0x60/0x60 [13108726.360240] Code: 4c 8b 45 98 0f 8e 2e 01 00 00 83 f8 fe 0f 84 76 fe ff ff 85 c0 0f 85 2b 01 00 00 49 8b 50 40 b8 01 00 00 00 48 89 93 d0 1a 00 00 <f0> 0f c1 02 83 c0 01 83 f8 01 0f 8e 53 02 00 00 49 8b 44 24 38 [13108726.363769] RIP [<ffffffffc01f79eb>] svcauth_unix_set_client+0x2ab/0x520 [sunrpc] [13108726.365530] RSP <ffffa0c2a74bfd80> [13108726.367179] CR2: 0000000000000074
--- net/sunrpc/cache.c | 6 ------ 1 file changed, 6 deletions(-)
net/sunrpc/cache.c +0 -6
@@ -54,9 +54,6 @@ static void cache_init(struct cache_head *h, struct cache_detail *detail) h->last_refresh = now; } -static inline int cache_is_valid (struct cache_head *h); -static void cache_fresh_locked (struct cache_head *head,time_t expiry, -struct cache_detail *detail);static void cache_fresh_unlocked (struct cache_head *head,struct cache_detail *detail);
@@ -101,9 +98,6 @@ struct cache_head *sunrpc_cache_lookup(struct cache_detail *detail,if (cache_is_expired (detail, tmp)) {hlist_del_init (&tmp->cache_list); detail->entries --; -if (cache_is_valid (tmp) == -EAGAIN ) -set_bit (CACHE_NEGATIVE , &tmp->flags); -cache_fresh_locked (tmp,0 , detail); freeme = tmp;break ; }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 142/162 kernel/module.c: wakeup processes in module_wq on module unload
In reply to Greg Kroah-HartmanFrom: Konstantin Khorenko <[email protected]>
[ Upstream commit 5d603311615f612320bb77bd2a82553ef1ced5b7 ]
Fix the race between load and unload a kernel module.
sys_delete_module()
try_stop_module()
mod->state = _GOING
add_unformed_module()
old = find_module_all() (old->state == _GOING =>
wait_event_interruptible())
During pre-condition finished_loading() rets 0 schedule() (never gets waken up later)
free_module()
mod->state = _UNFORMED
list_del_rcu(&mod->list)
(dels mod from "modules" list)
return
The race above leads to modprobe hanging forever on loading a module.
Error paths on loading module call wake_up_all(&module_wq) after freeing module, so let's do the same on straight module unload.
--- kernel/module.c | 2 ++ 1 file changed, 2 insertions(+)
kernel/module.c +2 -0
@@ -1014,6 +1014,8 @@ SYSCALL_DEFINE2(delete_module, const chastrlcpy (last_unloaded_module, mod->name,sizeof (last_unloaded_module));free_module (mod); +/* someone could wait for the module in add_unformed_module() */ +wake_up_all (&module_wq);return 0 ; out:mutex_unlock (&module_mutex);
Greg Kroah-Hartman
maintainerPATCH 143/162 net: bridge: deny dev_set_mac_address() when unregistering
In reply to Greg Kroah-HartmanFrom: Nikolay Aleksandrov <[email protected]>
[ Upstream commit c4b4c421857dc7b1cf0dccbd738472360ff2cd70 ]
We have an interesting memory leak in the bridge when it is being unregistered and is a slave to a master device which would change the mac of its slaves on unregister (e.g. bond, team). This is a very unusual setup but we do end up leaking 1 fdb entry because dev_set_mac_address() would cause the bridge to insert the new mac address into its table after all fdbs are flushed, i.e. after dellink() on the bridge has finished and we call NETDEV_UNREGISTER the bond/team would release it and will call dev_set_mac_address() to restore its original address and that in turn will add an fdb in the bridge.
One fix is to check for the bridge dev's reg_state in its ndo_set_mac_address callback and return an error if the bridge is not in NETREG_REGISTERED.
Easy steps to reproduce:
1. add bond in mode != A/B
2. add any slave to the bond
3. add bridge dev as a slave to the bond
4. destroy the bridge device
Trace:
unreferenced object 0xffff888035c4d080 (size 128):
comm "ip", pid 4068, jiffies 4296209429 (age 1413.753s) hex dump (first 32 bytes):
41 1d c9 36 80 88 ff ff 00 00 00 00 00 00 00 00 A..6............
d2 19 c9 5e 3f d7 00 00 00 00 00 00 00 00 00 00 ...^?...........
backtrace:
[<00000000ddb525dc>] kmem_cache_alloc+0x155/0x26f
[<00000000633ff1e0>] fdb_create+0x21/0x486 [bridge]
[<0000000092b17e9c>] fdb_insert+0x91/0xdc [bridge]
[<00000000f2a0f0ff>] br_fdb_change_mac_address+0xb3/0x175 [bridge]
[<000000001de02dbd>] br_stp_change_bridge_id+0xf/0xff [bridge]
[<00000000ac0e32b1>] br_set_mac_address+0x76/0x99 [bridge]
[<000000006846a77f>] dev_set_mac_address+0x63/0x9b
[<00000000d30738fc>] __bond_release_one+0x3f6/0x455 [bonding]
[<00000000fc7ec01d>] bond_netdev_event+0x2f2/0x400 [bonding]
[<00000000305d7795>] notifier_call_chain+0x38/0x56
[<0000000028885d4a>] call_netdevice_notifiers+0x1e/0x23
[<000000008279477b>] rollback_registered_many+0x353/0x6a4
[<0000000018ef753a>] unregister_netdevice_many+0x17/0x6f
[<00000000ba854b7a>] rtnl_delete_link+0x3c/0x43
[<00000000adf8618d>] rtnl_dellink+0x1dc/0x20a
[<000000009b6395fd>] rtnetlink_rcv_msg+0x23d/0x268--- net/bridge/br_device.c | 6 ++++++ 1 file changed, 6 insertions(+)
net/bridge/br_device.c +6 -0
@@ -199,6 +199,12 @@ static int br_set_mac_address(struct netif (!is_valid_ether_addr (addr->sa_data))return -EADDRNOTAVAIL ; +/* dev_set_mac_addr() can be called by a master device on bridge's +* NETDEV_UNREGISTER, but since it's being destroyed do nothing +*/ +if (dev->reg_state !=NETREG_REGISTERED ) +return -EBUSY ; +spin_lock_bh (&br->lock);if (!ether_addr_equal (dev->dev_addr, addr->sa_data)) {/* Mac address will be changed in br_stp_change_bridge_id(). */
Greg Kroah-Hartman
maintainerPATCH 144/162 tcp: md5: fix potential overestimation of TCP option space
In reply to Greg Kroah-HartmanFrom: Eric Dumazet <[email protected]>
[ Upstream commit 9424e2e7ad93ffffa88f882c9bc5023570904b55 ]
Back in 2008, Adam Langley fixed the corner case of packets for flows having all of the following options : MD5 TS SACK
Since MD5 needs 20 bytes, and TS needs 12 bytes, no sack block can be cooked from the remaining 8 bytes.
tcp_established_options() correctly sets opts->num_sack_blocks to zero, but returns 36 instead of 32.
This means TCP cooks packets with 4 extra bytes at the end of options, containing unitialized bytes.
--- net/ipv4/tcp_output.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
net/ipv4/tcp_output.c +3 -2
@@ -710,8 +710,9 @@ static unsigned int tcp_established_opti min_t(unsigned int, eff_sacks, (remaining -TCPOLEN_SACK_BASE_ALIGNED ) / TCPOLEN_SACK_PERBLOCK); - size +=TCPOLEN_SACK_BASE_ALIGNED + - opts->num_sack_blocks *TCPOLEN_SACK_PERBLOCK ; +if (likely (opts->num_sack_blocks)) + size +=TCPOLEN_SACK_BASE_ALIGNED + + opts->num_sack_blocks *TCPOLEN_SACK_PERBLOCK ; }return size;
Greg Kroah-Hartman
maintainerPATCH 145/162 tipc: fix ordering of tipc module init and exit routine
In reply to Greg Kroah-HartmanFrom: Taehee Yoo <[email protected]>
[ Upstream commit 9cf1cd8ee3ee09ef2859017df2058e2f53c5347f ]
In order to set/get/dump, the tipc uses the generic netlink infrastructure. So, when tipc module is inserted, init function calls genl_register_family().
After genl_register_family(), set/get/dump commands are immediately allowed and these callbacks internally use the net_generic. net_generic is allocated by register_pernet_device() but this is called after genl_register_family() in the __init function. So, these callbacks would use un-initialized net_generic.
Test commands:
#SHELL1
while :
do
modprobe tipc
modprobe -rv tipc
done
#SHELL2
while :
do
tipc link list
done
Splat looks like:
[ 59.616322][ T2788] kasan: CONFIG_KASAN_INLINE enabled [ 59.617234][ T2788] kasan: GPF could be caused by NULL-ptr deref or user memory access [ 59.618398][ T2788] general protection fault: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN PTI [ 59.619389][ T2788] CPU: 3 PID: 2788 Comm: tipc Not tainted 5.4.0+ #194 [ 59.620231][ T2788] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006 [ 59.621428][ T2788] RIP: 0010:tipc_bcast_get_broadcast_mode+0x131/0x310 [tipc] [ 59.622379][ T2788] Code: c7 c6 ef 8b 38 c0 65 ff 0d 84 83 c9 3f e8 d7 a5 f2 e3 48 8d bb 38 11 00 00 48 b8 00 00 00 00 [ 59.622550][ T2780] NET: Registered protocol family 30 [ 59.624627][ T2788] RSP: 0018:ffff88804b09f578 EFLAGS: 00010202 [ 59.624630][ T2788] RAX: dffffc0000000000 RBX: 0000000000000011 RCX: 000000008bc66907 [ 59.624631][ T2788] RDX: 0000000000000229 RSI: 000000004b3cf4cc RDI: 0000000000001149 [ 59.624633][ T2788] RBP: ffff88804b09f588 R08: 0000000000000003 R09: fffffbfff4fb3df1 [ 59.624635][ T2788] R10: fffffbfff50318f8 R11: ffff888066cadc18 R12: ffffffffa6cc2f40 [ 59.624637][ T2788] R13: 1ffff11009613eba R14: ffff8880662e9328 R15: ffff8880662e9328 [ 59.624639][ T2788] FS: 00007f57d8f7b740(0000) GS:ffff88806cc00000(0000) knlGS:0000000000000000 [ 59.624645][ T2788] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 59.625875][ T2780] tipc: Started in single node mode [ 59.626128][ T2788] CR2: 00007f57d887a8c0 CR3: 000000004b140002 CR4: 00000000000606e0 [ 59.633991][ T2788] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 59.635195][ T2788] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 59.636478][ T2788] Call Trace: [ 59.637025][ T2788] tipc_nl_add_bc_link+0x179/0x1470 [tipc] [ 59.638219][ T2788] ? lock_downgrade+0x6e0/0x6e0 [ 59.638923][ T2788] ? __tipc_nl_add_link+0xf90/0xf90 [tipc] [ 59.639533][ T2788] ? tipc_nl_node_dump_link+0x318/0xa50 [tipc] [ 59.640160][ T2788] ? mutex_lock_io_nested+0x1380/0x1380 [ 59.640746][ T2788] tipc_nl_node_dump_link+0x4fd/0xa50 [tipc] [ 59.641356][ T2788] ? tipc_nl_node_reset_link_stats+0x340/0x340 [tipc] [ 59.642088][ T2788] ? __skb_ext_del+0x270/0x270 [ 59.642594][ T2788] genl_lock_dumpit+0x85/0xb0 [ 59.643050][ T2788] netlink_dump+0x49c/0xed0 [ 59.643529][ T2788] ? __netlink_sendskb+0xc0/0xc0 [ 59.644044][ T2788] ? __netlink_dump_start+0x190/0x800 [ 59.644617][ T2788] ? __mutex_unlock_slowpath+0xd0/0x670 [ 59.645177][ T2788] __netlink_dump_start+0x5a0/0x800 [ 59.645692][ T2788] genl_rcv_msg+0xa75/0xe90 [ 59.646144][ T2788] ? __lock_acquire+0xdfe/0x3de0 [ 59.646692][ T2788] ? genl_family_rcv_msg_attrs_parse+0x320/0x320 [ 59.647340][ T2788] ? genl_lock_dumpit+0xb0/0xb0 [ 59.647821][ T2788] ? genl_unlock+0x20/0x20 [ 59.648290][ T2788] ? genl_parallel_done+0xe0/0xe0 [ 59.648787][ T2788] ? find_held_lock+0x39/0x1d0 [ 59.649276][ T2788] ? genl_rcv+0x15/0x40 [ 59.649722][ T2788] ? lock_contended+0xcd0/0xcd0 [ 59.650296][ T2788] netlink_rcv_skb+0x121/0x350 [ 59.650828][ T2788] ? genl_family_rcv_msg_attrs_parse+0x320/0x320 [ 59.651491][ T2788] ? netlink_ack+0x940/0x940 [ 59.651953][ T2788] ? lock_acquire+0x164/0x3b0 [ 59.652449][ T2788] genl_rcv+0x24/0x40 [ 59.652841][ T2788] netlink_unicast+0x421/0x600
[ ... ]
--- net/tipc/core.c | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-)
net/tipc/core.c +15 -14
@@ -117,14 +117,6 @@ static int __init tipc_init(void)TIPC_CRITICAL_IMPORTANCE ; sysctl_tipc_rmem[2 ] =TIPC_CONN_OVERLOAD_LIMIT ; - err =tipc_netlink_start (); -if (err) - goto out_netlink; - - err =tipc_netlink_compat_start (); -if (err) - goto out_netlink_compat; - err =tipc_register_sysctl ();if (err) goto out_sysctl;
@@ -145,8 +137,21 @@ static int __init tipc_init(void)if (err) goto out_bearer; + err =tipc_netlink_start (); +if (err) + goto out_netlink; + + err =tipc_netlink_compat_start (); +if (err) + goto out_netlink_compat; +pr_info ("Started in single node mode\n" );return 0 ; + +out_netlink_compat: +tipc_netlink_stop (); +out_netlink: +tipc_bearer_cleanup (); out_bearer:unregister_pernet_device (&tipc_topsrv_net_ops); out_pernet_topsrv:
@@ -156,22 +161,18 @@ out_socket: out_pernet:tipc_unregister_sysctl (); out_sysctl: -tipc_netlink_compat_stop (); -out_netlink_compat: -tipc_netlink_stop (); -out_netlink:pr_err ("Unable to start in single node mode\n" );return err; } static void __exit tipc_exit(void) { +tipc_netlink_compat_stop (); +tipc_netlink_stop ();tipc_bearer_cleanup ();unregister_pernet_device (&tipc_topsrv_net_ops);tipc_socket_stop ();unregister_pernet_device (&tipc_net_ops); -tipc_netlink_stop (); -tipc_netlink_compat_stop ();tipc_unregister_sysctl ();pr_info ("Deactivated\n" );
Greg Kroah-Hartman
maintainerPATCH 146/162 inet: protect against too small mtu values.
In reply to Greg Kroah-HartmanFrom: Eric Dumazet <[email protected]>
[ Upstream commit 501a90c945103e8627406763dac418f20f3837b2 ]
syzbot was once again able to crash a host by setting a very small mtu on loopback device.
Let's make inetdev_valid_mtu() available in include/net/ip.h, and use it in ip_setup_cork(), so that we protect both ip_append_page() and __ip_append_data()
Also add a READ_ONCE() when the device mtu is read.
Pairs this lockless read with one WRITE_ONCE() in __dev_set_mtu(), even if other code paths might write over this field.
Add a big comment in include/linux/netdevice.h about dev->mtu needing READ_ONCE()/WRITE_ONCE() annotations.
Hopefully we will add the missing ones in followup patches.
[1]
refcount_t: saturated; leaking memory.
WARNING: CPU: 0 PID: 9464 at lib/refcount.c:22 refcount_warn_saturate+0x138/0x1f0 lib/refcount.c:22 Kernel panic - not syncing: panic_on_warn set ... CPU: 0 PID: 9464 Comm: syz-executor850 Not tainted 5.4.0-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x197/0x210 lib/dump_stack.c:118 panic+0x2e3/0x75c kernel/panic.c:221 __warn.cold+0x2f/0x3e kernel/panic.c:582 report_bug+0x289/0x300 lib/bug.c:195 fixup_bug arch/x86/kernel/traps.c:174 [inline] fixup_bug arch/x86/kernel/traps.c:169 [inline] do_error_trap+0x11b/0x200 arch/x86/kernel/traps.c:267 do_invalid_op+0x37/0x50 arch/x86/kernel/traps.c:286 invalid_op+0x23/0x30 arch/x86/entry/entry_64.S:1027 RIP: 0010:refcount_warn_saturate+0x138/0x1f0 lib/refcount.c:22 Code: 06 31 ff 89 de e8 c8 f5 e6 fd 84 db 0f 85 6f ff ff ff e8 7b f4 e6 fd 48 c7 c7 e0 71 4f 88 c6 05 56 a6 a4 06 01 e8 c7 a8 b7 fd <0f> 0b e9 50 ff ff ff e8 5c f4 e6 fd 0f b6 1d 3d a6 a4 06 31 ff 89 RSP: 0018:ffff88809689f550 EFLAGS: 00010286 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 RDX: 0000000000000000 RSI: ffffffff815e4336 RDI: ffffed1012d13e9c RBP: ffff88809689f560 R08: ffff88809c50a3c0 R09: fffffbfff15d31b1 R10: fffffbfff15d31b0 R11: ffffffff8ae98d87 R12: 0000000000000001 R13: 0000000000040100 R14: ffff888099041104 R15: ffff888218d96e40 refcount_add include/linux/refcount.h:193 [inline] skb_set_owner_w+0x2b6/0x410 net/core/sock.c:1999 sock_wmalloc+0xf1/0x120 net/core/sock.c:2096 ip_append_page+0x7ef/0x1190 net/ipv4/ip_output.c:1383 udp_sendpage+0x1c7/0x480 net/ipv4/udp.c:1276 inet_sendpage+0xdb/0x150 net/ipv4/af_inet.c:821 kernel_sendpage+0x92/0xf0 net/socket.c:3794 sock_sendpage+0x8b/0xc0 net/socket.c:936 pipe_to_sendpage+0x2da/0x3c0 fs/splice.c:458 splice_from_pipe_feed fs/splice.c:512 [inline] __splice_from_pipe+0x3ee/0x7c0 fs/splice.c:636 splice_from_pipe+0x108/0x170 fs/splice.c:671 generic_splice_sendpage+0x3c/0x50 fs/splice.c:842 do_splice_from fs/splice.c:861 [inline] direct_splice_actor+0x123/0x190 fs/splice.c:1035 splice_direct_to_actor+0x3b4/0xa30 fs/splice.c:990 do_splice_direct+0x1da/0x2a0 fs/splice.c:1078 do_sendfile+0x597/0xd00 fs/read_write.c:1464 __do_sys_sendfile64 fs/read_write.c:1525 [inline] __se_sys_sendfile64 fs/read_write.c:1511 [inline] __x64_sys_sendfile64+0x1dd/0x220 fs/read_write.c:1511 do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x441409 Code: e8 ac e8 ff ff 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 eb 08 fc ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:00007fffb64c4f78 EFLAGS: 00000246 ORIG_RAX: 0000000000000028 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 0000000000441409 RDX: 0000000000000000 RSI: 0000000000000006 RDI: 0000000000000005 RBP: 0000000000073b8a R08: 0000000000000010 R09: 0000000000000010 R10: 0000000000010001 R11: 0000000000000246 R12: 0000000000402180 R13: 0000000000402210 R14: 0000000000000000 R15: 0000000000000000
Kernel Offset: disabled
Rebooting in 86400 seconds..
--- include/linux/netdevice.h | 5 +++++ include/net/ip.h | 5 +++++ net/core/dev.c | 3 ++- net/ipv4/devinet.c | 5 ----- net/ipv4/ip_output.c | 14 +++++++++----- 5 files changed, 21 insertions(+), 11 deletions(-)
include/linux/netdevice.h +5 -0
@@ -1617,6 +1617,11 @@ struct net_device {unsigned char if_port;unsigned char dma; +/* Note : dev->mtu is often read without holding a lock. +* Writers usually hold RTNL. +* It is recommended to use READ_ONCE() to annotate the reads, +* and to use WRITE_ONCE() to annotate the writes. +*/ unsigned int mtu;unsigned short type;unsigned short hard_header_len;
include/net/ip.h +5 -0
@@ -596,4 +596,9 @@ extern int sysctl_icmp_msgs_burst;int ip_misc_proc_init (void );#endif +static inline bool inetdev_valid_mtu (unsigned int mtu) +{ +return likely (mtu >=IPV4_MIN_MTU ); +} +#endif /* _IP_H */
net/core/dev.c +2 -1
@@ -6126,7 +6126,8 @@ static int __dev_set_mtu(struct net_deviif (ops->ndo_change_mtu)return ops->ndo_change_mtu (dev, new_mtu); - dev->mtu = new_mtu; +/* Pairs with all the lockless reads of dev->mtu in the stack */ +WRITE_ONCE (dev->mtu, new_mtu);return 0 ; }
net/ipv4/devinet.c +0 -5
@@ -1364,11 +1364,6 @@ skip: } } -static bool inetdev_valid_mtu (unsigned int mtu) -{ -return mtu >=IPV4_MIN_MTU ; -} -static void inetdev_send_gratuitous_arp (struct net_device *dev,struct in_device *in_dev)
net/ipv4/ip_output.c +9 -5
@@ -1145,13 +1145,17 @@ static int ip_setup_cork(struct sock *sk rt = *rtp;if (unlikely (!rt))return -EFAULT ; -/* -* We steal reference to this route, caller should not release it -*/ - *rtp =NULL ; + cork->fragsize =ip_sk_use_pmtu (sk) ? -dst_mtu (&rt->dst) : rt->dst.dev->mtu; +dst_mtu (&rt->dst) :READ_ONCE (rt->dst.dev->mtu); + +if (!inetdev_valid_mtu (cork->fragsize)) +return -ENETUNREACH ; + cork->dst = &rt->dst; +/* We stole this route, caller should not release it. */ + *rtp =NULL ; + cork->length =0 ; cork->ttl = ipc->ttl; cork->tos = ipc->tos;
Greg Kroah-Hartman
maintainerPATCH 147/162 tcp: fix rejected syncookies due to stale timestamps
In reply to Greg Kroah-HartmanFrom: Guillaume Nault <[email protected]>
[ Upstream commit 04d26e7b159a396372646a480f4caa166d1b6720 ]
If no synflood happens for a long enough period of time, then the synflood timestamp isn't refreshed and jiffies can advance so much that time_after32() can't accurately compare them any more.
Therefore, we can end up in a situation where time_after32(now, last_overflow + HZ) returns false, just because these two values are too far apart. In that case, the synflood timestamp isn't updated as it should be, which can trick tcp_synq_no_recent_overflow() into rejecting valid syncookies.
For example, let's consider the following scenario on a system with HZ=1000:
* The synflood timestamp is 0, either because that's the timestamp of the last synflood or, more commonly, because we're working with a freshly created socket.
* We receive a new SYN, which triggers synflood protection. Let's say
that this happens when jiffies == 2147484649 (that is,
'synflood timestamp' + HZ + 2^31 + 1). * Then tcp_synq_overflow() doesn't update the synflood timestamp, because time_after32(2147484649, 1000) returns false. With:
- 2147484649: the value of jiffies, aka. 'now'.
- 1000: the value of 'last_overflow' + HZ.
* A bit later, we receive the ACK completing the 3WHS. But cookie_v[46]_check() rejects it because tcp_synq_no_recent_overflow() says that we're not under synflood. That's because time_after32(2147484649, 120000) returns false.
With:
- 2147484649: the value of jiffies, aka. 'now'.
- 120000: the value of 'last_overflow' + TCP_SYNCOOKIE_VALID.
Of course, in reality jiffies would have increased a bit, but this condition will last for the next 119 seconds, which is far enough to accommodate for jiffie's growth.
Fix this by updating the overflow timestamp whenever jiffies isn't within the [last_overflow, last_overflow + HZ] range. That shouldn't have any performance impact since the update still happens at most once per second.
Now we're guaranteed to have fresh timestamps while under synflood, so tcp_synq_no_recent_overflow() can safely use it with time_after32() in such situations.
Stale timestamps can still make tcp_synq_no_recent_overflow() return the wrong verdict when not under synflood. This will be handled in the next patch.
For 64 bits architectures, the problem was introduced with the conversion of ->tw_ts_recent_stamp to 32 bits integer by commit cca9bab1b72c ("tcp: use monotonic timestamps for PAWS"). The problem has always been there on 32 bits architectures.
--- include/linux/time.h | 12 ++++++++++++ include/net/tcp.h | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-)
include/linux/time.h +12 -0
@@ -262,4 +262,16 @@ static __always_inline void timespec_add a->tv_nsec = ns; } +/** +* time_between32 - check if a 32-bit timestamp is within a given time range +* @t: the time which may be within [l,h] +* @l: the lower bound of the range +* @h: the higher bound of the range +* +* time_before32(t, l, h) returns true if @l <= @t <= @h. All operands are +* treated as 32-bit integers. +* +* Equivalent to !(time_before32(@t, @l) || time_after32(@t, @h)). +*/ +#define time_between32 (t, l, h) ((u32)(h) - (u32)(l) >= (u32)(t) - (u32)(l))#endif
include/net/tcp.h +1 -1
@@ -505,7 +505,7 @@ static inline void tcp_synq_overflow(conunsigned long last_overflow =tcp_sk (sk)->rx_opt.ts_recent_stamp;unsigned long now = jiffies; -if (time_after (now, last_overflow +HZ )) +if (!time_between32 (now, last_overflow, last_overflow +HZ ))tcp_sk (sk)->rx_opt.ts_recent_stamp = now; }
Greg Kroah-Hartman
maintainerPATCH 148/162 tcp: tighten acceptance of ACKs not matching a child socket
In reply to Greg Kroah-HartmanFrom: Guillaume Nault <[email protected]>
[ Upstream commit cb44a08f8647fd2e8db5cc9ac27cd8355fa392d8 ]
When no synflood occurs, the synflood timestamp isn't updated. Therefore it can be so old that time_after32() can consider it to be in the future.
That's a problem for tcp_synq_no_recent_overflow() as it may report that a recent overflow occurred while, in fact, it's just that jiffies has grown past 'last_overflow' + TCP_SYNCOOKIE_VALID + 2^31.
Spurious detection of recent overflows lead to extra syncookie verification in cookie_v[46]_check(). At that point, the verification should fail and the packet dropped. But we should have dropped the packet earlier as we didn't even send a syncookie.
Let's refine tcp_synq_no_recent_overflow() to report a recent overflow only if jiffies is within the
[last_overflow, last_overflow + TCP_SYNCOOKIE_VALID] interval. This way, no spurious recent overflow is reported when jiffies wraps and 'last_overflow' becomes in the future from the point of view of time_after32().
However, if jiffies wraps and enters the
[last_overflow, last_overflow + TCP_SYNCOOKIE_VALID] interval (with 'last_overflow' being a stale synflood timestamp), then tcp_synq_no_recent_overflow() still erroneously reports an overflow. In such cases, we have to rely on syncookie verification to drop the packet. We unfortunately have no way to differentiate between a fresh and a stale syncookie timestamp.
In practice, using last_overflow as lower bound is problematic. If the synflood timestamp is concurrently updated between the time we read jiffies and the moment we store the timestamp in 'last_overflow', then 'now' becomes smaller than 'last_overflow' and tcp_synq_no_recent_overflow() returns true, potentially dropping a valid syncookie.
Reading jiffies after loading the timestamp could fix the problem, but that'd require a memory barrier. Let's just accommodate for potential timestamp growth instead and extend the interval using 'last_overflow - HZ' as lower bound.
--- include/net/tcp.h | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
include/net/tcp.h +9 -1
@@ -514,7 +514,15 @@ static inline bool tcp_synq_no_recent_ov {unsigned long last_overflow =tcp_sk (sk)->rx_opt.ts_recent_stamp; -return time_after (jiffies, last_overflow +TCP_SYNCOOKIE_VALID ); +/* If last_overflow <= jiffies <= last_overflow + TCP_SYNCOOKIE_VALID, +* then we're under synflood. However, we have to use +* 'last_overflow - HZ' as lower bound. That's because a concurrent +* tcp_synq_overflow() could update .ts_recent_stamp after we read +* jiffies but before we store .ts_recent_stamp into last_overflow, +* which could lead to rejecting a valid syncookie. +*/ +return !time_between32 (jiffies, last_overflow -HZ , + last_overflow +TCP_SYNCOOKIE_VALID ); }static inline u32 tcp_cookie_time (void )
Greg Kroah-Hartman
maintainerPATCH 149/162 tcp: Protect accesses to .ts_recent_stamp with {READ,WRITE}_ONCE()
In reply to Greg Kroah-HartmanFrom: Guillaume Nault <[email protected]>
[ Upstream commit 721c8dafad26ccfa90ff659ee19755e3377b829d ]
Syncookies borrow the ->rx_opt.ts_recent_stamp field to store the timestamp of the last synflood. Protect them with READ_ONCE() and WRITE_ONCE() since reads and writes aren't serialised.
Use of .rx_opt.ts_recent_stamp for storing the synflood timestamp was introduced by a0f82f64e269 ("syncookies: remove last_synq_overflow from struct tcp_sock"). But unprotected accesses were already there when timestamp was stored in .last_synq_overflow.
--- include/net/tcp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
include/net/tcp.h +3 -3
@@ -502,17 +502,17 @@ struct sock *cookie_v4_check(struct sock*/ static inline void tcp_synq_overflow (const struct sock *sk) { -unsigned long last_overflow =tcp_sk (sk)->rx_opt.ts_recent_stamp; +unsigned long last_overflow =READ_ONCE (tcp_sk (sk)->rx_opt.ts_recent_stamp);unsigned long now = jiffies;if (!time_between32 (now, last_overflow, last_overflow +HZ )) -tcp_sk (sk)->rx_opt.ts_recent_stamp = now; +WRITE_ONCE (tcp_sk (sk)->rx_opt.ts_recent_stamp, now); }/* syncookies: no recent synqueue overflow on this listening socket? */ static inline bool tcp_synq_no_recent_overflow (const struct sock *sk) { -unsigned long last_overflow =tcp_sk (sk)->rx_opt.ts_recent_stamp; +unsigned long last_overflow =READ_ONCE (tcp_sk (sk)->rx_opt.ts_recent_stamp);/* If last_overflow <= jiffies <= last_overflow + TCP_SYNCOOKIE_VALID, * then we're under synflood. However, we have to use
Greg Kroah-Hartman
maintainerPATCH 150/162 net: ethernet: ti: cpsw: fix extra rx interrupt
In reply to Greg Kroah-HartmanFrom: Grygorii Strashko <[email protected]>
[ Upstream commit 51302f77bedab8768b761ed1899c08f89af9e4e2 ]
Now RX interrupt is triggered twice every time, because in cpsw_rx_interrupt() it is asked first and then disabled. So there will be pending interrupt always, when RX interrupt is enabled again in NAPI handler.
Fix it by first disabling IRQ and then do ask.
--- drivers/net/ethernet/ti/cpsw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/ti/cpsw.c +1 -1
@@ -777,8 +777,8 @@ static irqreturn_t cpsw_rx_interrupt(int {struct cpsw_priv *priv = dev_id; -cpdma_ctlr_eoi (priv->dma,CPDMA_EOI_RX );writel (0 , &priv->wr_regs->rx_en); +cpdma_ctlr_eoi (priv->dma,CPDMA_EOI_RX );if (priv->quirk_irq) {disable_irq_nosync (priv->irqs_table[0 ]);
Greg Kroah-Hartman
maintainerPATCH 151/162 PCI: Fix Intel ACS quirk UPDCR register address
In reply to Greg Kroah-HartmanFrom: Steffen Liebergeld <[email protected]>
commit d8558ac8c93d429d65d7490b512a3a67e559d0d4 upstream.
According to documentation [0] the correct offset for the Upstream Peer Decode Configuration Register (UPDCR) is 0x1014. It was previously defined as 0x1114.
d99321b63b1f ("PCI: Enable quirks for PCIe ACS on Intel PCH root ports") intended to enforce isolation between PCI devices allowing them to be put into separate IOMMU groups. Due to the wrong register offset the intended isolation was not fully enforced. This is fixed with this patch.
Please note that I did not test this patch because I have no hardware that implements this register.
[0] https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/4th-gen-core-family-mobile-i-o-datasheet.pdf (page 325)
--- drivers/pci/quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/quirks.c +1 -1
@@ -4038,7 +4038,7 @@ int pci_dev_specific_acs_enabled(struct#define INTEL_BSPR_REG_BPPD (1 << 9)/* Upstream Peer Decode Configuration Register */ -#define INTEL_UPDCR_REG 0x1114 +#define INTEL_UPDCR_REG 0x1014/* 5:0 Peer Decode Enable bits */ #define INTEL_UPDCR_REG_MASK 0x3f
Greg Kroah-Hartman
maintainerPATCH 152/162 PCI/MSI: Fix incorrect MSI-X masking on resume
In reply to Greg Kroah-HartmanFrom: Jian-Hong Pan <[email protected]>
commit e045fa29e89383c717e308609edd19d2fd29e1be upstream.
When a driver enables MSI-X, msix_program_entries() reads the MSI-X Vector Control register for each vector and saves it in desc->masked. Each register is 32 bits and bit 0 is the actual Mask bit.
When we restored these registers during resume, we previously set the Mask bit if *any* bit in desc->masked was set instead of when the Mask bit itself was set:
pci_restore_state
pci_restore_msi_state
__pci_restore_msix_state
for_each_pci_msi_entry
msix_mask_irq(entry, entry->masked) <-- entire u32 word
__pci_msix_desc_mask_irq(desc, flag)
mask_bits = desc->masked & ~PCI_MSIX_ENTRY_CTRL_MASKBIT
if (flag) <-- testing entire u32, not just bit 0
mask_bits |= PCI_MSIX_ENTRY_CTRL_MASKBIT
writel(mask_bits, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL)This means that after resume, MSI-X vectors were masked when they shouldn't be, which leads to timeouts like this:
nvme nvme0: I/O 978 QID 3 timeout, completion polled
On resume, set the Mask bit only when the saved Mask bit from suspend was set.
This should remove the need for 19ea025e1d28 ("nvme: Add quirk for Kingston NVME SSD running FW E8FK11.T").
--- drivers/pci/msi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/msi.c +1 -1
@@ -224,7 +224,7 @@ u32 __pci_msix_desc_mask_irq(struct msi_return 0 ; mask_bits &= ~PCI_MSIX_ENTRY_CTRL_MASKBIT ; -if (flag) +if (flag &PCI_MSIX_ENTRY_CTRL_MASKBIT ) mask_bits |=PCI_MSIX_ENTRY_CTRL_MASKBIT ;writel (mask_bits, desc->mask_base + offset);
Greg Kroah-Hartman
maintainerPATCH 153/162 xtensa: fix TLB sanity checker
In reply to Greg Kroah-HartmanFrom: Max Filippov <[email protected]>
commit 36de10c4788efc6efe6ff9aa10d38cb7eea4c818 upstream.
Virtual and translated addresses retrieved by the xtensa TLB sanity checker must be consistent, i.e. correspond to the same state of the checked TLB entry. KASAN shadow memory is mapped dynamically using auto-refill TLB entries and thus may change TLB state between the virtual and translated address retrieval, resulting in false TLB insanity report.
Move read_xtlb_translation close to read_xtlb_virtual to make sure that read values are consistent.
--- arch/xtensa/mm/tlb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/xtensa/mm/tlb.c +2 -2
@@ -218,6 +218,8 @@ static int check_tlb_entry(unsigned w, uunsigned tlbidx = w | (e <<PAGE_SHIFT );unsigned r0 = dtlb ?read_dtlb_virtual (tlbidx) :read_itlb_virtual (tlbidx); +unsigned r1 = dtlb ? +read_dtlb_translation (tlbidx) :read_itlb_translation (tlbidx);unsigned vpn = (r0 &PAGE_MASK ) | (e <<PAGE_SHIFT );unsigned pte =get_pte_for_vaddr (vpn);unsigned mm_asid = (get_rasid_register () >>8 ) &ASID_MASK ;
@@ -233,8 +235,6 @@ static int check_tlb_entry(unsigned w, u }if (tlb_asid == mm_asid) { -unsigned r1 = dtlb ?read_dtlb_translation (tlbidx) : -read_itlb_translation (tlbidx);if ((pte ^ r1) &PAGE_MASK ) {pr_err ("%cTLB: way: %u, entry: %u, mapping: %08x->%08x, PTE: %08x\n" , dtlb ?'D' :'I' , w, e, r0, r1, pte);
Greg Kroah-Hartman
maintainerPATCH 154/162 CIFS: Respect O_SYNC and O_DIRECT flags during reconnect
In reply to Greg Kroah-HartmanFrom: Pavel Shilovsky <[email protected]>
commit 44805b0e62f15e90d233485420e1847133716bdc upstream.
Currently the client translates O_SYNC and O_DIRECT flags into corresponding SMB create options when openning a file. The problem is that on reconnect when the file is being re-opened the client doesn't set those flags and it causes a server to reject re-open requests because create options don't match. The latter means that any subsequent system call against that open file fail until a share is re-mounted.
Fix this by properly setting SMB create options when re-openning files after reconnects.
--- fs/cifs/file.c | 7 +++++++ 1 file changed, 7 insertions(+)
fs/cifs/file.c +7 -0
@@ -703,6 +703,13 @@ cifs_reopen_file(struct cifsFileInfo *cfif (backup_cred (cifs_sb)) create_options |=CREATE_OPEN_BACKUP_INTENT ; +/* O_SYNC also has bit for O_DSYNC so following check picks up either */ +if (cfile->f_flags &O_SYNC ) + create_options |=CREATE_WRITE_THROUGH ; + +if (cfile->f_flags &O_DIRECT ) + create_options |=CREATE_NO_BUFFER ; +if (server->ops->get_lease_key) server->ops->get_lease_key (inode, &cfile->fid);
Greg Kroah-Hartman
maintainerPATCH 155/162 ARM: dts: s3c64xx: Fix init order of clock providers
In reply to Greg Kroah-HartmanFrom: Lihua Yao <[email protected]>
commit d60d0cff4ab01255b25375425745c3cff69558ad upstream.
fin_pll is the parent of clock-controller@7e00f000, specify the dependency to ensure proper initialization order of clock providers.
without this patch:
[ 0.000000] S3C6410 clocks: apll = 0, mpll = 0 [ 0.000000] epll = 0, arm_clk = 0
with this patch:
[ 0.000000] S3C6410 clocks: apll = 532000000, mpll = 532000000 [ 0.000000] epll = 24000000, arm_clk = 532000000
--- arch/arm/boot/dts/s3c6410-mini6410.dts | 4 ++++ arch/arm/boot/dts/s3c6410-smdk6410.dts | 4 ++++ 2 files changed, 8 insertions(+)
arch/arm/boot/dts/s3c6410-mini6410.dts +4 -0
@@ -167,6 +167,10 @@ }; }; +&clocks { + clocks = <&fin_pll>; +}; + &sdhci0 { pinctrl-names = "default"; pinctrl-0 = <&sd0_clk>, <&sd0_cmd>, <&sd0_cd>, <&sd0_bus4>;
arch/arm/boot/dts/s3c6410-smdk6410.dts +4 -0
@@ -71,6 +71,10 @@ }; }; +&clocks { + clocks = <&fin_pll>; +}; + &sdhci0 { pinctrl-names = "default"; pinctrl-0 = <&sd0_clk>, <&sd0_cmd>, <&sd0_cd>, <&sd0_bus4>;
Greg Kroah-Hartman
maintainerPATCH 156/162 ARM: tegra: Fix FLOW_CTLR_HALT register clobbering by tegra_resume()
In reply to Greg Kroah-HartmanFrom: Dmitry Osipenko <[email protected]>
commit d70f7d31a9e2088e8a507194354d41ea10062994 upstream.
There is an unfortunate typo in the code that results in writing to FLOW_CTLR_HALT instead of FLOW_CTLR_CSR.
--- arch/arm/mach-tegra/reset-handler.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/mach-tegra/reset-handler.S +3 -3
@@ -56,16 +56,16 @@ ENTRY(tegra_resume) cmp r6, #TEGRA20 beq 1f @ Yes /* Clear the flow controller flags for this CPU. */ - cpu_to_csr_reg r1, r0 + cpu_to_csr_reg r3, r0 mov32 r2, TEGRA_FLOW_CTRL_BASE - ldr r1, [r2, r1] + ldr r1, [r2, r3] /* Clear event & intr flag */ orr r1, r1, \ #FLOW_CTRL_CSR_INTR_FLAG | FLOW_CTRL_CSR_EVENT_FLAG movw r0, #0x3FFD @ enable, cluster_switch, immed, bitmaps @ & ext flags for CPU power mgnt bic r1, r1, r0 - str r1, [r2] + str r1, [r2, r3] 1: mov32 r9, 0xc09
Greg Kroah-Hartman
maintainerPATCH 157/162 vfio/pci: call irq_bypass_unregister_producer() before freeing irq
In reply to Greg Kroah-HartmanFrom: Jiang Yi <[email protected]>
commit d567fb8819162099035e546b11a736e29c2af0ea upstream.
Since irq_bypass_register_producer() is called after request_irq(), we should do tear-down in reverse order: irq_bypass_unregister_producer() then free_irq().
Specifically free_irq() may release resources required by the irqbypass del_producer() callback. Notably an example provided by Marc Zyngier on arm64 with GICv4 that he indicates has the potential to wedge the hardware:
free_irq(irq)
__free_irq(irq)
irq_domain_deactivate_irq(irq)
its_irq_domain_deactivate()
[unmap the VLPI from the ITS]
kvm_arch_irq_bypass_del_producer(cons, prod)
kvm_vgic_v4_unset_forwarding(kvm, irq, ...)
its_unmap_vlpi(irq)
[Unmap the VLPI from the ITS (again), remap the original LPI]
--- drivers/vfio/pci/vfio_pci_intrs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/vfio/pci/vfio_pci_intrs.c +1 -1
@@ -318,8 +318,8 @@ static int vfio_msi_set_vector_signal(streturn -EINVAL ;if (vdev->ctx[vector].trigger) { -free_irq (irq, vdev->ctx[vector].trigger);irq_bypass_unregister_producer (&vdev->ctx[vector].producer); +free_irq (irq, vdev->ctx[vector].trigger);kfree (vdev->ctx[vector].name);eventfd_ctx_put (vdev->ctx[vector].trigger); vdev->ctx[vector].trigger =NULL ;
Greg Kroah-Hartman
maintainerPATCH 158/162 dm btree: increase rebalance threshold in __rebalance2()
In reply to Greg Kroah-HartmanFrom: Hou Tao <[email protected]>
commit 474e559567fa631dea8fb8407ab1b6090c903755 upstream.
We got the following warnings from thin_check during thin-pool setup:
$ thin_check /dev/vdb
examining superblock
examining devices tree
missing devices: [1, 84]
too few entries in btree_node: 41, expected at least 42 (block 138, max_entries = 126)
examining mapping treeThe phenomenon is the number of entries in one node of details_info tree is less than (max_entries / 3). And it can be easily reproduced by the following procedures:
$ new a thin pool
$ presume the max entries of details_info tree is 126
$ new 127 thin devices (e.g. 1~127) to make the root node being full
and then split
$ remove the first 43 (e.g. 1~43) thin devices to make the children
reblance repeatedly
$ stop the thin pool
$ thin_checkThe root cause is that the B-tree removal procedure in __rebalance2() doesn't guarantee the invariance: the minimal number of entries in non-root node should be >= (max_entries / 3).
Simply fix the problem by increasing the rebalance threshold to make sure the number of entries in each child will be greater than or equal to (max_entries / 3 + 1), so no matter which child is used for removal, the number will still be valid.
--- drivers/md/persistent-data/dm-btree-remove.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/md/persistent-data/dm-btree-remove.c +7 -1
@@ -203,7 +203,13 @@ static void __rebalance2(struct dm_btreestruct btree_node *right = r->n;uint32_t nr_left =le32_to_cpu (left->header.nr_entries);uint32_t nr_right =le32_to_cpu (right->header.nr_entries); -unsigned threshold =2 *merge_threshold (left) +1 ; +/* +* Ensure the number of entries in each child will be greater +* than or equal to (max_entries / 3 + 1), so no matter which +* child is used for removal, the number will still be not +* less than (max_entries / 3). +*/ +unsigned int threshold =2 * (merge_threshold (left) +1 );if (nr_left + nr_right < threshold) {/*
Greg Kroah-Hartman
maintainerPATCH 159/162 drm/radeon: fix r1xx/r2xx register checker for POT textures
In reply to Greg Kroah-HartmanFrom: Alex Deucher <[email protected]>
commit 008037d4d972c9c47b273e40e52ae34f9d9e33e7 upstream.
Shift and mask were reversed. Noticed by chance.
--- drivers/gpu/drm/radeon/r100.c | 4 ++-- drivers/gpu/drm/radeon/r200.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/radeon/r100.c +2 -2
@@ -1826,8 +1826,8 @@ static int r100_packet0_check(struct rad track->textures[i].use_pitch =1 ; }else { track->textures[i].use_pitch =0 ; - track->textures[i].width =1 << ((idx_value >>RADEON_TXFORMAT_WIDTH_SHIFT ) &RADEON_TXFORMAT_WIDTH_MASK ); - track->textures[i].height =1 << ((idx_value >>RADEON_TXFORMAT_HEIGHT_SHIFT ) &RADEON_TXFORMAT_HEIGHT_MASK ); + track->textures[i].width =1 << ((idx_value &RADEON_TXFORMAT_WIDTH_MASK ) >>RADEON_TXFORMAT_WIDTH_SHIFT ); + track->textures[i].height =1 << ((idx_value &RADEON_TXFORMAT_HEIGHT_MASK ) >>RADEON_TXFORMAT_HEIGHT_SHIFT ); }if (idx_value &RADEON_TXFORMAT_CUBIC_MAP_ENABLE ) track->textures[i].tex_coord_type =2 ;
drivers/gpu/drm/radeon/r200.c +2 -2
@@ -476,8 +476,8 @@ int r200_packet0_check(struct radeon_cs_ track->textures[i].use_pitch =1 ; }else { track->textures[i].use_pitch =0 ; - track->textures[i].width =1 << ((idx_value >>RADEON_TXFORMAT_WIDTH_SHIFT ) &RADEON_TXFORMAT_WIDTH_MASK ); - track->textures[i].height =1 << ((idx_value >>RADEON_TXFORMAT_HEIGHT_SHIFT ) &RADEON_TXFORMAT_HEIGHT_MASK ); + track->textures[i].width =1 << ((idx_value &RADEON_TXFORMAT_WIDTH_MASK ) >>RADEON_TXFORMAT_WIDTH_SHIFT ); + track->textures[i].height =1 << ((idx_value &RADEON_TXFORMAT_HEIGHT_MASK ) >>RADEON_TXFORMAT_HEIGHT_SHIFT ); }if (idx_value &R200_TXFORMAT_LOOKUP_DISABLE ) track->textures[i].lookup_disable = true;
Greg Kroah-Hartman
maintainerPATCH 160/162 xhci: fix USB3 device initiated resume race with roothub autosuspend
In reply to Greg Kroah-HartmanFrom: Mathias Nyman <[email protected]>
commit 057d476fff778f1d3b9f861fdb5437ea1a3cfc99 upstream.
A race in xhci USB3 remote wake handling may force device back to suspend after it initiated resume siganaling, causing a missed resume event or warm reset of device.
When a USB3 link completes resume signaling and goes to enabled (UO) state a interrupt is issued and the interrupt handler will clear the bus_state->port_remote_wakeup resume flag, allowing bus suspend.
If the USB3 roothub thread just finished reading port status before the interrupt, finding ports still in suspended (U3) state, but hasn't yet started suspending the hub, then the xhci interrupt handler will clear the flag that prevented roothub suspend and allow bus to suspend, forcing all port links back to suspended (U3) state.
Example case:usb_runtime_suspend() # because all ports still show suspended U3
usb_suspend_both()
hub_suspend(); # successful as hub->wakeup_bits not set yet
==> INTERRUPT
xhci_irq()
handle_port_status()
clear bus_state->port_remote_wakeup
usb_wakeup_notification()
sets hub->wakeup_bits;
kick_hub_wq()<== END INTERRUPT
hcd_bus_suspend()
xhci_bus_suspend() # success as port_remote_wakeup bits cleared
Fix this by increasing roothub usage count during port resume to prevent roothub autosuspend, and by making sure bus_state->port_remote_wakeup flag is only cleared after resume completion is visible, i.e. after xhci roothub returned U0 or other non-U3 link state link on a get port status request.
Issue rootcaused by Chiasheng Lee
--- drivers/usb/host/xhci-hub.c | 8 ++++++++ drivers/usb/host/xhci-ring.c | 6 +----- drivers/usb/host/xhci.h | 1 + 3 files changed, 10 insertions(+), 5 deletions(-)
drivers/usb/host/xhci-hub.c +8 -0
@@ -736,6 +736,14 @@ static u32 xhci_get_port_status(struct u status |=USB_PORT_STAT_C_BH_RESET <<16 ;if ((raw_port_status &PORT_CEC )) status |=USB_PORT_STAT_C_CONFIG_ERROR <<16 ; + +/* USB3 remote wake resume signaling completed */ +if (bus_state->port_remote_wakeup & (1 << wIndex) && + (raw_port_status &PORT_PLS_MASK ) !=XDEV_RESUME && + (raw_port_status &PORT_PLS_MASK ) !=XDEV_RECOVERY ) { + bus_state->port_remote_wakeup &= ~(1 << wIndex); +usb_hcd_end_port_resume (&hcd->self, wIndex); + } }if (hcd->speed <HCD_USB3 ) {
drivers/usb/host/xhci-ring.c +1 -5
@@ -1602,9 +1602,6 @@ static void handle_port_status(struct xhusb_hcd_resume_root_hub (hcd); } -if (hcd->speed >=HCD_USB3 && (temp &PORT_PLS_MASK ) ==XDEV_INACTIVE ) - bus_state->port_remote_wakeup &= ~(1 << faked_port_index); -if ((temp &PORT_PLC ) && (temp &PORT_PLS_MASK ) ==XDEV_RESUME ) {xhci_dbg (xhci,"port resume event for port %d\n" , port_id);
@@ -1623,6 +1620,7 @@ static void handle_port_status(struct xh bus_state->port_remote_wakeup |=1 << faked_port_index;xhci_test_and_clear_bit (xhci, port_array, faked_port_index,PORT_PLC ); +usb_hcd_start_port_resume (&hcd->self, faked_port_index);xhci_set_link_state (xhci, port_array, faked_port_index,XDEV_U0 );/* Need to wait until the next link state change
@@ -1660,8 +1658,6 @@ static void handle_port_status(struct xhif (slot_id && xhci->devs[slot_id])xhci_ring_device (xhci, slot_id);if (bus_state->port_remote_wakeup & (1 << faked_port_index)) { - bus_state->port_remote_wakeup &= - ~(1 << faked_port_index);xhci_test_and_clear_bit (xhci, port_array, faked_port_index,PORT_PLC ); usb_wakeup_notification(hcd->self.root_hub,
drivers/usb/host/xhci.h +1 -0
@@ -314,6 +314,7 @@ struct xhci_op_regs {#define XDEV_U3 (0x3 << 5)#define XDEV_INACTIVE (0x6 << 5)#define XDEV_POLLING (0x7 << 5) +#define XDEV_RECOVERY (0x8 << 5)#define XDEV_COMP_MODE (0xa << 5)#define XDEV_RESUME (0xf << 5)/* true: port has power (see HCC_PPC) */
Greg Kroah-Hartman
maintainerPATCH 161/162 net: stmmac: use correct DMA buffer size in the RX descriptor
In reply to Greg Kroah-HartmanFrom: Aaro Koskinen <[email protected]>
commit 583e6361414903c5206258a30e5bd88cb03c0254 upstream.
We always program the maximum DMA buffer size into the receive descriptor, although the allocated size may be less. E.g. with the default MTU size we allocate only 1536 bytes. If somebody sends us a bigger frame, then memory may get corrupted.
Fix by using exact buffer sizes.
[acj: backport to v4.4 -stable :
- Modified patch since v4.4 driver has no support for Big endian
- Skipped the section modifying non-existent functions in dwmac4_descs.c and dwxgmac2_descs.c ]
--- drivers/net/ethernet/stmicro/stmmac/common.h | 2 +- drivers/net/ethernet/stmicro/stmmac/descs_com.h | 14 ++++++++++---- drivers/net/ethernet/stmicro/stmmac/enh_desc.c | 10 +++++++--- drivers/net/ethernet/stmicro/stmmac/norm_desc.c | 10 +++++++--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++-- 5 files changed, 27 insertions(+), 13 deletions(-)
drivers/net/ethernet/stmicro/stmmac/common.h +1 -1
@@ -301,7 +301,7 @@ struct dma_features {struct stmmac_desc_ops {/* DMA RX descriptor ring initialization */ void (*init_rx_desc) (struct dma_desc *p,int disable_rx_ic,int mode, -int end); +int end,int bfsize);/* DMA TX descriptor ring initialization */ void (*init_tx_desc) (struct dma_desc *p,int mode,int end);
drivers/net/ethernet/stmicro/stmmac/descs_com.h +10 -4
@@ -33,9 +33,10 @@/* Specific functions used for Ring mode */ /* Enhanced descriptors */ -static inline void ehn_desc_rx_set_on_ring (struct dma_desc *p,int end) +static inline void ehn_desc_rx_set_on_ring (struct dma_desc *p,int end,int bfsize) { - p->des01.erx.buffer2_size = BUF_SIZE_8KiB -1 ; +if (bfsize == BUF_SIZE_16KiB) + p->des01.erx.buffer2_size = BUF_SIZE_8KiB -1 ;if (end) p->des01.erx.end_ring =1 ; }
@@ -61,9 +62,14 @@ static inline void enh_set_tx_desc_len_o }/* Normal descriptors */ -static inline void ndesc_rx_set_on_ring (struct dma_desc *p,int end) +static inline void ndesc_rx_set_on_ring (struct dma_desc *p,int end,int bfsize) { - p->des01.rx.buffer2_size = BUF_SIZE_2KiB -1 ; +int size; + +if (bfsize >= BUF_SIZE_2KiB) { + size =min (bfsize - BUF_SIZE_2KiB +1 , BUF_SIZE_2KiB -1 ); + p->des01.rx.buffer2_size = size; + }if (end) p->des01.rx.end_ring =1 ; }
drivers/net/ethernet/stmicro/stmmac/enh_desc.c +7 -3
@@ -238,16 +238,20 @@ static int enh_desc_get_rx_status(void * }static void enh_desc_init_rx_desc (struct dma_desc *p,int disable_rx_ic, -int mode,int end) +int mode,int end,int bfsize) { +int bfsize1; + p->des01.all_flags =0 ; p->des01.erx.own =1 ; - p->des01.erx.buffer1_size = BUF_SIZE_8KiB -1 ; + + bfsize1 =min (bfsize, BUF_SIZE_8KiB -1 ); + p->des01.erx.buffer1_size = bfsize1;if (mode ==STMMAC_CHAIN_MODE )ehn_desc_rx_set_on_chain (p, end);else -ehn_desc_rx_set_on_ring (p, end); +ehn_desc_rx_set_on_ring (p, end, bfsize);if (disable_rx_ic) p->des01.erx.disable_ic =1 ;
drivers/net/ethernet/stmicro/stmmac/norm_desc.c +7 -3
@@ -121,16 +121,20 @@ static int ndesc_get_rx_status(void *dat }static void ndesc_init_rx_desc (struct dma_desc *p,int disable_rx_ic,int mode, -int end) +int end,int bfsize) { +int bfsize1; + p->des01.all_flags =0 ; p->des01.rx.own =1 ; - p->des01.rx.buffer1_size = BUF_SIZE_2KiB -1 ; + + bfsize1 =min (bfsize, (BUF_SIZE_2KiB -1 )); + p->des01.rx.buffer1_size = bfsize1;if (mode ==STMMAC_CHAIN_MODE )ndesc_rx_set_on_chain (p, end);else -ndesc_rx_set_on_ring (p, end); +ndesc_rx_set_on_ring (p, end, bfsize);if (disable_rx_ic) p->des01.rx.disable_ic =1 ;
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +2 -2
@@ -964,11 +964,11 @@ static void stmmac_clear_descriptors(strif (priv->extend_desc) priv->hw->desc->init_rx_desc (&priv->dma_erx[i].basic, priv->use_riwt, priv->mode, - (i == rxsize -1 )); + (i == rxsize -1 ), priv->dma_buf_sz);else priv->hw->desc->init_rx_desc (&priv->dma_rx[i], priv->use_riwt, priv->mode, - (i == rxsize -1 )); + (i == rxsize -1 ), priv->dma_buf_sz);for (i =0 ; i < txsize; i++)if (priv->extend_desc) priv->hw->desc->init_tx_desc(&priv->dma_etx[i].basic,
Greg Kroah-Hartman
maintainerPATCH 162/162 net: stmmac: dont stop NAPI processing when dropping a packet
In reply to Greg Kroah-HartmanFrom: Aaro Koskinen <[email protected]>
commit 07b3975352374c3f5ebb4a42ef0b253fe370542d upstream.
Currently, if we drop a packet, we exit from NAPI loop before the budget is consumed. In some situations this will make the RX processing stall e.g. when flood pinging the system with oversized packets, as the errorneous packets are not dropped efficiently.
If we drop a packet, we should just continue to the next one as long as the budget allows.
[acj: backport v4.4 -stable
-adjust context]
--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +6 -6
@@ -2176,8 +2176,7 @@ static inline void stmmac_rx_refill(strustatic int stmmac_rx (struct stmmac_priv *priv,int limit) {unsigned int rxsize = priv->dma_rx_size; -unsigned int entry = priv->cur_rx % rxsize; -unsigned int next_entry; +unsigned int next_entry = priv->cur_rx % rxsize;unsigned int count =0 ;int coe = priv->hw->rx_csum;
@@ -2189,9 +2188,11 @@ static int stmmac_rx(struct stmmac_privstmmac_display_ring ((void *)priv->dma_rx, rxsize,0 ); }while (count < limit) { -int status; +int status, entry;struct dma_desc *p; + entry = next_entry; +if (priv->extend_desc) p = (struct dma_desc *)(priv->dma_erx + entry);else
@@ -2239,7 +2240,7 @@ static int stmmac_rx(struct stmmac_priv/* check if frame_len fits the preallocated memory */ if (frame_len > priv->dma_buf_sz) { priv->dev->stats.rx_length_errors++; -break ; +continue ; }/* ACS is set; GMAC core strips PAD/FCS for IEEE 802.3
@@ -2260,7 +2261,7 @@ static int stmmac_rx(struct stmmac_privpr_err ("%s: Inconsistent Rx descriptor chain\n" , priv->dev->name); priv->dev->stats.rx_dropped++; -break ; +continue ; }prefetch (skb->data -NET_IP_ALIGN ); priv->rx_skbuff[entry] =NULL ;
@@ -2291,7 +2292,6 @@ static int stmmac_rx(struct stmmac_priv priv->dev->stats.rx_packets++; priv->dev->stats.rx_bytes += frame_len; } - entry = next_entry; }stmmac_rx_refill (priv);
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.4.207 release. There are 162 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat, 21 Dec 2019 18:24:44 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 9 lines
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.207-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.4.y
and the diffstat can be found below.thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
Quoted 10 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.4.207 release. There are 162 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat, 21 Dec 2019 18:24:44 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 9 lines
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.207-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.4.y
and the diffstat can be found below.thanks,
greg k-h
Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.
Summary
------------------------------------------------------------------------
kernel: 4.4.207-rc1
git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git branch: linux-4.4.y
git commit: 9fe78e96326d85ca140930f72dbce8b198001210
git describe: v4.4.206-163-g9fe78e96326d
Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.4-oe/build/v4.4.206-163-g9fe78e96326d
No regressions (compared to build v4.4.206)
No fixes (compared to build v4.4.206)
Ran 16802 total tests in the following environments and test suites.
Environments
--------------
- i386
- juno-r2 - arm64
- qemu_arm
- qemu_arm64
- qemu_i386
- qemu_x86_64
- x15 - arm
- x86_64
Test Suites
-----------
* build
* kselftest
* libhugetlbfs
* linux-log-parser
* ltp-cap_bounds-tests
* ltp-commands-tests
* ltp-containers-tests
* ltp-cpuhotplug-tests
* ltp-cve-tests
* ltp-dio-tests
* ltp-fcntl-locktests-tests
* ltp-filecaps-tests
* ltp-fs-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-fsx-tests
* ltp-hugetlb-tests
* ltp-io-tests
* ltp-ipc-tests
* ltp-math-tests
* ltp-mm-tests
* ltp-nptl-tests
* ltp-open-posix-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* ltp-syscalls-tests
* network-basic-tests
* perf
* spectre-meltdown-checker-test
* v4l2-compliance
* kvm-unit-tests
* install-android-platform-tools-r2600
* kselftest-vsyscall-mode-native
* kselftest-vsyscall-mode-none
* prep-tmp-disk
* ssuite
Summary
------------------------------------------------------------------------
kernel: 4.4.207-rc1
git repo: https://git.linaro.org/lkft/arm64-stable-rc.git
git branch: 4.4.207-rc1-hikey-20191219-637
git commit: edc1100c367e3d8ec1489ada9ebd94f1024d0f51
git describe: 4.4.207-rc1-hikey-20191219-637
Test details: https://qa-reports.linaro.org/lkft/linaro-hikey-stable-rc-4.4-oe/build/4.4.207-rc1-hikey-20191219-637
No regressions (compared to build 4.4.207-rc1-hikey-20191219-636)
No fixes (compared to build 4.4.207-rc1-hikey-20191219-636)
Ran 1566 total tests in the following environments and test suites.
Environments
--------------
- hi6220-hikey - arm64
Test Suites
-----------
* build
* install-android-platform-tools-r2600
* kselftest
* libhugetlbfs
* linux-log-parser
* ltp-cap_bounds-tests
* ltp-commands-tests
* ltp-containers-tests
* ltp-cpuhotplug-tests
* ltp-cve-tests
* ltp-dio-tests
* ltp-fcntl-locktests-tests
* ltp-filecaps-tests
* ltp-fs-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-fsx-tests
* ltp-hugetlb-tests
* ltp-io-tests
* ltp-ipc-tests
* ltp-math-tests
* ltp-mm-tests
* ltp-nptl-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* ltp-syscalls-tests
* perf
* spectre-meltdown-checker-test
* v4l2-compliance
Signature · 2 lines
Linaro LKFT https://lkft.linaro.org
Jon Hunter
maintainerQuoted 14 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.4.207 release. There are 162 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat, 21 Dec 2019 18:24:44 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.207-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.4.y
and the diffstat can be found below.
Quoted 5 lines
thanks,
greg k-h
-------------
All tests are passing for Tegra ...
Test results for stable-v4.4:
6 builds: 6 pass, 0 fail
12 boots: 12 pass, 0 fail
19 tests: 19 pass, 0 failLinux version: 4.4.207-rc1-g9fe78e96326d
Boards tested: tegra124-jetson-tk1, tegra20-ventana,
tegra30-cardhu-a04
Cheers
Jon
Signature · 1 line
nvpublic
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.4.207 release. There are 162 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat, 21 Dec 2019 18:24:44 +0000. Anything received after that time might be too late.
Build results:
total: 170 pass: 170 fail: 0 Qemu test results: total: 327 pass: 327 fail: 0
Guenter