Skip to contentSkip to conversation

package/openrc: install sysv-rcs file

PATCH New aduskett at gmail.com 4 participants 5 messages Dec 19, 2019 – Dec 25, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/openrc: install sysv-rcs file

From: Adam Duskett <[email protected]>

package/openrc has the file sysv-rcs which starts sysvinit services not written for openrc. However, currently it is not installed to the target.

Install this file to $(TARGET_DIR)/etc/init.d during the target_install step.

---
 package/openrc/openrc.mk | 2 ++
 1 file changed, 2 insertions(+)
package/openrc/openrc.mk +2 -0
index 387962d4d5..c7c8b0461a 100644
@@ -35,6 +35,8 @@ endef
 
 define OPENRC_INSTALL_TARGET_CMDS
 	$(MAKE) $(OPENRC_MAKE_OPTS) DESTDIR=$(TARGET_DIR) -C $(@D) install
+	$(INSTALL) -D -m 0755 $(OPENRC_PKGDIR)/sysv-rcs \
+		$(TARGET_DIR)/etc/init.d/
 endef
 
 ifeq ($(BR2_PACKAGE_NETIFRC),y)
Signature · 1 line
2.24.1
#1 lore raw

PATCH 1/1 package/openrc: install sysv-rcs file

Quoted 10 lines · On Thu, 19 Dec 2019 11:01:35 -0800 aduskett at gmail.com wrote:

From: Adam Duskett <[email protected]>

package/openrc has the file sysv-rcs which starts sysvinit services not written for openrc. However, currently it is not installed to the target.

Install this file to $(TARGET_DIR)/etc/init.d during the target_install step.

Michal had what seems like a more elaborate solution:

http://patchwork.ozlabs.org/patch/1098590/

Michal, could you comment ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/openrc: install sysv-rcs file

Thomas, Adam, All,

On 2019-12-19 21:44 +0100, Thomas Petazzoni spake thusly:

Quoted 12 lines
Quoted 9 lines · On Thu, 19 Dec 2019 11:01:35 -0800 aduskett at gmail.com wrote:

From: Adam Duskett <[email protected]>

package/openrc has the file sysv-rcs which starts sysvinit services not written for openrc. However, currently it is not installed to the target.

Install this file to $(TARGET_DIR)/etc/init.d during the target_install step.

Quoted 7 lines
Quoted 1 line

Michal had what seems like a more elaborate solution:

http://patchwork.ozlabs.org/patch/1098590/

Michal, could you comment ?

We already have 162044407b (package/skeleton-init-openrc: add support for starting sysv scripts) which was edited by me, but I missed the fact that the script was not installed.

Adam, care to investigate what is different between our script, and the one from the package itself?

I am all in favour of dropping our script, if upstream has a functional one.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 package/openrc: install sysv-rcs file

Adam, All,

On 2019-12-19 21:50 +0100, Yann E. MORIN spake thusly:

Quoted 20 lines

On 2019-12-19 21:44 +0100, Thomas Petazzoni spake thusly:

Quoted 9 lines
Quoted 6 lines · On Thu, 19 Dec 2019 11:01:35 -0800 aduskett at gmail.com wrote:

From: Adam Duskett <[email protected]>

package/openrc has the file sysv-rcs which starts sysvinit services not written for openrc. However, currently it is not installed to the target.

Quoted 6 lines
Quoted 4 lines

Install this file to $(TARGET_DIR)/etc/init.d during the target_install step.

Michal had what seems like a more elaborate solution:
http://patchwork.ozlabs.org/patch/1098590/

We already have 162044407b (package/skeleton-init-openrc: add support for starting sysv scripts) which was edited by me, but I missed the fact that the script was not installed.

Quoted 5 lines

Adam, care to investigate what is different between our script, and the one from the package itself?

I am all in favour of dropping our script, if upstream has a functional one.

In fact, upstream does not have such a script. It is just that we forgot to install our own script.

Applied to master, changed the destination to a full path, and not just the directory, and pushed. Thanks.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH 1/1 package/openrc: install sysv-rcs file

In reply to aduskett at gmail.com
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"aduskett" == aduskett <[email protected]> writes:

From: Adam Duskett <[email protected]> package/openrc has the file sysv-rcs which starts sysvinit services not written for openrc. However, currently it is not installed to the target.

Install this file to $(TARGET_DIR)/etc/init.d during the target_install step.

Committed to 2019.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard