mfd: cros_ec: Add usbpd-notify to usbpd_charger
Subsystems (2)
PATCH v2 2/2 mfd: cros_ec: Add usbpd-notify to usbpd_charger
Add the cros-usbpd-notify driver as a cell for the cros_usbpd_charger subdevice on non-ACPI platforms.
This driver allows other cros-ec devices to receive PD event notifications from the Chrome OS Embedded Controller (EC) via a notification chain.
---
Changes in v2:
- Removed auto-generated Change-Id.
drivers/mfd/cros_ec_dev.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/mfd/cros_ec_dev.c +3 -0
@@ -85,6 +85,9 @@ static const struct mfd_cell cros_ec_sensorhub_cells[] = {static const struct mfd_cell cros_usbpd_charger_cells[] = { { .name ="cros-usbpd-charger" , }, { .name ="cros-usbpd-logger" , }, +#ifndef CONFIG_ACPI + { .name ="cros-usbpd-notify" , }, +#endif };static const struct cros_feature_to_cells cros_subdevices[] = {
Signature · 1 line
2.24.1.735.g03f4e72817-goog
Hi Prashant,
Please try to maintain versions and changelog consistently. I.e I see v2 here but I guess you only send this patch not the full series, also I see that you send v3 before this?
In general you should send the full series on every version and maintain a full changelog.
I'd like to see v4 including all the series so it's clear from were we pick up the patches.
Quoted 8 lines · Prashant Malani
Add the cros-usbpd-notify driver as a cell for the
cros_usbpd_chargersubdevice on non-ACPI platforms.This driver allows other cros-ec devices to receive PD event notifications from the Chrome OS Embedded Controller (EC) via a notification chain.
Signed-off-by Prashant Malani <[email protected]>
For v4 you can include:
Thanks,
Enric
Quoted 23 lines
---
Changes in v2:
- Removed auto-generated Change-Id.drivers/mfd/cros_ec_dev.c | 3 +++ 1 file changed, 3 insertions(+)drivers/mfd/cros_ec_dev.c +3
-0@@ -85,6 +85,9 @@ static const struct mfd_cell cros_ec_sensorhub_cells[] = {static const struct mfd_cell cros_usbpd_charger_cells[] = { { .name ="cros-usbpd-charger" , }, { .name ="cros-usbpd-logger" , }, +#ifndef CONFIG_ACPI + { .name ="cros-usbpd-notify" , }, +#endif };static const struct cros_feature_to_cells cros_subdevices[] = {
Quoted 21 lines · Enric Balletbo i Serra
Hi Prashant,
Please try to maintain versions and changelog consistently. I.e I see v2 here but I guess you only send this patch not the full series, also I see that you send v3 before this?
In general you should send the full series on every version and maintain a full changelog.
I'd like to see v4 including all the series so it's clear from were we pick up the patches.
Quoted 7 lines · Prashant Malani
Add the cros-usbpd-notify driver as a cell for the
cros_usbpd_chargersubdevice on non-ACPI platforms.This driver allows other cros-ec devices to receive PD event notifications from the Chrome OS Embedded Controller (EC) via a notification chain.
Quoted 5 lines
Quoted 1 line
Signed-off-by Prashant Malani <[email protected]>For v4 you can include:
Since the v4 of this patch involves a substantial difference from the previous version, I determined not to auto-add the Acked-by. My apologies if you reckon I should've added it anyway.
Quoted 27 lines
Thanks,
EnricQuoted 23 lines
---
Changes in v2:
- Removed auto-generated Change-Id.drivers/mfd/cros_ec_dev.c | 3 +++ 1 file changed, 3 insertions(+)drivers/mfd/cros_ec_dev.c +3
-0@@ -85,6 +85,9 @@ static const struct mfd_cell cros_ec_sensorhub_cells[] = {static const struct mfd_cell cros_usbpd_charger_cells[] = { { .name ="cros-usbpd-charger" , }, { .name ="cros-usbpd-logger" , }, +#ifndef CONFIG_ACPI + { .name ="cros-usbpd-notify" , }, +#endif };static const struct cros_feature_to_cells cros_subdevices[] = {