Skip to contentSkip to conversation

Add DU support

PATCH New Marian-Cristian Rotariu 3 participants 7 messages Dec 19, 2019 – Dec 23, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover Add DU support

This patch series add DU support for iWave iwg20d platform based on RZ/G1N.

This patch series is based on linux-4.4.y-cip and all the patches in this series are cherry-picked from upstream.

Biju Das (3):
dt-bindings: display: renesas: du: Document the r8a7744 bindings
drm: rcar-du: Add R8A7744 support
ARM: dts: r8a7744: Add DU support

 Documentation/devicetree/bindings/display/renesas,du.txt |  2 ++
 arch/arm/boot/dts/r8a7744.dtsi                           | 10 +++++++++-
 drivers/gpu/drm/rcar-du/rcar_du_drv.c                    |  3 ++-
 3 files changed, 13 insertions(+), 2 deletions(-)
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/3 dt-bindings: display: renesas: du: Document the r8a7744 bindings

From: Biju Das <[email protected]>

commit 5eb08d995564c9f9d4818a84050f7716b73c86cc upstream.

Document the RZ/G1N (R8A7744) SoC in the R-Car DU bindings.

---
 Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/display/renesas,du.txt +2 -0
index 2cc5fdd..96cc080 100644
@@ -4,6 +4,7 @@ Required Properties:
 
   - compatible: must be one of the following.
     - "renesas,du-r8a7743" for R8A7743 (RZ/G1M) compatible DU
+    - "renesas,du-r8a7744" for R8A7744 (RZ/G1N) compatible DU
     - "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
     - "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
     - "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU
@@ -46,6 +47,7 @@ corresponding to each DU output.
                       Port 0         Port1          Port2
 -----------------------------------------------------------------------------
  R8A7743 (RZ/G1M)     DPAD 0         LVDS 0         -
+ R8A7744 (RZ/G1N)     DPAD 0         LVDS 0         -
  R8A7745 (RZ/G1E)     DPAD 0         DPAD 1         -
  R8A7779 (R-Car H1)   DPAD 0         DPAD 1         -
  R8A7790 (R-Car H2)   DPAD 0         LVDS 0         LVDS 1
Signature · 1 line
2.7.4
#2 lore raw

PATCH 2/3 drm: rcar-du: Add R8A7744 support

In reply to Marian-Cristian Rotariu

From: Biju Das <[email protected]>

commit 5dc34af19c98171174f563a4b9f79a902bf665b4 upstream.

Add support for the R8A7744 DU (which is very similar to the R8A7743 DU); it has 1 DPAD (RGB) output and 1 LVDS output.

---
 drivers/gpu/drm/rcar-du/rcar_du_drv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/rcar-du/rcar_du_drv.c +2 -1
index 5187ed3..edb9c3f 100644
@@ -41,7 +41,7 @@ static const struct rcar_du_device_info rzg1_du_r8a7743_info = {
 	.num_crtcs = 2,
 	.routes = {
 		/*
-		 * R8A7743 has one RGB output and one LVDS output
+		 * R8A774[34] has one RGB output and one LVDS output
 		 */
 		[RCAR_DU_OUTPUT_DPAD0] = {
 			.possible_crtcs = BIT(1) | BIT(0),
@@ -175,6 +175,7 @@ static const struct rcar_du_device_info rcar_du_r8a7794_info = {
 
 static const struct of_device_id rcar_du_of_table[] = {
 	{ .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
+	{ .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
 	{ .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
 	{ .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
 	{ .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
Signature · 1 line
2.7.4
#3 lore raw

PATCH 3/3 ARM: dts: r8a7744: Add DU support

In reply to Marian-Cristian Rotariu

From: Biju Das <[email protected]>

commit 5f152018d340d90c185ced8ef6230b7044ea5540 upstream.

Add du node to r8a7744 SoC DT. Boards that want to enable the DU need to specify the output topology.

[marian: Removed reset and updated clk and power domain properties]
---
 arch/arm/boot/dts/r8a7744.dtsi | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
arch/arm/boot/dts/r8a7744.dtsi +9 -1
index 7902f7e..91e032a 100644
@@ -1278,8 +1278,17 @@
 		};
 
 		du: display at feb00000 {
+			compatible = "renesas,du-r8a7744";
 			reg = <0 0xfeb00000 0 0x40000>,
 			      <0 0xfeb90000 0 0x1c>;
+			reg-names = "du", "lvds.0";
+			interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&mstp7_clks R8A7744_CLK_DU0>,
+				 <&mstp7_clks R8A7744_CLK_DU1>,
+				 <&mstp7_clks R8A7744_CLK_LVDS0>;
+			clock-names = "du.0", "du.1", "lvds.0";
+			status = "disabled";
 
 			ports {
 				#address-cells = <1>;
@@ -1296,7 +1305,6 @@
 					};
 				};
 			};
-			/* placeholder */
 		};
 
 		cmt0: timer at ffca0000 {
Signature · 1 line
2.7.4
#4 lore raw

cover Add DU support

In reply to Marian-Cristian Rotariu

Hi Marian,

Quoted 22 lines

-----Original Message-----
From: Marian-Cristian Rotariu [mailto:marian-cristian.rotariu.rb at bp.renesas.com]
Sent: Friday, December 20, 2019 12:06 AM
To: cip-dev at lists.cip-project.org; iwamatsu nobuhiro(?? ?? ??? ?????) <[email protected]>; Pavel Machek <[email protected]>
Cc: Chris Paterson <[email protected]>; Biju Das <[email protected]>; Fabrizio Castro <[email protected]>
Subject: [PATCH 4.4.y-cip 0/3] Add DU support

This patch series add DU support for iWave iwg20d platform based on RZ/G1N.

This patch series is based on linux-4.4.y-cip and all the patches in this series are cherry-picked from upstream.

Biju Das (3):
dt-bindings: display: renesas: du: Document the r8a7744 bindings
drm: rcar-du: Add R8A7744 support
ARM: dts: r8a7744: Add DU support

Quoted 5 lines
 Documentation/devicetree/bindings/display/renesas,du.txt |  2 ++
 arch/arm/boot/dts/r8a7744.dtsi                           | 10
+++++++++-
 drivers/gpu/drm/rcar-du/rcar_du_drv.c                    |  3 ++-
 3 files changed, 13 insertions(+), 2 deletions(-)

Looks good to me these patches.
If other reviewer have no opinion, I will apply this series.

Best regards,
Nobuhiro.

#5 lore raw

cover Add DU support

Hi!

Quoted 10 lines
Quoted 10 lines

This patch series add DU support for iWave iwg20d platform based on RZ/G1N.

This patch series is based on linux-4.4.y-cip and all the patches in this series are cherry-picked from upstream.

Biju Das (3):
dt-bindings: display: renesas: du: Document the r8a7744 bindings
drm: rcar-du: Add R8A7744 support
ARM: dts: r8a7744: Add DU support

Quoted 8 lines
Quoted 5 lines
 Documentation/devicetree/bindings/display/renesas,du.txt |  2 ++
 arch/arm/boot/dts/r8a7744.dtsi                           | 10
+++++++++-
 drivers/gpu/drm/rcar-du/rcar_du_drv.c                    |  3 ++-
 3 files changed, 13 insertions(+), 2 deletions(-)

Looks good to me these patches.
If other reviewer have no opinion, I will apply this series.

Looks good to me, too. Go ahead :-).
Pavel

Signature · 9 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.cip-project.org/pipermail/cip-dev/attachments/20191220/5ef2b6f3/attachment.sig>
#6 lore raw

cover Add DU support

Hi,

Quoted 29 lines

-----Original Message-----
From: Pavel Machek [mailto:pavel at denx.de]
Sent: Friday, December 20, 2019 5:16 PM
To: iwamatsu nobuhiro(?? ?? ????????) <[email protected]>
Cc: marian-cristian.rotariu.rb at bp.renesas.com; cip-dev at lists.cip-project.org; pavel at denx.de; chris.paterson2 at renesas.com; biju.das at bp.renesas.com; fabrizio.castro at bp.renesas.com
Subject: Re: [PATCH 4.4.y-cip 0/3] Add DU support

Hi!

Quoted 1 line
Quoted 1 line

This patch series add DU support for iWave iwg20d platform based on

RZ/G1N.

Quoted 2 lines
Quoted 2 lines

This patch series is based on linux-4.4.y-cip and all the patches

in

Quoted 11 lines
Quoted 11 lines

this series are cherry-picked from upstream.

Biju Das (3):
dt-bindings: display: renesas: du: Document the r8a7744 bindings
drm: rcar-du: Add R8A7744 support
ARM: dts: r8a7744: Add DU support

 Documentation/devicetree/bindings/display/renesas,du.txt |  2 ++
 arch/arm/boot/dts/r8a7744.dtsi                           | 10
+++++++++-
 drivers/gpu/drm/rcar-du/rcar_du_drv.c                    |  3
Quoted 7 lines

++-

Quoted 4 lines
Quoted 1 line
 3 files changed, 13 insertions(+), 2 deletions(-)

Looks good to me these patches.
If other reviewer have no opinion, I will apply this series.

Looks good to me, too. Go ahead :-).

Thanks, Pavel.
Applied.

Best regards,
Nobuhiro