thermal: fix indentation in makefile

PATCH In review Yangtao Li 3 participants 4 messages Dec 21, 2019 – Feb 17, 2020 Thermal

lore

Share & tools

lore

Yangtao Li

author

2019-12-21 17:37 UTC #0 lore raw

PATCH 1/1 thermal: fix indentation in makefile

To unify code style.

Signed-off-by Yangtao Li <[email protected]>

---
 drivers/thermal/Makefile | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

drivers/thermal/Makefile +5 -5

index baeb70bf0568..ab9389bc42b2 100644
@@ -5,7 +5,7 @@
 
 obj-$(CONFIG_THERMAL)		+= thermal_sys.o
 thermal_sys-y			+= thermal_core.o thermal_sysfs.o \
-					thermal_helpers.o
+				   thermal_helpers.o
 
 # interface to/from other layers providing sensors
 thermal_sys-$(CONFIG_THERMAL_HWMON)		+= thermal_hwmon.o

@@ -25,11 +25,11 @@ thermal_sys-$(CONFIG_CPU_THERMAL)	+= cpu_cooling.o
 thermal_sys-$(CONFIG_CLOCK_THERMAL)	+= clock_cooling.o
 
 # devfreq cooling
-thermal_sys-$(CONFIG_DEVFREQ_THERMAL) += devfreq_cooling.o
+thermal_sys-$(CONFIG_DEVFREQ_THERMAL)	+= devfreq_cooling.o
 
 # platform thermal drivers
 obj-y				+= broadcom/
-obj-$(CONFIG_THERMAL_MMIO)		+= thermal_mmio.o
+obj-$(CONFIG_THERMAL_MMIO)	+= thermal_mmio.o
 obj-$(CONFIG_SPEAR_THERMAL)	+= spear_thermal.o
 obj-$(CONFIG_ROCKCHIP_THERMAL)	+= rockchip_thermal.o
 obj-$(CONFIG_RCAR_THERMAL)	+= rcar_thermal.o

@@ -49,9 +49,9 @@ obj-$(CONFIG_TI_SOC_THERMAL)	+= ti-soc-thermal/
 obj-y				+= st/
 obj-$(CONFIG_QCOM_TSENS)	+= qcom/
 obj-y				+= tegra/
-obj-$(CONFIG_HISI_THERMAL)     += hisi_thermal.o
+obj-$(CONFIG_HISI_THERMAL)	+= hisi_thermal.o
 obj-$(CONFIG_MTK_THERMAL)	+= mtk_thermal.o
 obj-$(CONFIG_GENERIC_ADC_THERMAL)	+= thermal-generic-adc.o
 obj-$(CONFIG_ZX2967_THERMAL)	+= zx2967_thermal.o
 obj-$(CONFIG_UNIPHIER_THERMAL)	+= uniphier_thermal.o
-obj-$(CONFIG_AMLOGIC_THERMAL)     += amlogic_thermal.o
+obj-$(CONFIG_AMLOGIC_THERMAL)	+= amlogic_thermal.o

Signature · 1 line

2.17.1

Daniel Lezcano

2019-12-21 18:57 UTC #1 lore raw

Quoted 12 lines · Yangtao Li

To unify code style.
Signed-off-by Yangtao Li <[email protected]>
---
 drivers/thermal/Makefile | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/thermal/Makefile +0 -0
index baeb70bf0568..ab9389bc42b2 100644

drivers/thermal/Makefile line 8

Quoted 5 lines

drivers/thermal/Makefile +1 -1

@@ -5,7 +5,7 @@
 
 obj-$(CONFIG_THERMAL)		+= thermal_sys.o
 thermal_sys-y			+= thermal_core.o thermal_sysfs.o \
-					thermal_helpers.o
+				   thermal_helpers.o

Here a tabulation is replaced with spaces.

Quoted 29 lines

drivers/thermal/Makefile +4 -4

 # interface to/from other layers providing sensors
 thermal_sys-$(CONFIG_THERMAL_HWMON)		+= thermal_hwmon.o

@@ -25,11 +25,11 @@ thermal_sys-$(CONFIG_CPU_THERMAL)	+= cpu_cooling.o
 thermal_sys-$(CONFIG_CLOCK_THERMAL)	+= clock_cooling.o
 
 # devfreq cooling
-thermal_sys-$(CONFIG_DEVFREQ_THERMAL) += devfreq_cooling.o
+thermal_sys-$(CONFIG_DEVFREQ_THERMAL)	+= devfreq_cooling.o
 
 # platform thermal drivers
 obj-y				+= broadcom/
-obj-$(CONFIG_THERMAL_MMIO)		+= thermal_mmio.o
+obj-$(CONFIG_THERMAL_MMIO)	+= thermal_mmio.o
 obj-$(CONFIG_SPEAR_THERMAL)	+= spear_thermal.o
 obj-$(CONFIG_ROCKCHIP_THERMAL)	+= rockchip_thermal.o
 obj-$(CONFIG_RCAR_THERMAL)	+= rcar_thermal.o

@@ -49,9 +49,9 @@ obj-$(CONFIG_TI_SOC_THERMAL)	+= ti-soc-thermal/
 obj-y				+= st/
 obj-$(CONFIG_QCOM_TSENS)	+= qcom/
 obj-y				+= tegra/
-obj-$(CONFIG_HISI_THERMAL)     += hisi_thermal.o
+obj-$(CONFIG_HISI_THERMAL)	+= hisi_thermal.o
 obj-$(CONFIG_MTK_THERMAL)	+= mtk_thermal.o
 obj-$(CONFIG_GENERIC_ADC_THERMAL)	+= thermal-generic-adc.o
 obj-$(CONFIG_ZX2967_THERMAL)	+= zx2967_thermal.o
 obj-$(CONFIG_UNIPHIER_THERMAL)	+= uniphier_thermal.o
-obj-$(CONFIG_AMLOGIC_THERMAL)     += amlogic_thermal.o
+obj-$(CONFIG_AMLOGIC_THERMAL)	+= amlogic_thermal.o

Signature · 5 lines

 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Frank Lee

author

2019-12-22 17:38 UTC #2 lore raw

：q

Quoted 15 lines · Daniel Lezcano

Quoted 13 lines · Yangtao Li
To unify code style.
Signed-off-by Yangtao Li <[email protected]>
---
 drivers/thermal/Makefile | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/thermal/Makefile +0 -0
index baeb70bf0568..ab9389bc42b2 100644
@@ -5,7 +5,7 @@
 

Quoted 6 lines

drivers/thermal/Makefile line 8
Quoted 4 lines
drivers/thermal/Makefile +1 -1
 obj-$(CONFIG_THERMAL)                += thermal_sys.o
 thermal_sys-y                        += thermal_core.o thermal_sysfs.o \
-                                     thermal_helpers.o
+                                thermal_helpers.o
Here a tabulation is replaced with spaces.

It won't align after using tab here, shouldn't modify it?

Yours,
Yangtao

Quoted 39 lines

Quoted 20 lines

drivers/thermal/Makefile +2 -2

 # interface to/from other layers providing sensors
 thermal_sys-$(CONFIG_THERMAL_HWMON)          += thermal_hwmon.o

@@ -25,11 +25,11 @@ thermal_sys-$(CONFIG_CPU_THERMAL) += cpu_cooling.o
 thermal_sys-$(CONFIG_CLOCK_THERMAL)  += clock_cooling.o
 
 # devfreq cooling
-thermal_sys-$(CONFIG_DEVFREQ_THERMAL) += devfreq_cooling.o
+thermal_sys-$(CONFIG_DEVFREQ_THERMAL)        += devfreq_cooling.o
 
 # platform thermal drivers
 obj-y                                += broadcom/
-obj-$(CONFIG_THERMAL_MMIO)           += thermal_mmio.o
+obj-$(CONFIG_THERMAL_MMIO)   += thermal_mmio.o
 obj-$(CONFIG_SPEAR_THERMAL)  += spear_thermal.o
 obj-$(CONFIG_ROCKCHIP_THERMAL)       += rockchip_thermal.o
 obj-$(CONFIG_RCAR_THERMAL)   += rcar_thermal.o

@@ -49,9 +49,9 @@ obj-$(CONFIG_TI_SOC_THERMAL)        += ti-soc-thermal/
 obj-y                                += st/

drivers/thermal/Makefile obj-$(CONFIG_TI_SOC_THERMAL) += ti-soc-thermal/ · line 57

Quoted 10 lines

drivers/thermal/Makefile +2 -2

 obj-$(CONFIG_QCOM_TSENS)     += qcom/
 obj-y                                += tegra/
-obj-$(CONFIG_HISI_THERMAL)     += hisi_thermal.o
+obj-$(CONFIG_HISI_THERMAL)   += hisi_thermal.o
 obj-$(CONFIG_MTK_THERMAL)    += mtk_thermal.o
 obj-$(CONFIG_GENERIC_ADC_THERMAL)    += thermal-generic-adc.o
 obj-$(CONFIG_ZX2967_THERMAL) += zx2967_thermal.o
 obj-$(CONFIG_UNIPHIER_THERMAL)       += uniphier_thermal.o
-obj-$(CONFIG_AMLOGIC_THERMAL)     += amlogic_thermal.o
+obj-$(CONFIG_AMLOGIC_THERMAL)        += amlogic_thermal.o

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Zhang Rui

reviewer

2020-02-17 07:39 UTC #3 lore raw

Quoted 27 lines · Frank Lee

：q
Quoted 15 lines · Daniel Lezcano
Quoted 13 lines · Yangtao Li
To unify code style.
Signed-off-by Yangtao Li <[email protected]>
---
 drivers/thermal/Makefile | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/thermal/Makefile +0 -0
index baeb70bf0568..ab9389bc42b2 100644
@@ -5,7 +5,7 @@
 
Quoted 7 lines
drivers/thermal/Makefile line 8
Quoted 5 lines
drivers/thermal/Makefile +1 -1
 obj-$(CONFIG_THERMAL)                += thermal_sys.o
 thermal_sys-y                        += thermal_core.o
 thermal_sysfs.o \
-                                     thermal_helpers.o
+                                thermal_helpers.o
Here a tabulation is replaced with spaces.

Quoted 1 line

It won't align after using tab here, shouldn't modify it?

I'd prefer using tab here. Other changes seem okay to me.

thanks,
rui

Quoted 48 lines

Yours,
Yangtao
Quoted 43 lines
Quoted 25 lines
drivers/thermal/Makefile +0 -0
 # interface to/from other layers providing sensors
 thermal_sys-$(CONFIG_THERMAL_HWMON)          += thermal_hwmon.o
@@ -25,11 +25,11 @@ thermal_sys-$(CONFIG_CPU_THERMAL) +=
cpu_cooling.o
thermal_sys-$(CONFIG_CLOCK_THERMAL) += clock_cooling.o
 # devfreq cooling
drivers/thermal/Makefile +1 -1
-thermal_sys-$(CONFIG_DEVFREQ_THERMAL) += devfreq_cooling.o
+thermal_sys-$(CONFIG_DEVFREQ_THERMAL)        +=
devfreq_cooling.o
 # platform thermal drivers
 obj-y                                += broadcom/
drivers/thermal/Makefile +1 -1
-obj-$(CONFIG_THERMAL_MMIO)           += thermal_mmio.o
+obj-$(CONFIG_THERMAL_MMIO)   += thermal_mmio.o
 obj-$(CONFIG_SPEAR_THERMAL)  += spear_thermal.o
 obj-$(CONFIG_ROCKCHIP_THERMAL)       += rockchip_thermal.o
 obj-$(CONFIG_RCAR_THERMAL)   += rcar_thermal.o
@@ -49,9 +49,9 @@ obj-$(CONFIG_TI_SOC_THERMAL)        += ti-soc-
thermal/
obj-y += st/
obj-$(CONFIG_QCOM_TSENS) += qcom/
obj-y += tegra/
drivers/thermal/Makefile obj-$(CONFIG_TI_SOC_THERMAL) += ti-soc-thermal/ · line 57
Quoted 8 lines
drivers/thermal/Makefile +2 -2
-obj-$(CONFIG_HISI_THERMAL)     += hisi_thermal.o
+obj-$(CONFIG_HISI_THERMAL)   += hisi_thermal.o
 obj-$(CONFIG_MTK_THERMAL)    += mtk_thermal.o
 obj-$(CONFIG_GENERIC_ADC_THERMAL)    += thermal-generic-adc.o
 obj-$(CONFIG_ZX2967_THERMAL) += zx2967_thermal.o
 obj-$(CONFIG_UNIPHIER_THERMAL)       += uniphier_thermal.o
-obj-$(CONFIG_AMLOGIC_THERMAL)     += amlogic_thermal.o
+obj-$(CONFIG_AMLOGIC_THERMAL)        += amlogic_thermal.o
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM
SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog