Skip to contentSkip to conversation

package/apitrace: needs threads

PATCH New Fabrice Fontaine 2 participants 3 messages Dec 17, 2019 – Dec 22, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/apitrace: needs threads

apitrace uses its own version of gtest which depends on threads since version 8.0 and
https://github.com/apitrace/apitrace/commit/85cf7c8b86129699246574dfeec846e88a3f88a2

Moreover, apitrace also uses std::thread in lib/os/os_thread.hpp

Fixes:
- http://autobuild.buildroot.org/results/03c4939fdfb7366c1835df946c4e869cd2b87b9f

---
 package/apitrace/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/apitrace/Config.in +3 -1
index 08313c4891..116a864681 100644
@@ -1,5 +1,6 @@
-comment "apitrace needs a toolchain w/ C++, wchar, gcc >= 4.9"
+comment "apitrace needs a toolchain w/ C++, wchar, threads, gcc >= 4.9"
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
+		!BR2_TOOLCHAIN_HAS_THREADS || \
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
 
 config BR2_PACKAGE_APITRACE
@@ -7,6 +8,7 @@ config BR2_PACKAGE_APITRACE
 	depends on BR2_USE_WCHAR
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_XLIB_LIBX11 if BR2_PACKAGE_XORG7
 	select BR2_PACKAGE_LIBPNG
 	help
Signature · 1 line
2.24.0
#1 lore raw

PATCH 2/2 package/apitrace: needs MMU

apitrace uses its own version of gtest which needs fork() since version 8.0 and
https://github.com/apitrace/apitrace/commit/85cf7c8b86129699246574dfeec846e88a3f88a2

Moreover, apitrace also uses fork in ./lib/os/os_posix.cpp

Fixes:
- http://autobuild.buildroot.org/results/1165ed62d9ae3dbdc13590c39bb55edd9a444567

---
 package/apitrace/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/apitrace/Config.in +2 -0
index 116a864681..abd7ae00ee 100644
@@ -1,10 +1,12 @@
 comment "apitrace needs a toolchain w/ C++, wchar, threads, gcc >= 4.9"
+	depends on BR2_USE_MMU
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
 		!BR2_TOOLCHAIN_HAS_THREADS || \
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
 
 config BR2_PACKAGE_APITRACE
 	bool "apitrace"
+	depends on BR2_USE_MMU # fork()
 	depends on BR2_USE_WCHAR
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
Signature · 1 line
2.24.0
#2 lore raw

PATCH 1/2 package/apitrace: needs threads

In reply to Fabrice Fontaine
Quoted 6 lines · On Tue, 17 Dec 2019 21:12:01 +0100 Fabrice Fontaine…

apitrace uses its own version of gtest which depends on threads since version 8.0 and
https://github.com/apitrace/apitrace/commit/85cf7c8b86129699246574dfeec846e88a3f88a2

Moreover, apitrace also uses std::thread in lib/os/os_thread.hpp

Quoted 7 lines

Fixes:
- http://autobuild.buildroot.org/results/03c4939fdfb7366c1835df946c4e869cd2b87b9f

---
 package/apitrace/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Both applied. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com