Skip to contentSkip to conversation

ELF, coredump: delete duplicated overflow check

PATCH In review Alexey Dobriyan 1 participant 1 message Dec 22, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/3 ELF, coredump: delete duplicated overflow check

array_size() macro will do overflow check anyway.

---

 fs/binfmt_elf.c |    2 --
 1 file changed, 2 deletions(-)
fs/binfmt_elf.c +0 -2
@@ -2257,8 +2257,6 @@ static int elf_core_dump(struct coredump_params *cprm)
 
 	dataoff = offset = roundup(offset, ELF_EXEC_PAGESIZE);
 
-	if (segs - 1 > ULONG_MAX / sizeof(*vma_filesz))
-		goto end_coredump;
 	vma_filesz = kvmalloc(array_size(sizeof(*vma_filesz), (segs - 1)),
 			      GFP_KERNEL);
 	if (ZERO_OR_NULL_PTR(vma_filesz))