Skip to contentSkip to conversation

package/python-pathlib2: select python-scandir

PATCH New Asaf Kahlon 3 participants 4 messages Dec 16, 2019 – Feb 17, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/python-pathlib2: select python-scandir

scandir is a runtime dependency of pathlib2.

---
 package/python-pathlib2/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/python-pathlib2/Config.in +1 -0
index e28de4c12e..ca948c271f 100644
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_PYTHON_PATHLIB2
 	bool "python-pathlib2"
 	depends on BR2_PACKAGE_PYTHON
+	select BR2_PACKAGE_PYTHON_SCANDIR # runtime
 	select BR2_PACKAGE_PYTHON_SIX # runtime
 	help
 	  Object-oriented filesystem paths.
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/python-pathlib2: select python-scandir

Quoted 12 lines · On Mon, 16 Dec 2019 21:48:15 +0200 Asaf Kahlon <[email protected]> wrote:

scandir is a runtime dependency of pathlib2.

---
 package/python-pathlib2/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/python-pathlib2/Config.in +0 -0
index e28de4c12e..ca948c271f 100644

package/python-pathlib2/Config.in line 4

Quoted 4 lines
package/python-pathlib2/Config.in +1 -0
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_PYTHON_PATHLIB2
 	bool "python-pathlib2"
 	depends on BR2_PACKAGE_PYTHON
+	select BR2_PACKAGE_PYTHON_SCANDIR # runtime

I see this in the setup.py:

    extras_require={
        ':python_version<"3.5"': ['scandir'],
        },

Doesn't that mean that it is needed only if the Python version is < 3.5 ?

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/python-pathlib2: select python-scandir

Hello,

Quoted 23 lines · Thomas Petazzoni
Quoted 12 lines · On Mon, 16 Dec 2019 21:48:15 +0200 Asaf Kahlon <[email protected]> wrote:

scandir is a runtime dependency of pathlib2.

---
 package/python-pathlib2/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/python-pathlib2/Config.in +0 -0
index e28de4c12e..ca948c271f 100644

package/python-pathlib2/Config.in line 4

Quoted 4 lines
package/python-pathlib2/Config.in +1 -0
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_PYTHON_PATHLIB2
      bool "python-pathlib2"
      depends on BR2_PACKAGE_PYTHON
+     select BR2_PACKAGE_PYTHON_SCANDIR # runtime

I see this in the setup.py:

Quoted 5 lines
    extras_require={
        ':python_version<"3.5"': ['scandir'],
        },

Doesn't that mean that it is needed only if the Python version is < 3.5 ?

Yeah that's true, but pathlib2 can be chosen only for python 2, so we can say for sure it's needed.

Quoted 8 lines

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Regards,
Asaf.

#3 lore raw

PATCH 1/1 package/python-pathlib2: select python-scandir

Asaf, All,

Quoted 3 lines · Asaf Kahlon

Yeah that's true, but pathlib2 can be chosen only for python 2, so we can say for sure it's needed.

I can confirm that pathlib2 will crash on first invocation when using python2 if BR2_PACKAGE_PYTHON_SCANDIR is not enabled.

Thanks,

Conrad

Signature · 12 lines
Conrad Ratschan | Software Engineer | Commercial Avionics
COLLINS AEROSPACE
400 Collins Road NE, Cedar Rapids, IA 52498, USA
conrad.ratschan at collins.com | collinsaerospace.com

CONFIDENTIALITY WARNING: This message may contain proprietary and/or
privileged information of Collins Aerospace and its affiliated
companies. If you are not the intended recipient, please 1) Do not
disclose, copy, distribute or use this message or its contents. 2)
Advise the sender by return email. 3) Delete all copies (including all
attachments) from your computer. Your cooperation is greatly
appreciated.