Skip to contentSkip to conversation

dma/rc4030: correctly reset DMA translation table at reset

PATCH In review Hervé Poussineau 2 participants 2 messages Dec 22, 2019 – Dec 23, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dma/rc4030: correctly reset DMA translation table at reset

This fixes a freeze at reboot, introduced in c627e7526a902dd5bb1907dbbd5cf961679dfa68

---
 hw/dma/rc4030.c | 1 +
 1 file changed, 1 insertion(+)
hw/dma/rc4030.c +1 -0
index c4cf8236f4..76302fe431 100644
@@ -534,6 +534,7 @@ static void rc4030_reset(DeviceState *dev)
 
     memset(s->dma_regs, 0, sizeof(s->dma_regs));
 
+    s->dma_tl_base = s->dma_tl_limit = 0;
     s->remote_failed_address = s->memory_failed_address = 0;
     s->cache_maint = 0;
     s->cache_ptag = s->cache_ltag = 0;
Signature · 1 line
2.19.2
#1 lore raw
Quoted 9 lines · Hervé Poussineau

This fixes a freeze at reboot, introduced in c627e7526a902dd5bb1907dbbd5cf9 61679dfa68

---
 hw/dma/rc4030.c | 1 +
 1 file changed, 1 insertion(+)

Hi, Herve,

Very good that you found the fix, but I would really appreciate if you provide the details on repro procedure.

One more thing, does this have anything to do eith the Finn's attempt to start Jazz machine with:

Quote:

I tried to boot NetBSD/arc but failed. I got a blue screen when I typed "cd:boot" at the "Run A Program" prompt in the ARC menu.

$ ln -s NTPROM.RAW mipsel_bios.bin
$ mips64el-softmmu/qemu-system-mips64el -M magnum -L .
-drive if=scsi,unit=2,media=cdrom,format=raw,file=NetBSD-8.1-arc.iso
-global ds1225y.filename=nvram -global ds1225y.size=8200
qemu-system-mips64el: g364: invalid read at [0000000000102000]
$

Best regards,
Alekssndar

hw/dma/rc4030.c +0 -0
Quoted 16 lines

index c4cf8236f4..76302fe431 100644

hw/dma/rc4030.c +1 -1
@@ -534,6 +534,7 @@ static void rc4030_reset(DeviceState *dev)
 
     memset(s->dma_regs, 0, sizeof(s->dma_regs));
 
+    s->dma_tl_base = s->dma_tl_limit = 0;
     s->remote_failed_address = s->memory_failed_address = 0;
     s->cache_maint = 0;
     s->cache_ptag = s->cache_ltag = 0;
--

2.19.2