Skip to contentSkip to conversation

phy: cpcap-usb: Fix flakey host idling and enumerating of devices

PATCH In review Tony Lindgren 2 participants 2 messages Dec 22, 2019 – Dec 26, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 phy: cpcap-usb: Fix flakey host idling and enumerating of devices

We must let the USB host idle things properly before we switch to debug UART mode. Otherwise the USB host may never idle after disconnecting devices, and that causes the next enumeration to be flakey.

Cc Jacopo Mondi <[email protected]>
Cc Marcel Partap <[email protected]>
Cc Merlijn Wajer <[email protected]>
Cc Michael Scott <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Sebastian Reichel <[email protected]>
Fixes 6d6ce40f63af ("phy: cpcap-usb: Add CPCAP PMIC USB support")

---

Kishon, looks like the v1 patch sent in August got lost somewhere. Here's a resend update against your fixes branch.

 drivers/phy/motorola/phy-cpcap-usb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/phy/motorola/phy-cpcap-usb.c +2 -2
@@ -283,13 +283,13 @@ static void cpcap_usb_detect(struct work_struct *work)
 		return;
 	}
 
+	cpcap_usb_try_musb_mailbox(ddata, MUSB_VBUS_OFF);
+
 	/* Default to debug UART mode */
 	error = cpcap_usb_set_uart_mode(ddata);
 	if (error)
 		goto out_err;
 
-	cpcap_usb_try_musb_mailbox(ddata, MUSB_VBUS_OFF);
-
 	dev_dbg(ddata->dev, "set UART mode\n");
 
 	return;
Signature · 1 line
2.24.1
Acked-by on v2 1/1
#1 lore raw
Quoted 9 lines · Tony Lindgren

We must let the USB host idle things properly before we switch to debug UART mode. Otherwise the USB host may never idle after disconnecting devices, and that causes the next enumeration to be flakey.

Cc Jacopo Mondi <[email protected]>
Cc Marcel Partap <[email protected]>
Cc Merlijn Wajer <[email protected]>
Cc Michael Scott <[email protected]>
Quoted 3 lines
Cc Sebastian Reichel <[email protected]>
Fixes 6d6ce40f63af ("phy: cpcap-usb: Add CPCAP PMIC USB support")

But it does not apply on top of 5.5-rc3 AFAICT.

Best regards,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html