memory: emif: convert to devm_platform_ioremap_resource

PATCH Applied Yangtao Li 8 participants 16 messages Dec 22, 2019 – Jan 8, 2020

Subsystems (9)

Arm MediaTek Arm Samsung Exynos Tegra architecture support Memory controller drivers +5 more subsystems

lore

Share & tools

lore

Yangtao Li

author

2019-12-22 18:50 UTC #0 lore raw

PATCH 1/9 memory: emif: convert to devm_platform_ioremap_resource

Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by Yangtao Li <[email protected]>

---
 drivers/memory/emif.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

drivers/memory/emif.c +1 -3

index 9d9127bf2a59..9a8463716a54 100644
@@ -1537,7 +1537,6 @@ static struct emif_data *__init_or_module get_device_details(
 static int __init_or_module emif_probe(struct platform_device *pdev)
 {
 	struct emif_data	*emif;
-	struct resource		*res;
 	int			irq;
 
 	if (pdev->dev.of_node)

@@ -1557,8 +1556,7 @@ static int __init_or_module emif_probe(struct platform_device *pdev)
 	emif->dev = &pdev->dev;
 	platform_set_drvdata(pdev, emif);
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	emif->base = devm_ioremap_resource(emif->dev, res);
+	emif->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(emif->base))
 		goto error;

Signature · 1 line

2.17.1

Yangtao Li

author

2019-12-22 18:50 UTC #1 lore raw

PATCH 2/9 memory: jz4780_nemc: convert to devm_platform_ioremap_resource

Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by Yangtao Li <[email protected]>

---
 drivers/memory/jz4780-nemc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

drivers/memory/jz4780-nemc.c +1 -3

index b232ed279fc3..857a9fa5cba5 100644
@@ -269,7 +269,6 @@ static int jz4780_nemc_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct jz4780_nemc *nemc;
-	struct resource *res;
 	struct device_node *child;
 	const __be32 *prop;
 	unsigned int bank;

@@ -287,8 +286,7 @@ static int jz4780_nemc_probe(struct platform_device *pdev)
 	spin_lock_init(&nemc->lock);
 	nemc->dev = dev;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	nemc->base = devm_ioremap_resource(dev, res);
+	nemc->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(nemc->base)) {
 		dev_err(dev, "failed to get I/O memory\n");
 		return PTR_ERR(nemc->base);

Signature · 1 line

2.17.1

Yangtao Li

author

2019-12-22 18:50 UTC #3 lore raw

PATCH 3/9 memory: mvebu-devbus: convert to devm_platform_ioremap_resource

In reply to Yangtao Li

Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by Yangtao Li <[email protected]>

---
 drivers/memory/mvebu-devbus.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

drivers/memory/mvebu-devbus.c +1 -3

index 095f8a3b2cfc..886aea587276 100644
@@ -267,7 +267,6 @@ static int mvebu_devbus_probe(struct platform_device *pdev)
 	struct devbus_read_params r;
 	struct devbus_write_params w;
 	struct devbus *devbus;
-	struct resource *res;
 	struct clk *clk;
 	unsigned long rate;
 	int err;

@@ -277,8 +276,7 @@ static int mvebu_devbus_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	devbus->dev = dev;
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	devbus->base = devm_ioremap_resource(&pdev->dev, res);
+	devbus->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(devbus->base))
 		return PTR_ERR(devbus->base);

Signature · 1 line

2.17.1

Gregory CLEMENT

2020-01-08 09:41 UTC #4 lore raw

Re: [PATCH 3/9] memory: mvebu-devbus: convert to devm_platform_ioremap_resource

Hi Yangtao Li,

Quoted 3 lines

Use devm_platform_ioremap_resource() to simplify code.
Signed-off-by Yangtao Li <[email protected]>

Applied on mvebu/drivers

Thanks,

Gregory

Quoted 34 lines

---
 drivers/memory/mvebu-devbus.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

drivers/memory/mvebu-devbus.c +1 -3

index 095f8a3b2cfc..886aea587276 100644
@@ -267,7 +267,6 @@ static int mvebu_devbus_probe(struct platform_device *pdev)
 	struct devbus_read_params r;
 	struct devbus_write_params w;
 	struct devbus *devbus;
-	struct resource *res;
 	struct clk *clk;
 	unsigned long rate;
 	int err;

@@ -277,8 +276,7 @@ static int mvebu_devbus_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	devbus->dev = dev;
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	devbus->base = devm_ioremap_resource(&pdev->dev, res);
+	devbus->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(devbus->base))
 		return PTR_ERR(devbus->base);

Signature · 7 lines

2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Signature · 3 lines

Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

Yangtao Li

author

2019-12-22 18:50 UTC #5 lore raw

PATCH 4/9 memory: tegra: convert to devm_platform_ioremap_resource

In reply to Yangtao Li

Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by Yangtao Li <[email protected]>

---
 drivers/memory/tegra/mc.c           | 4 +---
 drivers/memory/tegra/tegra124-emc.c | 4 +---
 drivers/memory/tegra/tegra186.c     | 4 +---
 drivers/memory/tegra/tegra20-emc.c  | 4 +---
 4 files changed, 4 insertions(+), 12 deletions(-)

drivers/memory/tegra/mc.c +1 -3

index ec8403557ed4..71390d4ad809 100644
@@ -593,7 +593,6 @@ static __maybe_unused irqreturn_t tegra20_mc_irq(int irq, void *data)
 
 static int tegra_mc_probe(struct platform_device *pdev)
 {
-	struct resource *res;
 	struct tegra_mc *mc;
 	void *isr;
 	u64 mask;

@@ -619,8 +618,7 @@ static int tegra_mc_probe(struct platform_device *pdev)
 	/* length of MC tick in nanoseconds */
 	mc->tick = 30;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	mc->regs = devm_ioremap_resource(&pdev->dev, res);
+	mc->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(mc->regs))
 		return PTR_ERR(mc->regs);

drivers/memory/tegra/tegra124-emc.c +1 -3

index 464f0ceaee63..2c73260654ba 100644
@@ -1085,7 +1085,6 @@ static int tegra_emc_probe(struct platform_device *pdev)
 	struct platform_device *mc;
 	struct device_node *np;
 	struct tegra_emc *emc;
-	struct resource *res;
 	u32 ram_code;
 	int err;

@@ -1095,8 +1094,7 @@ static int tegra_emc_probe(struct platform_device *pdev)
 
 	emc->dev = &pdev->dev;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	emc->regs = devm_ioremap_resource(&pdev->dev, res);
+	emc->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(emc->regs))
 		return PTR_ERR(emc->regs);

drivers/memory/tegra/tegra186.c +1 -3

index 441213a35930..226d2b16036d 100644
@@ -534,7 +534,6 @@ static const struct tegra_mc_client tegra186_mc_clients[] = {
 
 static int tegra186_mc_probe(struct platform_device *pdev)
 {
-	struct resource *res;
 	struct tegra_mc *mc;
 	unsigned int i;
 	int err = 0;

@@ -543,8 +542,7 @@ static int tegra186_mc_probe(struct platform_device *pdev)
 	if (!mc)
 		return -ENOMEM;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	mc->regs = devm_ioremap_resource(&pdev->dev, res);
+	mc->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(mc->regs))
 		return PTR_ERR(mc->regs);

drivers/memory/tegra/tegra20-emc.c +1 -3

index 1b23b1c34476..d2efd0c658c0 100644
@@ -482,7 +482,6 @@ static int tegra_emc_probe(struct platform_device *pdev)
 {
 	struct device_node *np;
 	struct tegra_emc *emc;
-	struct resource *res;
 	int irq, err;
 
 	/* driver has nothing to do in a case of memory timing absence */

@@ -518,8 +517,7 @@ static int tegra_emc_probe(struct platform_device *pdev)
 	if (err)
 		return err;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	emc->regs = devm_ioremap_resource(&pdev->dev, res);
+	emc->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(emc->regs))
 		return PTR_ERR(emc->regs);

Signature · 1 line

2.17.1

Dmitry Osipenko

Reviewed-by on v1 4/9

2019-12-23 15:42 UTC #6 lore raw

Re: [PATCH 4/9] memory: tegra: convert to devm_platform_ioremap_resource

22.12.2019 21:50, Yangtao Li пишет:

Quoted 90 lines

Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by Yangtao Li <[email protected]>

---
 drivers/memory/tegra/mc.c           | 4 +---
 drivers/memory/tegra/tegra124-emc.c | 4 +---
 drivers/memory/tegra/tegra186.c     | 4 +---
 drivers/memory/tegra/tegra20-emc.c  | 4 +---
 4 files changed, 4 insertions(+), 12 deletions(-)

drivers/memory/tegra/mc.c +1 -3

index ec8403557ed4..71390d4ad809 100644
@@ -593,7 +593,6 @@ static __maybe_unused irqreturn_t tegra20_mc_irq(int irq, void *data)
 
 static int tegra_mc_probe(struct platform_device *pdev)
 {
-	struct resource *res;
 	struct tegra_mc *mc;
 	void *isr;
 	u64 mask;

@@ -619,8 +618,7 @@ static int tegra_mc_probe(struct platform_device *pdev)
 	/* length of MC tick in nanoseconds */
 	mc->tick = 30;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	mc->regs = devm_ioremap_resource(&pdev->dev, res);
+	mc->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(mc->regs))
 		return PTR_ERR(mc->regs);

drivers/memory/tegra/tegra124-emc.c +1 -3

index 464f0ceaee63..2c73260654ba 100644
@@ -1085,7 +1085,6 @@ static int tegra_emc_probe(struct platform_device *pdev)
 	struct platform_device *mc;
 	struct device_node *np;
 	struct tegra_emc *emc;
-	struct resource *res;
 	u32 ram_code;
 	int err;

@@ -1095,8 +1094,7 @@ static int tegra_emc_probe(struct platform_device *pdev)
 
 	emc->dev = &pdev->dev;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	emc->regs = devm_ioremap_resource(&pdev->dev, res);
+	emc->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(emc->regs))
 		return PTR_ERR(emc->regs);

drivers/memory/tegra/tegra186.c +1 -3

index 441213a35930..226d2b16036d 100644
@@ -534,7 +534,6 @@ static const struct tegra_mc_client tegra186_mc_clients[] = {
 
 static int tegra186_mc_probe(struct platform_device *pdev)
 {
-	struct resource *res;
 	struct tegra_mc *mc;
 	unsigned int i;
 	int err = 0;

@@ -543,8 +542,7 @@ static int tegra186_mc_probe(struct platform_device *pdev)
 	if (!mc)
 		return -ENOMEM;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	mc->regs = devm_ioremap_resource(&pdev->dev, res);
+	mc->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(mc->regs))
 		return PTR_ERR(mc->regs);

drivers/memory/tegra/tegra20-emc.c +0 -1

index 1b23b1c34476..d2efd0c658c0 100644
@@ -482,7 +482,6 @@ static int tegra_emc_probe(struct platform_device *pdev)
 {
 	struct device_node *np;
 	struct tegra_emc *emc;
-	struct resource *res;
 	int irq, err;
 
 	/* driver has nothing to do in a case of memory timing absence */

drivers/memory/tegra/tegra20-emc.c static int tegra_emc_probe(struct platform_device *pdev) · line 523

Quoted 9 lines

drivers/memory/tegra/tegra20-emc.c +1 -2

@@ -518,8 +517,7 @@ static int tegra_emc_probe(struct platform_device *pdev)
 	if (err)
 		return err;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	emc->regs = devm_ioremap_resource(&pdev->dev, res);
+	emc->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(emc->regs))
 		return PTR_ERR(emc->regs);

Looks good, thanks!

Reviewed-by Dmitry Osipenko <[email protected]>

Yangtao Li

author

2019-12-22 18:50 UTC #7 lore raw

PATCH 5/9 memory: fsl-corenet-cf: convert to devm_platform_ioremap_resource

In reply to Yangtao Li

Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by Yangtao Li <[email protected]>

---
 drivers/memory/fsl-corenet-cf.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

drivers/memory/fsl-corenet-cf.c +1 -8

index 0b0ed72016da..2c62312ea513 100644
@@ -172,7 +172,6 @@ static irqreturn_t ccf_irq(int irq, void *dev_id)
 static int ccf_probe(struct platform_device *pdev)
 {
 	struct ccf_private *ccf;
-	struct resource *r;
 	const struct of_device_id *match;
 	u32 errinten;
 	int ret, irq;

@@ -185,13 +184,7 @@ static int ccf_probe(struct platform_device *pdev)
 	if (!ccf)
 		return -ENOMEM;
 
-	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!r) {
-		dev_err(&pdev->dev, "%s: no mem resource\n", __func__);
-		return -ENXIO;
-	}
-
-	ccf->regs = devm_ioremap_resource(&pdev->dev, r);
+	ccf->regs =  devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(ccf->regs)) {
 		dev_err(&pdev->dev, "%s: can't map mem resource\n", __func__);
 		return PTR_ERR(ccf->regs);

Signature · 1 line

2.17.1

Yangtao Li

author

2019-12-22 18:50 UTC #8 lore raw

PATCH 6/9 memory: ti-aemif: convert to devm_platform_ioremap_resource

In reply to Yangtao Li

Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by Yangtao Li <[email protected]>

---
 drivers/memory/ti-aemif.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

drivers/memory/ti-aemif.c +1 -3

index db526dbf71ee..6524229f634a 100644
@@ -328,7 +328,6 @@ static int aemif_probe(struct platform_device *pdev)
 {
 	int i;
 	int ret = -ENODEV;
-	struct resource *res;
 	struct device *dev = &pdev->dev;
 	struct device_node *np = dev->of_node;
 	struct device_node *child_np;

@@ -362,8 +361,7 @@ static int aemif_probe(struct platform_device *pdev)
 	else if (pdata)
 		aemif->cs_offset = pdata->cs_offset;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	aemif->base = devm_ioremap_resource(dev, res);
+	aemif->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(aemif->base)) {
 		ret = PTR_ERR(aemif->base);
 		goto error;

Signature · 1 line

2.17.1

Yangtao Li

author

2019-12-22 18:50 UTC #9 lore raw

PATCH 7/9 memory: samsung: exynos5422-dmc: convert to devm_platform_ioremap_resource

In reply to Yangtao Li

Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by Yangtao Li <[email protected]>

---
 drivers/memory/samsung/exynos5422-dmc.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

drivers/memory/samsung/exynos5422-dmc.c +2 -5

index 47dbf6d1789f..81a1b1d01683 100644
@@ -1374,7 +1374,6 @@ static int exynos5_dmc_probe(struct platform_device *pdev)
 	struct device *dev = &pdev->dev;
 	struct device_node *np = dev->of_node;
 	struct exynos5_dmc *dmc;
-	struct resource *res;
 	int irq[2];
 
 	dmc = devm_kzalloc(dev, sizeof(*dmc), GFP_KERNEL);

@@ -1386,13 +1385,11 @@ static int exynos5_dmc_probe(struct platform_device *pdev)
 	dmc->dev = dev;
 	platform_set_drvdata(pdev, dmc);
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	dmc->base_drexi0 = devm_ioremap_resource(dev, res);
+	dmc->base_drexi0 = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(dmc->base_drexi0))
 		return PTR_ERR(dmc->base_drexi0);
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
-	dmc->base_drexi1 = devm_ioremap_resource(dev, res);
+	dmc->base_drexi1 = devm_platform_ioremap_resource(pdev, 1);
 	if (IS_ERR(dmc->base_drexi1))
 		return PTR_ERR(dmc->base_drexi1);

Signature · 1 line

2.17.1

Lukasz Luba

maintainer Acked-by on v1 7/9

2019-12-30 09:13 UTC #10 lore raw

Re: [PATCH 7/9] memory: samsung: exynos5422-dmc: convert to devm_platform_ioremap_resource

Hi,

Quoted 26 lines · Yangtao Li

Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by Yangtao Li <[email protected]>

---
  drivers/memory/samsung/exynos5422-dmc.c | 7 ++-----
  1 file changed, 2 insertions(+), 5 deletions(-)

drivers/memory/samsung/exynos5422-dmc.c +0 -3

index 47dbf6d1789f..81a1b1d01683 100644
@@ -1374,7 +1374,6 @@ static int exynos5_dmc_probe(struct platform_device *pdev)
  	struct device *dev = &pdev->dev;
  	struct device_node *np = dev->of_node;
  	struct exynos5_dmc *dmc;
-	struct resource *res;
  	int irq[2];
 
  	dmc = devm_kzalloc(dev, sizeof(*dmc), GFP_KERNEL);

@@ -1386,13 +1385,11 @@ static int exynos5_dmc_probe(struct platform_device *pdev)
  	dmc->dev = dev;
  	platform_set_drvdata(pdev, dmc);
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	dmc->base_drexi0 = devm_ioremap_resource(dev, res);

drivers/memory/samsung/exynos5422-dmc.c static int exynos5_dmc_probe(struct platform_device *pdev) · line 1395

Quoted 10 lines

drivers/memory/samsung/exynos5422-dmc.c +2 -2

+	dmc->base_drexi0 = devm_platform_ioremap_resource(pdev, 0);
  	if (IS_ERR(dmc->base_drexi0))
  		return PTR_ERR(dmc->base_drexi0);
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
-	dmc->base_drexi1 = devm_ioremap_resource(dev, res);
+	dmc->base_drexi1 = devm_platform_ioremap_resource(pdev, 1);
  	if (IS_ERR(dmc->base_drexi1))
  		return PTR_ERR(dmc->base_drexi1);

Acked-by Lukasz Luba <[email protected]>

Regards,
Lukasz

Krzysztof Kozlowski

maintainer Applied

2019-12-30 17:56 UTC #11 lore raw

Re: [PATCH 7/9] memory: samsung: exynos5422-dmc: convert to devm_platform_ioremap_resource

In reply to Yangtao Li

Quoted 5 lines · Yangtao Li

Use devm_platform_ioremap_resource() to simplify code.
Signed-off-by Yangtao Li <[email protected]>
---
 drivers/memory/samsung/exynos5422-dmc.c | 7 ++-----

Thanks, applied.

Best regards,
Krzysztof

Yangtao Li

author

2019-12-22 18:50 UTC #12 lore raw

PATCH 8/9 memory: mtk-smi: convert to devm_platform_ioremap_resource

In reply to Yangtao Li

Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by Yangtao Li <[email protected]>

---
 drivers/memory/mtk-smi.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

drivers/memory/mtk-smi.c +3 -8

index a113e811faab..1cc5d94036a2 100644
@@ -269,7 +269,6 @@ static const struct of_device_id mtk_smi_larb_of_ids[] = {
 static int mtk_smi_larb_probe(struct platform_device *pdev)
 {
 	struct mtk_smi_larb *larb;
-	struct resource *res;
 	struct device *dev = &pdev->dev;
 	struct device_node *smi_node;
 	struct platform_device *smi_pdev;

@@ -279,8 +278,7 @@ static int mtk_smi_larb_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	larb->larb_gen = of_device_get_match_data(dev);
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	larb->base = devm_ioremap_resource(dev, res);
+	larb->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(larb->base))
 		return PTR_ERR(larb->base);

@@ -419,7 +417,6 @@ static int mtk_smi_common_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct mtk_smi *common;
-	struct resource *res;
 	int ret;
 
 	common = devm_kzalloc(dev, sizeof(*common), GFP_KERNEL);

@@ -453,8 +450,7 @@ static int mtk_smi_common_probe(struct platform_device *pdev)
 	 * base.
 	 */
 	if (common->plat->gen == MTK_SMI_GEN1) {
-		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-		common->smi_ao_base = devm_ioremap_resource(dev, res);
+		common->smi_ao_base = devm_platform_ioremap_resource(pdev, 0);
 		if (IS_ERR(common->smi_ao_base))
 			return PTR_ERR(common->smi_ao_base);

@@ -466,8 +462,7 @@ static int mtk_smi_common_probe(struct platform_device *pdev)
 		if (ret)
 			return ret;
 	} else {
-		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-		common->base = devm_ioremap_resource(dev, res);
+		common->base = devm_platform_ioremap_resource(pdev, 0);
 		if (IS_ERR(common->base))
 			return PTR_ERR(common->base);
 	}

Signature · 1 line

2.17.1

Yong Wu

maintainer Reviewed-by on v1 8/9

2019-12-27 07:24 UTC #13 lore raw

Re: [PATCH 8/9] memory: mtk-smi: convert to devm_platform_ioremap_resource

Quoted 6 lines · Yangtao Li

Use devm_platform_ioremap_resource() to simplify code.
Signed-off-by Yangtao Li <[email protected]>
---
 drivers/memory/mtk-smi.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

Reviewed-by Yong Wu <[email protected]>

Yangtao Li

author

2019-12-22 18:50 UTC #14 lore raw

PATCH 9/9 memory: omap-gpmc: switch to platform_get_irq

In reply to Yangtao Li

platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for requesting IRQ's resources, as they can be not ready yet. Using platform_get_irq() instead is preferred for getting IRQ even if it was not retrieved earlier.

Signed-off-by Yangtao Li <[email protected]>

---
 drivers/memory/omap-gpmc.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

drivers/memory/omap-gpmc.c +3 -7

index eff26c1b1394..6dd19d168f75 100644
@@ -2366,13 +2366,9 @@ static int gpmc_probe(struct platform_device *pdev)
 	if (IS_ERR(gpmc_base))
 		return PTR_ERR(gpmc_base);
 
-	res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-	if (!res) {
-		dev_err(&pdev->dev, "Failed to get resource: irq\n");
-		return -ENOENT;
-	}
-
-	gpmc->irq = res->start;
+	gpmc->irq = platform_get_irq(pdev, 0);
+	if (gpmc->irq < 0)
+		return gpmc->irq;
 
 	gpmc_l3_clk = devm_clk_get(&pdev->dev, "fck");
 	if (IS_ERR(gpmc_l3_clk)) {

Signature · 1 line

2.17.1

Roger Quadros

Acked-by on v1 9/9

2019-12-23 07:25 UTC #15 lore raw

Re: [PATCH 9/9] memory: omap-gpmc: switch to platform_get_irq

Quoted 6 lines · Yangtao Li

platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for requesting IRQ's resources, as they can be not ready yet. Using platform_get_irq() instead is preferred for getting IRQ even if it was not retrieved earlier.
Signed-off-by Yangtao Li <[email protected]>

Acked-by Roger Quadros <[email protected]>

Quoted 26 lines

---
  drivers/memory/omap-gpmc.c | 10 +++-------
  1 file changed, 3 insertions(+), 7 deletions(-)

drivers/memory/omap-gpmc.c +3 -7

index eff26c1b1394..6dd19d168f75 100644
@@ -2366,13 +2366,9 @@ static int gpmc_probe(struct platform_device *pdev)
  	if (IS_ERR(gpmc_base))
  		return PTR_ERR(gpmc_base);
 
-	res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-	if (!res) {
-		dev_err(&pdev->dev, "Failed to get resource: irq\n");
-		return -ENOENT;
-	}
-
-	gpmc->irq = res->start;
+	gpmc->irq = platform_get_irq(pdev, 0);
+	if (gpmc->irq < 0)
+		return gpmc->irq;
 
  	gpmc_l3_clk = devm_clk_get(&pdev->dev, "fck");
  	if (IS_ERR(gpmc_l3_clk)) {

Signature · 5 lines

cheers,
-roger

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki