Skip to contentSkip to conversation

package/fluidsynth: new package

PATCH Superseded Julien Olivain 3 participants 6 messages Dec 5, 2019 – Dec 22, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/fluidsynth: new package

FluidSynth is a real-time software synthesizer based on the SoundFont 2 specifications and has reached widespread distribution. FluidSynth itself does not have a graphical user interface, but due to its powerful API several applications utilize it and it has even found its way onto embedded systems and is used in some mobile apps.

http://www.fluidsynth.org/

---
 DEVELOPERS                         |  1 +
 package/Config.in                  |  1 +
 package/fluidsynth/Config.in       | 97 ++++++++++++++++++++++++++++++
 package/fluidsynth/fluidsynth.hash |  2 +
 package/fluidsynth/fluidsynth.mk   | 74 +++++++++++++++++++++++
 5 files changed, 175 insertions(+)
 create mode 100644 package/fluidsynth/Config.in
 create mode 100644 package/fluidsynth/fluidsynth.hash
 create mode 100644 package/fluidsynth/fluidsynth.mk
DEVELOPERS +1 -0
index a030be7890..33b828daed 100644
@@ -1347,6 +1347,7 @@ F:	board/technexion/imx8mmpico/
 F:	board/technexion/imx8mpico/
 F:	configs/imx8mmpico_defconfig
 F:	configs/imx8mpico_defconfig
+F:	package/fluidsynth/
 
 N:	Julien Viard de Galbert <[email protected]>
 F:	package/dieharder/
package/Config.in +1 -0
index 9e2b78fe6a..30dc329add 100644
@@ -23,6 +23,7 @@ menu "Audio and video applications"
 	source "package/ffmpeg/Config.in"
 	source "package/flac/Config.in"
 	source "package/flite/Config.in"
+	source "package/fluidsynth/Config.in"
 	source "package/gmrender-resurrect/Config.in"
 	source "package/gstreamer/Config.in"
 	source "package/gstreamer1/Config.in"
package/fluidsynth/Config.in new file +97 -0

97 lines not on this page · raw message

package/fluidsynth/fluidsynth.hash new file +2 -0
new file mode 100644
index 0000000000..d28073bb3d
@@ -0,0 +1,2 @@
+# Locally computed
+sha256 526addc6d8445035840d3af7282d3ba89567df209d28e183da04a1a877da2da3  fluidsynth-v2.1.0.tar.gz
package/fluidsynth/fluidsynth.mk new file +74 -0

74 lines not on this page · raw message

Signature · 1 line
2.23.0
#1 lore raw

PATCH 1/1 package/fluidsynth: new package

Hello Julien,

thanks for your contribution.
A few comments below
Thanks.
Gilles.

Le jeu. 5 d?c. 2019 ? 21:33, Julien Olivain <[email protected]> a ?crit :

Quoted 52 lines

FluidSynth is a real-time software synthesizer based on the SoundFont 2 specifications and has reached widespread distribution. FluidSynth itself does not have a graphical user interface, but due to its powerful API several applications utilize it and it has even found its way onto embedded systems and is used in some mobile apps.

http://www.fluidsynth.org/

---
 DEVELOPERS                         |  1 +
 package/Config.in                  |  1 +
 package/fluidsynth/Config.in       | 97 ++++++++++++++++++++++++++++++
 package/fluidsynth/fluidsynth.hash |  2 +
 package/fluidsynth/fluidsynth.mk   | 74 +++++++++++++++++++++++
 5 files changed, 175 insertions(+)
 create mode 100644 package/fluidsynth/Config.in
 create mode 100644 package/fluidsynth/fluidsynth.hash
 create mode 100644 package/fluidsynth/fluidsynth.mk
DEVELOPERS +1 -0
index a030be7890..33b828daed 100644
@@ -1347,6 +1347,7 @@ F:        board/technexion/imx8mmpico/
 F:     board/technexion/imx8mpico/
 F:     configs/imx8mmpico_defconfig
 F:     configs/imx8mpico_defconfig
+F:     package/fluidsynth/
 
 N:     Julien Viard de Galbert <[email protected]>
 F:     package/dieharder/
package/Config.in +1 -0
index 9e2b78fe6a..30dc329add 100644
@@ -23,6 +23,7 @@ menu "Audio and video applications"
        source "package/ffmpeg/Config.in"
        source "package/flac/Config.in"
        source "package/flite/Config.in"
+       source "package/fluidsynth/Config.in"
        source "package/gmrender-resurrect/Config.in"
        source "package/gstreamer/Config.in"
        source "package/gstreamer1/Config.in"
package/fluidsynth/Config.in new file +0 -0
new file mode 100644
index 0000000000..b50aa11ee7

package/fluidsynth/Config.in line 5

Quoted 5 lines
package/fluidsynth/Config.in new file +5 -0
@@ -0,0 +1,97 @@
+config BR2_PACKAGE_FLUIDSYNTH
+       bool "fluidsynth"
+       depends on BR2_USE_WCHAR
+       depends on BR2_TOOLCHAIN_HAS_THREADS
+       depends on BR2_USE_MMU

It might be interesting to mention that these dependencies are brought up by libglib2
e.g. depends on BR2_USE_WCHAR # libglib2

Quoted 61 lines
package/fluidsynth/Config.in new file +61 -0
+       select BR2_PACKAGE_LIBGLIB2
+       help
+         FluidSynth is a real-time software synthesizer based on the
+         SoundFont 2 specifications and has reached widespread
+         distribution. FluidSynth itself does not have a graphical
+         user interface, but due to its powerful API several
+         applications utilize it and it has even found its way onto
+         embedded systems and is used in some mobile apps.
+
+         http://www.fluidsynth.org/
+
+if BR2_PACKAGE_FLUIDSYNTH
+
+comment "Output support"
+
+config BR2_PACKAGE_FLUIDSYNTH_ALSA_LIB
+       bool "alsa"
+       default y
+       select BR2_PACKAGE_ALSA_LIB
+       help
+         Enable alsa support.
+
+config BR2_PACKAGE_FLUIDSYNTH_JACK2
+       bool "jack2"
+       # See: https://sourceware.org/bugzilla/show_bug.cgi?id=19908
+       depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_MIPS
+       depends on !BR2_STATIC_LIBS
+       depends on BR2_INSTALL_LIBSTDCPP
+       depends on BR2_TOOLCHAIN_HAS_SYNC_4
+       select BR2_PACKAGE_JACK2
+       help
+         Enable jack support.
+
+comment "jack support needs a toolchain w/ dynamic library"
+       depends on BR2_TOOLCHAIN_HAS_SYNC_4
+       depends on BR2_STATIC_LIBS
+
+config BR2_PACKAGE_FLUIDSYNTH_LIBSNDFILE
+       bool "libsndfile"
+       select BR2_PACKAGE_LIBSNDFILE
+       help
+         Enable libsndfile support, for writing output to WAV files.
+
+config BR2_PACKAGE_FLUIDSYNTH_PORTAUDIO
+       bool "portaudio"
+       select BR2_PACKAGE_PORTAUDIO
+       help
+         Enable portaudio support.
+
+config BR2_PACKAGE_FLUIDSYNTH_PULSEAUDIO
+       bool "pulseaudio"
+       # See: https://sourceware.org/bugzilla/show_bug.cgi?id=19908
+       depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_MIPS
+       depends on !BR2_STATIC_LIBS
+       select BR2_PACKAGE_PULSEAUDIO
+       help
+         Enable PulseAudio support.
+
+comment "pulseaudio support needs a toolchain w/ dynamic library"
+       depends on BR2_STATIC_LIBS
+

package/fluidsynth/Config.in line 76

Quoted 10 lines
package/fluidsynth/Config.in new file +10 -0
+comment "Misc options"
+
+config BR2_PACKAGE_FLUIDSYNTH_DBUS
+       bool "dbus"
+       select BR2_PACKAGE_DBUS
+       help
+         Enable dbus support.
+
+config BR2_PACKAGE_FLUIDSYNTH_FLOATS
+       bool "floats"

I would change the name here. "floats" is pretty vague. what about "32-bit single precision float" ?

Quoted 6 lines
package/fluidsynth/Config.in new file +6 -0
+       help
+         Enable 32-bit single precision float support, instead of
+         64-bit double precision floats for DSP samples.
+
+config BR2_PACKAGE_FLUIDSYNTH_READLINE
+       bool "readline"

package/fluidsynth/Config.in line 92

Quoted 10 lines
package/fluidsynth/Config.in new file +10 -0
+       select BR2_PACKAGE_READLINE
+       help
+         Enable readline support, for better line editing in FluidSynth
+         shell.
+
+config BR2_PACKAGE_FLUIDSYNTH_THREADS
+       bool "threads"
+       default y
+       help
+         Enable multi-thread support.

The package needs a toolchain with threads support.
Do we need this option? I would just enable it all the time in the recipe.

package/fluidsynth/fluidsynth.hash line 2

Quoted 13 lines
package/fluidsynth/Config.in new file +5 -0
+
+endif # BR2_PACKAGE_FLUIDSYNTH
+
+comment "fluidsynth needs a toolchain w/ threads, wchar"
+       depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
package/fluidsynth/fluidsynth.hash new file +2 -0
new file mode 100644
index 0000000000..d28073bb3d
@@ -0,0 +1,2 @@
+# Locally computed
+sha256 526addc6d8445035840d3af7282d3ba89567df209d28e183da04a1a877da2da3  fluidsynth-v2.1.0.tar.gz

The hash for the license file is missing.

package/fluidsynth/fluidsynth.mk line 7

Quoted 13 lines
package/fluidsynth/fluidsynth.mk new file +7 -0
new file mode 100644
index 0000000000..ef1ac8ed85
@@ -0,0 +1,74 @@
+################################################################################
+#
+# fluidsynth
+#
+################################################################################
+
+FLUIDSYNTH_VERSION = v2.1.0

I would move the "v" to FLUIDSYNTH_SITE for better version tracking with release-monitoring.org
https://release-monitoring.org/project/10437/

package/fluidsynth/fluidsynth.mk line 8

Quoted 1 line
package/fluidsynth/fluidsynth.mk new file +1 -0
+FLUIDSYNTH_SITE = $(call github,FluidSynth,fluidsynth,$(FLUIDSYNTH_VERSION))

As mentioned just above, please add "v" in front of $(FLUIDSYNTH_VERSION)

package/fluidsynth/fluidsynth.mk line 9

Quoted 1 line
package/fluidsynth/fluidsynth.mk new file +1 -0
+FLUIDSYNTH_LICENSE = LGPLv2+

It is LGPL-2.1+

Quoted 53 lines
package/fluidsynth/fluidsynth.mk new file +53 -0
+FLUIDSYNTH_LICENSE_FILES = LICENSE
+FLUIDSYNTH_DEPENDENCIES = libglib2
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_ALSA_LIB),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-alsa=1
+FLUIDSYNTH_DEPENDENCIES += alsa-lib
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-alsa=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_DBUS),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-dbus=1
+FLUIDSYNTH_DEPENDENCIES += dbus
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-dbus=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_FLOATS),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-floats=1
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-floats=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_JACK2),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-jack=1
+FLUIDSYNTH_DEPENDENCIES += jack2
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-jack=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_LIBSNDFILE),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-libsndfile=1
+FLUIDSYNTH_DEPENDENCIES += libsndfile
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-libsndfile=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_PORTAUDIO),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-portaudio=1
+FLUIDSYNTH_DEPENDENCIES += portaudio
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-portaudio=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_PULSEAUDIO),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-pulseaudio=1
+FLUIDSYNTH_DEPENDENCIES += pulseaudio
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-pulseaudio=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_READLINE),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-readline=1

package/fluidsynth/fluidsynth.mk line 72

Quoted 10 lines
package/fluidsynth/fluidsynth.mk new file +10 -0
+FLUIDSYNTH_DEPENDENCIES += readline
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-readline=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_THREADS),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-threads=1
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-threads=0
+endif

As mentioned above, I would enable this option aways.

Quoted 9 lines
package/fluidsynth/fluidsynth.mk new file +2 -1
+
+$(eval $(cmake-package))
--

2.23.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#2 lore raw

PATCH 1/1 package/fluidsynth: new package

Hi Gilles,

Thanks for your review! I agree with all your comments, and I'll post an updated version of the patch.

Best regards,

Julien.

Quoted 285 lines · Gilles Talis

Hello Julien,

thanks for your contribution.
A few comments below
Thanks.
Gilles.

Le jeu. 5 d?c. 2019 ? 21:33, Julien Olivain <[email protected]> a ?crit :

Quoted 54 lines

FluidSynth is a real-time software synthesizer based on the SoundFont 2 specifications and has reached widespread distribution. FluidSynth itself does not have a graphical user interface, but due to its powerful API several applications utilize it and it has even found its way onto embedded systems and is used in some mobile apps.

http://www.fluidsynth.org/

---
 DEVELOPERS                         |  1 +
 package/Config.in                  |  1 +
 package/fluidsynth/Config.in       | 97 
++++++++++++++++++++++++++++++
 package/fluidsynth/fluidsynth.hash |  2 +
 package/fluidsynth/fluidsynth.mk   | 74 +++++++++++++++++++++++
 5 files changed, 175 insertions(+)
 create mode 100644 package/fluidsynth/Config.in
 create mode 100644 package/fluidsynth/fluidsynth.hash
 create mode 100644 package/fluidsynth/fluidsynth.mk
DEVELOPERS +1 -0
index a030be7890..33b828daed 100644
@@ -1347,6 +1347,7 @@ F:        board/technexion/imx8mmpico/
 F:     board/technexion/imx8mpico/
 F:     configs/imx8mmpico_defconfig
 F:     configs/imx8mpico_defconfig
+F:     package/fluidsynth/
 
 N:     Julien Viard de Galbert <[email protected]>
 F:     package/dieharder/
package/Config.in +1 -0
index 9e2b78fe6a..30dc329add 100644
@@ -23,6 +23,7 @@ menu "Audio and video applications"
        source "package/ffmpeg/Config.in"
        source "package/flac/Config.in"
        source "package/flite/Config.in"
+       source "package/fluidsynth/Config.in"
        source "package/gmrender-resurrect/Config.in"
        source "package/gstreamer/Config.in"
        source "package/gstreamer1/Config.in"
package/fluidsynth/Config.in new file +0 -0
new file mode 100644
index 0000000000..b50aa11ee7

package/fluidsynth/Config.in line 5

Quoted 5 lines
package/fluidsynth/Config.in new file +5 -0
@@ -0,0 +1,97 @@
+config BR2_PACKAGE_FLUIDSYNTH
+       bool "fluidsynth"
+       depends on BR2_USE_WCHAR
+       depends on BR2_TOOLCHAIN_HAS_THREADS
+       depends on BR2_USE_MMU

It might be interesting to mention that these dependencies are brought up by libglib2
e.g. depends on BR2_USE_WCHAR # libglib2

Quoted 61 lines
package/fluidsynth/Config.in new file +61 -0
+       select BR2_PACKAGE_LIBGLIB2
+       help
+         FluidSynth is a real-time software synthesizer based on the
+         SoundFont 2 specifications and has reached widespread
+         distribution. FluidSynth itself does not have a graphical
+         user interface, but due to its powerful API several
+         applications utilize it and it has even found its way onto
+         embedded systems and is used in some mobile apps.
+
+         http://www.fluidsynth.org/
+
+if BR2_PACKAGE_FLUIDSYNTH
+
+comment "Output support"
+
+config BR2_PACKAGE_FLUIDSYNTH_ALSA_LIB
+       bool "alsa"
+       default y
+       select BR2_PACKAGE_ALSA_LIB
+       help
+         Enable alsa support.
+
+config BR2_PACKAGE_FLUIDSYNTH_JACK2
+       bool "jack2"
+       # See: https://sourceware.org/bugzilla/show_bug.cgi?id=19908
+       depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_MIPS
+       depends on !BR2_STATIC_LIBS
+       depends on BR2_INSTALL_LIBSTDCPP
+       depends on BR2_TOOLCHAIN_HAS_SYNC_4
+       select BR2_PACKAGE_JACK2
+       help
+         Enable jack support.
+
+comment "jack support needs a toolchain w/ dynamic library"
+       depends on BR2_TOOLCHAIN_HAS_SYNC_4
+       depends on BR2_STATIC_LIBS
+
+config BR2_PACKAGE_FLUIDSYNTH_LIBSNDFILE
+       bool "libsndfile"
+       select BR2_PACKAGE_LIBSNDFILE
+       help
+         Enable libsndfile support, for writing output to WAV files.
+
+config BR2_PACKAGE_FLUIDSYNTH_PORTAUDIO
+       bool "portaudio"
+       select BR2_PACKAGE_PORTAUDIO
+       help
+         Enable portaudio support.
+
+config BR2_PACKAGE_FLUIDSYNTH_PULSEAUDIO
+       bool "pulseaudio"
+       # See: https://sourceware.org/bugzilla/show_bug.cgi?id=19908
+       depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_MIPS
+       depends on !BR2_STATIC_LIBS
+       select BR2_PACKAGE_PULSEAUDIO
+       help
+         Enable PulseAudio support.
+
+comment "pulseaudio support needs a toolchain w/ dynamic library"
+       depends on BR2_STATIC_LIBS
+

package/fluidsynth/Config.in line 76

Quoted 10 lines
package/fluidsynth/Config.in new file +10 -0
+comment "Misc options"
+
+config BR2_PACKAGE_FLUIDSYNTH_DBUS
+       bool "dbus"
+       select BR2_PACKAGE_DBUS
+       help
+         Enable dbus support.
+
+config BR2_PACKAGE_FLUIDSYNTH_FLOATS
+       bool "floats"

I would change the name here. "floats" is pretty vague. what about "32-bit single precision float" ?

Quoted 10 lines
package/fluidsynth/Config.in new file +9 -0
+       help
+         Enable 32-bit single precision float support, instead of
+         64-bit double precision floats for DSP samples.
+
+config BR2_PACKAGE_FLUIDSYNTH_READLINE
+       bool "readline"
+       select BR2_PACKAGE_READLINE
+       help
+         Enable readline support, for better line editing in 

FluidSynth

package/fluidsynth/Config.in line 92

Quoted 7 lines
package/fluidsynth/Config.in new file +7 -0
+         shell.
+
+config BR2_PACKAGE_FLUIDSYNTH_THREADS
+       bool "threads"
+       default y
+       help
+         Enable multi-thread support.

The package needs a toolchain with threads support.
Do we need this option? I would just enable it all the time in the recipe.

Quoted 14 lines
package/fluidsynth/Config.in new file +5 -0
+
+endif # BR2_PACKAGE_FLUIDSYNTH
+
+comment "fluidsynth needs a toolchain w/ threads, wchar"
+       depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
package/fluidsynth/fluidsynth.hash new file +2 -0
new file mode 100644
index 0000000000..d28073bb3d
@@ -0,0 +1,2 @@
+# Locally computed
+sha256 
Quoted 2 lines

526addc6d8445035840d3af7282d3ba89567df209d28e183da04a1a877da2da3 fluidsynth-v2.1.0.tar.gz

The hash for the license file is missing.

Quoted 7 lines
package/fluidsynth/fluidsynth.mk new file +0 -0
new file mode 100644
index 0000000000..ef1ac8ed85

package/fluidsynth/fluidsynth.mk line 7

Quoted 7 lines
package/fluidsynth/fluidsynth.mk new file +7 -0
@@ -0,0 +1,74 @@
+################################################################################
+#
+# fluidsynth
+#
+################################################################################
+
+FLUIDSYNTH_VERSION = v2.1.0

I would move the "v" to FLUIDSYNTH_SITE for better version tracking with release-monitoring.org
https://release-monitoring.org/project/10437/

Quoted 2 lines
package/fluidsynth/fluidsynth.mk new file +1 -0
+FLUIDSYNTH_SITE = $(call 

github,FluidSynth,fluidsynth,$(FLUIDSYNTH_VERSION))

As mentioned just above, please add "v" in front of $(FLUIDSYNTH_VERSION)

Quoted 1 line

+FLUIDSYNTH_LICENSE = LGPLv2+

It is LGPL-2.1+

Quoted 53 lines
package/fluidsynth/fluidsynth.mk new file +53 -0
+FLUIDSYNTH_LICENSE_FILES = LICENSE
+FLUIDSYNTH_DEPENDENCIES = libglib2
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_ALSA_LIB),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-alsa=1
+FLUIDSYNTH_DEPENDENCIES += alsa-lib
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-alsa=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_DBUS),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-dbus=1
+FLUIDSYNTH_DEPENDENCIES += dbus
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-dbus=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_FLOATS),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-floats=1
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-floats=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_JACK2),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-jack=1
+FLUIDSYNTH_DEPENDENCIES += jack2
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-jack=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_LIBSNDFILE),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-libsndfile=1
+FLUIDSYNTH_DEPENDENCIES += libsndfile
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-libsndfile=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_PORTAUDIO),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-portaudio=1
+FLUIDSYNTH_DEPENDENCIES += portaudio
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-portaudio=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_PULSEAUDIO),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-pulseaudio=1
+FLUIDSYNTH_DEPENDENCIES += pulseaudio
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-pulseaudio=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_READLINE),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-readline=1

package/fluidsynth/fluidsynth.mk line 72

Quoted 10 lines
package/fluidsynth/fluidsynth.mk new file +10 -0
+FLUIDSYNTH_DEPENDENCIES += readline
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-readline=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_THREADS),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-threads=1
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-threads=0
+endif

As mentioned above, I would enable this option aways.

Quoted 9 lines

+
+$(eval $(cmake-package))
--
2.23.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#3 lore raw

PATCH v2 1/1 package/fluidsynth: new package

In reply to Julien Olivain

FluidSynth is a real-time software synthesizer based on the SoundFont 2 specifications and has reached widespread distribution. FluidSynth itself does not have a graphical user interface, but due to its powerful API several applications utilize it and it has even found its way onto embedded systems and is used in some mobile apps.

http://www.fluidsynth.org/

---
Changes v1 -> v2:
Included all Gilles' comments:
- Add comments for dependencies
- Clarified "float" option
- Removed useless "thread" option
- Add LICENSE file hash
- Removed "v" in VERSION
- Fixed LICENSE to LGPL-2.1+

---
 DEVELOPERS                         |  1 +
 package/Config.in                  |  1 +
 package/fluidsynth/Config.in       | 91 ++++++++++++++++++++++++++++++
 package/fluidsynth/fluidsynth.hash |  3 +
 package/fluidsynth/fluidsynth.mk   | 68 ++++++++++++++++++++++
 5 files changed, 164 insertions(+)
 create mode 100644 package/fluidsynth/Config.in
 create mode 100644 package/fluidsynth/fluidsynth.hash
 create mode 100644 package/fluidsynth/fluidsynth.mk
DEVELOPERS +1 -0
index 61bcd99d43..d0cfec3bac 100644
@@ -1352,6 +1352,7 @@ F:	board/technexion/imx8mmpico/
 F:	board/technexion/imx8mpico/
 F:	configs/imx8mmpico_defconfig
 F:	configs/imx8mpico_defconfig
+F:	package/fluidsynth/
 
 N:	Julien Viard de Galbert <[email protected]>
 F:	package/dieharder/
package/Config.in +1 -0
index 307583d01f..962d2f2612 100644
@@ -23,6 +23,7 @@ menu "Audio and video applications"
 	source "package/ffmpeg/Config.in"
 	source "package/flac/Config.in"
 	source "package/flite/Config.in"
+	source "package/fluidsynth/Config.in"
 	source "package/gmrender-resurrect/Config.in"
 	source "package/gstreamer/Config.in"
 	source "package/gstreamer1/Config.in"
package/fluidsynth/Config.in new file +91 -0

91 lines not on this page · raw message

package/fluidsynth/fluidsynth.hash new file +3 -0
new file mode 100644
index 0000000000..5c5c226cbc
@@ -0,0 +1,3 @@
+# Locally computed
+sha256 526addc6d8445035840d3af7282d3ba89567df209d28e183da04a1a877da2da3  fluidsynth-2.1.0.tar.gz
+sha256 9b872a8a070b8ad329c4bd380fb1bf0000f564c75023ec8e1e6803f15364b9e9  LICENSE
package/fluidsynth/fluidsynth.mk new file +68 -0

68 lines not on this page · raw message

Signature · 1 line
2.23.0
#4 lore raw

PATCH v2 1/1 package/fluidsynth: new package

Hello Julien, all,

New version looks good to me.

Le lun. 9 d?c. 2019 ? 21:03, Julien Olivain <[email protected]> a ?crit :

Quoted 239 lines

FluidSynth is a real-time software synthesizer based on the SoundFont 2 specifications and has reached widespread distribution. FluidSynth itself does not have a graphical user interface, but due to its powerful API several applications utilize it and it has even found its way onto embedded systems and is used in some mobile apps.

http://www.fluidsynth.org/

---
Changes v1 -> v2:
Included all Gilles' comments:
- Add comments for dependencies
- Clarified "float" option
- Removed useless "thread" option
- Add LICENSE file hash
- Removed "v" in VERSION
- Fixed LICENSE to LGPL-2.1+

---
 DEVELOPERS                         |  1 +
 package/Config.in                  |  1 +
 package/fluidsynth/Config.in       | 91 ++++++++++++++++++++++++++++++
 package/fluidsynth/fluidsynth.hash |  3 +
 package/fluidsynth/fluidsynth.mk   | 68 ++++++++++++++++++++++
 5 files changed, 164 insertions(+)
 create mode 100644 package/fluidsynth/Config.in
 create mode 100644 package/fluidsynth/fluidsynth.hash
 create mode 100644 package/fluidsynth/fluidsynth.mk
DEVELOPERS +1 -0
index 61bcd99d43..d0cfec3bac 100644
@@ -1352,6 +1352,7 @@ F:        board/technexion/imx8mmpico/
 F:     board/technexion/imx8mpico/
 F:     configs/imx8mmpico_defconfig
 F:     configs/imx8mpico_defconfig
+F:     package/fluidsynth/
 
 N:     Julien Viard de Galbert <[email protected]>
 F:     package/dieharder/
package/Config.in +1 -0
index 307583d01f..962d2f2612 100644
@@ -23,6 +23,7 @@ menu "Audio and video applications"
        source "package/ffmpeg/Config.in"
        source "package/flac/Config.in"
        source "package/flite/Config.in"
+       source "package/fluidsynth/Config.in"
        source "package/gmrender-resurrect/Config.in"
        source "package/gstreamer/Config.in"
        source "package/gstreamer1/Config.in"
package/fluidsynth/Config.in new file +91 -0
new file mode 100644
index 0000000000..6e319a80bb
@@ -0,0 +1,91 @@
+config BR2_PACKAGE_FLUIDSYNTH
+       bool "fluidsynth"
+       depends on BR2_USE_WCHAR # libglib2
+       depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
+       depends on BR2_USE_MMU # libglib2
+       select BR2_PACKAGE_LIBGLIB2
+       help
+         FluidSynth is a real-time software synthesizer based on the
+         SoundFont 2 specifications and has reached widespread
+         distribution. FluidSynth itself does not have a graphical
+         user interface, but due to its powerful API several
+         applications utilize it and it has even found its way onto
+         embedded systems and is used in some mobile apps.
+
+         http://www.fluidsynth.org/
+
+if BR2_PACKAGE_FLUIDSYNTH
+
+comment "Output support"
+
+config BR2_PACKAGE_FLUIDSYNTH_ALSA_LIB
+       bool "alsa"
+       default y
+       select BR2_PACKAGE_ALSA_LIB
+       help
+         Enable alsa support.
+
+config BR2_PACKAGE_FLUIDSYNTH_JACK2
+       bool "jack2"
+       # See: https://sourceware.org/bugzilla/show_bug.cgi?id=19908
+       depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_MIPS
+       depends on !BR2_STATIC_LIBS # jack2
+       depends on BR2_INSTALL_LIBSTDCPP # jack2
+       depends on BR2_TOOLCHAIN_HAS_SYNC_4 # jack2
+       select BR2_PACKAGE_JACK2
+       help
+         Enable jack support.
+
+comment "jack support needs a toolchain w/ dynamic library"
+       depends on BR2_TOOLCHAIN_HAS_SYNC_4
+       depends on BR2_STATIC_LIBS
+
+config BR2_PACKAGE_FLUIDSYNTH_LIBSNDFILE
+       bool "libsndfile"
+       select BR2_PACKAGE_LIBSNDFILE
+       help
+         Enable libsndfile support, for writing output to WAV files.
+
+config BR2_PACKAGE_FLUIDSYNTH_PORTAUDIO
+       bool "portaudio"
+       select BR2_PACKAGE_PORTAUDIO
+       help
+         Enable portaudio support.
+
+config BR2_PACKAGE_FLUIDSYNTH_PULSEAUDIO
+       bool "pulseaudio"
+       # See: https://sourceware.org/bugzilla/show_bug.cgi?id=19908
+       depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_MIPS
+       depends on !BR2_STATIC_LIBS # pulseaudio
+       select BR2_PACKAGE_PULSEAUDIO
+       help
+         Enable PulseAudio support.
+
+comment "pulseaudio support needs a toolchain w/ dynamic library"
+       depends on BR2_STATIC_LIBS
+
+comment "Misc options"
+
+config BR2_PACKAGE_FLUIDSYNTH_DBUS
+       bool "dbus"
+       select BR2_PACKAGE_DBUS
+       help
+         Enable dbus support.
+
+config BR2_PACKAGE_FLUIDSYNTH_FLOATS
+       bool "32-bit single precision float"
+       help
+         Enable 32-bit single precision float support, instead of
+         64-bit double precision floats for DSP samples.
+
+config BR2_PACKAGE_FLUIDSYNTH_READLINE
+       bool "readline"
+       select BR2_PACKAGE_READLINE
+       help
+         Enable readline support, for better line editing in FluidSynth
+         shell.
+
+endif # BR2_PACKAGE_FLUIDSYNTH
+
+comment "fluidsynth needs a toolchain w/ threads, wchar"
+       depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
package/fluidsynth/fluidsynth.hash new file +3 -0
new file mode 100644
index 0000000000..5c5c226cbc
@@ -0,0 +1,3 @@
+# Locally computed
+sha256 526addc6d8445035840d3af7282d3ba89567df209d28e183da04a1a877da2da3  fluidsynth-2.1.0.tar.gz
+sha256 9b872a8a070b8ad329c4bd380fb1bf0000f564c75023ec8e1e6803f15364b9e9  LICENSE
package/fluidsynth/fluidsynth.mk new file +68 -1
new file mode 100644
index 0000000000..4ef0a6f40d
@@ -0,0 +1,68 @@
+################################################################################
+#
+# fluidsynth
+#
+################################################################################
+
+FLUIDSYNTH_VERSION = 2.1.0
+FLUIDSYNTH_SITE = $(call github,FluidSynth,fluidsynth,v$(FLUIDSYNTH_VERSION))
+FLUIDSYNTH_LICENSE = LGPL-2.1+
+FLUIDSYNTH_LICENSE_FILES = LICENSE
+FLUIDSYNTH_DEPENDENCIES = libglib2
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_ALSA_LIB),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-alsa=1
+FLUIDSYNTH_DEPENDENCIES += alsa-lib
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-alsa=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_DBUS),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-dbus=1
+FLUIDSYNTH_DEPENDENCIES += dbus
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-dbus=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_FLOATS),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-floats=1
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-floats=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_JACK2),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-jack=1
+FLUIDSYNTH_DEPENDENCIES += jack2
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-jack=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_LIBSNDFILE),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-libsndfile=1
+FLUIDSYNTH_DEPENDENCIES += libsndfile
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-libsndfile=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_PORTAUDIO),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-portaudio=1
+FLUIDSYNTH_DEPENDENCIES += portaudio
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-portaudio=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_PULSEAUDIO),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-pulseaudio=1
+FLUIDSYNTH_DEPENDENCIES += pulseaudio
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-pulseaudio=0
+endif
+
+ifeq ($(BR2_PACKAGE_FLUIDSYNTH_READLINE),y)
+FLUIDSYNTH_CONF_OPTS += -Denable-readline=1
+FLUIDSYNTH_DEPENDENCIES += readline
+else
+FLUIDSYNTH_CONF_OPTS += -Denable-readline=0
+endif
+
+$(eval $(cmake-package))
--

2.23.0

Quoted 4 lines

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#5 lore raw

PATCH v2 1/1 package/fluidsynth: new package

In reply to Julien Olivain
Quoted 10 lines · On Mon, 9 Dec 2019 21:03:24 +0100 Julien Olivain <[email protected]> wrote:

FluidSynth is a real-time software synthesizer based on the SoundFont 2 specifications and has reached widespread distribution. FluidSynth itself does not have a graphical user interface, but due to its powerful API several applications utilize it and it has even found its way onto embedded systems and is used in some mobile apps.

http://www.fluidsynth.org/

Quoted 9 lines

---
Changes v1 -> v2:
Included all Gilles' comments:
- Add comments for dependencies
- Clarified "float" option
- Removed useless "thread" option
- Add LICENSE file hash
- Removed "v" in VERSION
- Fixed LICENSE to LGPL-2.1+

I've done a number of improvements to the Config.in file in terms of dependencies, and applied to master. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com