Skip to contentSkip to conversation

package/samba4: fix build without python3

PATCH New Fabrice Fontaine 2 participants 2 messages Dec 15, 2019 – Dec 22, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/samba4: fix build without python3

python3 is mandatory since version 4.11 and
https://gitlab.com/samba-team/samba/commit/63d20d7822ead1626f7cb41fdbae6c9300893314

The only way to build samba4 without python3 is to disable python bindings through --disable-python option

Fixes:
- http://autobuild.buildroot.org/results/c4bb3d41fa07e38f0360a563bdcb4a368740cfe5

---
 package/samba4/samba4.mk | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
package/samba4/samba4.mk +3 -4
index 201328fe4b..05df0d4efc 100644
@@ -31,10 +31,9 @@ SAMBA4_PYTHON = \
 	PYTHON_CONFIG="$(STAGING_DIR)/usr/bin/python3-config"
 SAMBA4_DEPENDENCIES += host-python3 python3
 else
-SAMBA4_PYTHON = \
-	PYTHON="$(HOST_DIR)/bin/python2" \
-	PYTHON_CONFIG="$(STAGING_DIR)/usr/bin/python-config"
-SAMBA4_DEPENDENCIES += host-python python
+SAMBA4_PYTHON = PYTHON="$(HOST_DIR)/bin/python2" 
+SAMBA4_DEPENDENCIES += host-python
+SAMBA4_CONF_OPTS += --disable-python
 endif
 
 ifeq ($(BR2_PACKAGE_LIBTIRPC),y)
Signature · 1 line
2.24.0
#1 lore raw

PATCH 1/1 package/samba4: fix build without python3

Quoted 6 lines · On Sun, 15 Dec 2019 18:36:29 +0100 Fabrice Fontaine…

python3 is mandatory since version 4.11 and
https://gitlab.com/samba-team/samba/commit/63d20d7822ead1626f7cb41fdbae6c9300893314

The only way to build samba4 without python3 is to disable python bindings through --disable-python option

Quoted 7 lines

Fixes:
- http://autobuild.buildroot.org/results/c4bb3d41fa07e38f0360a563bdcb4a368740cfe5

---
 package/samba4/samba4.mk | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com