Skip to contentSkip to conversation

armv8: fsl-layerscape: Kconfig: Correct I2C dependecies

PATCH Superseded Biwen Li 2 participants 3 messages Dec 23, 2019 Arm (32-bit)

lore
Share & tools
lore

Biwen Li

author
#0 lore raw

PATCH v2 1/1 armv8: fsl-layerscape: Kconfig: Correct I2C dependecies

Don't select SYS_I2C_MXC_I2C* when DM_I2C is enabled. This is required to resolve below warnings while 'make *defconfig'

	ARCH_LS1046A [=y] && ARM [=y]
	WARNING: unmet direct dependencies detected for SYS_I2C_MXC_I2C3
	Depends on [n]: SYS_I2C_MXC [=y] && (!DM_I2C [=y] || SPL [=n])
	Selected by [y]:

---
Change in v2:
- update subject and descriptions

 arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
arch/arm/cpu/armv8/fsl-layerscape/Kconfig +10 -10
index f1578b10bc..84ece4d587 100644
@@ -16,8 +16,8 @@ config ARCH_LS1012A
 	select ARCH_EARLY_INIT_R
 	select BOARD_EARLY_INIT_F
 	select SYS_I2C_MXC
-	select SYS_I2C_MXC_I2C1
-	select SYS_I2C_MXC_I2C2
+	select SYS_I2C_MXC_I2C1 if !DM_I2C
+	select SYS_I2C_MXC_I2C2 if !DM_I2C
 	imply PANIC_HANG
 
 config ARCH_LS1028A
@@ -75,10 +75,10 @@ config ARCH_LS1043A
 	select ARCH_EARLY_INIT_R
 	select BOARD_EARLY_INIT_F
 	select SYS_I2C_MXC
-	select SYS_I2C_MXC_I2C1
-	select SYS_I2C_MXC_I2C2
-	select SYS_I2C_MXC_I2C3
-	select SYS_I2C_MXC_I2C4
+	select SYS_I2C_MXC_I2C1 if !DM_I2C
+	select SYS_I2C_MXC_I2C2 if !DM_I2C
+	select SYS_I2C_MXC_I2C3 if !DM_I2C
+	select SYS_I2C_MXC_I2C4 if !DM_I2C
 	imply CMD_PCI
 
 config ARCH_LS1046A
@@ -108,10 +108,10 @@ config ARCH_LS1046A
 	select ARCH_EARLY_INIT_R
 	select BOARD_EARLY_INIT_F
 	select SYS_I2C_MXC
-	select SYS_I2C_MXC_I2C1
-	select SYS_I2C_MXC_I2C2
-	select SYS_I2C_MXC_I2C3
-	select SYS_I2C_MXC_I2C4
+	select SYS_I2C_MXC_I2C1 if !DM_I2C
+	select SYS_I2C_MXC_I2C2 if !DM_I2C
+	select SYS_I2C_MXC_I2C3 if !DM_I2C
+	select SYS_I2C_MXC_I2C4 if !DM_I2C
 	imply SCSI
 	imply SCSI_AHCI
 
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/1 armv8: fsl-layerscape: Kconfig: Correct I2C dependecies

Hi Biwen,

Quoted 18 lines

-----Original Message-----
From: Biwen Li <[email protected]>
Sent: Monday, December 23, 2019 12:09 PM
To: Priyanka Jain <[email protected]>; Jagdish Gediya <[email protected]>
Cc: u-boot at lists.denx.de; Jiafei Pan <[email protected]>; Biwen Li <[email protected]>
Subject: [v2] armv8: fsl-layerscape: Kconfig: Correct I2C dependecies

Don't select SYS_I2C_MXC_I2C* when DM_I2C is enabled. This is required to resolve below warnings while 'make *defconfig'

	ARCH_LS1046A [=y] && ARM [=y]
	WARNING: unmet direct dependencies detected for
SYS_I2C_MXC_I2C3
	Depends on [n]: SYS_I2C_MXC [=y] && (!DM_I2C [=y] || SPL [=n])
	Selected by [y]:
Quoted 6 lines

---
Change in v2:
- update subject and descriptions

 arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 20 ++++++++++----------

These changes are not required in upstream as this issue caused by http://patchwork.ozlabs.org/patch/1213011/ and it is not accepted yet. Merge these changes with http://patchwork.ozlabs.org/patch/1213011/.

Quoted 8 lines
 1 file changed, 10 insertions(+), 10 deletions(-)
arch/arm/cpu/armv8/fsl-layerscape/Kconfig +0 -0
index f1578b10bc..84ece4d587 100644

arch/arm/cpu/armv8/fsl-layerscape/Kconfig config ARCH_LS1012A · line 21

Quoted 8 lines
arch/arm/cpu/armv8/fsl-layerscape/Kconfig +2 -2
@@ -16,8 +16,8 @@ config ARCH_LS1012A
 	select ARCH_EARLY_INIT_R
 	select BOARD_EARLY_INIT_F
 	select SYS_I2C_MXC
-	select SYS_I2C_MXC_I2C1
-	select SYS_I2C_MXC_I2C2
+	select SYS_I2C_MXC_I2C1 if !DM_I2C
+	select SYS_I2C_MXC_I2C2 if !DM_I2C
 	imply PANIC_HANG

Merge above changes in http://patchwork.ozlabs.org/patch/1213016/

Quoted 5 lines
arch/arm/cpu/armv8/fsl-layerscape/Kconfig +0 -0
 config ARCH_LS1028A
@@ -75,10 +75,10 @@ config ARCH_LS1043A
 	select ARCH_EARLY_INIT_R
 	select BOARD_EARLY_INIT_F

arch/arm/cpu/armv8/fsl-layerscape/Kconfig config ARCH_LS1043A · line 82

Quoted 10 lines
arch/arm/cpu/armv8/fsl-layerscape/Kconfig +4 -4
 	select SYS_I2C_MXC
-	select SYS_I2C_MXC_I2C1
-	select SYS_I2C_MXC_I2C2
-	select SYS_I2C_MXC_I2C3
-	select SYS_I2C_MXC_I2C4
+	select SYS_I2C_MXC_I2C1 if !DM_I2C
+	select SYS_I2C_MXC_I2C2 if !DM_I2C
+	select SYS_I2C_MXC_I2C3 if !DM_I2C
+	select SYS_I2C_MXC_I2C4 if !DM_I2C
 	imply CMD_PCI

Merge above changes in http://patchwork.ozlabs.org/patch/1213017/

Quoted 6 lines
arch/arm/cpu/armv8/fsl-layerscape/Kconfig +0 -0
 config ARCH_LS1046A
@@ -108,10 +108,10 @@ config ARCH_LS1046A
 	select ARCH_EARLY_INIT_R
 	select BOARD_EARLY_INIT_F
 	select SYS_I2C_MXC

arch/arm/cpu/armv8/fsl-layerscape/Kconfig config ARCH_LS1046A · line 116

Quoted 10 lines
arch/arm/cpu/armv8/fsl-layerscape/Kconfig +4 -4
-	select SYS_I2C_MXC_I2C1
-	select SYS_I2C_MXC_I2C2
-	select SYS_I2C_MXC_I2C3
-	select SYS_I2C_MXC_I2C4
+	select SYS_I2C_MXC_I2C1 if !DM_I2C
+	select SYS_I2C_MXC_I2C2 if !DM_I2C
+	select SYS_I2C_MXC_I2C3 if !DM_I2C
+	select SYS_I2C_MXC_I2C4 if !DM_I2C
 	imply SCSI
 	imply SCSI_AHCI

Merge above changes in http://patchwork.ozlabs.org/patch/1213018/

--Jagdish

author
#2 lore raw

PATCH v2 1/1 armv8: fsl-layerscape: Kconfig: Correct I2C dependecies

Quoted 41 lines

-----Original Message-----
From: Jagdish Gediya <[email protected]>
Sent: 2019年12月23日 18:22
To: Biwen Li <[email protected]>; Priyanka Jain <[email protected]>
Cc: u-boot at lists.denx.de; Jiafei Pan <[email protected]>; Biwen Li <[email protected]>
Subject: RE: [v2] armv8: fsl-layerscape: Kconfig: Correct I2C dependecies

Hi Biwen,

Quoted 18 lines

-----Original Message-----
From: Biwen Li <[email protected]>
Sent: Monday, December 23, 2019 12:09 PM
To: Priyanka Jain <[email protected]>; Jagdish Gediya <[email protected]>
Cc: u-boot at lists.denx.de; Jiafei Pan <[email protected]>; Biwen Li <[email protected]>
Subject: [v2] armv8: fsl-layerscape: Kconfig: Correct I2C dependecies

Don't select SYS_I2C_MXC_I2C* when DM_I2C is enabled. This is required to resolve below warnings while 'make *defconfig'

	ARCH_LS1046A [=y] && ARM [=y]
	WARNING: unmet direct dependencies detected for
SYS_I2C_MXC_I2C3
	Depends on [n]: SYS_I2C_MXC [=y] && (!DM_I2C [=y] || SPL [=n])
	Selected by [y]:
Quoted 6 lines

---
Change in v2:
- update subject and descriptions

 arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 20 ++++++++++----------

These changes are not required in upstream as this issue caused by
http://patchwork.ozlabs.org/patch/1213011/ and it is not accepted yet. Merge these changes with http://patchwork.ozlabs.org/patch/1213011/.

Quoted 2 lines
 1 file changed, 10 insertions(+), 10 deletions(-)
Quoted 15 lines
Quoted 6 lines
arch/arm/cpu/armv8/fsl-layerscape/Kconfig +0 -0
index f1578b10bc..84ece4d587 100644

arch/arm/cpu/armv8/fsl-layerscape/Kconfig config ARCH_LS1012A · line 21

Quoted 8 lines
arch/arm/cpu/armv8/fsl-layerscape/Kconfig +2 -2
@@ -16,8 +16,8 @@ config ARCH_LS1012A
 	select ARCH_EARLY_INIT_R
 	select BOARD_EARLY_INIT_F
 	select SYS_I2C_MXC
-	select SYS_I2C_MXC_I2C1
-	select SYS_I2C_MXC_I2C2
+	select SYS_I2C_MXC_I2C1 if !DM_I2C
+	select SYS_I2C_MXC_I2C2 if !DM_I2C
 	imply PANIC_HANG

Merge above changes in http://patchwork.ozlabs.org/patch/1213016/

Ok, I will merge it in v6

Quoted 16 lines
Quoted 5 lines
arch/arm/cpu/armv8/fsl-layerscape/Kconfig +0 -0
 config ARCH_LS1028A
@@ -75,10 +75,10 @@ config ARCH_LS1043A
 	select ARCH_EARLY_INIT_R
 	select BOARD_EARLY_INIT_F

arch/arm/cpu/armv8/fsl-layerscape/Kconfig config ARCH_LS1043A · line 82

Quoted 10 lines
arch/arm/cpu/armv8/fsl-layerscape/Kconfig +4 -4
 	select SYS_I2C_MXC
-	select SYS_I2C_MXC_I2C1
-	select SYS_I2C_MXC_I2C2
-	select SYS_I2C_MXC_I2C3
-	select SYS_I2C_MXC_I2C4
+	select SYS_I2C_MXC_I2C1 if !DM_I2C
+	select SYS_I2C_MXC_I2C2 if !DM_I2C
+	select SYS_I2C_MXC_I2C3 if !DM_I2C
+	select SYS_I2C_MXC_I2C4 if !DM_I2C
 	imply CMD_PCI

Merge above changes in http://patchwork.ozlabs.org/patch/1213017/

Ok, I will merge it in v6.

Quoted 17 lines
Quoted 6 lines
arch/arm/cpu/armv8/fsl-layerscape/Kconfig +0 -0
 config ARCH_LS1046A
@@ -108,10 +108,10 @@ config ARCH_LS1046A
 	select ARCH_EARLY_INIT_R
 	select BOARD_EARLY_INIT_F
 	select SYS_I2C_MXC

arch/arm/cpu/armv8/fsl-layerscape/Kconfig config ARCH_LS1046A · line 116

Quoted 10 lines
arch/arm/cpu/armv8/fsl-layerscape/Kconfig +4 -4
-	select SYS_I2C_MXC_I2C1
-	select SYS_I2C_MXC_I2C2
-	select SYS_I2C_MXC_I2C3
-	select SYS_I2C_MXC_I2C4
+	select SYS_I2C_MXC_I2C1 if !DM_I2C
+	select SYS_I2C_MXC_I2C2 if !DM_I2C
+	select SYS_I2C_MXC_I2C3 if !DM_I2C
+	select SYS_I2C_MXC_I2C4 if !DM_I2C
 	imply SCSI
 	imply SCSI_AHCI

Merge above changes in http://patchwork.ozlabs.org/patch/1213018/

Ok, I will merge it in v6

Quoted 2 lines

--Jagdish