Skip to contentSkip to conversation

usb: gadget: legacy: set max_speed to super-speed

PATCH In review Roger Quadros 2 participants 2 messages Dec 23, 2019 – Jan 2, 2020 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: gadget: legacy: set max_speed to super-speed

These interfaces do support super-speed so let's not limit maximum speed to high-speed.

---

Hi Felipe,

Please queue this for -rc. Thanks.

cheers,
-roger

 drivers/usb/gadget/legacy/cdc2.c  | 2 +-
 drivers/usb/gadget/legacy/g_ffs.c | 2 +-
 drivers/usb/gadget/legacy/multi.c | 2 +-
 drivers/usb/gadget/legacy/ncm.c   | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
drivers/usb/gadget/legacy/cdc2.c +1 -1
index da1c37933ca1..8d7a556ece30 100644
@@ -225,7 +225,7 @@ static struct usb_composite_driver cdc_driver = {
 	.name		= "g_cdc",
 	.dev		= &device_desc,
 	.strings	= dev_strings,
-	.max_speed	= USB_SPEED_HIGH,
+	.max_speed	= USB_SPEED_SUPER,
 	.bind		= cdc_bind,
 	.unbind		= cdc_unbind,
 };
drivers/usb/gadget/legacy/g_ffs.c +1 -1
index b640ed3fcf70..ae6d8f7092b8 100644
@@ -149,7 +149,7 @@ static struct usb_composite_driver gfs_driver = {
 	.name		= DRIVER_NAME,
 	.dev		= &gfs_dev_desc,
 	.strings	= gfs_dev_strings,
-	.max_speed	= USB_SPEED_HIGH,
+	.max_speed	= USB_SPEED_SUPER,
 	.bind		= gfs_bind,
 	.unbind		= gfs_unbind,
 };
drivers/usb/gadget/legacy/multi.c +1 -1
index 50515f9e1022..ec9749845660 100644
@@ -482,7 +482,7 @@ static struct usb_composite_driver multi_driver = {
 	.name		= "g_multi",
 	.dev		= &device_desc,
 	.strings	= dev_strings,
-	.max_speed	= USB_SPEED_HIGH,
+	.max_speed	= USB_SPEED_SUPER,
 	.bind		= multi_bind,
 	.unbind		= multi_unbind,
 	.needs_serial	= 1,
drivers/usb/gadget/legacy/ncm.c +1 -1
index 8465f081e921..c61e71ba7045 100644
@@ -197,7 +197,7 @@ static struct usb_composite_driver ncm_driver = {
 	.name		= "g_ncm",
 	.dev		= &device_desc,
 	.strings	= dev_strings,
-	.max_speed	= USB_SPEED_HIGH,
+	.max_speed	= USB_SPEED_SUPER,
 	.bind		= gncm_bind,
 	.unbind		= gncm_unbind,
 };
Signature · 2 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
#1 lore raw

Hi,

Quoted 9 lines · Roger Quadros

These interfaces do support super-speed so let's not limit maximum speed to high-speed.

---

Hi Felipe,

Please queue this for -rc. Thanks.

This is probably one of those "has never worked before" changes. Doesn't seem really important for the -rc. I'll add a Cc stable instead

Signature · 1 line
balbi