Skip to contentSkip to conversation

of: mdio: Add missing inline to of_mdiobus_child_is_phy() dummy

PATCH Applied Geert Uytterhoeven 4 participants 4 messages Dec 23, 2019 – Dec 26, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 of: mdio: Add missing inline to of_mdiobus_child_is_phy() dummy

If CONFIG_OF_MDIO=n:

drivers/net/phy/mdio_bus.c:23:
include/linux/of_mdio.h:58:13: warning: ‘of_mdiobus_child_is_phy’ defined but not used [-Wunused-function]
static bool of_mdiobus_child_is_phy(struct device_node *child)
^~~~~~~~~~~~~~~~~~~~~~~

Fix this by adding the missing "inline" keyword.

Fixes 0aa4d016c043d16a ("of: mdio: export of_mdiobus_child_is_phy")
---
 include/linux/of_mdio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/of_mdio.h +1 -1
index 79bc82e30c02333d..491a2b7e77c1e906 100644
@@ -55,7 +55,7 @@ static inline int of_mdio_parse_addr(struct device *dev,
 }
 
 #else /* CONFIG_OF_MDIO */
-static bool of_mdiobus_child_is_phy(struct device_node *child)
+static inline bool of_mdiobus_child_is_phy(struct device_node *child)
 {
 	return false;
 }
Signature · 1 line
2.17.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Geert Uytterhoeven

If CONFIG_OF_MDIO=n:

drivers/net/phy/mdio_bus.c:23:
include/linux/of_mdio.h:58:13: warning: ‘of_mdiobus_child_is_phy’ defined but not used [-Wunused-function]
static bool of_mdiobus_child_is_phy(struct device_node *child)
^~~~~~~~~~~~~~~~~~~~~~~

Fix this by adding the missing "inline" keyword.

Fixes 0aa4d016c043d16a ("of: mdio: export of_mdiobus_child_is_phy")

Andrew

Acked-by on v1 1/1
#2 lore raw
In reply to Geert Uytterhoeven
Quoted 21 lines · Geert Uytterhoeven

If CONFIG_OF_MDIO=n:

drivers/net/phy/mdio_bus.c:23:
include/linux/of_mdio.h:58:13: warning: ‘of_mdiobus_child_is_phy’ defined but not used [-Wunused-function]
static bool of_mdiobus_child_is_phy(struct device_node *child)
^~~~~~~~~~~~~~~~~~~~~~~

Fix this by adding the missing "inline" keyword.

Fixes 0aa4d016c043d16a ("of: mdio: export of_mdiobus_child_is_phy")
---
 include/linux/of_mdio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/of_mdio.h +0 -0
index 79bc82e30c02333d..491a2b7e77c1e906 100644

include/linux/of_mdio.h static inline int of_mdio_parse_addr(struct device *dev, · line 61

Quoted 8 lines
include/linux/of_mdio.h +1 -1
@@ -55,7 +55,7 @@ static inline int of_mdio_parse_addr(struct device *dev,
 }
 
 #else /* CONFIG_OF_MDIO */
-static bool of_mdiobus_child_is_phy(struct device_node *child)
+static inline bool of_mdiobus_child_is_phy(struct device_node *child)
 {
 	return false;
 }

I'm seeing it too with rc3.

Thx.

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
maintainer Applied
#3 lore raw
In reply to Geert Uytterhoeven

From: Geert Uytterhoeven <[email protected]>
Date: Mon, 23 Dec 2019 11:03:21 +0100

Quoted 11 lines

If CONFIG_OF_MDIO=n:

drivers/net/phy/mdio_bus.c:23:
include/linux/of_mdio.h:58:13: warning: ‘of_mdiobus_child_is_phy’ defined but not used [-Wunused-function]
static bool of_mdiobus_child_is_phy(struct device_node *child)
^~~~~~~~~~~~~~~~~~~~~~~

Fix this by adding the missing "inline" keyword.

Fixes 0aa4d016c043d16a ("of: mdio: export of_mdiobus_child_is_phy")

Applied, thank you.