Skip to contentSkip to conversation

powerpc/shared: include correct header for static key

PATCH Applied Jason A. Donenfeld 2 participants 2 messages Dec 23, 2019 – Jan 6, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/shared: include correct header for static key

Recently, the spinlock implementation grew a static key optimization, but the jump_label.h header include was left out, leading to build errors:

linux/arch/powerpc/include/asm/spinlock.h:44:7: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration]
44 | if (!static_branch_unlikely(&shared_processor))

This commit adds the missing header.

Fixes 656c21d6af5d ("powerpc/shared: Use static key to detect shared processor")
Cc Srikar Dronamraju <[email protected]>
---
 arch/powerpc/include/asm/spinlock.h | 1 +
 1 file changed, 1 insertion(+)
arch/powerpc/include/asm/spinlock.h +1 -0
index 1b55fc08f853..860228e917dc 100644
@@ -15,6 +15,7 @@
  *
  * (the type definitions are in asm/spinlock_types.h)
  */
+#include <linux/jump_label.h>
 #include <linux/irqflags.h>
 #ifdef CONFIG_PPC64
 #include <asm/paca.h>
Signature · 1 line
2.24.1
#1 lore raw
Quoted 4 lines · Jason A. Donenfeld

Recently, the spinlock implementation grew a static key optimization, but the jump_label.h header include was left out, leading to build errors:

Quoted 8 lines

linux/arch/powerpc/include/asm/spinlock.h:44:7: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration]
44 | if (!static_branch_unlikely(&shared_processor))

This commit adds the missing header.

Fixes 656c21d6af5d ("powerpc/shared: Use static key to detect shared processor")
Cc Srikar Dronamraju <[email protected]>

Applied to powerpc fixes, thanks.

https://git.kernel.org/powerpc/c/6da3eced8c5f3b03340b0c395bacd552c4d52411

cheers