Skip to contentSkip to conversation

iio: chemical: pms7003: fix unmet triggered buffer dependency

PATCH Applied Tomasz Duszynski 2 participants 2 messages Dec 13, 2019 – Dec 23, 2019 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: chemical: pms7003: fix unmet triggered buffer dependency

IIO triggered buffer depends on IIO buffer which is missing from Kconfig file. This should go unnoticed most of the time because there's a chance something else has already enabled buffers. In some rare cases though one might experience kbuild warnings about unmet direct dependencies and build failures due to missing symbols.

Fix this by selecting IIO_BUFFER explicitly.

---
 drivers/iio/chemical/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/chemical/Kconfig +1 -0
index fa4586037bb8..0b91de4df8f4 100644
@@ -65,6 +65,7 @@ config IAQCORE
 config PMS7003
 	tristate "Plantower PMS7003 particulate matter sensor"
 	depends on SERIAL_DEV_BUS
+	select IIO_BUFFER
 	select IIO_TRIGGERED_BUFFER
 	help
 	  Say Y here to build support for the Plantower PMS7003 particulate
Signature · 1 line
2.24.1
#1 lore raw
Quoted 9 lines · On Fri, 13 Dec 2019 22:38:08 +0100 Tomasz Duszynski <[email protected]> wrote:

IIO triggered buffer depends on IIO buffer which is missing from Kconfig file. This should go unnoticed most of the time because there's a chance something else has already enabled buffers. In some rare cases though one might experience kbuild warnings about unmet direct dependencies and build failures due to missing symbols.

Fix this by selecting IIO_BUFFER explicitly.

Applied to the fixes-togreg branch of iio.git. Marked for stable and with the addition of a fixes tag.

Thanks,

Jonathan

Quoted 16 lines
---
 drivers/iio/chemical/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/chemical/Kconfig +1 -0
index fa4586037bb8..0b91de4df8f4 100644
@@ -65,6 +65,7 @@ config IAQCORE
 config PMS7003
 	tristate "Plantower PMS7003 particulate matter sensor"
 	depends on SERIAL_DEV_BUS
+	select IIO_BUFFER
 	select IIO_TRIGGERED_BUFFER
 	help
 	  Say Y here to build support for the Plantower PMS7003 particulate