Skip to contentSkip to conversation

board/imx6-sabresd: Fix the Qt5 display names

PATCH New Fabio Estevam 4 participants 7 messages Dec 23, 2019 – Dec 25, 2019 Arm i.MX and Layerscape

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/2 board/imx6-sabresd: Fix the Qt5 display names

The correct syntax that Qt5 understands for display names is "HDMI1" and "LVDS1", so fix it accordingly.

---
 board/freescale/imx6-sabresd/rootfs_overlay/root/sabresd.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
board/freescale/imx6-sabresd/rootfs_overlay/root/sabresd.json +2 -2
index d5d063af87..fe92ce5b29 100644
@@ -4,11 +4,11 @@
   "pbuffers": true,
   "outputs": [
     {
-      "name": "HDMI-1",
+      "name": "HDMI1",
       "mode": "off"
     },
     {
-      "name": "LVDS-1",
+      "name": "LVDS1",
       "mode": "1024x768"
     }
   ]
Signature · 1 line
2.17.1
author reviewer
#1 lore raw

PATCH 2/2 board/imx6-sabresd: Remove unneeded CONFIG_VIDEO_CODA fragment

Since kernel commit a5a56f07c272 ("ARM: imx_v6_v7_defconfig: Select the coda driver as module") the VPU coda driver is selected as module, so it can be safely removed from linux_qt5.fragment.

---
 board/freescale/imx6-sabresd/linux_qt5.fragment | 1 -
 1 file changed, 1 deletion(-)
board/freescale/imx6-sabresd/linux_qt5.fragment +0 -1
index d4f26b163c..ffa5f63eab 100644
@@ -2,4 +2,3 @@
 # ondemand governor with a mainline kernel.
 # CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND is not set
 CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=y
-CONFIG_VIDEO_CODA=m
Signature · 1 line
2.17.1
#2 lore raw

PATCH 1/2 board/imx6-sabresd: Fix the Qt5 display names

In reply to Fabio Estevam
Quoted 7 lines · On Mon, 23 Dec 2019 09:22:52 -0300 Fabio Estevam <[email protected]> wrote:

The correct syntax that Qt5 understands for display names is "HDMI1" and "LVDS1", so fix it accordingly.

---
 board/freescale/imx6-sabresd/rootfs_overlay/root/sabresd.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Both applied. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/2 board/imx6-sabresd: Fix the Qt5 display names

In reply to Fabio Estevam

Hi Fabio and Jagan

Quoted 17 lines · Fabio Estevam

The correct syntax that Qt5 understands for display names is "HDMI1" and "LVDS1", so fix it accordingly.

---
 board/freescale/imx6-sabresd/rootfs_overlay/root/sabresd.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
board/freescale/imx6-sabresd/rootfs_overlay/root/sabresd.json +0 -0
index d5d063af87..fe92ce5b29 100644
@@ -4,11 +4,11 @@
   "pbuffers": true,
   "outputs": [
     {

board/freescale/imx6-sabresd/rootfs_overlay/root/sabresd.json line 14

Quoted 10 lines
board/freescale/imx6-sabresd/rootfs_overlay/root/sabresd.json +2 -2
-      "name": "HDMI-1",
+      "name": "HDMI1",
       "mode": "off"
     },
     {
-      "name": "LVDS-1",
+      "name": "LVDS1",
       "mode": "1024x768"
     }
   ]

Do the engicam board has the same problem? I can not test right now

Michael

Quoted 7 lines

--
2.17.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 4 lines
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |
author reviewer
#5 lore raw

PATCH 1/2 board/imx6-sabresd: Fix the Qt5 display names

Hi Michael,

Quoted 1 line · Michael Nazzareno Trimarchi

Do the engicam board has the same problem? I can not test right now

Yes, I can send a fix tomorrow for the engicam .json files.

#6 lore raw

PATCH 1/2 board/imx6-sabresd: Fix the Qt5 display names

Hi

Quoted 9 lines · Fabio Estevam

Hi Michael,

Quoted 1 line · Michael Nazzareno Trimarchi

Do the engicam board has the same problem? I can not test right now

Yes, I can send a fix tomorrow for the engicam .json files.

Good, I can't just test right now. I have already here but I think that we need to test it

Michael

Signature · 4 lines
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |