Skip to contentSkip to conversation

hw/rtc/mc146818: Add missing dependency on ISA Bus

PATCH Applied Philippe Mathieu-Daudé 3 participants 3 messages Dec 24, 2019 – Jan 7, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/rtc/mc146818: Add missing dependency on ISA Bus

The MC146818 sits on an ISA bus. Since it can not be used without it, select ISA in the Kconfig.

Fixes 82f5181777e
---
 hw/rtc/Kconfig | 1 +
 1 file changed, 1 insertion(+)
hw/rtc/Kconfig +1 -0
index 45daa8d655..3dc2dd6888 100644
@@ -17,6 +17,7 @@ config TWL92230
     depends on I2C
 
 config MC146818RTC
+    depends on ISA_BUS
     bool
 
 config SUN4V_RTC
Signature · 1 line
2.21.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Philippe Mathieu-Daudé

The MC146818 sits on an ISA bus. Since it can not be used without it, select ISA in the Kconfig.

Fixes 82f5181777e
---
 hw/rtc/Kconfig | 1 +
 1 file changed, 1 insertion(+)
Quoted 17 lines
hw/rtc/Kconfig +1 -0
index 45daa8d655..3dc2dd6888 100644
@@ -17,6 +17,7 @@ config TWL92230
     depends on I2C
 
 config MC146818RTC
+    depends on ISA_BUS
     bool
 
 config SUN4V_RTC
Signature · 1 line
2.21.0
#2 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 15 lines · Philippe Mathieu-Daudé

The MC146818 sits on an ISA bus. Since it can not be used without it, select ISA in the Kconfig.

Fixes 82f5181777e
---
 hw/rtc/Kconfig | 1 +
 1 file changed, 1 insertion(+)
hw/rtc/Kconfig +0 -0
index 45daa8d655..3dc2dd6888 100644

hw/rtc/Kconfig config TWL92230 · line 23

Quoted 7 lines
hw/rtc/Kconfig +1 -0
@@ -17,6 +17,7 @@ config TWL92230
     depends on I2C
 
 config MC146818RTC
+    depends on ISA_BUS
     bool
 
 config SUN4V_RTC

Queued, thanks.

Paolo