Skip to contentSkip to conversation

package/fontconfig: Fix UUIDD dependency

PATCH New Michael Trimarchi 2 participants 7 messages Dec 24, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/fontconfig: Fix UUIDD dependency

The build with BR2_PACKAGE_XORG7 and BR2_PACKAGE_OPENJDK was failing for missing include of uuid support. The BR2_PACKAGE_UTIL_LINUX_UUIDD select automatically BR2_PACKAGE_UTIL_LINUX_LIBUUID but the first one is needed

---
 package/fontconfig/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/fontconfig/Config.in +1 -1
index d274b06350..e92e184119 100644
@@ -3,7 +3,7 @@ config BR2_PACKAGE_FONTCONFIG
 	select BR2_PACKAGE_FREETYPE
 	select BR2_PACKAGE_EXPAT
 	select BR2_PACKAGE_UTIL_LINUX
-	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
+	select BR2_PACKAGE_UTIL_LINUX_UUIDD
 	help
 	  Fontconfig is a library for configuring and customizing font
 	  access.
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 package/fontconfig: Fix UUIDD dependency

Hello Michael,

Quoted 6 lines · On Tue, 24 Dec 2019 12:23:30 +0100 Michael Trimarchi…

The build with BR2_PACKAGE_XORG7 and BR2_PACKAGE_OPENJDK was failing for missing include of uuid support. The BR2_PACKAGE_UTIL_LINUX_UUIDD select automatically BR2_PACKAGE_UTIL_LINUX_LIBUUID but the first one is needed

Thanks for your patch! Could you give some more details about the configuration that is failing and the exact error you are getting ?

Indeed, fontconfig does not fail to build in the autobuilders, so I'd like to understand what is the exact issue, and make sure we are doing the right fix.

Thanks a lot!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/fontconfig: Fix UUIDD dependency

Hi Thomas

Quoted 11 lines · Thomas Petazzoni

Hello Michael,

Quoted 5 lines · On Tue, 24 Dec 2019 12:23:30 +0100 Michael Trimarchi…

The build with BR2_PACKAGE_XORG7 and BR2_PACKAGE_OPENJDK was failing for missing include of uuid support. The BR2_PACKAGE_UTIL_LINUX_UUIDD select automatically BR2_PACKAGE_UTIL_LINUX_LIBUUID but the first one is needed

Quoted 8 lines
Quoted 1 line

Thanks for your patch! Could you give some more details about the configuration that is failing and the exact error you are getting ?

Indeed, fontconfig does not fail to build in the autobuilders, so I'd like to understand what is the exact issue, and make sure we are doing the right fix.

Give time to build from clean again. I will send you the log

Michael

Quoted 8 lines

Thanks a lot!

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Signature · 4 lines
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |
#3 lore raw

PATCH 1/1 package/fontconfig: Fix UUIDD dependency

Quoted 5 lines · On Tue, 24 Dec 2019 13:56:37 +0100 Michael Nazzareno Trimarchi…
Quoted 3 lines

Indeed, fontconfig does not fail to build in the autobuilders, so I'd like to understand what is the exact issue, and make sure we are doing the right fix.

Give time to build from clean again. I will send you the log

Could you also share the .config, or even better, a minimal configuration that exhibits the issue ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/1 package/fontconfig: Fix UUIDD dependency

Hi

Quoted 4 lines · Thomas Petazzoni

On Tue, 24 Dec 2019 13:56:37 +0100
Michael Nazzareno Trimarchi <[email protected]> wrote:

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

Indeed, fontconfig does not fail to build in the autobuilders, so I'd like to understand what is the exact issue, and make sure we are doing the right fix.

Give time to build from clean again. I will send you the log

Could you also share the .config, or even better, a minimal configuration that exhibits the issue ?

I created the config in two steps. Now I'm thinking that was only happen after I have added the XORG
and OPENJDK. I have added this two components without re-build from scratch. Basically libconfig was looking for uuid and fail to find in the filesystem. I was thinking looking at the config.in that the right thing to do is adding
that one instead of LIBUIID. I'm checking now

Michael

Quoted 8 lines

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Signature · 4 lines
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |
#5 lore raw

PATCH 1/1 package/fontconfig: Fix UUIDD dependency

Quoted 7 lines · On Tue, 24 Dec 2019 14:39:12 +0100 Michael Nazzareno Trimarchi…

I created the config in two steps. Now I'm thinking that was only happen after I have added the XORG
and OPENJDK. I have added this two components without re-build from scratch. Basically libconfig was looking for uuid and fail to find in the filesystem. I was thinking looking at the config.in that the right thing to do is adding
that one instead of LIBUIID. I'm checking now

This feels like you did some partial build: util-linux was first build with libuuid, and then you enabled something that needed libuuid, without doing a full rebuild, or at least without forcing the rebuild of util-linux.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#6 lore raw

PATCH 1/1 package/fontconfig: Fix UUIDD dependency

Hi Thomas

Quoted 12 lines · Thomas Petazzoni
Quoted 7 lines · On Tue, 24 Dec 2019 14:39:12 +0100 Michael Nazzareno Trimarchi…

I created the config in two steps. Now I'm thinking that was only happen after I have added the XORG
and OPENJDK. I have added this two components without re-build from scratch. Basically libconfig was looking for uuid and fail to find in the filesystem. I was thinking looking at the config.in that the right thing to do is adding
that one instead of LIBUIID. I'm checking now

Quoted 4 lines

This feels like you did some partial build: util-linux was first build with libuuid, and then you enabled something that needed libuuid, without doing a full rebuild, or at least without forcing the rebuild of util-linux.

Well. I have done in this way, but you are right. It works fine.

Michael

Quoted 6 lines

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Signature · 4 lines
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |