add thermal sensor driver for A64, A83T, H3, H5, H6, R40
Vasily Khoruzhick
maintainerv8 cover add thermal sensor driver for A64, A83T, H3, H5, H6, R40
This patchset adds driver for thermal sensor in A64, A83T, H3, H5, H6 and R40 SoCs.
v8:
- [vasily] Address more Maxime's comments for dt-schema
- [vasily] Add myself to MAINTAINERS for the driver and schema
- [vasily] Round calibration data size to word boundary for H6 and A64
- [vasily] Change offset for A64 since it reports too low temp otherwise. Likely conversion formula in user manual is not correct.
v7:
- [vasily] Address Maxime's comments for dt-schema
- [vasily] Move common part of H3 and H5 dts into sunxi-h3-h5.dtsi
- [vasily] Add Maxime's a-b to the driver patch
v6:
- [ondrej, vasily] Squash all driver related changes into a single patch
- [ondrej] Rename calib -> calibration
- [ondrej] Fix thermal zone registration check
- [ondrej] Lower rate of sensor data interrupts to 4/sec/sensor
- [ondrej] Rework scale/offset values, H6 calibration
- [ondrej] Explicitly set mod clock to 24 MHz
- [ondrej] Set undocumented bits in CTRL0 for H6
- [ondrej] Add support for A83T
- [ondrej] Add dts changes for A83T, H3, H5, H6
- [vasily] Add dts changes for A64
- [vasily] Address Maxime's comments for YAML scheme
- [vasily] Make .calc_temp callback mandatory
- [vasily] Set .max_register in regmap config, so regs can be inspected using debugfs
Ondrej Jirman (4):
ARM: dts: sun8i-a83t: Add thermal sensor and thermal zones
ARM: dts: sun8i-h3: Add thermal sensor and thermal zones
arm64: dts: allwinner: h5: Add thermal sensor and thermal zones
arm64: dts: allwinner: h6: Add thermal sensor and thermal zones
Vasily Khoruzhick (1):
arm64: dts: allwinner: a64: Add thermal sensors and thermal zones
Yangtao Li (2):
thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40
dt-bindings: thermal: add YAML schema for sun8i-thermal driver
bindings
.../thermal/allwinner,sun8i-a83t-ths.yaml | 160 +++++ MAINTAINERS | 8 + arch/arm/boot/dts/sun8i-a83t.dtsi | 36 + arch/arm/boot/dts/sun8i-h3.dtsi | 20 + arch/arm/boot/dts/sunxi-h3-h5.dtsi | 6 + arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 42 ++ arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 26 + arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 33 + drivers/thermal/Kconfig | 14 + drivers/thermal/Makefile | 1 + drivers/thermal/sun8i_thermal.c | 639 ++++++++++++++++++ 11 files changed, 985 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml create mode 100644 drivers/thermal/sun8i_thermal.c
Signature · 1 line
2.24.1
Vasily Khoruzhick
maintainerPATCH v8 1/7 thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40
From: Yangtao Li <[email protected]>
This patch adds the support for allwinner thermal sensor, within allwinner SoC. It will register sensors for thermal framework and use device tree to bind cooling device.
--- MAINTAINERS | 8 + drivers/thermal/Kconfig | 14 + drivers/thermal/Makefile | 1 + drivers/thermal/sun8i_thermal.c | 639 ++++++++++++++++++++++++++++++++ 4 files changed, 662 insertions(+) create mode 100644 drivers/thermal/sun8i_thermal.c
MAINTAINERS +8 -0
@@ -694,6 +694,14 @@ L: [email protected] S: Maintained F: drivers/crypto/allwinner/ +ALLWINNER THERMAL DRIVER +M: Vasily Khoruzhick <[email protected]> +M: Yangtao Li <[email protected]> +L: [email protected] +S: Maintained +F: Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml +F: drivers/thermal/sun8i_thermal.c + ALLWINNER VPU DRIVER M: Maxime Ripard <[email protected]> M: Paul Kocialkowski <[email protected]>
drivers/thermal/Kconfig +14 -0
@@ -263,6 +263,20 @@ config SPEAR_THERMAL Enable this to plug the SPEAr thermal sensor driver into the Linux thermal framework. +config SUN8I_THERMAL + tristate "Allwinner sun8i thermal driver" + depends on ARCH_SUNXI || COMPILE_TEST + depends on HAS_IOMEM + depends on NVMEM + depends on OF + depends on RESET_CONTROLLER + help + Support for the sun8i thermal sensor driver into the Linux thermal + framework. + + To compile this driver as a module, choose M here: the + module will be called sun8i-thermal. + config ROCKCHIP_THERMAL tristate "Rockchip thermal driver" depends on ARCH_ROCKCHIP || COMPILE_TEST
drivers/thermal/Makefile +1 -0
@@ -31,6 +31,7 @@ thermal_sys-$(CONFIG_DEVFREQ_THERMAL) += devfreq_cooling.o obj-y += broadcom/ obj-$(CONFIG_THERMAL_MMIO) += thermal_mmio.o obj-$(CONFIG_SPEAR_THERMAL) += spear_thermal.o +obj-$(CONFIG_SUN8I_THERMAL) += sun8i_thermal.o obj-$(CONFIG_ROCKCHIP_THERMAL) += rockchip_thermal.o obj-$(CONFIG_RCAR_THERMAL) += rcar_thermal.o obj-$(CONFIG_RCAR_GEN3_THERMAL) += rcar_gen3_thermal.o
drivers/thermal/sun8i_thermal.c new file +639 -0
639 lines not on this page · raw message
Signature · 7 lines
2.24.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Daniel Lezcano
AppliedRe: [PATCH v8 1/7] thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40
Quoted 11 lines · Vasily Khoruzhick
From: Yangtao Li <[email protected]>
This patch adds the support for allwinner thermal sensor, within allwinner SoC. It will register sensors for thermal framework and use device tree to bind cooling device.
Signed-off-by Yangtao Li <[email protected]>Signed-off-by Ondrej Jirman <[email protected]>Signed-off-by Vasily Khoruzhick <[email protected]>Acked-by Maxime Ripard <[email protected]>---
Applied, thanks.
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Vasily Khoruzhick
maintainerPATCH v8 2/7 dt-bindings: thermal: add YAML schema for sun8i-thermal driver bindings
In reply to Vasily KhoruzhickFrom: Yangtao Li <[email protected]>
sun8i-thermal driver supports thermal sensor in wide range of Allwinner SoCs. Add YAML schema for its bindings.
--- .../thermal/allwinner,sun8i-a83t-ths.yaml | 160 ++++++++++++++++++ 1 file changed, 160 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml new file +160 -0
@@ -0,0 +1,160 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/thermal/allwinner,sun8i-a83t-ths.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Allwinner SUN8I Thermal Controller Device Tree Bindings + +maintainers: + - Vasily Khoruzhick <[email protected]> + - Yangtao Li <[email protected]> + +properties: + compatible: + enum: + - allwinner,sun8i-a83t-ths + - allwinner,sun8i-h3-ths + - allwinner,sun8i-r40-ths + - allwinner,sun50i-a64-ths + - allwinner,sun50i-h5-ths + - allwinner,sun50i-h6-ths + + clocks: + minItems: 1 + maxItems: 2 + items: + - description: Bus Clock + - description: Module Clock + + clock-names: + minItems: 1 + maxItems: 2 + items: + - const: bus + - const: mod + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + resets: + maxItems: 1 + + nvmem-cells: + maxItems: 1 + description: Calibration data for thermal sensors + + nvmem-cell-names: + const: calibration + + # See ./thermal.txt for details + "#thermal-sensor-cells": + enum: + - 0 + - 1 + +allOf: + - if: + properties: + compatible: + contains: + const: allwinner,sun50i-h6-ths + + then: + properties: + clocks: + maxItems: 1 + + clock-names: + maxItems: 1 + + else: + properties: + clocks: + minItems: 2 + + clock-names: + minItems: 2 + + - if: + properties: + compatible: + contains: + const: allwinner,sun8i-h3-ths + + then: + properties: + "#thermal-sensor-cells": + const: 0 + + else: + properties: + "#thermal-sensor-cells": + const: 1 + + - if: + properties: + compatible: + contains: + enum: + - const: allwinner,sun8i-h3-ths + - const: allwinner,sun8i-r40-ths + - const: allwinner,sun50i-a64-ths + - const: allwinner,sun50i-h5-ths + - const: allwinner,sun50i-h6-ths + + then: + required: + - clocks + - clock-names + - resets + +required: + - compatible + - reg + - interrupts + - '#thermal-sensor-cells' + +additionalProperties: false + +examples: + - | + thermal-sensor@1f04000 { + compatible = "allwinner,sun8i-a83t-ths"; + reg = <0x01f04000 0x100>; + interrupts = <0 31 0>; + nvmem-cells = <&ths_calibration>; + nvmem-cell-names = "calibration"; + #thermal-sensor-cells = <1>; + }; + + - | + thermal-sensor@1c25000 { + compatible = "allwinner,sun8i-h3-ths"; + reg = <0x01c25000 0x400>; + clocks = <&ccu 0>, <&ccu 1>; + clock-names = "bus", "mod"; + resets = <&ccu 2>; + interrupts = <0 31 0>; + nvmem-cells = <&ths_calibration>; + nvmem-cell-names = "calibration"; + #thermal-sensor-cells = <0>; + }; + + - | + thermal-sensor@5070400 { + compatible = "allwinner,sun50i-h6-ths"; + reg = <0x05070400 0x100>; + clocks = <&ccu 0>; + clock-names = "bus"; + resets = <&ccu 2>; + interrupts = <0 15 0>; + nvmem-cells = <&ths_calibration>; + nvmem-cell-names = "calibration"; + #thermal-sensor-cells = <1>; + }; + +...
Signature · 1 line
2.24.1
Re: [PATCH v8 2/7] dt-bindings: thermal: add YAML schema for sun8i-thermal driver bindings
Quoted 7 lines · Vasily Khoruzhick
From: Yangtao Li <[email protected]>
sun8i-thermal driver supports thermal sensor in wide range of Allwinner SoCs. Add YAML schema for its bindings.
Signed-off-by Yangtao Li <[email protected]>Signed-off-by Vasily Khoruzhick <[email protected]>
Thanks!
Maxime
Vasily Khoruzhick
maintainerPATCH v8 3/7 ARM: dts: sun8i-a83t: Add thermal sensor and thermal zones
In reply to Vasily KhoruzhickFrom: Ondrej Jirman <[email protected]>
There are three sensors, two for each CPU cluster, one for GPU.
--- arch/arm/boot/dts/sun8i-a83t.dtsi | 36 +++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+)
arch/arm/boot/dts/sun8i-a83t.dtsi +36 -0
@@ -50,6 +50,7 @@ #include <dt-bindings/reset/sun8i-a83t-ccu.h> #include <dt-bindings/reset/sun8i-de2.h> #include <dt-bindings/reset/sun8i-r-ccu.h> +#include <dt-bindings/thermal/thermal.h> / { interrupt-parent = <&gic>;
@@ -581,6 +582,12 @@ mmc2: mmc@1c11000 { sid: eeprom@1c14000 { compatible = "allwinner,sun8i-a83t-sid"; reg = <0x1c14000 0x400>; + #address-cells = <1>; + #size-cells = <1>; + + ths_calibration: thermal-sensor-calibration@34 { + reg = <0x34 8>; + }; }; crypto: crypto@1c15000 {
@@ -1165,5 +1172,34 @@ r_rsb: rsb@1f03400 { #address-cells = <1>; #size-cells = <0>; }; + + ths: thermal-sensor@1f04000 { + compatible = "allwinner,sun8i-a83t-ths"; + reg = <0x01f04000 0x100>; + interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>; + nvmem-cells = <&ths_calibration>; + nvmem-cell-names = "calibration"; + #thermal-sensor-cells = <1>; + }; + }; + + thermal-zones { + cpu0_thermal: cpu0-thermal { + polling-delay-passive = <0>; + polling-delay = <0>; + thermal-sensors = <&ths 0>; + }; + + cpu1_thermal: cpu1-thermal { + polling-delay-passive = <0>; + polling-delay = <0>; + thermal-sensors = <&ths 1>; + }; + + gpu_thermal: gpu-thermal { + polling-delay-passive = <0>; + polling-delay = <0>; + thermal-sensors = <&ths 2>; + }; }; };
Signature · 1 line
2.24.1
Vasily Khoruzhick
maintainerPATCH v8 4/7 ARM: dts: sun8i-h3: Add thermal sensor and thermal zones
In reply to Vasily KhoruzhickFrom: Ondrej Jirman <[email protected]>
There is just one sensor for the CPU.
--- arch/arm/boot/dts/sun8i-h3.dtsi | 20 ++++++++++++++++++++ arch/arm/boot/dts/sunxi-h3-h5.dtsi | 6 ++++++ 2 files changed, 26 insertions(+)
arch/arm/boot/dts/sun8i-h3.dtsi +20 -0
@@ -199,6 +199,26 @@ mali: gpu@1c40000 { assigned-clocks = <&ccu CLK_GPU>; assigned-clock-rates = <384000000>; }; + + ths: thermal-sensor@1c25000 { + compatible = "allwinner,sun8i-h3-ths"; + reg = <0x01c25000 0x400>; + interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>; + resets = <&ccu RST_BUS_THS>; + clocks = <&ccu CLK_BUS_THS>, <&ccu CLK_THS>; + clock-names = "bus", "mod"; + nvmem-cells = <&ths_calibration>; + nvmem-cell-names = "calibration"; + #thermal-sensor-cells = <0>; + }; + }; + + thermal-zones { + cpu_thermal: cpu-thermal { + polling-delay-passive = <0>; + polling-delay = <0>; + thermal-sensors = <&ths 0>; + }; }; };
arch/arm/boot/dts/sunxi-h3-h5.dtsi +6 -0
@@ -231,6 +231,12 @@ mmc2: mmc@1c11000 { sid: eeprom@1c14000 { /* compatible is in per SoC .dtsi file */ reg = <0x1c14000 0x400>; + #address-cells = <1>; + #size-cells = <1>; + + ths_calibration: thermal-sensor-calibration@34 { + reg = <0x34 4>; + }; }; usb_otg: usb@1c19000 {
Signature · 1 line
2.24.1
Vasily Khoruzhick
maintainerPATCH v8 5/7 arm64: dts: allwinner: h5: Add thermal sensor and thermal zones
In reply to Vasily KhoruzhickFrom: Ondrej Jirman <[email protected]>
There are two sensors, one for CPU, one for GPU.
--- arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 26 ++++++++++++++++++++ 1 file changed, 26 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi +26 -0
@@ -176,6 +176,32 @@ mali: gpu@1e80000 { assigned-clocks = <&ccu CLK_GPU>; assigned-clock-rates = <384000000>; }; + + ths: thermal-sensor@1c25000 { + compatible = "allwinner,sun50i-h5-ths"; + reg = <0x01c25000 0x400>; + interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>; + resets = <&ccu RST_BUS_THS>; + clocks = <&ccu CLK_BUS_THS>, <&ccu CLK_THS>; + clock-names = "bus", "mod"; + nvmem-cells = <&ths_calibration>; + nvmem-cell-names = "calibration"; + #thermal-sensor-cells = <1>; + }; + }; + + thermal-zones { + cpu_thermal: cpu-thermal { + polling-delay-passive = <0>; + polling-delay = <0>; + thermal-sensors = <&ths 0>; + }; + + gpu_thermal { + polling-delay-passive = <0>; + polling-delay = <0>; + thermal-sensors = <&ths 1>; + }; }; };
Signature · 1 line
2.24.1
Vasily Khoruzhick
maintainerPATCH v8 6/7 arm64: dts: allwinner: h6: Add thermal sensor and thermal zones
In reply to Vasily KhoruzhickFrom: Ondrej Jirman <[email protected]>
There are two sensors, one for CPU, one for GPU.
--- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 33 ++++++++++++++++++++ 1 file changed, 33 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +33 -0
@@ -11,6 +11,7 @@ #include <dt-bindings/reset/sun50i-h6-ccu.h> #include <dt-bindings/reset/sun50i-h6-r-ccu.h> #include <dt-bindings/reset/sun8i-de2.h> +#include <dt-bindings/thermal/thermal.h> / { interrupt-parent = <&gic>;
@@ -233,6 +234,12 @@ dma: dma-controller@3002000 { sid: efuse@3006000 { compatible = "allwinner,sun50i-h6-sid"; reg = <0x03006000 0x400>; + #address-cells = <1>; + #size-cells = <1>; + + ths_calibration: thermal-sensor-calibration@14 { + reg = <0x14 0x8>; + }; }; watchdog: watchdog@30090a0 {
@@ -856,5 +863,31 @@ r_i2c: i2c@7081400 { #address-cells = <1>; #size-cells = <0>; }; + + ths: thermal-sensor@5070400 { + compatible = "allwinner,sun50i-h6-ths"; + reg = <0x05070400 0x100>; + interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ccu CLK_BUS_THS>; + clock-names = "bus"; + resets = <&ccu RST_BUS_THS>; + nvmem-cells = <&ths_calibration>; + nvmem-cell-names = "calibration"; + #thermal-sensor-cells = <1>; + }; + }; + + thermal-zones { + cpu-thermal { + polling-delay-passive = <0>; + polling-delay = <0>; + thermal-sensors = <&ths 0>; + }; + + gpu-thermal { + polling-delay-passive = <0>; + polling-delay = <0>; + thermal-sensors = <&ths 1>; + }; }; };
Signature · 1 line
2.24.1
Vasily Khoruzhick
maintainerPATCH v8 7/7 arm64: dts: allwinner: a64: Add thermal sensors and thermal zones
In reply to Vasily KhoruzhickA64 has 3 thermal sensors: 1 for CPU, 2 for GPU.
--- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +42 -0
@@ -49,6 +49,7 @@ #include <dt-bindings/reset/sun50i-a64-ccu.h> #include <dt-bindings/reset/sun8i-de2.h> #include <dt-bindings/reset/sun8i-r-ccu.h> +#include <dt-bindings/thermal/thermal.h> / { interrupt-parent = <&gic>;
@@ -211,6 +212,29 @@ timer { (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>; }; + thermal-zones { + cpu_thermal: cpu0-thermal { + /* milliseconds */ + polling-delay-passive = <0>; + polling-delay = <0>; + thermal-sensors = <&ths 0>; + }; + + gpu0_thermal: gpu0-thermal { + /* milliseconds */ + polling-delay-passive = <0>; + polling-delay = <0>; + thermal-sensors = <&ths 1>; + }; + + gpu1_thermal: gpu1-thermal { + /* milliseconds */ + polling-delay-passive = <0>; + polling-delay = <0>; + thermal-sensors = <&ths 2>; + }; + }; + soc { compatible = "simple-bus"; #address-cells = <1>;
@@ -485,6 +509,12 @@ mmc2: mmc@1c11000 { sid: eeprom@1c14000 { compatible = "allwinner,sun50i-a64-sid"; reg = <0x1c14000 0x400>; + #address-cells = <1>; + #size-cells = <1>; + + ths_calibration: thermal-sensor-calibration@34 { + reg = <0x34 0x8>; + }; }; crypto: crypto@1c15000 {
@@ -810,6 +840,18 @@ codec: codec@1c22e00 { status = "disabled"; }; + ths: thermal-sensor@1c25000 { + compatible = "allwinner,sun50i-a64-ths"; + reg = <0x01c25000 0x100>; + clocks = <&ccu CLK_BUS_THS>, <&ccu CLK_THS>; + clock-names = "bus", "mod"; + interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>; + resets = <&ccu RST_BUS_THS>; + nvmem-cells = <&ths_calibration>; + nvmem-cell-names = "calibration"; + #thermal-sensor-cells = <1>; + }; + uart0: serial@1c28000 { compatible = "snps,dw-apb-uart"; reg = <0x01c28000 0x400>;
Signature · 1 line
2.24.1
Hi,
Quoted 2 lines · Vasily Khoruzhick
This patchset adds driver for thermal sensor in A64, A83T, H3, H5, H6 and R40 SoCs.
Thanks again for working on this.
I'll merge the DT patches when the driver will have been merged.
Maxime
Quoted 9 lines · Maxime Ripard
Hi,
Quoted 2 lines · Vasily Khoruzhick
This patchset adds driver for thermal sensor in A64, A83T, H3, H5, H6 and R40 SoCs.
Thanks again for working on this.
I'll merge the DT patches when the driver will have been merged.
I've applied patches 1 & 2.
They are in the testing branch and will go to the linux-next branch as soon as the kernelci passes.
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Quoted 7 lines · Daniel Lezcano
Quoted 6 lines · Maxime Ripard
Hi,
Quoted 2 lines · Vasily Khoruzhick
This patchset adds driver for thermal sensor in A64, A83T, H3, H5, H6 and R40 SoCs.
Quoted 8 lines
Quoted 3 lines
Thanks again for working on this.
I'll merge the DT patches when the driver will have been merged.
I've applied patches 1 & 2.
They are in the testing branch and will go to the linux-next branch as soon as the kernelci passes.
I just merged all the other patches (except the patch 6, for the H6, as requested by Vasily on IRC).
Thanks to everyone involved!
Maxime
Quoted 12 lines · Maxime Ripard
Quoted 11 lines · Daniel Lezcano
Quoted 9 lines · Maxime Ripard
Hi,
Quoted 2 lines · Vasily Khoruzhick
This patchset adds driver for thermal sensor in A64, A83T, H3, H5, H6 and R40 SoCs.
Thanks again for working on this.
I'll merge the DT patches when the driver will have been merged.
Quoted 7 lines
Quoted 4 lines
I've applied patches 1 & 2.
They are in the testing branch and will go to the linux-next branch as soon as the kernelci passes.
I just merged all the other patches (except the patch 6, for the H6, as requested by Vasily on IRC).
Hello,
I think you can apply H6 patch. This was just some misunderstanding and H6 is working.
thnaks and regards,
o.
Quoted 9 lines
Thanks to everyone involved!
Maxime_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 18 lines · Ondřej Jirman
Quoted 17 lines · Maxime Ripard
Quoted 15 lines · Daniel Lezcano
Quoted 9 lines · Maxime Ripard
Hi,
Quoted 2 lines · Vasily Khoruzhick
This patchset adds driver for thermal sensor in A64, A83T, H3, H5, H6 and R40 SoCs.
Thanks again for working on this.
I'll merge the DT patches when the driver will have been merged.
I've applied patches 1 & 2.
They are in the testing branch and will go to the linux-next branch as soon as the kernelci passes.
Quoted 7 lines
Quoted 2 lines
I just merged all the other patches (except the patch 6, for the H6, as requested by Vasily on IRC).
Hello,
I think you can apply H6 patch. This was just some misunderstanding and H6 is working.
Done, thanks!
Maxime
Quoted 12 lines · Maxime Ripard
Quoted 11 lines · Daniel Lezcano
Quoted 9 lines · Maxime Ripard
Hi,
Quoted 2 lines · Vasily Khoruzhick
This patchset adds driver for thermal sensor in A64, A83T, H3, H5, H6 and R40 SoCs.
Thanks again for working on this.
I'll merge the DT patches when the driver will have been merged.
Quoted 8 lines
Quoted 4 lines
I've applied patches 1 & 2.
They are in the testing branch and will go to the linux-next branch as soon as the kernelci passes.
I just merged all the other patches (except the patch 6, for the H6, as requested by Vasily on IRC).
Hello
Vasily asked to not apply H6 due to my test failling on h6 and since he didnt own any H6 hw. But it was failling due my fault (a failling build).
So the patchset work perfect on H6 (opi1+, opi3, pineH64 both model A and B) as reported by my answer to this thread.
Regards
Frank Lee
maintainerQuoted 23 lines · Corentin Labbe
Quoted 12 lines · Maxime Ripard
Quoted 11 lines · Daniel Lezcano
Quoted 9 lines · Maxime Ripard
Hi,
Quoted 2 lines · Vasily Khoruzhick
This patchset adds driver for thermal sensor in A64, A83T, H3, H5, H6 and R40 SoCs.
Thanks again for working on this.
I'll merge the DT patches when the driver will have been merged.
Quoted 8 lines
Quoted 4 lines
I've applied patches 1 & 2.
They are in the testing branch and will go to the linux-next branch as soon as the kernelci passes.
I just merged all the other patches (except the patch 6, for the H6, as requested by Vasily on IRC).
Quoted 6 lines
Hello
Vasily asked to not apply H6 due to my test failling on h6 and since he didnt own any H6 hw. But it was failling due my fault (a failling build).
So the patchset work perfect on H6 (opi1+, opi3, pineH64 both model A and B) as reported by my answer to this thread.
HI Corentin,
Although it is not calibrated, it should work on the R40. Can you give my patch a try?
Thx,
Yangtao
Quoted 2 lines
Regards
Quoted 30 lines · Frank Lee
Quoted 28 lines · Corentin Labbe
Quoted 12 lines · Maxime Ripard
Quoted 11 lines · Daniel Lezcano
Quoted 9 lines · Maxime Ripard
Hi,
Quoted 2 lines · Vasily Khoruzhick
This patchset adds driver for thermal sensor in A64, A83T, H3, H5, H6 and R40 SoCs.
Thanks again for working on this.
I'll merge the DT patches when the driver will have been merged.
Quoted 8 lines
Quoted 4 lines
I've applied patches 1 & 2.
They are in the testing branch and will go to the linux-next branch as soon as the kernelci passes.
I just merged all the other patches (except the patch 6, for the H6, as requested by Vasily on IRC).
Hello
Vasily asked to not apply H6 due to my test failling on h6 and since he didnt own any H6 hw. But it was failling due my fault (a failling build).
Quoted 7 lines
Quoted 1 line
So the patchset work perfect on H6 (opi1+, opi3, pineH64 both model A and B) as reported by my answer to this thread.
HI Corentin,
Although it is not calibrated, it should work on the R40. Can you give my patch a try?
Hello
It is planned, I will report the result.
Regards
Corentin Labbe
Tested-byQuoted 32 lines · Frank Lee
Quoted 23 lines · Corentin Labbe
Quoted 12 lines · Maxime Ripard
Quoted 11 lines · Daniel Lezcano
Quoted 9 lines · Maxime Ripard
Hi,
Quoted 2 lines · Vasily Khoruzhick
This patchset adds driver for thermal sensor in A64, A83T, H3, H5, H6 and R40 SoCs.
Thanks again for working on this.
I'll merge the DT patches when the driver will have been merged.
Quoted 8 lines
Quoted 4 lines
I've applied patches 1 & 2.
They are in the testing branch and will go to the linux-next branch as soon as the kernelci passes.
I just merged all the other patches (except the patch 6, for the H6, as requested by Vasily on IRC).
Quoted 6 lines
Hello
Vasily asked to not apply H6 due to my test failling on h6 and since he didnt own any H6 hw. But it was failling due my fault (a failling build).
So the patchset work perfect on H6 (opi1+, opi3, pineH64 both model A and B) as reported by my answer to this thread.
Quoted 8 lines
HI Corentin,
Although it is not calibrated, it should work on the R40. Can you give my patch a try?
Thx,
Yangtao
Hello
It works:
uname -a
Linux zlad 5.5.0-rc2-next-20191220+ #196 SMP PREEMPT Sun Dec 29 22:08:05 CET 2019 armv7l ARMv7 Processor rev 5 (v7l) Allwinner sun8i Family GNU/Linux cat /sys/devices/virtual/thermal/thermal_zone0/temp
30736
cat /sys/devices/virtual/thermal/thermal_zone0/type
cpu0-thermal
cat /sys/devices/virtual/thermal/thermal_zone1/temp
29380
cat /sys/devices/virtual/thermal/thermal_zone1/type
gpu-thermal
So you could add to your patch:
Tested-on: sun8i-r40-bananapi-m2-ultra
thanks
Regards
Quoted 46 lines · Vasily Khoruzhick
This patchset adds driver for thermal sensor in A64, A83T, H3, H5, H6 and R40 SoCs.
v8:
- [vasily] Address more Maxime's comments for dt-schema
- [vasily] Add myself toMAINTAINERSfor the driver and schema
- [vasily] Round calibration data size to word boundary for H6 and A64
- [vasily] Change offset for A64 since it reports too low temp otherwise. Likely conversion formula in user manual is not correct.v7:
- [vasily] Address Maxime's comments for dt-schema
- [vasily] Move common part of H3 and H5 dts intosunxi-h3-h5.dtsi
- [vasily] Add Maxime's a-b to the driver patchv6:
- [ondrej, vasily] Squash all driver related changes into a single patch
- [ondrej] Rename calib -> calibration
- [ondrej] Fix thermal zone registration check
- [ondrej] Lower rate of sensor data interrupts to 4/sec/sensor
- [ondrej] Rework scale/offset values, H6 calibration
- [ondrej] Explicitly set mod clock to 24 MHz
- [ondrej] Set undocumented bits in CTRL0 for H6
- [ondrej] Add support for A83T
- [ondrej] Add dts changes for A83T, H3, H5, H6
- [vasily] Add dts changes for A64
- [vasily] Address Maxime's comments for YAML scheme
- [vasily] Make .calc_temp callback mandatory
- [vasily] Set .max_register in regmap config, so regs can be inspected using debugfsOndrej Jirman (4):
ARM: dts: sun8i-a83t: Add thermal sensor and thermal zones
ARM: dts: sun8i-h3: Add thermal sensor and thermal zones
arm64: dts: allwinner: h5: Add thermal sensor and thermal zones
arm64: dts: allwinner: h6: Add thermal sensor and thermal zonesVasily Khoruzhick (1):
arm64: dts: allwinner: a64: Add thermal sensors and thermal zonesYangtao Li (2):
thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40
dt-bindings: thermal: add YAML schema for sun8i-thermal driver
bindings
Quoted 18 lines
.../thermal/allwinner,sun8i-a83t-ths.yaml | 160 +++++ MAINTAINERS | 8 + arch/arm/boot/dts/sun8i-a83t.dtsi | 36 + arch/arm/boot/dts/sun8i-h3.dtsi | 20 + arch/arm/boot/dts/sunxi-h3-h5.dtsi | 6 + arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 42 ++ arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 26 + arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 33 + drivers/thermal/Kconfig | 14 + drivers/thermal/Makefile | 1 + drivers/thermal/sun8i_thermal.c | 639 ++++++++++++++++++ 11 files changed, 985 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml create mode 100644 drivers/thermal/sun8i_thermal.cSignature · 1 line
2.24.1
Hello
Thanks for your work.
Tested-on: sun50i-h6-pine-h64-model-b
Tested-on: sun50i-h6-pine-h64
Tested-on: sun8i-a83t-bananapi-m3
Tested-on: sun8i-h2-plus-orangepi-zero
Tested-on: sun8i-h2-plus-orangepi-r1
Tested-on: sun8i-h2-plus-libretech-all-h3-cc
Tested-on: sun8i-h3-libretech-all-h3-cc
Tested-on: sun50i-h5-libretech-all-h3-cc
Tested-on: sun50i-a64-pine64-plus
Note that your patch serie support R40 but you do not have any R40 DT patch. If you need testing, do not hesitate to ask.
Regards
Frank Lee
maintainerQuoted 82 lines · Corentin Labbe
Quoted 61 lines · Vasily Khoruzhick
This patchset adds driver for thermal sensor in A64, A83T, H3, H5, H6 and R40 SoCs.
v8:
- [vasily] Address more Maxime's comments for dt-schema
- [vasily] Add myself toMAINTAINERSfor the driver and schema
- [vasily] Round calibration data size to word boundary for H6 and A64
- [vasily] Change offset for A64 since it reports too low temp otherwise. Likely conversion formula in user manual is not correct.v7:
- [vasily] Address Maxime's comments for dt-schema
- [vasily] Move common part of H3 and H5 dts intosunxi-h3-h5.dtsi
- [vasily] Add Maxime's a-b to the driver patchv6:
- [ondrej, vasily] Squash all driver related changes into a single patch
- [ondrej] Rename calib -> calibration
- [ondrej] Fix thermal zone registration check
- [ondrej] Lower rate of sensor data interrupts to 4/sec/sensor
- [ondrej] Rework scale/offset values, H6 calibration
- [ondrej] Explicitly set mod clock to 24 MHz
- [ondrej] Set undocumented bits in CTRL0 for H6
- [ondrej] Add support for A83T
- [ondrej] Add dts changes for A83T, H3, H5, H6
- [vasily] Add dts changes for A64
- [vasily] Address Maxime's comments for YAML scheme
- [vasily] Make .calc_temp callback mandatory
- [vasily] Set .max_register in regmap config, so regs can be inspected using debugfsOndrej Jirman (4):
ARM: dts: sun8i-a83t: Add thermal sensor and thermal zones
ARM: dts: sun8i-h3: Add thermal sensor and thermal zones
arm64: dts: allwinner: h5: Add thermal sensor and thermal zones
arm64: dts: allwinner: h6: Add thermal sensor and thermal zonesVasily Khoruzhick (1):
arm64: dts: allwinner: a64: Add thermal sensors and thermal zonesYangtao Li (2):
thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40
dt-bindings: thermal: add YAML schema for sun8i-thermal driver
bindings.../thermal/allwinner,sun8i-a83t-ths.yaml | 160 +++++ MAINTAINERS | 8 + arch/arm/boot/dts/sun8i-a83t.dtsi | 36 + arch/arm/boot/dts/sun8i-h3.dtsi | 20 + arch/arm/boot/dts/sunxi-h3-h5.dtsi | 6 + arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 42 ++ arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 26 + arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 33 + drivers/thermal/Kconfig | 14 + drivers/thermal/Makefile | 1 + drivers/thermal/sun8i_thermal.c | 639 ++++++++++++++++++ 11 files changed, 985 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml create mode 100644 drivers/thermal/sun8i_thermal.cQuoted 3 lines
--
2.24.1Hello
Thanks for your work.
Tested-by Corentin Labbe <[email protected]>Tested-on: sun50i-h6-pine-h64-model-b
Tested-on: sun50i-h6-pine-h64
Tested-on: sun8i-a83t-bananapi-m3
Tested-on: sun8i-h2-plus-orangepi-zero
Tested-on: sun8i-h2-plus-orangepi-r1
Tested-on: sun8i-h2-plus-libretech-all-h3-cc
Tested-on: sun8i-h3-libretech-all-h3-cc
Tested-on: sun50i-h5-libretech-all-h3-cc
Tested-on: sun50i-a64-pine64-plus
Quoted 2 lines
Note that your patch serie support R40 but you do not have any R40 DT patch. If you need testing, do not hesitate to ask.
How about this? No one has yet added the R40's SID, and I'm not sure about the available size of the sid. So the current therm sensor is not calibrated, hope this is available.
arch/arm/boot/dts/sun8i-r40.dtsi +28 -0
@@ -46,6 +46,7 @@ #include <dt-bindings/clock/sun8i-r40-ccu.h> #include <dt-bindings/reset/sun8i-r40-ccu.h> #include <dt-bindings/reset/sun8i-de2.h> +#include <dt-bindings/thermal/thermal.h> / { #address-cells = <1>;
@@ -109,6 +110,22 @@ status = "disabled"; }; + thermal-zones { + cpu_thermal: cpu0-thermal { + /* milliseconds */ + polling-delay-passive = <0>; + polling-delay = <0>; + thermal-sensors = <&ths 0>; + }; + + gpu_thermal: gpu-thermal { + /* milliseconds */ + polling-delay-passive = <0>; + polling-delay = <0>; + thermal-sensors = <&ths 1>; + }; + }; + soc { compatible = "simple-bus"; #address-cells = <1>;
@@ -421,6 +438,17 @@ clocks = <&osc24M>; }; + ths: thermal-sensor@1c24c00 { + compatible = "allwinner,sun8i-r40-ths"; + reg = <0x01c24c00 0x100>; + clocks = <&ccu CLK_BUS_THS>, <&ccu CLK_THS>; + clock-names = "bus", "mod"; + interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>; + resets = <&ccu RST_BUS_THS>; + /* TODO: add nvmem-cells for calibration */ + #thermal-sensor-cells = <1>; + }; + uart0: serial@1c28000 { compatible = "snps,dw-apb-uart"; reg = <0x01c28000 0x400>;
drivers/thermal/sun8i_thermal.c +1 -1
@@ -565,7 +565,7 @@ static const struct ths_thermal_chip sun8i_h3_ths = { };static const struct ths_thermal_chip sun8i_r40_ths = { - .sensor_num =3 , + .sensor_num =2 , .offset =251086 , .scale =1130 , .has_mod_clk = true,
MBR,
Yangtao
Quoted 2 lines
Regards
Hi Vasily,
For this entire series, the DTS files don't contain any trip points. Did I miss some other series?
At a minimum, you should add some "hot" or "critical" trip points since then don't require a cooling-map with throttling actions. If you have "passive" trip points, then you need to provide cooling-maps.
Since this series has been merged, could you please follow up with a fixup series to add the trip points?
Regards,
Amit
p.s. We should catch all this automatically, I'll send out yaml bindings for the thermal framework soon that should catch this stuff.
Quoted 65 lines · Vasily Khoruzhick
This patchset adds driver for thermal sensor in A64, A83T, H3, H5, H6 and R40 SoCs.
v8:
- [vasily] Address more Maxime's comments for dt-schema
- [vasily] Add myself toMAINTAINERSfor the driver and schema
- [vasily] Round calibration data size to word boundary for H6 and A64
- [vasily] Change offset for A64 since it reports too low temp otherwise. Likely conversion formula in user manual is not correct.v7:
- [vasily] Address Maxime's comments for dt-schema
- [vasily] Move common part of H3 and H5 dts intosunxi-h3-h5.dtsi
- [vasily] Add Maxime's a-b to the driver patchv6:
- [ondrej, vasily] Squash all driver related changes into a single patch
- [ondrej] Rename calib -> calibration
- [ondrej] Fix thermal zone registration check
- [ondrej] Lower rate of sensor data interrupts to 4/sec/sensor
- [ondrej] Rework scale/offset values, H6 calibration
- [ondrej] Explicitly set mod clock to 24 MHz
- [ondrej] Set undocumented bits in CTRL0 for H6
- [ondrej] Add support for A83T
- [ondrej] Add dts changes for A83T, H3, H5, H6
- [vasily] Add dts changes for A64
- [vasily] Address Maxime's comments for YAML scheme
- [vasily] Make .calc_temp callback mandatory
- [vasily] Set .max_register in regmap config, so regs can be inspected using debugfsOndrej Jirman (4):
ARM: dts: sun8i-a83t: Add thermal sensor and thermal zones
ARM: dts: sun8i-h3: Add thermal sensor and thermal zones
arm64: dts: allwinner: h5: Add thermal sensor and thermal zones
arm64: dts: allwinner: h6: Add thermal sensor and thermal zonesVasily Khoruzhick (1):
arm64: dts: allwinner: a64: Add thermal sensors and thermal zonesYangtao Li (2):
thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40
dt-bindings: thermal: add YAML schema for sun8i-thermal driver
bindings.../thermal/allwinner,sun8i-a83t-ths.yaml | 160 +++++ MAINTAINERS | 8 + arch/arm/boot/dts/sun8i-a83t.dtsi | 36 + arch/arm/boot/dts/sun8i-h3.dtsi | 20 + arch/arm/boot/dts/sunxi-h3-h5.dtsi | 6 + arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 42 ++ arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 26 + arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 33 + drivers/thermal/Kconfig | 14 + drivers/thermal/Makefile | 1 + drivers/thermal/sun8i_thermal.c | 639 ++++++++++++++++++ 11 files changed, 985 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml create mode 100644 drivers/thermal/sun8i_thermal.c--
2.24.1
Hi Amit,
Quoted 11 lines · Amit Kucheria
Hi Vasily,
For this entire series, the DTS files don't contain any trip points. Did I miss some other series?
At a minimum, you should add some "hot" or "critical" trip points since then don't require a cooling-map with throttling actions. If you have "passive" trip points, then you need to provide cooling-maps.
Since this series has been merged, could you please follow up with a fixup series to add the trip points?
I don't think lack of trip points causes runtime issues. Or does it? I planned to send update with some trip points and cooling maps for 5.7 merge window. Is this acceptable?
If not, I can send a patch that adds:
+ trips {
+ cpu-very-hot {
+ temperature = <100000>; + hysteresis = <0>; + type = "critical";
+ };
+ };
and
+ trips {
+ gpu-very-hot {
+ temperature = <100000>; + hysteresis = <0>; + type = "critical";
+ };
+ };
everywhere where appropriate. Though that will make rebase of out of tree patches that already have a more complicated setup to be sent for the next merge window a bit tedious.
thank you,
Ondrej
Quoted 5 lines
Regards,
Amit
p.s. We should catch all this automatically, I'll send out yaml bindings for the thermal framework soon that should catch this stuff.
Quoted 66 lines
Quoted 65 lines · Vasily Khoruzhick
This patchset adds driver for thermal sensor in A64, A83T, H3, H5, H6 and R40 SoCs.
v8:
- [vasily] Address more Maxime's comments for dt-schema
- [vasily] Add myself toMAINTAINERSfor the driver and schema
- [vasily] Round calibration data size to word boundary for H6 and A64
- [vasily] Change offset for A64 since it reports too low temp otherwise. Likely conversion formula in user manual is not correct.v7:
- [vasily] Address Maxime's comments for dt-schema
- [vasily] Move common part of H3 and H5 dts intosunxi-h3-h5.dtsi
- [vasily] Add Maxime's a-b to the driver patchv6:
- [ondrej, vasily] Squash all driver related changes into a single patch
- [ondrej] Rename calib -> calibration
- [ondrej] Fix thermal zone registration check
- [ondrej] Lower rate of sensor data interrupts to 4/sec/sensor
- [ondrej] Rework scale/offset values, H6 calibration
- [ondrej] Explicitly set mod clock to 24 MHz
- [ondrej] Set undocumented bits in CTRL0 for H6
- [ondrej] Add support for A83T
- [ondrej] Add dts changes for A83T, H3, H5, H6
- [vasily] Add dts changes for A64
- [vasily] Address Maxime's comments for YAML scheme
- [vasily] Make .calc_temp callback mandatory
- [vasily] Set .max_register in regmap config, so regs can be inspected using debugfsOndrej Jirman (4):
ARM: dts: sun8i-a83t: Add thermal sensor and thermal zones
ARM: dts: sun8i-h3: Add thermal sensor and thermal zones
arm64: dts: allwinner: h5: Add thermal sensor and thermal zones
arm64: dts: allwinner: h6: Add thermal sensor and thermal zonesVasily Khoruzhick (1):
arm64: dts: allwinner: a64: Add thermal sensors and thermal zonesYangtao Li (2):
thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40
dt-bindings: thermal: add YAML schema for sun8i-thermal driver
bindings.../thermal/allwinner,sun8i-a83t-ths.yaml | 160 +++++ MAINTAINERS | 8 + arch/arm/boot/dts/sun8i-a83t.dtsi | 36 + arch/arm/boot/dts/sun8i-h3.dtsi | 20 + arch/arm/boot/dts/sunxi-h3-h5.dtsi | 6 + arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 42 ++ arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 26 + arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 33 + drivers/thermal/Kconfig | 14 + drivers/thermal/Makefile | 1 + drivers/thermal/sun8i_thermal.c | 639 ++++++++++++++++++ 11 files changed, 985 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml create mode 100644 drivers/thermal/sun8i_thermal.c--
2.24.1
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 13 lines · Ondřej Jirman
Hi Amit,
Quoted 9 lines · Amit Kucheria
Hi Vasily,
For this entire series, the DTS files don't contain any trip points. Did I miss some other series?
At a minimum, you should add some "hot" or "critical" trip points since then don't require a cooling-map with throttling actions. If you have "passive" trip points, then you need to provide cooling-maps.
Quoted 6 lines
Quoted 2 lines
Since this series has been merged, could you please follow up with a fixup series to add the trip points?
I don't think lack of trip points causes runtime issues. Or does it? I planned to send update with some trip points and cooling maps for 5.7 merge window. Is this acceptable?
Yes, I think that would be fine.
Quoted 20 lines
If not, I can send a patch that adds:
+ trips {
(quoted diff) +6
-0+ cpu-very-hot { + temperature = <100000>; + hysteresis = <0>; + type = "critical"; + }; + };and
+ trips {
(quoted diff) +6
-0+ gpu-very-hot { + temperature = <100000>; + hysteresis = <0>; + type = "critical"; + }; + };
Quoted 3 lines
everywhere where appropriate. Though that will make rebase of out of tree patches that already have a more complicated setup to be sent for the next merge window a bit tedious.
Right, don't do that.
Quoted 7 lines
thank you,
OndrejQuoted 4 lines
Regards,
Amit
p.s. We should catch all this automatically, I'll send out yaml bindings for the thermal framework soon that should catch this stuff.
Hi Amit,
Quoted 8 lines · Amit Kucheria
Hi Vasily,
For this entire series, the DTS files don't contain any trip points. Did I miss some other series?
At a minimum, you should add some "hot" or "critical" trip points since then don't require a cooling-map with throttling actions. If you have "passive" trip points, then you need to provide cooling-maps.
Except I'm misunderstanding the bindings, a thermal zone must define these required properties:
- polling-delay
- polling-delay-passive
- thermal-sensors
- trips
- cooling-maps
Quoted 7 lines
Since this series has been merged, could you please follow up with a fixup series to add the trip points?
Regards,
Amit
p.s. We should catch all this automatically, I'll send out yaml bindings for the thermal framework soon that should catch this stuff.
+1
There was a small discussion about converting the binding to a schema:
https://www.spinics.net/lists/devicetree/msg332424.html
Quoted 66 lines · Vasily Khoruzhick
Quoted 65 lines
This patchset adds driver for thermal sensor in A64, A83T, H3, H5, H6 and R40 SoCs.
v8:
- [vasily] Address more Maxime's comments for dt-schema
- [vasily] Add myself toMAINTAINERSfor the driver and schema
- [vasily] Round calibration data size to word boundary for H6 and A64
- [vasily] Change offset for A64 since it reports too low temp otherwise. Likely conversion formula in user manual is not correct.v7:
- [vasily] Address Maxime's comments for dt-schema
- [vasily] Move common part of H3 and H5 dts intosunxi-h3-h5.dtsi
- [vasily] Add Maxime's a-b to the driver patchv6:
- [ondrej, vasily] Squash all driver related changes into a single patch
- [ondrej] Rename calib -> calibration
- [ondrej] Fix thermal zone registration check
- [ondrej] Lower rate of sensor data interrupts to 4/sec/sensor
- [ondrej] Rework scale/offset values, H6 calibration
- [ondrej] Explicitly set mod clock to 24 MHz
- [ondrej] Set undocumented bits in CTRL0 for H6
- [ondrej] Add support for A83T
- [ondrej] Add dts changes for A83T, H3, H5, H6
- [vasily] Add dts changes for A64
- [vasily] Address Maxime's comments for YAML scheme
- [vasily] Make .calc_temp callback mandatory
- [vasily] Set .max_register in regmap config, so regs can be inspected using debugfsOndrej Jirman (4):
ARM: dts: sun8i-a83t: Add thermal sensor and thermal zones
ARM: dts: sun8i-h3: Add thermal sensor and thermal zones
arm64: dts: allwinner: h5: Add thermal sensor and thermal zones
arm64: dts: allwinner: h6: Add thermal sensor and thermal zonesVasily Khoruzhick (1):
arm64: dts: allwinner: a64: Add thermal sensors and thermal zonesYangtao Li (2):
thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40
dt-bindings: thermal: add YAML schema for sun8i-thermal driver
bindings.../thermal/allwinner,sun8i-a83t-ths.yaml | 160 +++++ MAINTAINERS | 8 + arch/arm/boot/dts/sun8i-a83t.dtsi | 36 + arch/arm/boot/dts/sun8i-h3.dtsi | 20 + arch/arm/boot/dts/sunxi-h3-h5.dtsi | 6 + arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 42 ++ arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 26 + arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 33 + drivers/thermal/Kconfig | 14 + drivers/thermal/Makefile | 1 + drivers/thermal/sun8i_thermal.c | 639 ++++++++++++++++++ 11 files changed, 985 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml create mode 100644 drivers/thermal/sun8i_thermal.c--
2.24.1
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Quoted 14 lines · Daniel Lezcano
Hi Amit,
Quoted 8 lines · Amit Kucheria
Hi Vasily,
For this entire series, the DTS files don't contain any trip points. Did I miss some other series?
At a minimum, you should add some "hot" or "critical" trip points since then don't require a cooling-map with throttling actions. If you have "passive" trip points, then you need to provide cooling-maps.
Quoted 8 lines
Except I'm misunderstanding the bindings, a thermal zone must define these required properties:
- polling-delay
- polling-delay-passive
- thermal-sensors
- trips
- cooling-maps
Right, except for the cooling-maps. Those are exempted if there is the trip type is not passive. That is my understanding of the existing bindings.
Trip type critical triggers a shutdown and trip type hot only triggers a notification - see thermal_core.c:handle_critical_trips(). So we only need cooling maps for passive trip types.
Quoted 8 lines
Quoted 7 lines
Since this series has been merged, could you please follow up with a fixup series to add the trip points?
Regards,
Amit
p.s. We should catch all this automatically, I'll send out yaml bindings for the thermal framework soon that should catch this stuff.
Quoted 5 lines
+1
There was a small discussion about converting the binding to a schema:
Aah, I missed that. I started working on something last week that looks similar to your discussion. Pushed a WIP branch here[1], it looks like I had a similar idea on how to split the bindings. Hope to finish this up tomorrow for an RFC.
Regards,
Amit
[1] https://github.com/idlethread/linux/commits/up/thermal/yaml-conversion-v1
Quoted 75 lines
Quoted 63 lines · Vasily Khoruzhick
Quoted 62 lines
This patchset adds driver for thermal sensor in A64, A83T, H3, H5, H6 and R40 SoCs.
v8:
- [vasily] Address more Maxime's comments for dt-schema
- [vasily] Add myself toMAINTAINERSfor the driver and schema
- [vasily] Round calibration data size to word boundary for H6 and A64
- [vasily] Change offset for A64 since it reports too low temp otherwise. Likely conversion formula in user manual is not correct.v7:
- [vasily] Address Maxime's comments for dt-schema
- [vasily] Move common part of H3 and H5 dts intosunxi-h3-h5.dtsi
- [vasily] Add Maxime's a-b to the driver patchv6:
- [ondrej, vasily] Squash all driver related changes into a single patch
- [ondrej] Rename calib -> calibration
- [ondrej] Fix thermal zone registration check
- [ondrej] Lower rate of sensor data interrupts to 4/sec/sensor
- [ondrej] Rework scale/offset values, H6 calibration
- [ondrej] Explicitly set mod clock to 24 MHz
- [ondrej] Set undocumented bits in CTRL0 for H6
- [ondrej] Add support for A83T
- [ondrej] Add dts changes for A83T, H3, H5, H6
- [vasily] Add dts changes for A64
- [vasily] Address Maxime's comments for YAML scheme
- [vasily] Make .calc_temp callback mandatory
- [vasily] Set .max_register in regmap config, so regs can be inspected using debugfsOndrej Jirman (4):
ARM: dts: sun8i-a83t: Add thermal sensor and thermal zones
ARM: dts: sun8i-h3: Add thermal sensor and thermal zones
arm64: dts: allwinner: h5: Add thermal sensor and thermal zones
arm64: dts: allwinner: h6: Add thermal sensor and thermal zonesVasily Khoruzhick (1):
arm64: dts: allwinner: a64: Add thermal sensors and thermal zonesYangtao Li (2):
thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40
dt-bindings: thermal: add YAML schema for sun8i-thermal driver
bindings.../thermal/allwinner,sun8i-a83t-ths.yaml | 160 +++++ MAINTAINERS | 8 + arch/arm/boot/dts/sun8i-a83t.dtsi | 36 + arch/arm/boot/dts/sun8i-h3.dtsi | 20 + arch/arm/boot/dts/sunxi-h3-h5.dtsi | 6 + arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 42 ++ arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 26 + arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 33 + drivers/thermal/Kconfig | 14 + drivers/thermal/Makefile | 1 + drivers/thermal/sun8i_thermal.c | 639 ++++++++++++++++++ 11 files changed, 985 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml create mode 100644 drivers/thermal/sun8i_thermal.cQuoted 3 lines
Quoted 3 lines
--
2.24.1--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCsFollow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Quoted 25 lines · Amit Kucheria
Quoted 14 lines · Daniel Lezcano
Hi Amit,
Quoted 8 lines · Amit Kucheria
Hi Vasily,
For this entire series, the DTS files don't contain any trip points. Did I miss some other series?
At a minimum, you should add some "hot" or "critical" trip points since then don't require a cooling-map with throttling actions. If you have "passive" trip points, then you need to provide cooling-maps.
Quoted 8 lines
Except I'm misunderstanding the bindings, a thermal zone must define these required properties:
- polling-delay
- polling-delay-passive
- thermal-sensors
- trips
- cooling-maps
Quoted 3 lines
Right, except for the cooling-maps. Those are exempted if there is the trip type is not passive. That is my understanding of the existing bindings.
The binding is ambiguous.
For me it states the cooling maps must be defined as it is a required node of the thermal zone.
We may not have an active or passive cooling device for the thermal zone, thus we can not comply with the dt binding and strictly speaking we shouldn't add this thermal zone.
But the logic of having a 'hot' or a 'critical' trip point without a cooling device is correct.
As we move this binding to a schema, we shall clarify the cooling-maps is required if there are active or passive trip points otherwise it is optional.
Quoted 16 lines
Trip type critical triggers a shutdown and trip type hot only triggers a notification - see thermal_core.c:handle_critical_trips(). So we only need cooling maps for passive trip types.
Quoted 12 lines
Quoted 7 lines
Since this series has been merged, could you please follow up with a fixup series to add the trip points?
Regards,
Amit
p.s. We should catch all this automatically, I'll send out yaml bindings for the thermal framework soon that should catch this stuff.+1
There was a small discussion about converting the binding to a schema:
Quoted 7 lines
Aah, I missed that. I started working on something last week that looks similar to your discussion. Pushed a WIP branch here[1], it looks like I had a similar idea on how to split the bindings. Hope to finish this up tomorrow for an RFC.
Great, thanks for taking care of that.
Quoted 77 lines
[1] https://github.com/idlethread/linux/commits/up/thermal/yaml-conversion-v1
Quoted 75 lines
Quoted 63 lines · Vasily Khoruzhick
Quoted 62 lines
This patchset adds driver for thermal sensor in A64, A83T, H3, H5, H6 and R40 SoCs.
v8:
- [vasily] Address more Maxime's comments for dt-schema
- [vasily] Add myself toMAINTAINERSfor the driver and schema
- [vasily] Round calibration data size to word boundary for H6 and A64
- [vasily] Change offset for A64 since it reports too low temp otherwise. Likely conversion formula in user manual is not correct.v7:
- [vasily] Address Maxime's comments for dt-schema
- [vasily] Move common part of H3 and H5 dts intosunxi-h3-h5.dtsi
- [vasily] Add Maxime's a-b to the driver patchv6:
- [ondrej, vasily] Squash all driver related changes into a single patch
- [ondrej] Rename calib -> calibration
- [ondrej] Fix thermal zone registration check
- [ondrej] Lower rate of sensor data interrupts to 4/sec/sensor
- [ondrej] Rework scale/offset values, H6 calibration
- [ondrej] Explicitly set mod clock to 24 MHz
- [ondrej] Set undocumented bits in CTRL0 for H6
- [ondrej] Add support for A83T
- [ondrej] Add dts changes for A83T, H3, H5, H6
- [vasily] Add dts changes for A64
- [vasily] Address Maxime's comments for YAML scheme
- [vasily] Make .calc_temp callback mandatory
- [vasily] Set .max_register in regmap config, so regs can be inspected using debugfsOndrej Jirman (4):
ARM: dts: sun8i-a83t: Add thermal sensor and thermal zones
ARM: dts: sun8i-h3: Add thermal sensor and thermal zones
arm64: dts: allwinner: h5: Add thermal sensor and thermal zones
arm64: dts: allwinner: h6: Add thermal sensor and thermal zonesVasily Khoruzhick (1):
arm64: dts: allwinner: a64: Add thermal sensors and thermal zonesYangtao Li (2):
thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40
dt-bindings: thermal: add YAML schema for sun8i-thermal driver
bindings.../thermal/allwinner,sun8i-a83t-ths.yaml | 160 +++++ MAINTAINERS | 8 + arch/arm/boot/dts/sun8i-a83t.dtsi | 36 + arch/arm/boot/dts/sun8i-h3.dtsi | 20 + arch/arm/boot/dts/sunxi-h3-h5.dtsi | 6 + arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 42 ++ arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 26 + arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 33 + drivers/thermal/Kconfig | 14 + drivers/thermal/Makefile | 1 + drivers/thermal/sun8i_thermal.c | 639 ++++++++++++++++++ 11 files changed, 985 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml create mode 100644 drivers/thermal/sun8i_thermal.cQuoted 3 lines
Quoted 3 lines
--
2.24.1--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCsFollow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Vasily Khoruzhick
maintainerQuoted 5 lines · Amit Kucheria
Hi Vasily,
For this entire series, the DTS files don't contain any trip points. Did I miss some other series?
Quoted 6 lines
At a minimum, you should add some "hot" or "critical" trip points since then don't require a cooling-map with throttling actions. If you have "passive" trip points, then you need to provide cooling-maps.
Since this series has been merged, could you please follow up with a fixup series to add the trip points?
A64 has already made it into linux-next, I believe there's other series in flight at least for H6 from Yangtao Li and for H5 from Chen-Yu Tsai
Quoted 71 lines
Regards,
Amit
p.s. We should catch all this automatically, I'll send out yaml bindings for the thermal framework soon that should catch this stuff.Quoted 65 lines · Vasily Khoruzhick
This patchset adds driver for thermal sensor in A64, A83T, H3, H5, H6 and R40 SoCs.
v8:
- [vasily] Address more Maxime's comments for dt-schema
- [vasily] Add myself toMAINTAINERSfor the driver and schema
- [vasily] Round calibration data size to word boundary for H6 and A64
- [vasily] Change offset for A64 since it reports too low temp otherwise. Likely conversion formula in user manual is not correct.v7:
- [vasily] Address Maxime's comments for dt-schema
- [vasily] Move common part of H3 and H5 dts intosunxi-h3-h5.dtsi
- [vasily] Add Maxime's a-b to the driver patchv6:
- [ondrej, vasily] Squash all driver related changes into a single patch
- [ondrej] Rename calib -> calibration
- [ondrej] Fix thermal zone registration check
- [ondrej] Lower rate of sensor data interrupts to 4/sec/sensor
- [ondrej] Rework scale/offset values, H6 calibration
- [ondrej] Explicitly set mod clock to 24 MHz
- [ondrej] Set undocumented bits in CTRL0 for H6
- [ondrej] Add support for A83T
- [ondrej] Add dts changes for A83T, H3, H5, H6
- [vasily] Add dts changes for A64
- [vasily] Address Maxime's comments for YAML scheme
- [vasily] Make .calc_temp callback mandatory
- [vasily] Set .max_register in regmap config, so regs can be inspected using debugfsOndrej Jirman (4):
ARM: dts: sun8i-a83t: Add thermal sensor and thermal zones
ARM: dts: sun8i-h3: Add thermal sensor and thermal zones
arm64: dts: allwinner: h5: Add thermal sensor and thermal zones
arm64: dts: allwinner: h6: Add thermal sensor and thermal zonesVasily Khoruzhick (1):
arm64: dts: allwinner: a64: Add thermal sensors and thermal zonesYangtao Li (2):
thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40
dt-bindings: thermal: add YAML schema for sun8i-thermal driver
bindings.../thermal/allwinner,sun8i-a83t-ths.yaml | 160 +++++ MAINTAINERS | 8 + arch/arm/boot/dts/sun8i-a83t.dtsi | 36 + arch/arm/boot/dts/sun8i-h3.dtsi | 20 + arch/arm/boot/dts/sunxi-h3-h5.dtsi | 6 + arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 42 ++ arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 26 + arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 33 + drivers/thermal/Kconfig | 14 + drivers/thermal/Makefile | 1 + drivers/thermal/sun8i_thermal.c | 639 ++++++++++++++++++ 11 files changed, 985 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml create mode 100644 drivers/thermal/sun8i_thermal.c--
2.24.1